From geoffgole@gmail.com Sun Feb 22 18:26:55 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Feb 2009 02:26:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1N2Qq1M015465 for ; Sun, 22 Feb 2009 18:26:53 -0800 Received: from mail.gnu.org ([199.232.76.166]:51070 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LbQUp-0006nM-FA for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 21:24:39 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LbQWx-00071V-C9 for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 21:26:51 -0500 Received: from rv-out-0708.google.com ([209.85.198.250]:63027) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LbQWx-00071J-3C for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 21:26:51 -0500 Received: by rv-out-0708.google.com with SMTP id f25so2118390rvb.6 for ; Sun, 22 Feb 2009 18:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=MQdCZRXAgw5UCtyO1ucHAKr1h2nVFWJt6uEiMWHc7i0=; b=bwMOnGqFVpwYnSU0MJ1fmKHY5OFb99JAyghCqOt/SJYqoKEQ7b/yosNkw+TrPnuUnN URyitJ7MyasM0B5TA6RrjhMzvdLNuImiK0nqwldJXNNaqSW+yEIPL1ZLeE33+AiOIQfl PykC+4s8jyyP6mPphHPb90S1A9zpq08PWs/MY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=YaI2Yj5OV9tumya7HKMHM1adQTzV87C9blAWYMv7lPWWxY1RMzys7cKoIvFnM1zm2p Jw+4h2lw+f1rKf/erw5at3GJFY+KnzkLDK/8fFkgIiAu1zDPj3Kk1rQt4kRHKOoQhKZy Lpf5BGSUQgjgzuf33rcZCraKmXeIqs25a1euA= MIME-Version: 1.0 Received: by 10.142.214.11 with SMTP id m11mr1737804wfg.22.1235356009403; Sun, 22 Feb 2009 18:26:49 -0800 (PST) Date: Mon, 23 Feb 2009 11:26:49 +0900 Message-ID: Subject: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer From: Geoff Gole To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) In ibuffer, running ibuffer-toggle-sorting-mode will produce a useful message telling the user what the buffer is now sorted by. That message is immediately clobbered by an useless `Mark set' message (useless because ibuffer stomps all over any such mark). To reproduce: emacs -Q M-x ibuffer , C-h e and observe that both "Sorting by ..." and "Mark set" appear A patch follows (against GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-22 on elegiac, modified by Debian). diff -c -L /usr/share/emacs/23.0.60/lisp/ibuffer.el.gz -L /tmp/buffer-content-31328m2 /tmp/jka-com3132uwF /tmp/buffer-content-31328m2 *** /usr/share/emacs/23.0.60/lisp/ibuffer.el.gz --- /tmp/buffer-content-31328m2 *************** *** 2277,2283 **** (setq buffer-read-only t) (set-buffer-modified-p ibuffer-did-modification) (setq ibuffer-did-modification nil) ! (goto-line (1+ orig))))) (defun ibuffer-quit () "Quit this `ibuffer' session. --- 2277,2284 ---- (setq buffer-read-only t) (set-buffer-modified-p ibuffer-did-modification) (setq ibuffer-did-modification nil) ! (goto-char 1) ! (forward-line orig)))) (defun ibuffer-quit () "Quit this `ibuffer' session. From lekktu@gmail.com Mon Feb 23 02:46:40 2009 Received: (at control) by emacsbugs.donarmstrong.com; 23 Feb 2009 10:46:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1NAkbaE011226 for ; Mon, 23 Feb 2009 02:46:38 -0800 Received: by ey-out-2122.google.com with SMTP id 25so363280eya.13 for ; Mon, 23 Feb 2009 02:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=wPUJ3RqF9E/Dv7d2b3ibQrCXTAETo6nLDjFjY6jaVdc=; b=PMGL3vkWmKwSqkBOPEUwOOFvWBxub5n5tPOa85X9xckj8cLDJot0DJsnEiVTE5dupQ ZShZTo9LcpBXspTv5mTtWluGL0CBStP4NPYHs7os97D0xqyB3ncEX2/eF6cDM1nSnSle 0oINUtPXEN9OccqqilatbHmLlALJyCMFHhS10= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=MhGJ7QqWer/oahOD/q07GwpNVvRX4SHLUFphtR/R+STI8Gcoukgpc1T8/1OGVQzHpn v750I2yYrKJ0XlFr5j1pBDU0Ki8DVr5Xyr1wTRWtL7dEu+W3cFWvUh7WRVxaMCaxLZMR Qp/4PAI5+9G8BAfwb2CDHOyQvDsMFALSqeV54= MIME-Version: 1.0 Received: by 10.210.67.13 with SMTP id p13mr1682948eba.20.1235385996740; Mon, 23 Feb 2009 02:46:36 -0800 (PST) Date: Mon, 23 Feb 2009 11:46:36 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 2437 spam reassign 2442 spam tags 2439 + patch reassign 2440 emacs,rmail reassign 2441 emacs,rmail quit From lekktu@gmail.com Mon Feb 23 03:02:01 2009 Received: (at 2439-done) by emacsbugs.donarmstrong.com; 23 Feb 2009 11:02:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=GMAIL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1NB1w2v014896 for <2439-done@emacsbugs.donarmstrong.com>; Mon, 23 Feb 2009 03:02:00 -0800 Received: by nf-out-0910.google.com with SMTP id g16so339652nfd.31 for <2439-done@emacsbugs.donarmstrong.com>; Mon, 23 Feb 2009 03:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=iUFzJYTfseau7JyV7xYRtoQSRRaFspttukaA90DUYfo=; b=tBrfM1ucHb+NIWkoMO/cFxiUS3vETlNTkjcxg83lqaDfDV8EikfMUE+SXfiQhXSUEl LTlc8rOSjR+J9CIWSBLw9N4oYh29/fisS70WSTv+y+s5p/N3UsNLvlBaQsT4Fa82rLp9 R7CIXzU1R2Ey2mK7XvzJa30VfEJ6MhXGCgDqE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=gMmeSM7VK42oimGNqhj5UD7CU02NxJoZLm/E/S8LxiNdISmCGfVH7JdI66Amrqg3Dz /T5J0gkq9fIs2yPAeEPkVqonFeu1EZhdX7pUehqBpoO+k1Hm1bL1cJvzoPBJ5TBnrSyu eAGgKLpmahBFTZatdjd8KZcMPWiAOGkEV+Krc= MIME-Version: 1.0 Received: by 10.210.42.20 with SMTP id p20mr3368893ebp.66.1235386917654; Mon, 23 Feb 2009 03:01:57 -0800 (PST) In-Reply-To: References: Date: Mon, 23 Feb 2009 12:01:57 +0100 Message-ID: Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer From: Juanma Barranquero To: Geoff Gole Cc: 2439-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Mon, Feb 23, 2009 at 03:26, Geoff Gole wrote: > A patch follows (against GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ > Version 2.12.11) of 2008-11-22 on elegiac, modified by Debian). Installed, thanks. Juanma From xma@gnu.org Mon Feb 23 13:26:07 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Feb 2009 21:26:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1NLQ45E012314 for ; Mon, 23 Feb 2009 13:26:05 -0800 Received: from mx10.gnu.org ([199.232.76.166]:42383) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LbiHG-00042f-62 for emacs-pretest-bug@gnu.org; Mon, 23 Feb 2009 16:23:50 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LbiJO-0004tO-Hz for emacs-pretest-bug@gnu.org; Mon, 23 Feb 2009 16:26:03 -0500 Received: from ded1.conovae.com ([88.191.52.166]:36914 helo=mf1.conovae.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LbiJO-0004tE-7p for emacs-pretest-bug@gnu.org; Mon, 23 Feb 2009 16:26:02 -0500 Received: by mf1.conovae.net (Postfix, from userid 10) id 5E1B6260122; Mon, 23 Feb 2009 22:25:03 +0100 (CET) Received: from zogzog.maillard.mobi (IDENT:1000@localhost [127.0.0.1]) by zogzog.maillard.mobi (8.14.3/8.13.8) with ESMTP id n1NLP3Di008081; Mon, 23 Feb 2009 22:25:03 +0100 Received: (from xma@localhost) by zogzog.maillard.mobi (8.14.3/8.13.8/Submit) id n1NLP36G008080; Mon, 23 Feb 2009 22:25:03 +0100 Date: Mon, 23 Feb 2009 22:25:03 +0100 Message-Id: <200902232125.n1NLP36G008080@zogzog.maillard.mobi> From: Xavier Maillard To: Geoff Gole CC: emacs-pretest-bug@gnu.org In-reply-to: message from Geoff Gole on Mon, 23 Feb 2009 11:26:49 +0900 Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer Organization: GNU's Not UNIX! User-Agent: Rmail GNU emacs 23.0 on Slackware 12.2.0 Jabber-ID: xma01@jabber.fr Reply-to: Xavier Maillard References: X-UUCPssh-Information: Please contact the ISP for more information X-UUCPssh: Found to be clean X-UUCPssh-SpamCheck: not spam, SpamAssassin (not cached, score=-4.399, required 6, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -2.60) X-UUCPssh-From: xma@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) In ibuffer, running ibuffer-toggle-sorting-mode will produce a useful message telling the user what the buffer is now sorted by. That message is immediately clobbered by an useless `Mark set' message (useless because ibuffer stomps all over any such mark). Confirmed. Your patch fixed that oddity. Xavier -- http://www.gnu.org http://www.april.org http://www.lolica.org From monnier@IRO.UMontreal.CA Wed Feb 25 08:30:29 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 25 Feb 2009 16:30:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PGUQpf029102 for ; Wed, 25 Feb 2009 08:30:27 -0800 Received: from mail.gnu.org ([199.232.76.166]:56997 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LcMcD-0004wF-6F for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 11:28:09 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LcMeL-0007uo-HJ for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 11:30:24 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:46588) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LcMeL-0007uU-4l for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 11:30:21 -0500 Received: from alfajor.home (vpn-132-204-232-24.acd.umontreal.ca [132.204.232.24]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n1PGUATf025054; Wed, 25 Feb 2009 11:30:10 -0500 Received: by alfajor.home (Postfix, from userid 20848) id 59DF5A2C19; Wed, 25 Feb 2009 11:30:10 -0500 (EST) From: Stefan Monnier To: Geoff Gole Cc: 2439@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer Message-ID: References: Date: Wed, 25 Feb 2009 11:30:10 -0500 In-Reply-To: (Geoff Gole's message of "Mon, 23 Feb 2009 11:26:49 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3218=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > ! (goto-char 1) > ! (forward-line orig)))) Thanks for your patch, but please try to avoid hardcoding "1" as above. Just use (point-min) instead. Stefan From lekktu@gmail.com Wed Feb 25 08:51:26 2009 Received: (at 2439) by emacsbugs.donarmstrong.com; 25 Feb 2009 16:51:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PGpNFH002826 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 08:51:24 -0800 Received: by nf-out-0910.google.com with SMTP id g16so45860nfd.31 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 08:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/cH26eSHZCs5momqr+gAJF/4LO9kjq7PV+l4rfeEP90=; b=Ctd245CWSb5fnIsEuqsKJx+3u36SAY7LeoZUqNgKr7kQOoYMGW1fZa5rQ5e7WwaV3C n32R7MA4YiQ0gC4hMFLgdEuLZnQeAfBV1uIYmZtl4dLIJgjxDwvxhor9u9ckJAXfuPaz I2SfSjgHlf01RlXXXVD24aBQwEbm/WLpBUWeM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QLkevjlQZfru0uOvlLRn5t0Khc6CUdVLkT6HmkmIPv5qaXP6jA5kSzDrUrJZvFBMRb YgUfyCBxFG1QoQj31OG2SWNsD77KZfO7V70eeqigmsPbZxcqIAfMI/aUG3hbREmH0Ol7 n1XnHjVwuCFb4VmtgD+ydg3euSXPIPua4IloI= MIME-Version: 1.0 Received: by 10.210.66.1 with SMTP id o1mr100033eba.92.1235580682480; Wed, 25 Feb 2009 08:51:22 -0800 (PST) In-Reply-To: References: Date: Wed, 25 Feb 2009 17:51:22 +0100 Message-ID: Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer From: Juanma Barranquero To: Stefan Monnier , 2439@debbugs.gnu.org Cc: Geoff Gole Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Wed, Feb 25, 2009 at 17:30, Stefan Monnier wrote: > Thanks for your patch, but please try to avoid hardcoding "1" as above. > Just use (point-min) instead. What is the point, when having a narrowed buffer would be an error? In this case, (goto-char 1) (forward-line orig) is not the same as (goto-line (1+ orig)) because `goto-line' uses `(save-restriction (widen) ...)'. So, if anything, is not that the patch should use `point-min', but that it should use (save-restriction (widen) (goto-char 1) (forward-line orig)) though I don't think narrowing the ibuffer buffer and then sorting is a common enough operation to worry about it. Same for bs-down, where I implemented the same fix. Juanma From monnier@IRO.UMontreal.CA Wed Feb 25 11:54:02 2009 Received: (at 2439) by emacsbugs.donarmstrong.com; 25 Feb 2009 19:54:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PJrwDD027532 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 11:53:59 -0800 Received: from alfajor.home (vpn-132-204-232-164.acd.umontreal.ca [132.204.232.164]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n1PJrvFP008858; Wed, 25 Feb 2009 14:53:57 -0500 Received: by alfajor.home (Postfix, from userid 20848) id D3DB2A2C19; Wed, 25 Feb 2009 14:53:56 -0500 (EST) From: Stefan Monnier To: Juanma Barranquero Cc: 2439@debbugs.gnu.org, Geoff Gole Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in Message-ID: References: Date: Wed, 25 Feb 2009 14:53:56 -0500 In-Reply-To: (Juanma Barranquero's message of "Wed, 25 Feb 2009 17:51:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3219=0 >> Thanks for your patch, but please try to avoid hardcoding "1" as above. >> Just use (point-min) instead. > What is the point, when having a narrowed buffer would be an error? Because 1 is sometimes an error, whereas (point-min) isn't. > because `goto-line' uses `(save-restriction (widen) ...)'. So, if > anything, is not that the patch should use `point-min', but that it > should use > (save-restriction > (widen) > (goto-char 1) > (forward-line orig)) No, it should be (save-restriction (widen) (goto-char (point-min)) (forward-line orig)) > though I don't think narrowing the ibuffer buffer and then sorting is > a common enough operation to worry about it. Same for bs-down, where > I implemented the same fix. Agreed. But still using (point-min) rather than 1. Stefan From lekktu@gmail.com Wed Feb 25 14:37:30 2009 Received: (at 2439) by emacsbugs.donarmstrong.com; 25 Feb 2009 22:37:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.191]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PMbRSK013628 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 14:37:28 -0800 Received: by nf-out-0910.google.com with SMTP id g16so115968nfd.31 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 14:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=kNGnp6JB9YbTegQL/dXwIMzSw0HsrhGzhOMXKmsG+DQ=; b=uCUvFU5KHAOiCDNH50jcyei+CZgHVBUZHiIfS3qP/eXh/tVMxjOyCiCO4ITDRpQqqh UR/8iWr6IAXdH5LgvnEF+aptRjrYlfPv10H4TovEn5TWcHOJUrLb3Sk2z444Sm8t3PIy CuvDbL8Jj0PVCmCJe3ycZagm1s46clbApT42k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YUYGsTGVxbpsNo1qkK6KoB801JL+yVDHRFSrCPkcQSHf25caA75V3YKsRhEPmGkZIX k4TsoKJOxGo3FF5tepbAwFzxkDbKErOek+uY9sMfa+q1NGRykQshZl+cN9uz5E725aq/ RDzi6cSxYXN3/5hNavNXriNLzsvz22ySK/3yQ= MIME-Version: 1.0 Received: by 10.211.196.13 with SMTP id y13mr440479ebp.79.1235601446619; Wed, 25 Feb 2009 14:37:26 -0800 (PST) In-Reply-To: References: Date: Wed, 25 Feb 2009 23:37:26 +0100 Message-ID: Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in From: Juanma Barranquero To: Stefan Monnier Cc: 2439@debbugs.gnu.org, Geoff Gole Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2009 at 20:53, Stefan Monnier wr= ote: > Agreed. =C2=A0But still using (point-min) rather than 1. OK, fixed in these two cases. There are still 31 instances of (goto-char 1) in 24 files: autoinsert.el indent.el simple.el emacs-lisp\gulp.el emacs-lisp\testcover.el international\ja-dic-cnv.el international\quail.el mail\mail-utils.el mail\mailalias.el net\ange-ftp.el nxml\rng-cmpct.el play\dissociate.el progmodes\ada-xref.el progmodes\cperl-mode.el progmodes\ebrowse.el progmodes\idlwave.el progmodes\ps-mode.el textmodes\page.el textmodes\reftex-cite.el textmodes\reftex-dcr.el textmodes\reftex-index.el textmodes\reftex-parse.el textmodes\reftex-ref.el textmodes\reftex.el Juanma From geoffgole@gmail.com Wed Feb 25 21:00:50 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 26 Feb 2009 05:00:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1Q50loD027744 for ; Wed, 25 Feb 2009 21:00:48 -0800 Received: from mx10.gnu.org ([199.232.76.166]:34237) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LcYKL-0000BC-PO for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 23:58:29 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LcYMX-0000DI-QH for emacs-pretest-bug@gnu.org; Thu, 26 Feb 2009 00:00:46 -0500 Received: from an-out-0708.google.com ([209.85.132.247]:49163) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LcYMX-0000DA-Hv for emacs-pretest-bug@gnu.org; Thu, 26 Feb 2009 00:00:45 -0500 Received: by an-out-0708.google.com with SMTP id b6so281192ana.21 for ; Wed, 25 Feb 2009 21:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=prX/cz/deLwmbweisXzXPjNCMlC2l6CCx1DYc2c3aRw=; b=tZaunel82GcfoCX9yHQ0aoVtdnwZfedj2GYs8Ec2l+oRGqM5E7KfSS9Pi/R/JFYAw6 iM8lu2DtMSUsMaAUm0mDsPfwtlDsp9UGfGRH6jhjCco9d4XZqfbthfCW554c4Jlv1nex /mRBA3oL2Uq7VwHS66+bMsv60zRv0PTDnZPTI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=IhL2sObbHMH4s+92zPQV8nVS0aLled4PTDHjmz1teRxW3F8ccUCpGrJQ+qMMmy7Zr/ pHnZUkjbhp7QUJki5cJF3lER4rbeFNFbh6mV1XKQ5AXAqy/IHxoeswjv3CHLx8ko6xW7 EipI5VqYj6kP4r7Q8SrwSVP3lmeJmq/O/bb6w= MIME-Version: 1.0 Received: by 10.143.29.17 with SMTP id g17mr461908wfj.109.1235624443904; Wed, 25 Feb 2009 21:00:43 -0800 (PST) In-Reply-To: References: Date: Thu, 26 Feb 2009 14:00:43 +0900 Message-ID: Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer From: Geoff Gole To: Stefan Monnier , emacs-pretest-bug@gnu.org, 2439@debbugs.gnu.org, lekktu@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) > Thanks for your patch, but please try to avoid hardcoding "1" as above. > Just use (point-min) instead. Good point. I took a peek at the source of goto-line to see if it did anything that I'd need to replicate, and grabbed the line from there without thinking. Should goto-line also use (point-min)? > I don't think narrowing the ibuffer buffer and then sorting is > a common enough operation to worry about it. I didn't bother with handling restrictions, as they don't seem to be respected by ibuffer. Narrowed ibuffer buffers will either behave strangely or simply clobber the restriction. Perhaps I should have mentioned that in a comment or when submitting the patch. From monnier@iro.umontreal.ca Thu Feb 26 07:17:23 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 26 Feb 2009 15:17:23 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1QFHKXB029407 for ; Thu, 26 Feb 2009 07:17:22 -0800 Received: from mx10.gnu.org ([199.232.76.166]:55294) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Lchx1-0004M8-Ef for emacs-pretest-bug@gnu.org; Thu, 26 Feb 2009 10:15:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LchzD-0001Wr-Rd for emacs-pretest-bug@gnu.org; Thu, 26 Feb 2009 10:17:20 -0500 Received: from ironport2-out.pppoe.ca ([206.248.154.182]:54067 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LchzD-0001Vv-Kq for emacs-pretest-bug@gnu.org; Thu, 26 Feb 2009 10:17:19 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgsFAP9ApklFxKYM/2dsb2JhbACBb9d+hBEGg2Y X-IronPort-AV: E=Sophos;i="4.38,271,1233550800"; d="scan'208";a="34438117" Received: from 69-196-166-12.dsl.teksavvy.com (HELO pastel.home) ([69.196.166.12]) by ironport2-out.teksavvy.com with ESMTP; 26 Feb 2009 10:17:16 -0500 Received: by pastel.home (Postfix, from userid 20848) id 58D9C9114; Thu, 26 Feb 2009 10:17:15 -0500 (EST) From: Stefan Monnier To: Geoff Gole Cc: emacs-pretest-bug@gnu.org, 2439@debbugs.gnu.org, lekktu@gmail.com Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in Message-ID: References: Date: Thu, 26 Feb 2009 10:17:15 -0500 In-Reply-To: (Geoff Gole's message of "Thu, 26 Feb 2009 14:00:43 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. > I didn't bother with handling restrictions, as they don't seem to be > respected by ibuffer. Narrowed ibuffer buffers will either behave > strangely or simply clobber the restriction. > Perhaps I should have mentioned that in a comment or when submitting > the patch. This issue is unrelated to your patch, really. Stefan From monnier@iro.umontreal.ca Thu Feb 26 07:16:25 2009 Received: (at 2439) by emacsbugs.donarmstrong.com; 26 Feb 2009 15:16:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1QFGMmW029382 for <2439@emacsbugs.donarmstrong.com>; Thu, 26 Feb 2009 07:16:23 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgsFAP9ApklFxKYM/2dsb2JhbACBb9d+hBEGg2Y X-IronPort-AV: E=Sophos;i="4.38,271,1233550800"; d="scan'208";a="34438050" Received: from 69-196-166-12.dsl.teksavvy.com (HELO pastel.home) ([69.196.166.12]) by ironport2-out.teksavvy.com with ESMTP; 26 Feb 2009 10:16:16 -0500 Received: by pastel.home (Postfix, from userid 20848) id D01A59114; Thu, 26 Feb 2009 10:16:15 -0500 (EST) From: Stefan Monnier To: Juanma Barranquero Cc: 2439@debbugs.gnu.org, Geoff Gole Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in Message-ID: References: Date: Thu, 26 Feb 2009 10:16:15 -0500 In-Reply-To: (Juanma Barranquero's message of "Wed, 25 Feb 2009 23:37:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable >> Agreed. =A0But still using (point-min) rather than 1. > OK, fixed in these two cases. There are still 31 instances of > (goto-char 1) in 24 files: There's no hurry to change that code. Just keep it in mind when you write new code or modify existing code. Stefan From unknown Wed Aug 20 02:46:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Mar 2009 14:24:12 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator