From unknown Sat Jun 21 12:14:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24384: [PATCH] Add tests for ring.el Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2016 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24384 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 24384@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14731883441979 (code B ref -1); Tue, 06 Sep 2016 19:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Sep 2016 18:59:04 +0000 Received: from localhost ([127.0.0.1]:51701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhLaK-0000Vr-A0 for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:59:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhLaG-0000VK-7E for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:59:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhLa1-000314-5c for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:58:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLa1-00030u-2h for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:58:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLZo-0001x1-Ro for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 14:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhLZi-0002uy-Fs for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 14:58:32 -0400 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]:32820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLZi-0002uq-3V for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 14:58:26 -0400 Received: by mail-lf0-x22b.google.com with SMTP id h127so49942368lfh.0 for ; Tue, 06 Sep 2016 11:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:message-id:mime-version; bh=HZe2A/LADtSqGXR4YmsAY2FzxDKKKuXUADXTpCfmnB4=; b=WnXKAIYU7SywPPqlWG0vBq8bbpPd4JuC0KkCNN9203HK2wnFbD5qyxwiuqI0wxhxLj w1aXvAaJ6fAozMdfJq+Bs3MfEqTDcAH2b77IdvGrxRRytbtQyDhzevn8jgzL8CtyBPwT V9CsmWPZ7dBtqU7XKvhm8LV8iRwZpTsxeh09BbZ3sys7h8BPXvMrcqXbXTymkdYsPAVr JmWc3nqqilK+8JnL1ygYbbg7YohRftBpso1laFCMnIfG+Qik88oe/N/MJBJGoIYDM0zl sYyLXq+56TOzM2ZQdnEe16P2Jki/mrl5S2izczEhQk8dD4GJQkoF4ek14UXt6s5UNG4P cKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:message-id:mime-version; bh=HZe2A/LADtSqGXR4YmsAY2FzxDKKKuXUADXTpCfmnB4=; b=R8gmeXOLtjbQSIgO72HAoG3lfr8oYKeCn1mhZ7ghlUDVryRVehJbbpDpIxXmfdzt48 bwwI64HiUPbeNw/APa6JGSfb1dZR2xtX5qtVsco0w4oCX87sq6N/7zcCMFvlbqIv5RTM OFrGJtWElNQB1/YtSiSsNmW04wSTTj7txcMEq7CZmW/eJNwmTXj9+lsCR6nqviaUUy7V kVSClRMIlWBk5o8CJhZDiYwNgJD1zrVQ68Vl9GrOs2xeJhS8TiMnlkPGtnrwGqUB6bVC xOhMfN0NpIgiswT1738re0D569FfmcUuRFrM9ScEmRELTYpZSorjbbQSBKRJzK9Wotwk seaA== X-Gm-Message-State: AE9vXwOxPhrRrUDChK8pqVxr+dlOgNF/3S90wawuMVE3gA74f+7S0u8gV/4FQHCwfFs/qA== X-Received: by 10.46.32.136 with SMTP id g8mr3645491lji.54.1473188304519; Tue, 06 Sep 2016 11:58:24 -0700 (PDT) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id q36sm5775258lfi.26.2016.09.06.11.58.23 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Sep 2016 11:58:23 -0700 (PDT) Date: Tue, 06 Sep 2016 20:58:22 +0200 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Message-Id: <1473188302.21137.0@smtp.gmail.com> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-9rZ4BsufzbamqtuM2Jmj" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-9rZ4BsufzbamqtuM2Jmj Content-Type: text/plain; charset=utf-8; format=flowed Hello, I saw that ring.el didn't have any tests, so I wrote some. Unless anyone has any objections, I'll install them within a few days. After the tests are in place I also plan to turn on lexical binding for ring.el. -- Simen --=-9rZ4BsufzbamqtuM2Jmj Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tests-for-ring.el.patch Content-Transfer-Encoding: quoted-printable >From 9213fba393ffa5f163398c46b923cea2fed9add5 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Simen=3D20Heggest=3DC3=3DB8yl?=3D Date: Sat, 3 Sep 2016 20:35:23 +0200 Subject: [PATCH] Add tests for ring.el * test/lisp/emacs-lisp/ring-tests.el: New file with tests for ring.el. --- test/lisp/emacs-lisp/ring-tests.el | 204 +++++++++++++++++++++++++++++++++= ++++ 1 file changed, 204 insertions(+) create mode 100644 test/lisp/emacs-lisp/ring-tests.el diff --git a/test/lisp/emacs-lisp/ring-tests.el b/test/lisp/emacs-lisp/ring= -tests.el new file mode 100644 index 0000000..705bfe5 --- /dev/null +++ b/test/lisp/emacs-lisp/ring-tests.el @@ -0,0 +1,204 @@ +;;; ring-tests.el --- Tests for ring.el -*- lexical-binding: t; -*- + +;; Copyright (C) 2016 Free Software Foundation, Inc. + +;; Author: Simen Heggest=C3=B8yl +;; Keywords: + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; + +;;; Code: + +(require 'ert) +(require 'ring) + +(ert-deftest ring-tests-make-ring-ring-p () + (should (ring-p (make-ring 5)))) + +(ert-deftest ring-tests-insert-at-beginning () + (let ((ring (make-ring 5))) + (ring-insert-at-beginning ring 'foo) + (ring-insert-at-beginning ring 'bar) + (should (equal (ring-elements ring) '(foo bar))))) + +(ert-deftest ring-tests-plus1 () + (should (=3D (ring-plus1 0 5) 1)) + (should (=3D (ring-plus1 4 5) 0))) + +(ert-deftest ring-tests-minus1 () + (should (=3D (ring-minus1 0 5) 4)) + (should (=3D (ring-minus1 4 5) 3))) + +(ert-deftest ring-tests-length () + (let ((ring (make-ring 2))) + (should (=3D (ring-length ring) 0)) + (ring-insert ring 'a) + (should (=3D (ring-length ring) 1)) + (ring-insert ring 'b) + (should (=3D (ring-length ring) 2)) + (ring-insert ring 'c) + (should (=3D (ring-length ring) 2)))) + +(ert-deftest ring-tests-index () + (should (=3D (ring-index 0 0 3 3) 2)) + (should (=3D (ring-index 0 0 3 5) 2)) + (should (=3D (ring-index 0 2 3 3) 1)) + (should (=3D (ring-index 1 2 3 3) 0)) + (should (=3D (ring-index 2 2 3 3) 2))) + +(ert-deftest ring-tests-empty-p () + (let ((ring (make-ring 5))) + (should (ring-empty-p ring)) + (ring-insert ring 1) + (should-not (ring-empty-p ring)) + (ring-remove ring) + (should (ring-empty-p ring)))) + +(ert-deftest ring-tests-size () + (let ((ring (make-ring 2))) + (should (=3D (ring-size ring) 2)) + (ring-insert ring "a") + (ring-insert ring "b") + (ring-insert ring "c") + (should (=3D (ring-size ring) 2)) + (ring-extend ring 3) + (should (=3D (ring-size ring) 5)))) + +(ert-deftest ring-tests-copy () + (let ((ring1 (make-ring 3))) + (ring-insert ring1 1) + (ring-insert ring1 2) + (let ((ring2 (ring-copy ring1))) + (should-not (eq ring1 ring2)) + (should (=3D (ring-size ring1) (ring-size ring2))) + (should (equal (ring-elements ring1) (ring-elements ring2)))))) + +(ert-deftest ring-tests-insert () + (let ((ring (make-ring 2))) + (ring-insert ring :a) + (should (equal (ring-elements ring) '(:a))) + (ring-insert ring :b) + (should (equal (ring-elements ring) '(:b :a))) + (ring-insert ring :c) + (should (equal (ring-elements ring) '(:c :b))))) + +(ert-deftest ring-tests-remove () + (let ((ring (make-ring 2))) + (should-error (ring-remove ring)) + (ring-insert ring 'foo) + (ring-insert ring 'bar) + (should (eq (ring-remove ring) 'foo)) + (should (equal (ring-elements ring) '(bar))) + (ring-insert ring 'baz) + (should (eq (ring-remove ring 0) 'baz)) + (should (equal (ring-elements ring) '(bar))))) + +(ert-deftest ring-tests-ref () + (let ((ring (make-ring 2))) + (should-error (ring-ref ring 0)) + (ring-insert ring :a) + (should (eq (ring-ref ring 0) :a)) + (ring-insert ring :b) + (should (eq (ring-ref ring 0) :b)) + (should (eq (ring-ref ring 1) :a)) + (should (eq (ring-ref ring 2) :b)))) + +(ert-deftest ring-tests-elements () + (let ((ring (make-ring 5))) + (ring-insert ring 3) + (ring-insert ring 2) + (ring-insert ring 1) + (should (equal (ring-elements ring) '(1 2 3))))) + +(ert-deftest ring-tests-member () + (let ((ring (make-ring 3))) + (ring-insert ring "foo") + (ring-insert ring "bar") + (should (=3D (ring-member ring "foo") 1)) + (should (=3D (ring-member ring "bar") 0)) + (should-not (ring-member ring "baz")))) + +(ert-deftest ring-tests-next () + (let ((ring (make-ring 3))) + (ring-insert ring 'a) + (ring-insert ring 'b) + (should (eq (ring-next ring 'b) 'a)) + (should (eq (ring-next ring 'a) 'b)) + (should-error (ring-next ring 'c)))) + +(ert-deftest ring-tests-previous () + (let ((ring (make-ring 3))) + (ring-insert ring 'a) + (ring-insert ring 'b) + (should (eq (ring-previous ring 'b) 'a)) + (should (eq (ring-previous ring 'a) 'b)) + (should-error (ring-previous ring 'c)))) + +(ert-deftest ring-tests-extend () + (let ((ring (make-ring 2))) + (ring-insert ring 1) + (ring-insert ring 2) + (should (=3D (ring-size ring) 2)) + (should (=3D (ring-length ring) 2)) + (ring-extend ring 3) + (ring-insert ring 3) + (should (=3D (ring-size ring) 5)) + (should (equal (ring-elements ring) '(3 2 1))))) + +(ert-deftest ring-tests-insert () + (let ((ring (make-ring 2))) + (ring-insert+extend ring :a) + (ring-insert+extend ring :b) + (should (equal (ring-elements ring) '(:b :a))) + (ring-insert+extend ring :c) + (should (equal (ring-elements ring) '(:c :b))) + (ring-insert+extend ring :d t) + (should (equal (ring-elements ring) '(:d :c :b))))) + +(ert-deftest ring-tests-remove+insert+extend () + (let ((ring (make-ring 3))) + (ring-insert ring 1) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-remove+insert+extend ring 1) + (should (equal (ring-elements ring) '(1 2))) + (ring-remove+insert+extend ring 0) + (should (equal (ring-elements ring) '(0 1 2))) + (ring-remove+insert+extend ring 3) + (should (equal (ring-elements ring) '(3 0 1))) + (ring-remove+insert+extend ring 4 t) + (should (equal (ring-elements ring) '(4 3 0 1))) + (ring-remove+insert+extend ring 1 t) + (should (equal (ring-elements ring) '(1 4 3 0))))) + +(ert-deftest ring-tests-convert-sequence-to-ring () + (let ((ring (ring-convert-sequence-to-ring '(a b c)))) + (should (equal (ring-elements ring) '(a b c)))) + (let ((ring (ring-convert-sequence-to-ring [1 2 3]))) + (should (equal (ring-elements ring) '(1 2 3)))) + (let ((ring (ring-convert-sequence-to-ring "abc"))) + (should (equal (ring-elements ring) '(?a ?b ?c)))) + (let ((ring (make-ring 2))) + (ring-insert ring :a) + (ring-insert ring :b) + (should + (equal (ring-elements (ring-convert-sequence-to-ring ring)) + (ring-elements ring))))) + +(provide 'ring-tests) +;;; ring-tests.el ends here --=20 2.9.3 = --=-9rZ4BsufzbamqtuM2Jmj-- From unknown Sat Jun 21 12:14:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Subject: bug#24384: closed (Re: bug#24384: [PATCH] Add tests for ring.el) Message-ID: References: <1473355280.21693.0@smtp.gmail.com> <1473188302.21137.0@smtp.gmail.com> X-Gnu-PR-Message: they-closed 24384 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 24384@debbugs.gnu.org Date: Thu, 08 Sep 2016 17:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1473355322-31847-1" This is a multi-part message in MIME format... ------------=_1473355322-31847-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24384: [PATCH] Add tests for ring.el which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24384@debbugs.gnu.org. --=20 24384: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24384 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1473355322-31847-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24384-done) by debbugs.gnu.org; 8 Sep 2016 17:21:30 +0000 Received: from localhost ([127.0.0.1]:53835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi310-0008H1-2B for submit@debbugs.gnu.org; Thu, 08 Sep 2016 13:21:30 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:34018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi30z-0008Gn-6f for 24384-done@debbugs.gnu.org; Thu, 08 Sep 2016 13:21:29 -0400 Received: by mail-lf0-f49.google.com with SMTP id u14so26607216lfd.1 for <24384-done@debbugs.gnu.org>; Thu, 08 Sep 2016 10:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:message-id:in-reply-to:references:mime-version; bh=Z8ZdeJfPnfdcIxvuopeF7bd6GFUXZE7zuvAdjDG9Mzw=; b=ux3Ut6QHQWjEw/j1R0OS5AG1McpLBPnUPFYPosfyS3Trm0gs+Yv0zKrJLdE3Hs98ov 1+COhDJr802PU9VufIQGIs/ompowcCCWBzyfzvxIk8uZF+3du0iYJsPHM4CsnWqCwQ/d 0PSEp75MBe4SYSHazYgz9DAxCfJyKV9eQDIWoBqjDqH926oNoz2ClEJQiCynbW7W+B7m e0jlGnuQKmpXLDp06Vtq19KdbyZL75XJXmd9QTivN1JQz0LArG0lNQ/rBEGC9LaR9t9E zEvSxtTMSsTZX/0Xe0+tlBuq5fOola36LB/Pp6jvl/dd5ARn2hWfJB5WYg7HUpTcs/or H3Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:message-id:in-reply-to :references:mime-version; bh=Z8ZdeJfPnfdcIxvuopeF7bd6GFUXZE7zuvAdjDG9Mzw=; b=P9YdWS6ejWy/e1Rmzz8FurS8YL1vJhTvmpPQG28PsLWPwv0oXquCm5rmPxM8udaqLU 8qvPYDO/Rc2qQfZJCj/N6BLfPAk8t/0pL6bvJ0GzuTJVN3SSIgtQ0NG40CMnBwPn5cXu bigwVcMaKF8S+CZwugYVnUELbk5vuYDPJc1O4nusJkq7nSWYrYP6wui/fplad/Tj9WhU HzN+NiWFl5trH+hZeDLYE5ckhE48+wmUyVLBuuzt/7X69fdT7p8yhVordJlyqEKnH9Y0 T/aXr/nEsVMfX+jyxwWDcQubyqcXFVcui028LfV5QC7cVAyQK1ccmd+MgovhZJGEbRg2 Dfbg== X-Gm-Message-State: AE9vXwMXS6DEIuGbSJwj6YzPOXM0G/IScSMEOgWV+z3CKZ03Rcsq7DIo/1l6k+Yx84n/ew== X-Received: by 10.46.5.9 with SMTP id 9mr279042ljf.17.1473355282681; Thu, 08 Sep 2016 10:21:22 -0700 (PDT) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id c125sm1553299lfe.10.2016.09.08.10.21.21 for <24384-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Sep 2016 10:21:22 -0700 (PDT) Date: Thu, 08 Sep 2016 19:21:20 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#24384: [PATCH] Add tests for ring.el To: 24384-done@debbugs.gnu.org Message-Id: <1473355280.21693.0@smtp.gmail.com> In-Reply-To: <1473188302.21137.0@smtp.gmail.com> References: <1473188302.21137.0@smtp.gmail.com> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Installed in master. -- Simen [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (simenheg[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.49 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.49 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 24384-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Installed in master. -- Simen [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.49 listed in dnsbl.sorbs.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.49 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (simenheg[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Installed in master. -- Simen ------------=_1473355322-31847-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Sep 2016 18:59:04 +0000 Received: from localhost ([127.0.0.1]:51701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhLaK-0000Vr-A0 for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:59:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhLaG-0000VK-7E for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:59:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhLa1-000314-5c for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:58:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLa1-00030u-2h for submit@debbugs.gnu.org; Tue, 06 Sep 2016 14:58:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLZo-0001x1-Ro for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 14:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhLZi-0002uy-Fs for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 14:58:32 -0400 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]:32820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLZi-0002uq-3V for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 14:58:26 -0400 Received: by mail-lf0-x22b.google.com with SMTP id h127so49942368lfh.0 for ; Tue, 06 Sep 2016 11:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:message-id:mime-version; bh=HZe2A/LADtSqGXR4YmsAY2FzxDKKKuXUADXTpCfmnB4=; b=WnXKAIYU7SywPPqlWG0vBq8bbpPd4JuC0KkCNN9203HK2wnFbD5qyxwiuqI0wxhxLj w1aXvAaJ6fAozMdfJq+Bs3MfEqTDcAH2b77IdvGrxRRytbtQyDhzevn8jgzL8CtyBPwT V9CsmWPZ7dBtqU7XKvhm8LV8iRwZpTsxeh09BbZ3sys7h8BPXvMrcqXbXTymkdYsPAVr JmWc3nqqilK+8JnL1ygYbbg7YohRftBpso1laFCMnIfG+Qik88oe/N/MJBJGoIYDM0zl sYyLXq+56TOzM2ZQdnEe16P2Jki/mrl5S2izczEhQk8dD4GJQkoF4ek14UXt6s5UNG4P cKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:message-id:mime-version; bh=HZe2A/LADtSqGXR4YmsAY2FzxDKKKuXUADXTpCfmnB4=; b=R8gmeXOLtjbQSIgO72HAoG3lfr8oYKeCn1mhZ7ghlUDVryRVehJbbpDpIxXmfdzt48 bwwI64HiUPbeNw/APa6JGSfb1dZR2xtX5qtVsco0w4oCX87sq6N/7zcCMFvlbqIv5RTM OFrGJtWElNQB1/YtSiSsNmW04wSTTj7txcMEq7CZmW/eJNwmTXj9+lsCR6nqviaUUy7V kVSClRMIlWBk5o8CJhZDiYwNgJD1zrVQ68Vl9GrOs2xeJhS8TiMnlkPGtnrwGqUB6bVC xOhMfN0NpIgiswT1738re0D569FfmcUuRFrM9ScEmRELTYpZSorjbbQSBKRJzK9Wotwk seaA== X-Gm-Message-State: AE9vXwOxPhrRrUDChK8pqVxr+dlOgNF/3S90wawuMVE3gA74f+7S0u8gV/4FQHCwfFs/qA== X-Received: by 10.46.32.136 with SMTP id g8mr3645491lji.54.1473188304519; Tue, 06 Sep 2016 11:58:24 -0700 (PDT) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id q36sm5775258lfi.26.2016.09.06.11.58.23 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Sep 2016 11:58:23 -0700 (PDT) Date: Tue, 06 Sep 2016 20:58:22 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: [PATCH] Add tests for ring.el To: bug-gnu-emacs@gnu.org Message-Id: <1473188302.21137.0@smtp.gmail.com> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-9rZ4BsufzbamqtuM2Jmj" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-9rZ4BsufzbamqtuM2Jmj Content-Type: text/plain; charset=utf-8; format=flowed Hello, I saw that ring.el didn't have any tests, so I wrote some. Unless anyone has any objections, I'll install them within a few days. After the tests are in place I also plan to turn on lexical binding for ring.el. -- Simen --=-9rZ4BsufzbamqtuM2Jmj Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tests-for-ring.el.patch Content-Transfer-Encoding: quoted-printable >From 9213fba393ffa5f163398c46b923cea2fed9add5 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Simen=3D20Heggest=3DC3=3DB8yl?=3D Date: Sat, 3 Sep 2016 20:35:23 +0200 Subject: [PATCH] Add tests for ring.el * test/lisp/emacs-lisp/ring-tests.el: New file with tests for ring.el. --- test/lisp/emacs-lisp/ring-tests.el | 204 +++++++++++++++++++++++++++++++++= ++++ 1 file changed, 204 insertions(+) create mode 100644 test/lisp/emacs-lisp/ring-tests.el diff --git a/test/lisp/emacs-lisp/ring-tests.el b/test/lisp/emacs-lisp/ring= -tests.el new file mode 100644 index 0000000..705bfe5 --- /dev/null +++ b/test/lisp/emacs-lisp/ring-tests.el @@ -0,0 +1,204 @@ +;;; ring-tests.el --- Tests for ring.el -*- lexical-binding: t; -*- + +;; Copyright (C) 2016 Free Software Foundation, Inc. + +;; Author: Simen Heggest=C3=B8yl +;; Keywords: + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; + +;;; Code: + +(require 'ert) +(require 'ring) + +(ert-deftest ring-tests-make-ring-ring-p () + (should (ring-p (make-ring 5)))) + +(ert-deftest ring-tests-insert-at-beginning () + (let ((ring (make-ring 5))) + (ring-insert-at-beginning ring 'foo) + (ring-insert-at-beginning ring 'bar) + (should (equal (ring-elements ring) '(foo bar))))) + +(ert-deftest ring-tests-plus1 () + (should (=3D (ring-plus1 0 5) 1)) + (should (=3D (ring-plus1 4 5) 0))) + +(ert-deftest ring-tests-minus1 () + (should (=3D (ring-minus1 0 5) 4)) + (should (=3D (ring-minus1 4 5) 3))) + +(ert-deftest ring-tests-length () + (let ((ring (make-ring 2))) + (should (=3D (ring-length ring) 0)) + (ring-insert ring 'a) + (should (=3D (ring-length ring) 1)) + (ring-insert ring 'b) + (should (=3D (ring-length ring) 2)) + (ring-insert ring 'c) + (should (=3D (ring-length ring) 2)))) + +(ert-deftest ring-tests-index () + (should (=3D (ring-index 0 0 3 3) 2)) + (should (=3D (ring-index 0 0 3 5) 2)) + (should (=3D (ring-index 0 2 3 3) 1)) + (should (=3D (ring-index 1 2 3 3) 0)) + (should (=3D (ring-index 2 2 3 3) 2))) + +(ert-deftest ring-tests-empty-p () + (let ((ring (make-ring 5))) + (should (ring-empty-p ring)) + (ring-insert ring 1) + (should-not (ring-empty-p ring)) + (ring-remove ring) + (should (ring-empty-p ring)))) + +(ert-deftest ring-tests-size () + (let ((ring (make-ring 2))) + (should (=3D (ring-size ring) 2)) + (ring-insert ring "a") + (ring-insert ring "b") + (ring-insert ring "c") + (should (=3D (ring-size ring) 2)) + (ring-extend ring 3) + (should (=3D (ring-size ring) 5)))) + +(ert-deftest ring-tests-copy () + (let ((ring1 (make-ring 3))) + (ring-insert ring1 1) + (ring-insert ring1 2) + (let ((ring2 (ring-copy ring1))) + (should-not (eq ring1 ring2)) + (should (=3D (ring-size ring1) (ring-size ring2))) + (should (equal (ring-elements ring1) (ring-elements ring2)))))) + +(ert-deftest ring-tests-insert () + (let ((ring (make-ring 2))) + (ring-insert ring :a) + (should (equal (ring-elements ring) '(:a))) + (ring-insert ring :b) + (should (equal (ring-elements ring) '(:b :a))) + (ring-insert ring :c) + (should (equal (ring-elements ring) '(:c :b))))) + +(ert-deftest ring-tests-remove () + (let ((ring (make-ring 2))) + (should-error (ring-remove ring)) + (ring-insert ring 'foo) + (ring-insert ring 'bar) + (should (eq (ring-remove ring) 'foo)) + (should (equal (ring-elements ring) '(bar))) + (ring-insert ring 'baz) + (should (eq (ring-remove ring 0) 'baz)) + (should (equal (ring-elements ring) '(bar))))) + +(ert-deftest ring-tests-ref () + (let ((ring (make-ring 2))) + (should-error (ring-ref ring 0)) + (ring-insert ring :a) + (should (eq (ring-ref ring 0) :a)) + (ring-insert ring :b) + (should (eq (ring-ref ring 0) :b)) + (should (eq (ring-ref ring 1) :a)) + (should (eq (ring-ref ring 2) :b)))) + +(ert-deftest ring-tests-elements () + (let ((ring (make-ring 5))) + (ring-insert ring 3) + (ring-insert ring 2) + (ring-insert ring 1) + (should (equal (ring-elements ring) '(1 2 3))))) + +(ert-deftest ring-tests-member () + (let ((ring (make-ring 3))) + (ring-insert ring "foo") + (ring-insert ring "bar") + (should (=3D (ring-member ring "foo") 1)) + (should (=3D (ring-member ring "bar") 0)) + (should-not (ring-member ring "baz")))) + +(ert-deftest ring-tests-next () + (let ((ring (make-ring 3))) + (ring-insert ring 'a) + (ring-insert ring 'b) + (should (eq (ring-next ring 'b) 'a)) + (should (eq (ring-next ring 'a) 'b)) + (should-error (ring-next ring 'c)))) + +(ert-deftest ring-tests-previous () + (let ((ring (make-ring 3))) + (ring-insert ring 'a) + (ring-insert ring 'b) + (should (eq (ring-previous ring 'b) 'a)) + (should (eq (ring-previous ring 'a) 'b)) + (should-error (ring-previous ring 'c)))) + +(ert-deftest ring-tests-extend () + (let ((ring (make-ring 2))) + (ring-insert ring 1) + (ring-insert ring 2) + (should (=3D (ring-size ring) 2)) + (should (=3D (ring-length ring) 2)) + (ring-extend ring 3) + (ring-insert ring 3) + (should (=3D (ring-size ring) 5)) + (should (equal (ring-elements ring) '(3 2 1))))) + +(ert-deftest ring-tests-insert () + (let ((ring (make-ring 2))) + (ring-insert+extend ring :a) + (ring-insert+extend ring :b) + (should (equal (ring-elements ring) '(:b :a))) + (ring-insert+extend ring :c) + (should (equal (ring-elements ring) '(:c :b))) + (ring-insert+extend ring :d t) + (should (equal (ring-elements ring) '(:d :c :b))))) + +(ert-deftest ring-tests-remove+insert+extend () + (let ((ring (make-ring 3))) + (ring-insert ring 1) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-remove+insert+extend ring 1) + (should (equal (ring-elements ring) '(1 2))) + (ring-remove+insert+extend ring 0) + (should (equal (ring-elements ring) '(0 1 2))) + (ring-remove+insert+extend ring 3) + (should (equal (ring-elements ring) '(3 0 1))) + (ring-remove+insert+extend ring 4 t) + (should (equal (ring-elements ring) '(4 3 0 1))) + (ring-remove+insert+extend ring 1 t) + (should (equal (ring-elements ring) '(1 4 3 0))))) + +(ert-deftest ring-tests-convert-sequence-to-ring () + (let ((ring (ring-convert-sequence-to-ring '(a b c)))) + (should (equal (ring-elements ring) '(a b c)))) + (let ((ring (ring-convert-sequence-to-ring [1 2 3]))) + (should (equal (ring-elements ring) '(1 2 3)))) + (let ((ring (ring-convert-sequence-to-ring "abc"))) + (should (equal (ring-elements ring) '(?a ?b ?c)))) + (let ((ring (make-ring 2))) + (ring-insert ring :a) + (ring-insert ring :b) + (should + (equal (ring-elements (ring-convert-sequence-to-ring ring)) + (ring-elements ring))))) + +(provide 'ring-tests) +;;; ring-tests.el ends here --=20 2.9.3 = --=-9rZ4BsufzbamqtuM2Jmj-- ------------=_1473355322-31847-1--