GNU bug report logs - #24383
25.1.50; Deprecation/internalization of `read-from-whole-string'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Tue, 6 Sep 2016 16:53:02 UTC

Severity: minor

Found in version 25.1.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 24383 <at> debbugs.gnu.org
Subject: bug#24383: 25.1.50; Deprecation/internalization of `read-from-whole-string'
Date: Sat, 06 Feb 2021 13:37:51 +0100
Drew Adams <drew.adams <at> oracle.com> writes:

> What's the rationale behind the demotion of `read-from-whole-string'
> and its replacement by "internal" function
> `thing-at-point--read-from-whole-string'?
>
>   "This is an internal thingatpt function and should not be used."
>
> Should not be used?  Really?  Why?

"Should not be used" is perhaps over-stating the case, but it's an
internal thingatpt function with a name that didn't reflect that, so
renaming it is appropriate.

> Based on this (seemingly gratuitous) change, existing user code now
> has to fiddle, to be usable in more than one Emacs version (versions
> 0 to 24.5 vs version 25.1).
>
>  (if (fboundp 'read-from-whole-string)
>      (read-from-whole-string strg)
>    (thing-at-point--read-from-whole-string strg))

It's up to you whether you want to use internal Emacs functions, of
course.

Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 106 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.