From juri@jurta.org Sun Feb 22 13:56:12 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 22 Feb 2009 21:56:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1MLu9IZ012189 for ; Sun, 22 Feb 2009 13:56:10 -0800 Received: from mx10.gnu.org ([199.232.76.166]:51316) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LbMGq-00074n-PJ for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 16:53:56 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LbMIx-0000CX-Of for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 16:56:08 -0500 Received: from relay01.kiev.sovam.com ([62.64.120.200]:4002) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LbMIx-0000BH-Bv for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 16:56:07 -0500 Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.69) (envelope-from ) id 1LbMIs-000BO6-3s for emacs-pretest-bug@gnu.org; Sun, 22 Feb 2009 23:56:02 +0200 From: Juri Linkov To: emacs-pretest-bug@gnu.org Subject: Unable to find location of adviced function Organization: JURTA Date: Sun, 22 Feb 2009 23:52:41 +0200 Message-ID: <874oymjjpy.fsf@jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanner-Signature: 1118cf21f7425d415ed61e91afc5cb63 X-DrWeb-checked: yes X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) Test case: 1. Create a file test.el with: (defun test1 () (interactive) (message "Test1")) (defadvice test1 (around my-test1 act) (message "Test1 pre") ad-do-it (message "Test1 post")) 2. Load it. 3. Type `C-h f test1 RET'. 4. Follow the link `test.el' to the source code. It fails with the error message: "Unable to find location in file" That's because `describe-function-1' uses the variable `real-function' that holds the value "ad-Orig-test1" instead of the variable `function' with the correct value "test1" referring to the original definition. This can be fixed with the following patch: Index: lisp/help-fns.el =================================================================== RCS file: /sources/emacs/emacs/lisp/help-fns.el,v retrieving revision 1.131 diff -u -r1.131 help-fns.el --- lisp/help-fns.el 5 Jan 2009 03:19:15 -0000 1.131 +++ lisp/help-fns.el 22 Feb 2009 21:51:25 -0000 @@ -406,7 +406,7 @@ (with-current-buffer standard-output (save-excursion (re-search-backward "`\\([^`']+\\)'" nil t) - (help-xref-button 1 'help-function-def real-function file-name)))) + (help-xref-button 1 'help-function-def function file-name)))) (princ ".") (with-current-buffer (help-buffer) (fill-region-as-paragraph (save-excursion (goto-char pt1) (forward-line 0) (point)) -- Juri Linkov http://www.jurta.org/emacs/ From lekktu@gmail.com Mon Feb 23 03:24:28 2009 Received: (at control) by emacsbugs.donarmstrong.com; 23 Feb 2009 11:24:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f176.google.com (mail-ew0-f176.google.com [209.85.219.176]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1NBOOtn020519 for ; Mon, 23 Feb 2009 03:24:26 -0800 Received: by ewy24 with SMTP id 24so71426ewy.1 for ; Mon, 23 Feb 2009 03:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=5BuY9b7aLHn2wgUjmfRqqNqIslGDCDu5EAsUChOfp2I=; b=PSwHf6rEcIfuRO7dpBxAFqvcAOZoopS4SkvIvXQl7EIiafuHjPj3pbooVrjVqqMetE 0zqq4DRSH5/phWSSuBC9csPIgbUYmCmTOBH9R+DA8DdZ5DkW879tyYyQnGcyBEJa2QAT PRXR3b9xz4gabEAxhKhkPJSSAQPJdZsZrx/84= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=teRRBhy/FhOEqSIpnUgROCjn4oIKCnL8xerIFgRjn2pcD+nofLwkhH3TPws16T5TDi dTZLwP7DvJYwEOWkynmn2h/zZisPysCdNcsbVRxq9Ihxi3CKYbygkoc/QaFPA2R95lMs 5OOS+dJmsm1BPKM//pJ+nhEzNYIsQSl7BFx30= MIME-Version: 1.0 Received: by 10.210.143.11 with SMTP id q11mr1645099ebd.115.1235388259065; Mon, 23 Feb 2009 03:24:19 -0800 (PST) Date: Mon, 23 Feb 2009 12:24:18 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 2433 emacs,documentation tags 2438 + patch reassign 2419 emacs,python retitle 1854 Emacs opens browser tab twice tags 1854 + moreinfo quit From cyd@stupidchicken.com Sat Jun 27 22:08:30 2009 Received: (at 2438-done) by emacsbugs.donarmstrong.com; 28 Jun 2009 05:08:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.2 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po34.its.yale.edu (pantheon-po34.its.yale.edu [130.132.50.80]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5S58PNZ011386 for <2438-done@emacsbugs.donarmstrong.com>; Sat, 27 Jun 2009 22:08:27 -0700 Received: from furry (c-71-192-161-14.hsd1.nh.comcast.net [71.192.161.14]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n5S58KXO005620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 28 Jun 2009 01:08:20 -0400 Received: by furry (Postfix, from userid 1000) id 41319C09B; Sun, 28 Jun 2009 01:08:20 -0400 (EDT) From: Chong Yidong To: Juri Linkov Cc: 2438-done@debbugs.gnu.org Subject: Re: Unable to find location of adviced function Date: Sun, 28 Jun 2009 01:08:20 -0400 Message-ID: <87y6rdoshn.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) > "Unable to find location in file" > > That's because `describe-function-1' uses the variable `real-function' > that holds the value "ad-Orig-test1" instead of the variable `function' > with the correct value "test1" referring to the original definition. > > This can be fixed with the following patch: I've checked your patch into CVS trunk. Thanks. From unknown Mon Aug 18 04:46:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Jul 2009 14:24:19 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator