GNU bug report logs - #24378
[PATCH 0/6] Small fixes and improvements

Previous Next

Package: emacs;

Reported by: Michal Nazarewicz <mina86 <at> mina86.com>

Date: Tue, 6 Sep 2016 13:29:02 UTC

Severity: minor

Tags: patch

Done: Michal Nazarewicz <mina86 <at> mina86.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michal Nazarewicz <mina86 <at> mina86.com>
Cc: 24378 <at> debbugs.gnu.org
Subject: bug#24378: [PATCH 1/6] Don’t use FETCH_MULTIBYTE_CHAR when advancing index
Date: Tue, 06 Sep 2016 17:43:48 +0300

> From: Michal Nazarewicz <mina86 <at> mina86.com>
> Date: Tue,  6 Sep 2016 15:31:29 +0200
> 
> * src/casefiddle.c (casify_region): use STRING_CHAR_AND_LENGTH as a safe
> alternative to FETCH_MULTIBYTE_CHAR which is documented in src/buffer.h
> as unsafe when used for advancing index.

AFAIK, that comment is stale and no longer correct.  I don't think
there's a reason to make this change anymore, since STRING_CHAR no
longer unifies characters.

Thanks.
This bug report was last modified 8 years and 306 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.