GNU bug report logs - #24362
25.1.50; Inconsistent docstring between pcase-let and pcase-let*

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Robert Cochran <robert-emacs <at> cochranmail.com>
Cc: 24362 <at> debbugs.gnu.org, Chunyang Xu <xuchunyang.me <at> gmail.com>
Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let*
Date: Thu, 15 Sep 2016 23:36:21 +0200

Robert Cochran <robert-emacs <at> cochranmail.com> writes:

> This patch changes the pcase-let* docstring to match the pcase-let
> docstring, but IMO I don't think that the phrase 'a list of
> expressions' is exactly the right term for this. That (to me) implies
> that we are wrapping the whole body in a list, which you don't.

Isn't this just normal "Elisp speak" for a &rest parameter?  Sure, the
value of the parameter doesn't appear in the code (only "spliced in") -
but we use this wording all the time.

> diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
> index 0b8dddf..2d61642 100644
> --- a/lisp/emacs-lisp/pcase.el
> +++ b/lisp/emacs-lisp/pcase.el
> @@ -261,7 +261,7 @@ pcase--let*
>  ;;;###autoload
>  (defmacro pcase-let* (bindings &rest body)
>    "Like `let*' but where you can use `pcase' patterns for bindings.
> -BODY should be an expression, and BINDINGS should be a list of bindings
> +BODY should be a list of expressions, and BINDINGS should be a list of bindings

Looks ok to me.


Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.