From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Chunyang Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Sep 2016 04:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24362@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.147296319611436 (code B ref -1); Sun, 04 Sep 2016 04:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Sep 2016 04:26:36 +0000 Received: from localhost ([127.0.0.1]:49075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgP0t-0002yN-O0 for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgP0s-0002yB-2v for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgP0m-0006F8-4m for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgP0m-0006Ez-1T for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgP0k-0000ZU-33 for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 00:26:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgP0f-0006EV-RR for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 00:26:24 -0400 Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:34115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgP0f-0006ER-LF for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 00:26:21 -0400 Received: by mail-pf0-x235.google.com with SMTP id p64so54619788pfb.1 for ; Sat, 03 Sep 2016 21:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=UIpPVlwicR9tAnTOtHxOR+/C2NUhhLLSM4aLpQzagiw=; b=vA+X9AvnufY04x6HQEWdvEXRChVXXlMEiVyd0TEgietltB9ynHXd2oqbCJn0njhSAn jjYjwzCbBuFA9Rz9DRshpXKsjXBX+P5g8VLGbXxxpEetnkQ4dJTzt773vwh23V8Q+9sm 06AvDa3UFWOgtgfygy1rd+uZbcVLzOo2Af6idlRZP2/gtOPsGa31GoXAn9G0eVIasadG iRSKZUC6FrQXR4kziQdT5Y+klNo2sBJ8yXY0IuD1Pz/rhwYRCFzIPLes9vS1mDLMlzIs c7t4Gd0rPF2ShCuHFe+ZkPQ2PkrlHhAa3tKrn2MFyZ7eDnWbMutZX7gbOFr1rPOjikiT vHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=UIpPVlwicR9tAnTOtHxOR+/C2NUhhLLSM4aLpQzagiw=; b=m+O2VdYAJ91LuX4Ybw89xLo9CJhmyF7bnBTUprbN/lbj5W7Mnr68jPcwePRYuV/QbD Zl14FFaxWbg5wBFCqUuCqlESZMG/ZUJohP3CrSMFQoUk8Gl7tXA/lrHBG1WQq33zTrY4 hj83JkN388BcaAjY5+AVvN6PFE/owARB8HJEy/c3UQmGuesLwLSN36OM33911mj8DCHl 8VLuK89k+w7gZ1gjfmbG3xAsI+sAY0kwm3f0mMn3GyVLfdPVo93Pjju7bVJyacfz2F41 fOD8285pTMK1tethrAa+Cdt6IZbDSqAgOhErjFyubpdt4agfoPDYMz/z8NwBhRYzngEm MEBA== X-Gm-Message-State: AE9vXwMRQXu9JCYfS1NsobA1wq4pawK8ZfimF8MNGWnmTjzkeoHsXJGrE25CmRRmFT8Abg== X-Received: by 10.98.69.201 with SMTP id n70mr51615477pfi.64.1472963180428; Sat, 03 Sep 2016 21:26:20 -0700 (PDT) Received: from localhost ([47.88.9.6]) by smtp.gmail.com with ESMTPSA id l128sm24834637pfl.21.2016.09.03.21.26.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Sep 2016 21:26:19 -0700 (PDT) From: Chunyang Xu Date: Sun, 04 Sep 2016 12:26:05 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It looks like, to me, the structure of the BODY arg of these two should be the same (accepting a list froms). (pcase-let ((a 1)) (incf a) a) => 2 (pcase-let* ((a 1)) (incf a) a) => 2 but the docstrings are using the different words. (pcase-let BINDINGS &rest BODY) Like `let' but where you can use `pcase' patterns for bindings. BODY should be a list of expressions, and BINDINGS should be a list of bindings ^^^^^^^^^^^^^^^^^^^^^ of the form (PAT EXP). (pcase-let* BINDINGS &rest BODY) Like `let*' but where you can use `pcase' patterns for bindings. BODY should be an expression, and BINDINGS should be a list of bindings ^^^^^^^^^^^^^ of the form (PAT EXP). From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 00:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chunyang Xu Cc: 24362@debbugs.gnu.org Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.147390082622529 (code B ref 24362); Thu, 15 Sep 2016 00:54:02 +0000 Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 00:53:46 +0000 Received: from localhost ([127.0.0.1]:59915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkKvy-0005rI-Dj for submit@debbugs.gnu.org; Wed, 14 Sep 2016 20:53:46 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:55185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkKvw-0005r9-JB for 24362@debbugs.gnu.org; Wed, 14 Sep 2016 20:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=0aeP52Ta5xUoEwov7aBfdTCjqds=; b=jtmi+ 0R4llEMHK5K9UB4J8bWNQB/TZBZMFBm94zjA5c8yTNgESzKv5iWn/kGySkZU9VF0 3r0Gzijlmk0K7teRFQsAXx7gNZNgRI4qXzOMijFZ018+5J9biLixBrsXChcvbqcQ Esx9FPU4Y/D9BuJzeP2rE9xcAonQ6qAK5Z2JyuiV/bXm+lZUYsf0Za3zI/ofJNIk f//VeyEI7wsS3XW0ChgBvVxAshC984m1jUOspyw6RyBJTEsPQ6gDZcemW5pH5eEC rEIqSh0gJiALyOHEwWTDPqtcQJIfryZa/pu3YZMM+Uv4icYZSX9vXLsBSMHpfmDl Menxxbv+lRZcKw4Vg== Received: (qmail 4526 invoked by uid 0); 14 Sep 2016 23:07:00 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=N1PlYwfCXo7DZmeRtjb2YBBGZtXAtQEmqW9l/gvJ76vYpKianPkOzlI+UOKyGdLHb6F0mTmtFgCgmCKNJiTnyg==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 14 Sep 2016 23:07:00 -0000 From: Robert Cochran References: Date: Wed, 14 Sep 2016 16:06:57 -0700 In-Reply-To: (Chunyang Xu's message of "Sun, 04 Sep 2016 12:26:05 +0800") Message-ID: <87fup2nkry.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Chunyang Xu writes: > It looks like, to me, the structure of the BODY arg of these two should > be the same (accepting a list froms). > > (pcase-let ((a 1)) > (incf a) > a) > => 2 > > (pcase-let* ((a 1)) > (incf a) > a) > => 2 It appears to be so. Here's what I did: (pcase-let* ((a 1) (b 2)) (message "%d" a) (message "%d" b)) and ended up with 1 2 in my *Messages* buffer. > but the docstrings are using the different words. > > (pcase-let BINDINGS &rest BODY) > > Like `let' but where you can use `pcase' patterns for bindings. > BODY should be a list of expressions, and BINDINGS should be a list of bindings > ^^^^^^^^^^^^^^^^^^^^^ > of the form (PAT EXP). > > (pcase-let* BINDINGS &rest BODY) > > Like `let*' but where you can use `pcase' patterns for bindings. > BODY should be an expression, and BINDINGS should be a list of bindings > ^^^^^^^^^^^^^ > of the form (PAT EXP). This patch changes the pcase-let* docstring to match the pcase-let docstring, but IMO I don't think that the phrase 'a list of expressions' is exactly the right term for this. That (to me) implies that we are wrapping the whole body in a list, which you don't. For example - ; What that phrase implies to me: (pcase-let ((a 1)) ((incf a) a)) But I have no idea how to better phrase this. For certain, though, they ought to match because they both behave the same way. ----- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-docstring-of-pcase-let.patch Content-Description: Fix docstring of pcase-let* to accurately reflect what BODY can be >From c41219fcbbb01b5a219733ac54ad2cade438513b Mon Sep 17 00:00:00 2001 From: Robert Cochran Date: Wed, 14 Sep 2016 15:52:29 -0700 Subject: [PATCH] Fix docstring of pcase-let* pcase-let*'s docstring could have been taken to mean that the BODY parameter can only be a single expression, but it can be any numbers of expressions. Fix it to be more accurate. * lisp/emacs-lisp/pcase.el (pcase-let*): Fix docstring to be more accurate about what the BODY parameter can be. --- lisp/emacs-lisp/pcase.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el index 0b8dddf..2d61642 100644 --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -261,7 +261,7 @@ pcase--let* ;;;###autoload (defmacro pcase-let* (bindings &rest body) "Like `let*' but where you can use `pcase' patterns for bindings. -BODY should be an expression, and BINDINGS should be a list of bindings +BODY should be a list of expressions, and BINDINGS should be a list of bindings of the form (PAT EXP)." (declare (indent 1) (debug ((&rest (pcase-PAT &optional form)) body))) -- 2.7.4 --=-=-= Content-Type: text/plain ----- HTH, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 --=-=-=-- From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 21:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Cochran Cc: 24362@debbugs.gnu.org, Chunyang Xu Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.14739754054099 (code B ref 24362); Thu, 15 Sep 2016 21:37:01 +0000 Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 21:36:45 +0000 Received: from localhost ([127.0.0.1]:60815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeKr-000143-I8 for submit@debbugs.gnu.org; Thu, 15 Sep 2016 17:36:45 -0400 Received: from mout.web.de ([212.227.17.12]:59521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeKp-00013p-H0 for 24362@debbugs.gnu.org; Thu, 15 Sep 2016 17:36:44 -0400 Received: from drachen.dragon ([90.186.1.83]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MCqkB-1bsf4d3bZj-009ko6; Thu, 15 Sep 2016 23:36:33 +0200 From: Michael Heerdegen References: <87fup2nkry.fsf@cochranmail.com> Date: Thu, 15 Sep 2016 23:36:21 +0200 In-Reply-To: <87fup2nkry.fsf@cochranmail.com> (Robert Cochran's message of "Wed, 14 Sep 2016 16:06:57 -0700") Message-ID: <87k2ecalre.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:eL6MXGebYtpvRruUQHHbK/kp0Zl+2VJdz/JknTGEOhljmkg4gp6 3f0zChWD+tpxqxHBOTnAOMrPUWAzdoAs7byVxtHlvUKKR+mmoCPDV10am7BYVUUW2aVU1bX 7ZEtPFzH5amEtTv3s7KcxmK8HdYnPV7+G/ZKQpCEQJj7Ji4y7gc9rnut+NWwQm0CXAr8bRQ CU3tRfNeJwJb58gy4zFzg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9PKs+I4mdOc=:tO4JRn697Fe/2AsCU2FFhh 7+tJvutTJQm16hiX4lnzgdE0A+JE+6yx+QPAf6LJ9URiG5j1PdgzlfG6ls7l9RTNrueSRz/1V yHn56T0+8pPJng9x6Sjr5zntSzCtxkSR9k+hU5ovkApBvBGrj4bEjD6mBsGJYSx+4zF0xGrx6 VYPQ06Jfds8eIW47vIY7FMfp0zjt0FQFx2KP8aRIKJz6lu0hH1qRmbr0AbQSuZrWRSK6KaxMb J+l0unDhTKQxEOIYRwyUqgtqQ+0+8ufnXeMavM2f8toU2ocgGl57Fm/8FRD0z61uqNLDGP3J/ 6kGpAEIHzRtIM22idTTqEGzJtzL1sj7K5JLN+DNOOCObUVy9h6ZGsXzl2Othx/VvEtizG/px3 Qzd11q5G9nRKJkfFvThg0A1udlVTehMy3ampNEG2Aq2LJkODJtX45SKR2GE6k+OKXHbyLpCJm Z7tBfEbQvaF61G5vlHZaHFHWad9kNVfNS+Pv/IZeqPl9pPtEfWdQ9+GcEA+sCnbxoKnSyQNih ZLa6Q3NENUK2h7xV/Op8+9NdMUo/vQCPXIOogSSXN2LNkrYQL46SFh2ZegsaF3MqlL8yRdzt3 iIFWlF3D2UQSjwZ8BjKtTpwhm1l7YYmxL6jgWYuQl8rCkRuFf1QMHr9HxMH4V+kbCGTKuUGqP ZqvE3nF0gq0LzhWfg4U2tru/djBB0RBn22K87XLLcGvvBlIFLGZTMx27EgNfMVDiPh5gJhBN/ gGOGX4NwuMy3hpMoGzATP3cqOX/CssA7npO/b2tootLFKf8huMd5SK7L4pU+1GYagHul4/4zS FeXMxqpjhNzXT7k/LJupx9SasGBcg== X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Robert Cochran writes: > This patch changes the pcase-let* docstring to match the pcase-let > docstring, but IMO I don't think that the phrase 'a list of > expressions' is exactly the right term for this. That (to me) implies > that we are wrapping the whole body in a list, which you don't. Isn't this just normal "Elisp speak" for a &rest parameter? Sure, the value of the parameter doesn't appear in the code (only "spliced in") - but we use this wording all the time. > diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el > index 0b8dddf..2d61642 100644 > --- a/lisp/emacs-lisp/pcase.el > +++ b/lisp/emacs-lisp/pcase.el > @@ -261,7 +261,7 @@ pcase--let* > ;;;###autoload > (defmacro pcase-let* (bindings &rest body) > "Like `let*' but where you can use `pcase' patterns for bindings. > -BODY should be an expression, and BINDINGS should be a list of bindings > +BODY should be a list of expressions, and BINDINGS should be a list of bindings Looks ok to me. Michael. From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 21:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Robert Cochran , 24362@debbugs.gnu.org, Chunyang Xu Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.14739766545985 (code B ref 24362); Thu, 15 Sep 2016 21:58:01 +0000 Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 21:57:34 +0000 Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeez-0001YT-UV for submit@debbugs.gnu.org; Thu, 15 Sep 2016 17:57:34 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:57671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeex-0001YG-NM for 24362@debbugs.gnu.org; Thu, 15 Sep 2016 17:57:32 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=tqZ3HF8hYBUDMWxoFh8GVJuwG0k=; b=omFRB DzkM+pyN3KGXD5pQHszCkcAd+eEY9aROGOUjNaughPbNrxTG5vW05/O0CskZVJFq 9yhWJ9Tly0hhcU+D/l0pMmiBpK2qMuVo/xb+g9RqBtZemBPfF4d5vPHBdulz5X02 c5RzL7OdoU4Bai6ETZxvKJ9+8dvezU782dEz8Y2pJ02ktjtXGCWZnXxDt0NJl31d N890lpwLFySEAqyqCK3vhlUDRGaLWbLNopdFoqSItVq4Yr2YH6Yszj6bdTfsu15f FBMyBOYqmBDyygazTy4ntY6zndxsqZ2zgd5PXaFHTwOQ0odxy2dK59fMiAzQiMoe lKGxKVhojGFSJov3Q== Received: (qmail 22081 invoked by uid 0); 15 Sep 2016 21:57:29 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=KrZC++qnQOJZYI6spHkmFQxmCOIz7pPiVQSg8kRWN2iFPDimtM9G4vP/YOLhv3InZJHOMlwpq4kDawlZbv4Ksg==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 15 Sep 2016 21:57:29 -0000 From: Robert Cochran References: <87fup2nkry.fsf@cochranmail.com> <87k2ecalre.fsf@web.de> Date: Thu, 15 Sep 2016 14:57:24 -0700 In-Reply-To: <87k2ecalre.fsf@web.de> (Michael Heerdegen's message of "Thu, 15 Sep 2016 23:36:21 +0200") Message-ID: <87fup03jy3.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Michael Heerdegen writes: > Robert Cochran writes: > >> This patch changes the pcase-let* docstring to match the pcase-let >> docstring, but IMO I don't think that the phrase 'a list of >> expressions' is exactly the right term for this. That (to me) implies >> that we are wrapping the whole body in a list, which you don't. > > Isn't this just normal "Elisp speak" for a &rest parameter? Sure, the > value of the parameter doesn't appear in the code (only "spliced in") - > but we use this wording all the time. It may very well be. I haven't been around long enough to know. Now, don't get me wrong, I *knew* what 'a list of expressions' had to mean in context (it wouldn't have worked any other way), but my natural parsing still evokes the wrong idea in my mind. If it's already established tradition, then I have no qualms. >> diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el >> index 0b8dddf..2d61642 100644 >> --- a/lisp/emacs-lisp/pcase.el >> +++ b/lisp/emacs-lisp/pcase.el >> @@ -261,7 +261,7 @@ pcase--let* >> ;;;###autoload >> (defmacro pcase-let* (bindings &rest body) >> "Like `let*' but where you can use `pcase' patterns for bindings. >> -BODY should be an expression, and BINDINGS should be a list of bindings >> +BODY should be a list of expressions, and BINDINGS should be a list of bindings > > Looks ok to me. Thanks! Not that there's much to do wrong there. ;) -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen , Robert Cochran Cc: 24362@debbugs.gnu.org, Chunyang Xu Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.14739768396346 (code B ref 24362); Thu, 15 Sep 2016 22:01:02 +0000 Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 22:00:39 +0000 Received: from localhost ([127.0.0.1]:60832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkehz-0001eH-Ce for submit@debbugs.gnu.org; Thu, 15 Sep 2016 18:00:39 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkehx-0001e4-7b for 24362@debbugs.gnu.org; Thu, 15 Sep 2016 18:00:37 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8FM0Swl008544 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 15 Sep 2016 22:00:28 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u8FM0SKv029217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 15 Sep 2016 22:00:28 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u8FM0GKf027056; Thu, 15 Sep 2016 22:00:27 GMT MIME-Version: 1.0 Message-ID: <874c9f9a-631e-4cfc-8301-f9279228e121@default> Date: Thu, 15 Sep 2016 15:00:15 -0700 (PDT) From: Drew Adams References: <87fup2nkry.fsf@cochranmail.com> <87k2ecalre.fsf@web.de> In-Reply-To: <87k2ecalre.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -4.5 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) > > This patch changes the pcase-let* docstring to match the pcase-let > > docstring, but IMO I don't think that the phrase 'a list of > > expressions' is exactly the right term for this. That (to me) implies > > that we are wrapping the whole body in a list, which you don't. >=20 > Isn't this just normal "Elisp speak" for a &rest parameter? Sure, the > value of the parameter doesn't appear in the code (only "spliced in") - > but we use this wording all the time. An &rest formal parameter corresponds to a list of actual arguments in the calling sequence. Consider (defun foo (&rest xs) (message "Args: %S" xs)). At runtime, XS is the only argument that you can access by name - the only argument whose value is bound to a variable. And yes, its value at runtime, i.e., in any actual call, is a list. On the other hand, not only (foo 1 2) but also (funcall #'foo 1 2) treat 1 and 2 as actual arguments. The list (1 2) does not appear explicitly in these calling sequences. So if you are talking about `foo's actual arguments for such a call then you can say they are 1 and 2. But if you are talking about the value of the &rest argument XS for such a call then you must say that the value is a list. From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 22:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: Robert Cochran , 24362@debbugs.gnu.org, Chunyang Xu Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.147397926110015 (code B ref 24362); Thu, 15 Sep 2016 22:41:01 +0000 Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 22:41:01 +0000 Received: from localhost ([127.0.0.1]:60845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkfL3-0002bS-2i for submit@debbugs.gnu.org; Thu, 15 Sep 2016 18:41:01 -0400 Received: from mout.web.de ([212.227.15.14]:52228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkfL1-0002bF-Rd for 24362@debbugs.gnu.org; Thu, 15 Sep 2016 18:41:00 -0400 Received: from drachen.dragon ([90.186.1.83]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0M3BeZ-1auLrW1H6N-00svXv; Fri, 16 Sep 2016 00:40:45 +0200 From: Michael Heerdegen References: <87fup2nkry.fsf@cochranmail.com> <87k2ecalre.fsf@web.de> <874c9f9a-631e-4cfc-8301-f9279228e121@default> Date: Fri, 16 Sep 2016 00:40:43 +0200 In-Reply-To: <874c9f9a-631e-4cfc-8301-f9279228e121@default> (Drew Adams's message of "Thu, 15 Sep 2016 15:00:15 -0700 (PDT)") Message-ID: <877facais4.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:twK8nLOLvQ9Bk4LY/peMGnc1yZ1qM/PTw+0FeWfRXg5Sizfr+od chwYVDqRqsDXQzT5Yv8cq2bcOmkAr0bQ6FNj6/xUVWVnL/SOHkCWHgXacuq1mvl9W9LUiKU QXg4NFHo3hEcB+wbxRlP8ZFSUO1fBQ4UzkJkQnTE+G0+zMRvij1qLMxNjq5rrSdsvBgEyGz 10SAp2XWfZiBttnyagsbg== X-UI-Out-Filterresults: notjunk:1;V01:K0:UbYbxTJgsLg=:zZnTjUxyxzr8EJ2fedd/d8 Hcby8nBLai6KpM+i9eRFTVMcE9IAe8W5o9dphrc/YbQ5EheGED8rLXfp8ZRG25OoNwkDlcVCw yuGbAO8QjwCHYVeNPi3joEMKzocyPiu4dIkpNFZOi5VtbnLnHsRdak00RyNlw00zgk7gtL9K3 1/Kn/DLeWLdoTekE7oPZL225PMY+TUkzsW7Ij7zrDOwUkt67LJoZXT3qRVtObJQXDo76V1aYS nlzLZhAvh0KLyvdW0RBEvNkpNHn0c5jBfD5gXt9anppacITNQayXgauAlzZ5t24qHLQaDh+rW Lx19cLGKRSyYMelG7lBmggDBlTgiutDlaNSSISPK7ARb17zrCl8/t4piUAeREyKY6JsqIzg29 vqbk/zP3bzqoyJOWCwxuKoPEPWRMQ9ZNyqNcgObF5fXfd7uW1EXsnmIw4/i+BWXxqQcSJ3su4 Uv5iUQpvt8iwp7uWndL768HpX5WpVElbnpDKaOfIU5BMlP0ErnyTyHp1KcMxEc2myD3XhuQsU 95BrurnzKq1XMobDW8QF5k2lbKiCKWvkV+CvzWck+YlnqdjrVv1EJ3RFZa18CKQEo3KaplC3I J5rmk4fAmxy7Ykdx+VpcsdN9drRjz9hkx3M9nitOpMTUtskDPbkoFO2rQM+ei8afd4q5xoGkI ktbViqWHuDLyYuKW9WjJYswAiCDqml/Se6zSJu7EBbxnTA7urF1Kecdm9OLQvtnWjnb4opZdq UbWf/8Yqdz2tnINizF1NGMkF2MZTPk5/MafPDg7viIhsg/w9dxPkAnEZJCs/58l8GKJ4PFFdx sazMT/YQEySPW+Fwcof54lvYp9G5g== X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Drew Adams writes: > So if you are talking about `foo's actual arguments for such a call > then you can say they are 1 and 2. But if you are talking about the > value of the &rest argument XS for such a call then you must say that > the value is a list. Hah Drew! Actually we are indeed defining the meaning of the actual arguments, but we are describing the semantics of the value of the &rest parameter to do so. That's the reason why such descriptions can be a bit confusing at first. Michael. From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Cochran Cc: 24362@debbugs.gnu.org, Chunyang Xu Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.147464801412680 (code B ref 24362); Fri, 23 Sep 2016 16:27:01 +0000 Received: (at 24362) by debbugs.gnu.org; 23 Sep 2016 16:26:54 +0000 Received: from localhost ([127.0.0.1]:33654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnTJO-0003IR-Fi for submit@debbugs.gnu.org; Fri, 23 Sep 2016 12:26:54 -0400 Received: from mout.web.de ([212.227.17.12]:58666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnTJL-0003IB-P7 for 24362@debbugs.gnu.org; Fri, 23 Sep 2016 12:26:52 -0400 Received: from drachen.dragon ([90.186.2.222]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0LzKEH-1as5JJ42Gf-014SB8; Fri, 23 Sep 2016 18:26:41 +0200 From: Michael Heerdegen References: <87fup2nkry.fsf@cochranmail.com> Date: Fri, 23 Sep 2016 18:26:36 +0200 In-Reply-To: <87fup2nkry.fsf@cochranmail.com> (Robert Cochran's message of "Wed, 14 Sep 2016 16:06:57 -0700") Message-ID: <87ponutweb.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:XaE8BXEUj6e6c85w50sTfJQTqV8VsjxAWx9Zy1y4Zn9CUWSWiFK UG1DhMEEho/sg/jt6EuiiiFk8jiU26itiDr/O9uEBGwuvW3k3x9cG9F7Ut7+FYzjUm+Lv5j 4xzFb2HXy6QiJCTdXN/hEmtdt4hXVffkGw8AxUXPc0dBOyn6G7w9njNSx0FtpvhNADoEb4l 9hl/5exSHO6H9UCUdpyOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:9Y5oYQmPQJw=:T01NFhs6ZlJ926pqrFuM8B zAPZg2bdslOK3EjiteCmb9+AHqBQfhb12lEgpU35WbKA+RSuhPWRrWxO19ShKeVHh8QfnaNC9 rDCxiztAzH1CnbsgeCmWPLrkh0nH2LrjzzqIz/7jJHB8z/QSfBguAAukLaUvBaag+xO+HeSqp V1psqfEHRdC6ugYq8Q9DqMmipBvAZmn2IO0i+WQDfZZ/j9BXQ53/nYtxXDG9MVa8FNshFLlEM NcQw8O0+7Qgmq02ULx2/kTat8tcb2sLBSJnMRDKJE0lVwkjH4VZICxlQq1Wb02S+Hgo5R6g7P HxfstgQ4gwqfZlL8cIZi39IenONEbkowpLMystMvGlfRNmjcIRUBaoNju5EgJXix5IKg6sxTP yH9gGNKH6Ejg9xeTjiK+mbyFZ8qQkZknwamW0bHRuKxWBcAj7K4sq1RySX7HLb2O85u1D1Lha Fxl39OzhFI6MI4c827gAUlS9U28+wKXNIiy9C0JNvmFM3xhfJonLKMr7pNIHcNbCC3OFPyIMv iTghE6O+ogILPyqJrzkFYVVAEue9pFIZd2F8nM89mD499f6y7sT5bZXkP2yNrvBeUBZ1pPK0q XdOPHiKqTl4dxplCnEL8lViboAKgg4dIQQRNMFHzeK4o9b/GOJ2Su4+st7klab1YBgilXMqvN d/uBY4gKOxGhTNiHwSkeaXTvFKiF9dW3UB2NNqLhw1uPPINt1xonbTIO5dgY1W1GnaC4oKRS1 sKqQ32nfBkssJfQxJ/lRyVtxg55fSzextrpaPz0iA8cQVT57NKJ5JsFrioH7Ft81rdtCSyHgX Ho2HJRD X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Robert Cochran writes: > This patch changes the pcase-let* docstring to match the pcase-let > docstring [...] Seems you did not yet install it to master. I think the patch can be applied. Thanks, Michael. From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 20:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Robert Cochran , 24362@debbugs.gnu.org, Chunyang Xu Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.147466355210906 (code B ref 24362); Fri, 23 Sep 2016 20:46:02 +0000 Received: (at 24362) by debbugs.gnu.org; 23 Sep 2016 20:45:52 +0000 Received: from localhost ([127.0.0.1]:33735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnXM0-0002pq-7Y for submit@debbugs.gnu.org; Fri, 23 Sep 2016 16:45:52 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:56318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnXLy-0002pi-K9 for 24362@debbugs.gnu.org; Fri, 23 Sep 2016 16:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=BxzsW2ZpFJhoEQ3mdX2mUFZjaGw=; b=wQDvn RCH1w38C5J2mzZNqCJF0YhA/xpc1fJUyhHGh3t5R1cKiB3JjrI7J8m8OUpaq6hUa GL7lduw4qb0Hvr5pYQVS2LGzXmIIQBnYOBEWmAMk+gbUl2ZzMlfeElvMi4ipOJJ8 C3yg/P14oKsDNm2m7gq4pyxclIrTL9ht8uGcqlQixM6LwmROqSaxnnKWLqnqJVkP +nOz+93z8vGUw1sKWZS2V/QiP9vEEnXYAEtl9jyONQWGo9OU27zpP1LBBoq9cf+P Qjn8XCqCdc+djb43UkkIL43seNTcFDTh3J66ICmAlMmBMYvdIgjyfBdRCDiMYLhg ptRTTsd8pGgzrFa6g== Received: (qmail 10819 invoked by uid 0); 23 Sep 2016 20:45:48 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=Z37Y/klvsYzPmCS6MsuUZE0L849ALLZlLxe/Nc/ZBwqfiLNUsWxEc1G5im0L4pi7oPNEpyYwo5/ciWe1YGH2YA==; Received: from 74-93-99-217-washington.hfc.comcastbusiness.net (HELO SoraLaptop) (robert@cochranmail.com@74.93.99.217) by mail.cochrantribe.org with ESMTPA; 23 Sep 2016 20:45:48 -0000 From: Robert Cochran References: <87fup2nkry.fsf@cochranmail.com> <87ponutweb.fsf@web.de> Date: Fri, 23 Sep 2016 13:45:45 -0700 In-Reply-To: <87ponutweb.fsf@web.de> (Michael Heerdegen's message of "Fri, 23 Sep 2016 18:26:36 +0200") Message-ID: <871t0a1h1i.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Michael Heerdegen writes: > Seems you did not yet install it to master. I think the patch can be > applied. > I do not have commit access. Someone who does will need to do this. TIA, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2016 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Cochran Cc: 24362@debbugs.gnu.org Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.14748140108574 (code B ref 24362); Sun, 25 Sep 2016 14:34:02 +0000 Received: (at 24362) by debbugs.gnu.org; 25 Sep 2016 14:33:30 +0000 Received: from localhost ([127.0.0.1]:35660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boAUk-0002EE-50 for submit@debbugs.gnu.org; Sun, 25 Sep 2016 10:33:30 -0400 Received: from mout.web.de ([212.227.15.4]:62872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boAUi-0002E1-0l for 24362@debbugs.gnu.org; Sun, 25 Sep 2016 10:33:28 -0400 Received: from drachen.dragon ([90.186.2.21]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0LaCqs-1b6Z4p1OcY-00m6bT; Sun, 25 Sep 2016 16:33:17 +0200 From: Michael Heerdegen References: <87fup2nkry.fsf@cochranmail.com> <87ponutweb.fsf@web.de> <871t0a1h1i.fsf@cochranmail.com> Date: Sun, 25 Sep 2016 16:32:51 +0200 In-Reply-To: <871t0a1h1i.fsf@cochranmail.com> (Robert Cochran's message of "Fri, 23 Sep 2016 13:45:45 -0700") Message-ID: <87bmzcgics.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:zO4lAZOtsegXbLDXYq19dT61Sn3clfjIwzkomn0KUeLiHgN03um B+o5mRIt5igfxgdY9uBw8P0d2qs/ncdK8TuD4pFz0qhQT9ZvjNir9KJl/U94hDoCuxjjQvu Bhb8vQGdqRFDjiRxp1mz+lWKoIDC78eaxBQ+rIVTjWBA+J58OGZha6DzVm4B288LRKjYcAm CqMEJ/KLG+lQ5486X+FtQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:W+voRpdDtcY=:SakFmg4i4krgk7b/kd1oaM ZKElVu1YJqraQMn4KGgmWT+1b59CN5HFZ7rfJVxCXk10jTjL08OxzI5/UDMAlSpODpac4z2vT cPFAOPfzPU9tbWm1tzUxAvsR0Sqn9CLv58KXpUEVsHj4P7xBgX9brgeg88N72/2jHeTspZfCn hCTUVQ7hKGTyRxbH9AzyuAH6z4YepCVeQPBaq6G7dz9HzSGSOfTxg2zBzvUJ/NXPmTtYX2kQ+ wfCkn0a+99lOXYn7dtRWxdHltWJ6xiy4iTflpHBxKVqcB/T5MYjeHBQBSj8voLDMMYj2Rm2u1 ccGpZ2RZ+Spwwj1Gee9byMST2tFtVMyiqTj1a2/dwjmRuzRfzfxv2LW5w56iDcsO6p4K+Hkq6 xgpDL7wH6z4CFzoGhxCR/IlEkGVwNSP6c+puQsOhJm+CqkED3WsBwj2lqPdwtT3gco1GgpCZo rqdCBPfJvjFL/oS8CNGn/zz/8YVZDdQi3KOw1kyr/5uX15p4PHoP6DQcW0IjsINNcNbcKvY/g SkFVI/5QlttZUl4kQ/LoPZ262hi4Y+IK7XupRv7HB0QHPZzojULwmAGO1lIYbWmnreRA8R1zK N+YZH1LHejlm5PPwrJDikt7HG6qkoYKBUGvqeE48/QW6S8iFHwVAfkGMdOS/Fg3rI6aJhogMF CQh0zw4oiD+E0P3tdp0jabL1h11pK0lR6Ld2fyW0bFbLRHSjJNUln2dpYSWbSxI3pMTMHNjB3 YhI2EOuKreYH17gNfplnjOrEjKstpyVIblajgRT35P6TnKKWlJeK0KAtUodQlOeMGCk9mNAqp x1e4N2wTMGC/DSgefed5d9hdNjaiQ== X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Robert Cochran writes: > I do not have commit access. Someone who does will need to do this. Don't you want to get commit access? Michael. From unknown Mon Aug 18 17:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2016 23:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Robert Cochran , 24362@debbugs.gnu.org Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.147493316327242 (code B ref 24362); Mon, 26 Sep 2016 23:40:01 +0000 Received: (at 24362) by debbugs.gnu.org; 26 Sep 2016 23:39:23 +0000 Received: from localhost ([127.0.0.1]:36758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bofUZ-00075K-Gb for submit@debbugs.gnu.org; Mon, 26 Sep 2016 19:39:23 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:36713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bofUY-00075A-0C for 24362@debbugs.gnu.org; Mon, 26 Sep 2016 19:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=DaItehZxBk+GeOTNIS+KcZ+8Q3Q=; b=J6bdp +bEo29fKiQCr1vwzq+OiSjqoEyE8fNzEoab6Xm1bStaKRVH+y5Zd46T5/lK7vdJS 2cbkfj64xjPfIgV1xfFtv04o/wKq0o4ioK+ree2m04IugjZlra/8p9rdhVXoy4mf TSSiivA4TrPaRxN2oMAGrPMwQ2NqFdMiC7vKilOJZzfNnImLA4XurAcJyFiLoge9 79lWt/bjP9y++0qPsNKXU8KMBOGWltOgpwnZv9STXfqwHmpf+G6hthmtIWqUmtqm tIWDx97xKGylInFpYeqO/AGPfYEQyNHYoTHUgVi1ft0jvjq0b4hWOGipLkNM33AK M4Y19olO3NaplPJpw== Received: (qmail 25279 invoked by uid 0); 26 Sep 2016 23:39:18 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=HKSqtdU3wJ8IlcuNVu7R+kRBoc8GqyEfD6KSxyc/3RNKBiqn+KvcpUHXkicxq6rc4ajXFjPzfsjYfkS41YZ5iA==; Received: from unknown (HELO SoraLaptop) (robert@cochranmail.com@168.156.75.174) by mail.cochrantribe.org with ESMTPA; 26 Sep 2016 23:39:18 -0000 From: Robert Cochran References: <87fup2nkry.fsf@cochranmail.com> <87ponutweb.fsf@web.de> <871t0a1h1i.fsf@cochranmail.com> <87bmzcgics.fsf@web.de> Date: Mon, 26 Sep 2016 16:39:09 -0700 In-Reply-To: <87bmzcgics.fsf@web.de> (Michael Heerdegen's message of "Sun, 25 Sep 2016 16:32:51 +0200") Message-ID: <87h992p6xu.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Michael Heerdegen writes: > Don't you want to get commit access? Sure I would, but I figure that I don't have the required amount of 'known-ness' to bother requesting this access right now. I'd have imagined I'd need to have a few code commits (AFAIK, only 1 commit of mine in the master branch has anything other than documentation changes) and be known to be generally sane. I could be wrong about this; I just know that some people have commit rights and others do not. I have no idea what the process is for attaining said rights. Thanks, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 From unknown Mon Aug 18 17:53:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Chunyang Xu Subject: bug#24362: closed (Re: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let*) Message-ID: References: <87a797vxqm.fsf@marxist.se> X-Gnu-PR-Message: they-closed 24362 X-Gnu-PR-Package: emacs Reply-To: 24362@debbugs.gnu.org Date: Fri, 08 Nov 2019 03:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1573184642-13894-1" This is a multi-part message in MIME format... ------------=_1573184642-13894-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24362@debbugs.gnu.org. --=20 24362: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24362 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1573184642-13894-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24362-done) by debbugs.gnu.org; 8 Nov 2019 03:43:56 +0000 Received: from localhost ([127.0.0.1]:44329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSvBk-0003bk-Jx for submit@debbugs.gnu.org; Thu, 07 Nov 2019 22:43:56 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:43696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSvBi-0003bW-HH for 24362-done@debbugs.gnu.org; Thu, 07 Nov 2019 22:43:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gDXVsjOK43VCm+W1bV3qwdvdqOYsyBf/JS4NBvmGQvM=; b=WFP4Y5FrQl2OSSpU31Q9buCsYL lxKAbFSvCs3ReaSrJgacpdQLKOqSxqX/fKTRie4Qt/YfRFBXvJdo+mZRNx/dRwE0hWs2AoIALYxiq nODFFd16pJ1RV5rZjgac7zvqZ+y8nJyiDsJHg3Lj5bp7DuNRyYK2OL/FyhqjVhkuB050=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:37796 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iSvBb-00057v-AA; Thu, 07 Nov 2019 21:43:49 -0600 From: Stefan Kangas To: Chunyang Xu Subject: Re: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* In-Reply-To: (Chunyang Xu's message of "Sun, 04 Sep 2016 12:26:05 +0800") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Fri, 08 Nov 2019 04:43:45 +0100 Message-ID: <87a797vxqm.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24362-done Cc: 24362-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Chunyang Xu writes: > It looks like, to me, the structure of the BODY arg of these two should > be the same (accepting a list froms). > > (pcase-let ((a 1)) > (incf a) > a) > =3D> 2 > > (pcase-let* ((a 1)) > (incf a) > a) > =3D> 2 > > but the docstrings are using the different words. > > (pcase-let BINDINGS &rest BODY) > > Like `let' but where you can use `pcase' patterns for bindings. > BODY should be a list of expressions, and BINDINGS should be a list of bi= ndings > ^^^^^^^^^^^^^^^^^^^^^ > of the form (PAT EXP). > > (pcase-let* BINDINGS &rest BODY) > > Like `let*' but where you can use `pcase' patterns for bindings. > BODY should be an expression, and BINDINGS should be a list of bindings > ^^^^^^^^^^^^^ > of the form (PAT EXP). This has been changed on current master to: Like =E2=80=98let*=E2=80=99, but supports destructuring BINDINGS using = =E2=80=98pcase=E2=80=99 patterns. As with =E2=80=98pcase-let=E2=80=99, BINDINGS are of the form (PATTERN = EXP), but the EXP in each binding in BINDINGS can use the results of the destructuring bindings that precede it in BINDINGS=E2=80=99 order. =20=20=20=20 Each EXP should match (i.e. be of compatible structure) to its respective PATTERN; a mismatch may signal an error or may go undetected, binding variables to arbitrary values, such as nil. I'm therefore going to assume that the above is no longer an issue and close this bug report. If that is incorrect, please reopen. Best regards, Stefan Kangas ------------=_1573184642-13894-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Sep 2016 04:26:36 +0000 Received: from localhost ([127.0.0.1]:49075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgP0t-0002yN-O0 for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgP0s-0002yB-2v for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgP0m-0006F8-4m for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgP0m-0006Ez-1T for submit@debbugs.gnu.org; Sun, 04 Sep 2016 00:26:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgP0k-0000ZU-33 for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 00:26:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgP0f-0006EV-RR for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 00:26:24 -0400 Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:34115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgP0f-0006ER-LF for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 00:26:21 -0400 Received: by mail-pf0-x235.google.com with SMTP id p64so54619788pfb.1 for ; Sat, 03 Sep 2016 21:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=UIpPVlwicR9tAnTOtHxOR+/C2NUhhLLSM4aLpQzagiw=; b=vA+X9AvnufY04x6HQEWdvEXRChVXXlMEiVyd0TEgietltB9ynHXd2oqbCJn0njhSAn jjYjwzCbBuFA9Rz9DRshpXKsjXBX+P5g8VLGbXxxpEetnkQ4dJTzt773vwh23V8Q+9sm 06AvDa3UFWOgtgfygy1rd+uZbcVLzOo2Af6idlRZP2/gtOPsGa31GoXAn9G0eVIasadG iRSKZUC6FrQXR4kziQdT5Y+klNo2sBJ8yXY0IuD1Pz/rhwYRCFzIPLes9vS1mDLMlzIs c7t4Gd0rPF2ShCuHFe+ZkPQ2PkrlHhAa3tKrn2MFyZ7eDnWbMutZX7gbOFr1rPOjikiT vHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=UIpPVlwicR9tAnTOtHxOR+/C2NUhhLLSM4aLpQzagiw=; b=m+O2VdYAJ91LuX4Ybw89xLo9CJhmyF7bnBTUprbN/lbj5W7Mnr68jPcwePRYuV/QbD Zl14FFaxWbg5wBFCqUuCqlESZMG/ZUJohP3CrSMFQoUk8Gl7tXA/lrHBG1WQq33zTrY4 hj83JkN388BcaAjY5+AVvN6PFE/owARB8HJEy/c3UQmGuesLwLSN36OM33911mj8DCHl 8VLuK89k+w7gZ1gjfmbG3xAsI+sAY0kwm3f0mMn3GyVLfdPVo93Pjju7bVJyacfz2F41 fOD8285pTMK1tethrAa+Cdt6IZbDSqAgOhErjFyubpdt4agfoPDYMz/z8NwBhRYzngEm MEBA== X-Gm-Message-State: AE9vXwMRQXu9JCYfS1NsobA1wq4pawK8ZfimF8MNGWnmTjzkeoHsXJGrE25CmRRmFT8Abg== X-Received: by 10.98.69.201 with SMTP id n70mr51615477pfi.64.1472963180428; Sat, 03 Sep 2016 21:26:20 -0700 (PDT) Received: from localhost ([47.88.9.6]) by smtp.gmail.com with ESMTPSA id l128sm24834637pfl.21.2016.09.03.21.26.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Sep 2016 21:26:19 -0700 (PDT) From: Chunyang Xu To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Date: Sun, 04 Sep 2016 12:26:05 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It looks like, to me, the structure of the BODY arg of these two should be the same (accepting a list froms). (pcase-let ((a 1)) (incf a) a) => 2 (pcase-let* ((a 1)) (incf a) a) => 2 but the docstrings are using the different words. (pcase-let BINDINGS &rest BODY) Like `let' but where you can use `pcase' patterns for bindings. BODY should be a list of expressions, and BINDINGS should be a list of bindings ^^^^^^^^^^^^^^^^^^^^^ of the form (PAT EXP). (pcase-let* BINDINGS &rest BODY) Like `let*' but where you can use `pcase' patterns for bindings. BODY should be an expression, and BINDINGS should be a list of bindings ^^^^^^^^^^^^^ of the form (PAT EXP). ------------=_1573184642-13894-1--