Subject: Re: bug#24359: Patch for byte compilation bugs

From: [email-masked]
Date: Sun, 11 Sep 2016 12:36:30 -0400

Philipp Stephani <[email-masked]> writes:

>  Philipp Stephani <[email-masked]> writes:
>  >
>  > * lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled)
>  > (macroexp--warn-and-return): Use ‘byte-compile-warn’ instead of
>  > ‘byte-compile-log-warning’.
>  >
>  > * lisp/emacs-lisp/bytecomp.el (byte-compile-form, byte-compile-unfold-bcf)
>  > (byte-compile-setq, byte-compile-funcall): Use
>  > ‘byte-compile-report-error’ instead of ‘byte-compile-log-warning’.
>  [...]
>  > * lisp/emacs-lisp/cconv.el (cconv-convert, cconv--analyze-use)
>  > (cconv--analyze-function, cconv-analyze-form): Use
>  > ‘byte-compile-warn’ instead of ‘byte-compile-log-warning’.
>  >
>  > * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Use
>  > ‘byte-compile-warn’ instead of ‘byte-compile-log-warning’.
>  >
>  > * lisp/subr.el (add-to-list): Use ‘byte-compile-report-error’ instead
>  > of ‘byte-compile-log-warning’.
>  > (do-after-load-evaluation): Use ‘byte-compile-warn’ instead of
>  > ‘byte-compile-log-warning’.
>
>  I think you can combine all these into one entry.
>
> I wouldn't know how, as they are for different files, and AFAIK the changelog format doesn't allow combining messages across files.

Just put them together like entries in the same file, e.g.

* lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled)
(macroexp--warn-and-return):
* lisp/emacs-lisp/bytecomp.el (byte-compile-form, byte-compile-unfold-bcf)
(byte-compile-setq, byte-compile-funcall): Use
‘byte-compile-report-error’ and ‘byte-compile-warn’ instead of
‘byte-compile-log-warning’.

Another example is in 6acff252:

    * src/window.c (window_scroll_pixel_based):
    * src/xdisp.c (pos_visible_p): Don't allow simulated redisplay to
    start outside the accessible portion of the buffer.  This avoids
    assertion violations when some Lisp narrows the buffer to less
    than the current window, and then attempts to scroll the buffer.