From unknown Wed Jun 18 23:17:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24354 <24354@debbugs.gnu.org> To: bug#24354 <24354@debbugs.gnu.org> Subject: Status: Address some compiler warnings in undo-tree Reply-To: bug#24354 <24354@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:17:49 +0000 retitle 24354 Address some compiler warnings in undo-tree reassign 24354 emacs submitter 24354 Jonas Bernoulli severity 24354 minor tag 24354 patch wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 09:32:45 2016 Received: (at submit) by debbugs.gnu.org; 2 Sep 2016 13:32:45 +0000 Received: from localhost ([127.0.0.1]:47092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfoaL-00089H-3P for submit@debbugs.gnu.org; Fri, 02 Sep 2016 09:32:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfoaJ-000894-TH for submit@debbugs.gnu.org; Fri, 02 Sep 2016 09:32:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfoaD-00027h-Im for submit@debbugs.gnu.org; Fri, 02 Sep 2016 09:32:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfoaD-00027d-Fk for submit@debbugs.gnu.org; Fri, 02 Sep 2016 09:32:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfoaB-0007iA-94 for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2016 09:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfoa7-00026u-1t for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2016 09:32:34 -0400 Received: from mail.hostpark.net ([212.243.197.30]:45030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfoa6-00026X-NL for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2016 09:32:30 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C7FD316A38; Fri, 2 Sep 2016 15:32:27 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id rFfWHiYo6pi9; Fri, 2 Sep 2016 15:32:27 +0200 (CEST) Received: from hal (178-82-62-170.dynamic.hispeed.ch [178.82.62.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 8CAAB16A36; Fri, 2 Sep 2016 15:32:26 +0200 (CEST) User-agent: mu4e 0.9.17; emacs 25.1.1 From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org, Toby Cubitt Subject: Address some compiler warnings in undo-tree Date: Fri, 02 Sep 2016 15:32:26 +0200 Message-ID: <878tva8m1h.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, The below two commits address some compiler warnings in `undo-tree', which is available from GNU Elpa. They should be applied to the upstream repository, which should then be merged into its Elpa subtree. Earlier I have pointed out that `undo-tree' isn't currently being properly merged into the Elpa repository. See debbugs#24303. It would probably be a good idea to take care of that first. ---------------------------------------------------------------- After applying these two patches the byte-compiler still complains about some other things: In undo-tree-pull-undo-in-region-branch: undo-tree.el:2279:36:Warning: =E2=80=98undo-elt-crosses-region=E2=80=99= is an obsolete function (as of 25.1). In undo-tree-pull-redo-in-region-branch: undo-tree.el:2476:25:Warning: =E2=80=98undo-elt-crosses-region=E2=80=99= is an obsolete function (as of 25.1). In end of data: undo-tree.el:4381:1:Warning: the function =E2=80=98gv--defsetter=E2=80= =99 might not be defined at runtime. Maybe `undo-elt-crosses-region' should not be declared to be obsolete since `undo-tree' still uses it, or maybe `undo-tree' should stop using it. I don't know. `undo-tree.el' requires `cl' and uses `defsetf' which is defined there. The `defsetf' macro uses some functions from `gv.el', without requiring `gv'. Simply requiring `gv' in `undo-tree' should be avoided because that would break compatibility with older Emacsen. Also it does not actually make that warning go away. However it might be the case that without explicitly requiring `gv' when using Emacsen that come with that library might mean that `gv' might end up not being loaded at run-time, and should therefore be explicitly loaded for such Emacsen. I don't know. ---------------------------------------------------------------- The following changes since commit a3e81b682053a81e082139300ef0a913a7a610= a2 are available in the git repository at: git@github.com:tarsius/undo-tree.git silencio for you to fetch. ---------------------------------------------------------------- Jonas Bernoulli (2): Use _ as VAR in calls to dotimes. Declare two mode variables to silence byte-compiler. undo-tree.el | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) ---------------------------------------------------------------- Toby, I am aware that I have suggested before that you use `_' as VAR in calls to `dotimes' instead of `i'. You rejected that suggestion, claiming that the byte-compiler complaining about `i' not being used is a bug. That is not so, it is a feature, which is helpful when you accidentially don't use `i'. The byte-compiler *not* complaining when you use `_' instead is also a feature, it allows using `dotimes' even when you intentionally don't use `_' without getting these warnings which would be bogus in this case. This is not unique to `dotimes' and I think that now that `undo-tree' is part of Emacs/Elpa you should respect those conventions / use those features, even if you should think that they are misguided. Best regards, Jonas From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 26 09:01:37 2018 Received: (at control) by debbugs.gnu.org; 26 Jan 2018 14:01:38 +0000 Received: from localhost ([127.0.0.1]:43225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef4ZV-00065X-Pn for submit@debbugs.gnu.org; Fri, 26 Jan 2018 09:01:37 -0500 Received: from mail-it0-f51.google.com ([209.85.214.51]:38156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef4ZU-00065L-5f for control@debbugs.gnu.org; Fri, 26 Jan 2018 09:01:36 -0500 Received: by mail-it0-f51.google.com with SMTP id w14so1788414itc.3 for ; Fri, 26 Jan 2018 06:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=/rUj7ALrsm8RWMhbmLO2NBX7efqrx2p2j/FF+MTfQWU=; b=ebPvQdvcmse2p7t2ZQ2TUhzwwhz0H0v0r+ODgzVyFYv3WzxWWR0FXm+LreEpmfysxV RXwMK99pVHXHBpeyQwvu2fN+AYqfxbT9Dp9XFdSXx4RUsVU3qOhlXrOuogBTkdN9Fs+D 5jRzb4DrBmq7waT/kboloaU11Po2eS6Cqh02okfBDDorhB1yf/4M5rxL+L+bATtKfdjR dvqEezEc1MHHMjONPJrL4J6BzCpSDyke0ECH0fgtcUIcUyMYzoGoeLXbFGAAJuIcyezl vSz7JnSDeYpoJE9TR0ZsNJWLme0uSjxs6cfWA9gJEeD7KKc5DGVf3A+VqQXj0kdC1QEu dDWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=/rUj7ALrsm8RWMhbmLO2NBX7efqrx2p2j/FF+MTfQWU=; b=jMtbAE1SUvvm55vlU5LQv7uRtkeEyYq7iTSxnDFJ7nvlLRRpjy28J1SjrDqCEW76W8 CzwDwDrYRkoF61Jl1EYwwFNMEbapOGUVsZehY/SiO1iczgMvMRybMdRedMQbwHuxbKa2 CF1kXHFLhmN1OKJeieiSXojCmJgqwHI0+mr1TZVCmRdXAF37j37hwpOZ7UV8OrTNTXh0 RE/0NirMo1pEWWfJK/qQgDxuhtO7jEnw0zsBI/EZB+oCHoxkcfz6QBGqI5uEAg11il2p 6XVAmlCz45Avtv3yjVDUfJjEYPgt2FmHsMTGuizRfHNSjjGKbLS0vIVpc29fw6zKnovj e9/A== X-Gm-Message-State: AKwxytcDWjoRrFIedtE9NBPGBngmBE9iEW10HgodVfoFnr/z2hjw9//8 b9QcG5+ZurVPBJnCOmTsNWk61Q== X-Google-Smtp-Source: AH8x226tk5zHwnU8kJV5HjB3brzb+5AqiH/TJw3tf/YQnYBm2QPIVB68cRwxURReh9N0H7jFOK895w== X-Received: by 10.36.176.8 with SMTP id d8mr12321334itf.63.1516975290003; Fri, 26 Jan 2018 06:01:30 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v11sm2237100itf.6.2018.01.26.06.01.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 06:01:28 -0800 (PST) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #30235 Date: Fri, 26 Jan 2018 09:01:26 -0500 Message-ID: <87bmhgn2h5.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) severity 24354 minor merge 30235 24354 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 07:51:21 2019 Received: (at 24354) by debbugs.gnu.org; 25 Jun 2019 11:51:21 +0000 Received: from localhost ([127.0.0.1]:58790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjyr-0008P0-47 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 07:51:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjyo-0008Oo-KT; Tue, 25 Jun 2019 07:51:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfjyk-0007fv-6R; Tue, 25 Jun 2019 13:51:16 +0200 From: Lars Ingebrigtsen To: Alex Branham Subject: Re: bug#30235: [patch] undo-tree byte-compiler warnings References: <87y3ko9nbr.fsf@gmail.com> Date: Tue, 25 Jun 2019 13:51:14 +0200 In-Reply-To: <87y3ko9nbr.fsf@gmail.com> (Alex Branham's message of "Tue, 23 Jan 2018 17:18:00 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Branham writes: > I'm not sure if this is the right place to submit patches for ELPA > packages, but I couldn't find anywhere else to go. Let me know if this > should go some place else. > > This patch silences sever [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24354 Cc: 30235@debbugs.gnu.org, 24354@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > I'm not sure if this is the right place to submit patches for ELPA > packages, but I couldn't find anywhere else to go. Let me know if this > should go some place else. > > This patch silences several byte compiler warnings, mostly having to do > with unused lexical variables in loops. The unused dolist fixes look OK, but they could also be rewritten as (cl-loop repeat ... do ...) to avoid the binding altogether. The other changes (time-subtract/subtract-time) I'm not so sure about, because ELPA things are supposed to work across a large number of Emacs versions, and time-subtract is newer than subtract-time. The same with the other obsolete functions -- you're bound to get those warnings in ELPA packages. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 23:24:42 2019 Received: (at 24354) by debbugs.gnu.org; 26 Jun 2019 03:24:42 +0000 Received: from localhost ([127.0.0.1]:34045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfyY6-0005gB-AG for submit@debbugs.gnu.org; Tue, 25 Jun 2019 23:24:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfyY4-0005fr-8X; Tue, 25 Jun 2019 23:24:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfyXx-0007nc-Ot; Tue, 25 Jun 2019 23:24:35 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hfyXw-00012n-OS; Tue, 25 Jun 2019 23:24:32 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Lars Ingebrigtsen In-Reply-To: (message from Lars Ingebrigtsen on Tue, 25 Jun 2019 13:51:14 +0200) Subject: Re: bug#30235: [patch] undo-tree byte-compiler warnings References: <87y3ko9nbr.fsf@gmail.com> Message-Id: Date: Tue, 25 Jun 2019 23:24:32 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 24354 Cc: alex.branham@gmail.com, 30235@debbugs.gnu.org, 24354@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > The unused dolist fixes look OK, but they could also be rewritten as > (cl-loop repeat ... > do ...) > to avoid the binding altogether. Warnings are meant to be our helpers, not our masters. We should not get in the habit of jumping through hoops to satisfy a demanding, rigid program. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 08:39:21 2019 Received: (at control) by debbugs.gnu.org; 17 Sep 2019 12:39:21 +0000 Received: from localhost ([127.0.0.1]:51805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAClM-0008Ar-Ia for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:39:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAClL-0008Ak-82 for control@debbugs.gnu.org; Tue, 17 Sep 2019 08:39:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAClG-0000Gu-HS for control@debbugs.gnu.org; Tue, 17 Sep 2019 14:39:16 +0200 Date: Tue, 17 Sep 2019 14:39:14 +0200 Message-Id: <875zlrm70t.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #30235 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 30235 wontfix close 30235 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30235 wontfix close 30235 quit From unknown Wed Jun 18 23:17:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Oct 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator