GNU bug report logs - #24331
mkdir_p definition in po/Makefile.in.in

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24331 in the body.
You can then email your comments to 24331 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Santiago Vila <sanvila <at> unex.es>
To: bug-diffutils <at> gnu.org
Subject: mkdir_p definition in po/Makefile.in.in
Date: Mon, 29 Aug 2016 23:24:46 +0200 (CEST)

Greetings.

I'm planning to update the Debian package for diffutils.
The current patches are here:

http://sources.debian.net/src/diffutils/1:3.3-3/debian/patches/

Clearly, these four:

01-workaround-for-failing-gnulib-test
03-tune-compare-names-for-qsort
04-add-escapes-for-braces-in-perl-regex
99-config-guess-config-sub

are not required anymore.

But I'm in doubt about this one:

02-fix-mkdir-p-definition-in-po-makefile-in-in

because it would apply cleanly to diffutils-3.5 if I keep it.

The problem such patch was supposed to fix was this one:

https://lists.gnu.org/archive/html/bug-diffutils/2013-08/msg00010.html

and apparently the patch is not needed anymore.

So, to be sure: Would somebody know why the patch was required in
diffutils-3.3 and not anymore in diffutils-3.5?

Thanks.

Message #8 received at 24331 <at> debbugs.gnu.org (full text, mbox):

From: Santiago Vila <sanvila <at> unex.es>
To: 24331 <at> debbugs.gnu.org
Subject: Re: bug#24331: mkdir_p definition in po/Makefile.in.in
Date: Mon, 29 Aug 2016 22:59:34 +0100

Related: Linux From Scratch also modifies po/Makefile.in.in to fix
definition of mkdir_p:

http://www.linuxfromscratch.org/lfs/view/development/chapter06/diffutils.html

Thanks.

Message #11 received at 24331 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Santiago Vila <sanvila <at> unex.es>, 24331 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#24331: mkdir_p definition in po/Makefile.in.in
Date: Tue, 30 Aug 2016 09:41:22 -0700

Santiago Vila wrote:
> So, to be sure: Would somebody know why the patch was required in
> diffutils-3.3 and not anymore in diffutils-3.5?

The patch apparently works around a problem where Automake doesn't AC_SUBST for 
mkdir_p. There was some talk of Automake removing support for mkdir_p (it's 
still listed as deprecated in the man page). Perhaps Debian Automake removed 
mkdir_p support at some point, and then reverted the removal? That would explain 
why you don't need the patch any more.

Message #14 received at 24331 <at> debbugs.gnu.org (full text, mbox):

From: Santiago Vila <sanvila <at> unex.es>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 24331 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#24331: mkdir_p definition in po/Makefile.in.in
Date: Tue, 30 Aug 2016 17:55:44 +0100

On Tue, Aug 30, 2016 at 09:41:22AM -0700, Paul Eggert wrote:
> Santiago Vila wrote:
> >So, to be sure: Would somebody know why the patch was required in
> >diffutils-3.3 and not anymore in diffutils-3.5?
> 
> The patch apparently works around a problem where Automake doesn't AC_SUBST
> for mkdir_p. There was some talk of Automake removing support for mkdir_p
> (it's still listed as deprecated in the man page). Perhaps Debian Automake
> removed mkdir_p support at some point, and then reverted the removal? That
> would explain why you don't need the patch any more.

There must be some other reason. The Debian diffutils package does not
run autoreconf before compiling the package, as I still trust you GNU
people to provide a sane configure script.

Thanks.

Message #19 received at 24331-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Santiago Vila <sanvila <at> unex.es>
Cc: 24331-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#24331: mkdir_p definition in po/Makefile.in.in
Date: Tue, 30 Aug 2016 11:06:10 -0700

Santiago Vila wrote:
> There must be some other reason. The Debian diffutils package does not
> run autoreconf before compiling the package, as I still trust you GNU
> people to provide a sane configure script.

Ah, I found it. The fix was to Automake, here:

http://git.savannah.gnu.org/cgit/automake.git/commit/?id=d90001e3a90ea37fe6866120eb96be7bed8ba66c

Since Jim used a new-enough Automake to build the diffutils 3.5 distribution, 
you should be OK without 02-fix-mkdir-p-definition-in-po-makefile-in-in.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.