GNU bug report logs - #24317
25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix

Previous Next

Package: emacs;

Reported by: Tino Calancha <tino.calancha <at> gmail.com>

Date: Sat, 27 Aug 2016 08:05:01 UTC

Severity: minor

Found in version 25.1.50

Done: Tino Calancha <tino.calancha <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #35 received at 24317 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: Thien-Thi Nguyen <ttn <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>,
 24317 <at> debbugs.gnu.org
Subject: Re: bug#24317: 25.1.50;
 image-dired-rotate-original: regexp doesn't match .jpeg suffix
Date: Sun, 28 Aug 2016 08:22:32 +0200

On Aug 27 2016, Tino Calancha <tino.calancha <at> gmail.com> wrote:

> diff --git a/lisp/image-dired.el b/lisp/image-dired.el
> index 67b023d..61b0751 100644
> --- a/lisp/image-dired.el
> +++ b/lisp/image-dired.el
> @@ -1205,6 +1205,10 @@ image-dired-dired-file-marked-p
>       (beginning-of-line)
>       (not (looking-at "^ .*$"))))
>
> +(defsubst image-dired-jpeg-file-p (file)
> +  "Return non-nil if FILE has a JPEG extension."
> +  (string-match-p "\\.[Jj][Pp][Ee]?[Gg]$" file))

FWIW, the regexp should end in "\\'".

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
This bug report was last modified 8 years and 261 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.