GNU bug report logs - #24315
icalendar--read-element uses inefficient regexp

Previous Next

Full log

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: peder <at> klingenberg.no (Peder O. Klingenberg)
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#24315: 25.1.50;
 re-search-forward errors with "Variable binding depth exceeds
 max-specpdl-size"
Date: Fri, 02 Sep 2016 15:45:34 +0200

[Message part 1 (text/plain, inline)]

On Thu, Sep 01 2016 at 21:58, npostavs <at> users.sourceforge.net wrote:

>> -it finds."
>> +it finds. The current buffer should be an unfolded buffer as returned
>             ^
> Sentences should be double spaced.

Gah!  And I'm usually chided for using old-fashioned double spaces in
prose. :)

> Might be better to avoid finding the end of line twice (since apparently
> 40k lines do happen, I guess it's worth thinking a bit about
> optimizing):

Even finding the the end of the line twice was faster than the regexp
method, subjectively.  On my problematic 40k line, it did not take
noticable time, whereas the regexp caused a bit of a delay even on
shorter events.  But I agree, let's not make emacs do more work than
necessary.  Updated patch attached.

[bug24315.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.