GNU bug report logs - #24313
[PATCH] Add tests for dom.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> gmail.com>
Subject: bug#24313: closed (Re: bug#24313: [PATCH] Add tests for dom.el)
Date: Sun, 28 Aug 2016 16:39:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#24313: [PATCH] Add tests for dom.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 24313 <at> debbugs.gnu.org.

-- 
24313: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24313
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>,
 24313-done <at> debbugs.gnu.org
Subject: Re: bug#24313: [PATCH] Add tests for dom.el
Date: Sun, 28 Aug 2016 18:38:00 +0200

On Sun, Aug 28, 2016 at 11:21 AM, Michael Albinus 
<michael.albinus <at> gmx.de> wrote:
> It depends. Likely you are right, but sometimes it might be worth to
> note also what is NOT covered by a test, or to mention possible side
> effects which are tested implicitely. But it is your decision, of 
> course.

I agree with you. I went over the tests once more with this in mind and
found one instance which I think was worth a comment, but still think
the rest are trivial enough to stand on their own.

I've installed the tests with the changes you suggested last time.

Thanks again for your time.

-- Simen

[Message part 3 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: larsi <at> gnus.org
Cc: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add tests for dom.el
Date: Fri, 26 Aug 2016 20:26:10 +0200

[Message part 4 (text/plain, inline)]

Hello,

I saw that dom.el didn't have any tests, so I wrote some.

Do they look okay to add?

-- Simen

[0001-Add-tests-for-dom.el.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.