GNU bug report logs - #24313
[PATCH] Add tests for dom.el

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>, 24313 <at> debbugs.gnu.org
Subject: bug#24313: [PATCH] Add tests for dom.el
Date: Sun, 28 Aug 2016 11:21:30 +0200

Simen Heggestøyl <simenheg <at> gmail.com> writes:

Hi Simen,

>> It would also be nice if you could add a docstring per test.
>
> Does it any value to such trivial test cases? For most of these I don't
> think there's more to add than "Tests <name-of-function>.", which is
> already conveyed by the name of the test.

It depends. Likely you are right, but sometimes it might be worth to
note also what is NOT covered by a test, or to mention possible side
effects which are tested implicitely. But it is your decision, of course.

> Thank you all for the feedback.
>
> -- Simen

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.