GNU bug report logs - #24313
[PATCH] Add tests for dom.el

Previous Next

Full log

Message #17 received at 24313 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Michael Albinus
 <michael.albinus <at> gmx.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 24313 <at> debbugs.gnu.org
Subject: Re: bug#24313: [PATCH] Add tests for dom.el
Date: Sun, 28 Aug 2016 10:58:47 +0200

On Sat, Aug 27, 2016 at 12:07 PM, Michael Albinus 
<michael.albinus <at> gmx.de> wrote:
> Pls start all tests with the name of the package, "dom-tests-*".

OK, I'll change the test names.

> It would also be nice if you could add a docstring per test.

Does it any value to such trivial test cases? For most of these I don't
think there's more to add than "Tests <name-of-function>.", which is
already conveyed by the name of the test.

> This reads better as
> 
> (should-not (dom-attributes dom))

OK, I'll change it.

On Sat, Aug 27, 2016 at 10:18 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> If there are specific aspects of these tests about which you are
> unsure or which you'd like us to consider, please point them out.

Nothing in particular, I just wanted to get feedback before installing.

On Sat, Aug 27, 2016 at 3:46 PM, Lars Ingebrigtsen <larsi <at> gnus.org> 
wrote:
> Looks good to me.

Good, I'll install it shortly.

Thank you all for the feedback.

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.