GNU bug report logs - #24313
[PATCH] Add tests for dom.el

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: larsi <at> gnus.org, 24313 <at> debbugs.gnu.org
Subject: bug#24313: [PATCH] Add tests for dom.el
Date: Sat, 27 Aug 2016 12:07:13 +0200

Simen Heggestøyl <simenheg <at> gmail.com> writes:

> Hello,

Hi Simen,

> I saw that dom.el didn't have any tests, so I wrote some.
>
> Do they look okay to add?
>
> +;;; dom-tests.el --- Tests for dom.el  -*- lexical-binding: t; -*-
> +
> +(ert-deftest test-dom-tag ()

Pls start all tests with the name of the package, "dom-tests-*". It
would also be nice if you could add a docstring per test.

> +    (should (null (dom-attributes dom)))

This reads better as

(should-not (dom-attributes dom))

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.