Subject: Re: bug#24313: [PATCH] Add tests for dom.el

From: Michael Albinus <[email-masked]>
Date: Sat, 27 Aug 2016 12:07:13 +0200

Simen Heggestøyl <[email-masked]> writes:

> Hello,

Hi Simen,

> I saw that dom.el didn't have any tests, so I wrote some.
>
> Do they look okay to add?
>
> +;;; dom-tests.el --- Tests for dom.el  -*- lexical-binding: t; -*-
> +
> +(ert-deftest test-dom-tag ()

Pls start all tests with the name of the package, "dom-tests-*". It
would also be nice if you could add a docstring per test.

> +    (should (null (dom-attributes dom)))

This reads better as

(should-not (dom-attributes dom))

Best regards, Michael.