From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2016 18:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: larsi@gnus.org Cc: 24313@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14722359918811 (code B ref -1); Fri, 26 Aug 2016 18:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Aug 2016 18:26:31 +0000 Received: from localhost ([127.0.0.1]:41679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdLpm-0002I3-Op for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdLpl-0002Hq-3l for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdLpe-0000O5-8l for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdLpe-0000Nn-5I for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdLpb-0008TV-5Z for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 14:26:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdLpW-0000Mg-QY for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 14:26:18 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:33650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdLpW-0000ME-Ca for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 14:26:14 -0400 Received: by mail-lf0-x22d.google.com with SMTP id b199so62485435lfe.0 for ; Fri, 26 Aug 2016 11:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:mime-version; bh=sI9fgw/QHFoUHITueJ1Sw0zlwAsJqyPjMasdMJHr/p4=; b=NnRjOctAlS3U//eqQS2RuAbr5HOPmsgh30zNAAKmQs53xWt0JzSSrgS8mwVobLR0BT J/N6DNbdxRuqh9WRpAVVfrSu7ZiT9yzNelMh64vvtBKpd5Ezxn2nId5XZ0VQ5B+v9x4w hqLqtI21VERV4qxhZFJHdBAu8Hv91NmUo/fIpDAqHG0mmwAuNiUIbRLy6PH+vJsKKP5p ALWtltMyK+qSV2fA4xymI/hJYO343H5ldWLRjRxfC4R8aau52G1BpQaHG5ZeZYxTQ6l5 6p2C/jPd3NomZQIrGrYYLxYQzgWlTMZHzamrsDfOZ9Ajn/8oFCGDPOe/R9gzwW5TxlMj 97QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:mime-version; bh=sI9fgw/QHFoUHITueJ1Sw0zlwAsJqyPjMasdMJHr/p4=; b=Fb/in9NO/YHaaZjaM9w5WCpkmlRIgkrrPPoWXJFHRBGed050tI2X1dWuUuoj8gsuYr 1UeeF8U1YFuKwVe5+WiyvPMVhf7TNeIauwWOozBUjDKoCsrnld6d13DYqsP/w2uT9JrZ LA32ZmOcDqHM5SVhKsWpawWgwix92scsxuusWMt099eD6tBmAQ6bub//2PsH4VIZ+Dw5 hM5WDa1QbLsdEBO0W2xcmW3r2eHF+kt4Jg5n1K/JYvKdhApl/ML+dlNXTkvXHVLgUf/a E6efaCkXibc2aP4A13PCVd9AHZMlkSDTqM19Z83S/ksmNPfxPGI6pPznEP62cgcZNrC1 s+yg== X-Gm-Message-State: AE9vXwNE7XiZGln8XUwRTOR1qFyW6Zxomlz4g45erFVKHKRdUb+04yi3Qxfup0W4D/Gitw== X-Received: by 10.25.147.197 with SMTP id v188mr2150164lfd.9.1472235972913; Fri, 26 Aug 2016 11:26:12 -0700 (PDT) Received: from [192.168.100.6] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id g29sm4160435lji.45.2016.08.26.11.26.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Aug 2016 11:26:11 -0700 (PDT) Date: Fri, 26 Aug 2016 20:26:10 +0200 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Message-Id: <1472235970.16843.0@smtp.gmail.com> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-hRRMDl+vnggg4+zLWihd" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-hRRMDl+vnggg4+zLWihd Content-Type: text/plain; charset=utf-8; format=flowed Hello, I saw that dom.el didn't have any tests, so I wrote some. Do they look okay to add? -- Simen --=-hRRMDl+vnggg4+zLWihd Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tests-for-dom.el.patch Content-Transfer-Encoding: quoted-printable >From c74c0fac972ce235954efc56ff540021f9dd0615 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Simen=3D20Heggest=3DC3=3DB8yl?=3D Date: Sun, 14 Aug 2016 16:03:50 +0200 Subject: [PATCH] Add tests for dom.el * test/lisp/dom-tests.el: New file with tests for dom.el. --- test/lisp/dom-tests.el | 195 +++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 195 insertions(+) create mode 100644 test/lisp/dom-tests.el diff --git a/test/lisp/dom-tests.el b/test/lisp/dom-tests.el new file mode 100644 index 0000000..e3e14b2 --- /dev/null +++ b/test/lisp/dom-tests.el @@ -0,0 +1,195 @@ +;;; dom-tests.el --- Tests for dom.el -*- lexical-binding: t; -*- + +;; Copyright (C) 2016 Free Software Foundation, Inc. + +;; Author: Simen Heggest=C3=B8yl +;; Keywords: + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; + +;;; Code: + +(require 'dom) +(require 'ert) +(require 'subr-x) + +(defun dom-test-tree () + "Return a DOM tree for testing." + (dom-node "html" nil + (dom-node "head" nil + (dom-node "title" nil + "Test")) + (dom-node "body" nil + (dom-node "div" '((class . "foo") + (style . "color: red;")) + (dom-node "p" '((id . "bar")) + "foo")) + (dom-node "div" '((title . "2nd div")) + "bar")))) + +(ert-deftest test-dom-tag () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag dom) "html")) + (should (equal (dom-tag (car (dom-children dom))) "head")))) + +(ert-deftest test-dom-attributes () + (let ((dom (dom-test-tree))) + (should (null (dom-attributes dom))) + (should (equal (dom-attributes (dom-by-class dom "foo")) + '((class . "foo") (style . "color: red;")))))) + +(ert-deftest test-dom-children () + (let ((dom (dom-test-tree))) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body"))) + (should (equal (dom-tag (dom-children (dom-children dom))) + "title")))) + +(ert-deftest test-dom-non-text-children () + (let ((dom (dom-test-tree))) + (should (equal (dom-children dom) (dom-non-text-children dom))) + (should (null (dom-non-text-children + (dom-children (dom-children dom))))))) + +(ert-deftest test-dom-set-attributes () + (let ((dom (dom-test-tree)) + (attributes '((xmlns "http://www.w3.org/1999/xhtml")))) + (should (null (dom-attributes dom))) + (dom-set-attributes dom attributes) + (should (equal (dom-attributes dom) attributes)))) + +(ert-deftest test-dom-set-attribute () + (let ((dom (dom-test-tree)) + (attr 'xmlns) + (value "http://www.w3.org/1999/xhtml")) + (should (null (dom-attributes dom))) + (dom-set-attribute dom attr value) + (should (equal (dom-attr dom attr) value)))) + +(ert-deftest test-dom-attr () + (let ((dom (dom-test-tree))) + (should (null (dom-attr dom 'id))) + (should (equal (dom-attr (dom-by-id dom "bar") 'id) "bar")))) + +(ert-deftest test-dom-text () + (let ((dom (dom-test-tree))) + (should (string-empty-p (dom-text dom))) + (should (equal (dom-text (dom-by-tag dom "title")) "Test")))) + +(ert-deftest test-dom-texts () + (let ((dom (dom-test-tree))) + (should (equal (dom-texts dom) "Test foo bar")) + (should (equal (dom-texts dom ", ") "Test, foo, bar")))) + +(ert-deftest test-dom-child-by-tag () + (let ((dom (dom-test-tree))) + (should (equal (dom-child-by-tag dom "head") + (car (dom-children dom)))) + (should (not (dom-child-by-tag dom "title"))))) + +(ert-deftest test-dom-by-tag () + (let ((dom (dom-test-tree))) + (should (=3D (length (dom-by-tag dom "div")) 2)) + (should (null (dom-by-tag dom "article"))))) + +(ert-deftest test-dom-strings () + (let ((dom (dom-test-tree))) + (should (equal (dom-strings dom) '("Test" "foo" "bar"))) + (should (equal (dom-strings (dom-children dom)) '("Test"))))) + +(ert-deftest test-dom-by-class () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag (dom-by-class dom "foo")) "div")) + (should (null (dom-by-class dom "bar"))))) + +(ert-deftest test-dom-by-style () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag (dom-by-style dom "color")) "div")) + (should (null (dom-by-style dom "width"))))) + +(ert-deftest test-dom-by-id () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag (dom-by-id dom "bar")) "p")) + (should (null (dom-by-id dom "foo"))))) + +(ert-deftest test-dom-elements () + (let ((dom (dom-test-tree))) + (should (equal (dom-elements dom 'class "foo") + (dom-by-class dom "foo"))) + (should (equal (dom-attr (dom-elements dom 'title "2nd") 'title) + "2nd div")))) + +(ert-deftest test-dom-remove-node () + (let ((dom (dom-test-tree))) + (should (not (dom-remove-node dom dom))) + (should (=3D (length (dom-children dom)) 2)) + (dom-remove-node dom (car (dom-children dom))) + (should (=3D (length (dom-children dom)) 1)) + (dom-remove-node dom (car (dom-children dom))) + (should (null (dom-children dom))))) + +(ert-deftest test-dom-parent () + (let ((dom (dom-test-tree))) + (should (not (dom-parent dom dom))) + (should (equal (dom-parent dom (car (dom-children dom))) dom)))) + +(ert-deftest test-dom-previous-sibling () + (let ((dom (dom-test-tree))) + (should (not (dom-previous-sibling dom dom))) + (let ((children (dom-children dom))) + (should (equal (dom-previous-sibling dom (cadr children)) + (car children)))))) + +(ert-deftest test-dom-append-child () + (let ((dom (dom-test-tree))) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body"))) + (dom-append-child dom (dom-node "feet")) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body" "feet"))))) + +(ert-deftest test-dom-add-child-before () + (let ((dom (dom-test-tree))) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body"))) + (dom-add-child-before dom (dom-node "neck") + (dom-child-by-tag dom "body")) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "neck" "body"))) + (dom-add-child-before dom (dom-node "hat")) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("hat" "head" "neck" "body"))))) + +(ert-deftest test-dom-ensure-node () + (let ((node (dom-node "foo"))) + (should (equal (dom-ensure-node '("foo")) node)) + (should (equal (dom-ensure-node '(("foo"))) node)) + (should (equal (dom-ensure-node '("foo" nil)) node)) + (should (equal (dom-ensure-node '(("foo") nil)) node)))) + +(ert-deftest test-dom-pp () + (let ((node (dom-node "foo" nil ""))) + (with-temp-buffer + (dom-pp node) + (should (equal (buffer-string) "(\"foo\" nil\n \"\")"))) + (with-temp-buffer + (dom-pp node t) + (should (equal (buffer-string) "(\"foo\" nil)"))))) + +(provide 'dom-tests) +;;; dom-tests.el ends here --=20 2.9.3 = --=-hRRMDl+vnggg4+zLWihd-- From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 08:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: larsi@gnus.org, 24313@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.147228589527246 (code B ref 24313); Sat, 27 Aug 2016 08:19:01 +0000 Received: (at 24313) by debbugs.gnu.org; 27 Aug 2016 08:18:15 +0000 Received: from localhost ([127.0.0.1]:41824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdYoh-00075O-38 for submit@debbugs.gnu.org; Sat, 27 Aug 2016 04:18:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdYof-000757-Bf for 24313@debbugs.gnu.org; Sat, 27 Aug 2016 04:18:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdYoV-0000A3-9P for 24313@debbugs.gnu.org; Sat, 27 Aug 2016 04:18:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdYoV-00009y-6E; Sat, 27 Aug 2016 04:18:03 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1189 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bdYoT-0002Rh-AO; Sat, 27 Aug 2016 04:18:01 -0400 Date: Sat, 27 Aug 2016 11:18:25 +0300 Message-Id: <83eg5ad3qm.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1472235970.16843.0@smtp.gmail.com> (message from Simen =?UTF-8?Q?Heggest=C3=B8yl?= on Fri, 26 Aug 2016 20:26:10 +0200) References: <1472235970.16843.0@smtp.gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > Date: Fri, 26 Aug 2016 20:26:10 +0200 > From: Simen Heggestøyl > Cc: 24313@debbugs.gnu.org > > I saw that dom.el didn't have any tests, so I wrote some. > > Do they look okay to add? Tests are always okay to add and are very welcome, so thank you very much for this contribution. If there are specific aspects of these tests about which you are unsure or which you'd like us to consider, please point them out. Otherwise, if no comments are posted, let's push this in a few days. From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: larsi@gnus.org, 24313@debbugs.gnu.org Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.14722924445345 (code B ref 24313); Sat, 27 Aug 2016 10:08:01 +0000 Received: (at 24313) by debbugs.gnu.org; 27 Aug 2016 10:07:24 +0000 Received: from localhost ([127.0.0.1]:41859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdaWJ-0001O8-Sh for submit@debbugs.gnu.org; Sat, 27 Aug 2016 06:07:24 -0400 Received: from mout.gmx.net ([212.227.17.20]:49193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdaWJ-0001Nw-2o for 24313@debbugs.gnu.org; Sat, 27 Aug 2016 06:07:23 -0400 Received: from detlef.gmx.de ([87.146.60.197]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LzXTy-1b0aen3bd4-014gTl; Sat, 27 Aug 2016 12:07:16 +0200 From: Michael Albinus References: <1472235970.16843.0@smtp.gmail.com> Date: Sat, 27 Aug 2016 12:07:13 +0200 In-Reply-To: <1472235970.16843.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Fri, 26 Aug 2016 20:26:10 +0200") Message-ID: <87bn0e4jam.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:XFKN3oD/kkZ6+bR9Ud/PZeg5v0PLNp9CFUhqAOBswxSyJ3RHuf5 MWo9OGNz5L2RRgX21mSRQIZ36VWTwIhmri9JR/fok2jezVc9a6hwYUQ1ETZkSY3B+Xd3/qK m5Kb5Cjsm4Z0+E9l5ONn8NprjkoLuySb+rlnNp1F3iTMMkC71VPOlEjmtvVr61ZKz+uI0BR GC167TxhfD7fNJTeAF8kQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ulZofb367IQ=:Q92VgnYIiVrYHwYs0jUliy RRF61kBHmPkpF+izXf3fK+X2JTbLdJAdNHTFETCVuuXIQgyvtGhD2I0yioInLrAL5HEZw2XLn NGTDHZdRytmcXFI9OZF6QTJO2j7lbr4Baza+ynlTdFdlghutSjgWpfEfypsVrqD7Lw/p2UNvC z6CnkeZE8Z4HJQ7IXylqYRPueYTYmarMQgBR3UExpAY8ARr3oEtFgx/k64GA4IXVd+LMsC9WO Z3rq8+xmd2sbSOr911H5T2Ei/Yzznf460haLRywX4EFAztvwAGGitaakfS6xg5QZZOO5t8b3a U+5AEjek43Loux5pOsSXFTyYNfr1njbAEpn51w1Vjy3aFxNdcoHMXmYXKGRkPU2+NKTT+bqHv gpsEZ/iv7ejfiy5elMiw4+HFqQqgCs/lKfrKSM3yvRDhJYiXUKRSqH6tacAREJ1iHrRFbth/g 1HNm4K+GsANBTLzubGVQAzDLkJb6PrsoSKdQGbwr1d8PoFfvAhMEPfBTL5JcRj3joAPxVP/YS klj946E58AGRpkua6LB74OMeXbomepQjqgHpgqgsmvh5G/9X6KW4KrYT1mHvOge5bVIQ+tj72 FmbhSXAlcFW7eNcMdEv2vYW5o6h9aX4csEaTO+a4oTwoXE8JFXiWSz1SkcHHIV9s8uhs9Dgat 1F3z+khO+M2pC/dZri1wpOmmNfB9zj30Dm2Z80N3uyFzA1FTuwpIkLvYc+8mZhB3GzLZuWESb mpmSv13mjvghTvS4tJt1AwU5VRNFqkEX7RKgO+5sxUbKWdI92uXXlm2S+FMz2q2o7krdvmn9d dzseNk0 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Simen Heggest=C3=B8yl writes: > Hello, Hi Simen, > I saw that dom.el didn't have any tests, so I wrote some. > > Do they look okay to add? > > +;;; dom-tests.el --- Tests for dom.el -*- lexical-binding: t; -*- > + > +(ert-deftest test-dom-tag () Pls start all tests with the name of the package, "dom-tests-*". It would also be nice if you could add a docstring per test. > + (should (null (dom-attributes dom))) This reads better as (should-not (dom-attributes dom)) Best regards, Michael. From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: 24313@debbugs.gnu.org Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.147230566732603 (code B ref 24313); Sat, 27 Aug 2016 13:48:02 +0000 Received: (at 24313) by debbugs.gnu.org; 27 Aug 2016 13:47:47 +0000 Received: from localhost ([127.0.0.1]:41906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bddxb-0008Tn-7x for submit@debbugs.gnu.org; Sat, 27 Aug 2016 09:47:47 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:45979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bddxZ-0008Td-HW for 24313@debbugs.gnu.org; Sat, 27 Aug 2016 09:47:46 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bddxT-0007PS-Mc; Sat, 27 Aug 2016 15:47:41 +0200 From: Lars Ingebrigtsen References: <1472235970.16843.0@smtp.gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXk2eINBggFAgNiMzql jJYxEBYXCQyAXWtczaSjAAACQ0lEQVQ4jZWTQW+jMBCFLYUqZ0hDz7ii57YGfK2EI1+XEJMzRfFe K9l0/v4+m9DtbreHHUFi/OnNPDwDy3iaZvwaKa5rsCz7vR/ZCnAXH7vFouKLgn+NIrXsH9tQ5ADF pZekn/jOM4RSisRokYqfSSnd7c9sjcTVrskAnHR97ytFnvQL9slreg8K1wtBiSdHRI9MS0B1ALB2 8kolaokm7DMWAL/4lzW9FnJZ3ADs5QqS+aT0sr5B8UmSig9bI+GP3lYFQJS0k2IJAAWwAcDrQZI0 fbCqtOgfr8UjaMfoBrZEd2ZqHrMFNCOPqbfCu2NJDY4LgNw4zQvYGNke+dn4YwAN7327gNaQO/Kf JxZAVvReHXgVQe/8My9pO6D4A96jtbx8iwrh3zmn/hCPnVRtjAmH0Q5Co/LJbyLw2tRC1PDbdrLm r/yWLYC0CIFcm2E68gd+z1bFCrYmLzAp5ReQDNmDoc+gNqIOoA7mX8uXD2CGq60st3KiqKiCq5FP fbC17Ypcoo0R6GZvOL+fuseQK7diBc8FBLy8637g1NvhIkQVwWW0YXzLyVTobDS4gOJiagC7ayof OuswZdGVMX0A434WUisMnZBSHUbG5Xsc8G7nhHQSlQWG+WBZeiYnj1Ds5rp3hAoYoqDIcIiQ18MF QAQFBhbTgNZiTaEmkXSEpVek52ujQtDnmOPH+WfkeZqO4au9Jamdp1oppKlk+HW+A7jzaCH5Axzg n7TEMz2FVHnM0P2V8GuNJew3IP9fYO03ILf2F3dn4xh1VjaXAAAAAElFTkSuQmCC Date: Sat, 27 Aug 2016 15:46:38 +0200 In-Reply-To: <1472235970.16843.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Fri, 26 Aug 2016 20:26:10 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Simen Heggest=C3=B8yl writes: > I saw that dom.el didn't have any tests, so I wrote some. > > Do they look okay to add? Looks good to me. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2016 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen , Michael Albinus , Eli Zaretskii Cc: 24313@debbugs.gnu.org Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.14723747449242 (code B ref 24313); Sun, 28 Aug 2016 09:00:02 +0000 Received: (at 24313) by debbugs.gnu.org; 28 Aug 2016 08:59:04 +0000 Received: from localhost ([127.0.0.1]:42470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdvvh-0002Of-9x for submit@debbugs.gnu.org; Sun, 28 Aug 2016 04:59:04 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdvvc-0002OM-5Q for 24313@debbugs.gnu.org; Sun, 28 Aug 2016 04:58:59 -0400 Received: by mail-lf0-f50.google.com with SMTP id b199so82540557lfe.0 for <24313@debbugs.gnu.org>; Sun, 28 Aug 2016 01:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=au1ad52E8ckVAiRzpd8JfyFDrSY7Q74D2bYO3roOKpA=; b=wMyDPeMUdSsrRAR8HueMt3bL73xJDthrolcSn6dE8jO0IyhEJipbis+TBBWhUAJ04U 5sEIi1EIjazySQtZFSpMBTkD4xEb76X9StYCV1q93wTa2REc1yTX+WOlpx/jpIoAVxXK FC3KfG1PgPhQxmMZTmzx83WkJcr8CCgi7HX9mU1zkeC3IrfYaRSIWrrMvIBeA4A5Iqyj pHOkUmsn5oMARxT6oH7tlCYC8MmGEF0ousta9C3Se78uWsqSn8l+Jl2RE8IQtli6If0M FSodySGQ5xsTU0QqDndIY15BVAbfqTAPfdseU5gQPEBxWnybSRx4KbQhvtNqLGj0YuBl t5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=au1ad52E8ckVAiRzpd8JfyFDrSY7Q74D2bYO3roOKpA=; b=b4aGmugrH7YtZnXOXfbKyhrc/Z/CZfKxmd3gnF55eiRyYaqXJVejfUcaZ5mgAO5FXP HvmzK6hS90JwVLRkrK5wag52U5E8RLEIJXgLx35tgzUMUE9tmGDPsVcHb8Qg9ZdlrGhv jBumH4OjQl03f/0epCqyjFUh8TyAF5v6GPIJeVKNlER0CVKVK5SQ983wP9m2pOsBI4jH ESQ3Ybl0wa4a4LWEZvGRZctX8PesFt7M6HebYY3dhnxaDGaX6me/IB1/1rOsCieAkbRa 1YNPob1Tz22WIE36xeUypKm5Jbh7ytha3iPWAMt0SpsZb1va17ZpiskFqt9zEN7BHAos ao0w== X-Gm-Message-State: AE9vXwOHeQDNOCtBiPM3bGlwSkS2rYs0ew+mdBk96KBTCDYgvVY5NIt810CslQe/Z0ZT4Q== X-Received: by 10.25.18.78 with SMTP id h75mr4395697lfi.148.1472374729951; Sun, 28 Aug 2016 01:58:49 -0700 (PDT) Received: from [192.168.100.6] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id u2sm5381860lja.16.2016.08.28.01.58.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Aug 2016 01:58:49 -0700 (PDT) Date: Sun, 28 Aug 2016 10:58:47 +0200 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Message-Id: <1472374727.3660.0@smtp.gmail.com> In-Reply-To: References: <1472235970.16843.0@smtp.gmail.com> <"Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Fri, 26 Aug 2016 20:26:10 +0200"> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Aug 27, 2016 at 12:07 PM, Michael Albinus wrote: > Pls start all tests with the name of the package, "dom-tests-*". OK, I'll change the test names. > It would also be nice if you could add a docstring per test. Does it any value to such trivial test cases? For most of these I don't think there's more to add than "Tests .", which is already conveyed by the name of the test. > This reads better as > > (should-not (dom-attributes dom)) OK, I'll change it. On Sat, Aug 27, 2016 at 10:18 AM, Eli Zaretskii wrote: > If there are specific aspects of these tests about which you are > unsure or which you'd like us to consider, please point them out. Nothing in particular, I just wanted to get feedback before installing. On Sat, Aug 27, 2016 at 3:46 PM, Lars Ingebrigtsen wrote: > Looks good to me. Good, I'll install it shortly. Thank you all for the feedback. -- Simen From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2016 09:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: Lars Ingebrigtsen , Eli Zaretskii , 24313@debbugs.gnu.org Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.147237610311295 (code B ref 24313); Sun, 28 Aug 2016 09:22:02 +0000 Received: (at 24313) by debbugs.gnu.org; 28 Aug 2016 09:21:43 +0000 Received: from localhost ([127.0.0.1]:42475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdwHf-0002w7-EL for submit@debbugs.gnu.org; Sun, 28 Aug 2016 05:21:43 -0400 Received: from mout.gmx.net ([212.227.17.22]:63041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdwHe-0002vv-75 for 24313@debbugs.gnu.org; Sun, 28 Aug 2016 05:21:42 -0400 Received: from detlef.gmx.de ([87.146.62.18]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MB2G8-1bnneT3Wqa-009zaE; Sun, 28 Aug 2016 11:21:34 +0200 From: Michael Albinus References: <1472235970.16843.0@smtp.gmail.com> <1472374727.3660.0@smtp.gmail.com> Date: Sun, 28 Aug 2016 11:21:30 +0200 In-Reply-To: <1472374727.3660.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sun, 28 Aug 2016 10:58:47 +0200") Message-ID: <87poottfj9.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:zziHU2hhRBn7dmPhi9pSVsWxZ+XMjOKRUyLGQwZQRRHyARlg8Zm wpLOPwzjSvvW3jY6WrCjSgODj2Xqc7RowirpTrbBTiPDzF5fs3ll4ldeqhUzCJfg4WQcdu9 eWboi2aB9fjsOJ5j9ssc+dqBno31dy+nnB0jjB9hhtR7MuG0uyqQji04kWNcGy4n21Lh3SL O3ixxwPG5euZs5AdT2/Tw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZPLHXtZ2VHU=:4lahG76+XHL5Q5UvD75pn1 Y+E+tROR0plMF/ljCI4AkYrPkS13G+uv3wTHnxYmqUyJPOKwTe92RiCbx0U+bpziqjN6volgK Mp/yYB13I1gBMQuLlDolEH5JeGkI/Usjc8aTF4sc/tYCI7MG/TdixRAI6EA5rrc0s9yVtgkMo 5MuCssrdeoYQE79dADGCIoOPWElx83xGM6vag4MmXCDzpJBGa5ULhhXbpGBJiHINPKECwyhh7 FumFcoXseAT6eVWD5oCm9756hv7fvwvvUFTuYFNZ9uSataQlUZ/Ne0jP/02eR7t7bUJtMmHHp ymo6548KQ9zVTj6RSUHyynXUWnHJBEz4Aw2+urkhC+iaW/0FaOUvek02BmL1VIRx0DQaLNRZ4 XG77UWsueuyc4QvKXBWe3M+sFEoRo0iMVgDGEylvUQGRnv8kmtXF18mXTc8T7mQ6CXTjThlrl Qzjq9xP9Ts/r3CbeJdawZksCaZUJODQrKIO+V3TOb5bSOqIHjv0Ki6TAbK+BwJm+QaZhk6uwJ i45R+gL96nR/vYNf9qUBJbWRhvCDAnISBziOFuAnPkpfI5pP+jmy4/6YV/HilVJwsYwU5fVYw e0DfN036zQzcLWJOTwTNYoeqj198n4PRMZ7AD6JF3IUrQvGn2XVzI0tMszmbCqEtI/GywRNY9 l6KSHWdtDeqCCHyv00ohfCFpd0aJo1ITu7mSiJoPuVaY7rSL4MWlYzH+7fe7Ucv3DfHOfOZBw ojRy4TTVmcluhXAuGWCIjjVCv0LPbCFWrcOXsRH4o50t+7VgL4kJmH/6CvRe1jIHb/Yu5EBTU ItKZpGM X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Simen Heggest=C3=B8yl writes: Hi Simen, >> It would also be nice if you could add a docstring per test. > > Does it any value to such trivial test cases? For most of these I don't > think there's more to add than "Tests .", which is > already conveyed by the name of the test. It depends. Likely you are right, but sometimes it might be worth to note also what is NOT covered by a test, or to mention possible side effects which are tested implicitely. But it is your decision, of course. > Thank you all for the feedback. > > -- Simen Best regards, Michael. From unknown Sun Jun 22 00:20:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Subject: bug#24313: closed (Re: bug#24313: [PATCH] Add tests for dom.el) Message-ID: References: <1472402280.5159.0@smtp.gmail.com> <1472235970.16843.0@smtp.gmail.com> X-Gnu-PR-Message: they-closed 24313 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 24313@debbugs.gnu.org Date: Sun, 28 Aug 2016 16:39:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1472402342-31065-1" This is a multi-part message in MIME format... ------------=_1472402342-31065-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24313: [PATCH] Add tests for dom.el which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24313@debbugs.gnu.org. --=20 24313: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24313 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1472402342-31065-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24313-done) by debbugs.gnu.org; 28 Aug 2016 16:38:10 +0000 Received: from localhost ([127.0.0.1]:42973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be362-00083t-FR for submit@debbugs.gnu.org; Sun, 28 Aug 2016 12:38:10 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be361-00083b-0f for 24313-done@debbugs.gnu.org; Sun, 28 Aug 2016 12:38:09 -0400 Received: by mail-lf0-f47.google.com with SMTP id b199so86378441lfe.0 for <24313-done@debbugs.gnu.org>; Sun, 28 Aug 2016 09:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=hA5ADBwYXHn2i39KW24QXabkQcn/rrxTNu9rYHEPUDw=; b=Njacemsy131ytvAXhrJgWC/9O67SnAR3LSPl7tK+G9MQu2AZWDmdqTRG+cUC6gCNmQ mrrkWC26t6fDFD6UcSRoEU7vdlmZxwDU47fosTlpend8fapqL2t2+fN9BxM1RLeTv4U0 ALy4mxI09+ZbrSCbB9hgodXm7pFBdBuV+dtuT6Zo4WpSFh0isaRzL+RgCLAAuJln4Qlo 4QeR5/SVAu4JmqnMykYTuM3lyepAD9DXI5PoHF6cDmMMa/YoRH9HDfnS73UUtCb3VJca i77wKYfxOvvxkp9+HUrb1pU+O/9G+FU1UwCEDxpXOpl72VD2bToG3kjtKaiy2OW5Y6Lb BkJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=hA5ADBwYXHn2i39KW24QXabkQcn/rrxTNu9rYHEPUDw=; b=dN/rd2uftu0qVxnUe56Zs9EmVDS70pPNmH0ch9Yyb/s9gQhZVinJM2XCXyWdhpsupJ NJEAoxKuvXV0asJYmvZvo+OuKqixFYyukZ0KbXYGGzH3NEXIoY7w/wqKTusfoFhYB2KU 1DT4Ls6GAtysMW7L9TYuSWNmCNmkFRrR/hGY97tKBvQEE8Iyd2O8w5zE7fT8SzNSa5tC i3KygVX/2cvR1NsX/ymryU9zWI5pSsu0ftbJPKdquFVZEo+xzzmSddcf6L5JxUwJqEuL d7xL+HkUeP1MKAdG2PtV65AItplPzwHqwotnA1Y0jyJMzMshXGkEqd+O+tqR3TBwyYA2 syaQ== X-Gm-Message-State: AE9vXwPXAJMu+twXjCzJHV3nkTq8cFA4vLGaMsBRZ2rhmv3JtIrKBKmYefTnJZ0IxRuPzg== X-Received: by 10.25.160.15 with SMTP id j15mr4290720lfe.109.1472402282944; Sun, 28 Aug 2016 09:38:02 -0700 (PDT) Received: from [192.168.100.6] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id s2sm5796125lja.35.2016.08.28.09.38.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Aug 2016 09:38:02 -0700 (PDT) Date: Sun, 28 Aug 2016 18:38:00 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#24313: [PATCH] Add tests for dom.el To: Michael Albinus Message-Id: <1472402280.5159.0@smtp.gmail.com> In-Reply-To: <87poottfj9.fsf@gmx.de> References: <1472235970.16843.0@smtp.gmail.com> <1472374727.3660.0@smtp.gmail.com> <"Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sun, 28 Aug 2016 10:58:47 +0200"> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24313-done Cc: Lars Ingebrigtsen , Eli Zaretskii , 24313-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Aug 28, 2016 at 11:21 AM, Michael Albinus wrote: > It depends. Likely you are right, but sometimes it might be worth to > note also what is NOT covered by a test, or to mention possible side > effects which are tested implicitely. But it is your decision, of > course. I agree with you. I went over the tests once more with this in mind and found one instance which I think was worth a comment, but still think the rest are trivial enough to stand on their own. I've installed the tests with the changes you suggested last time. Thanks again for your time. -- Simen ------------=_1472402342-31065-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Aug 2016 18:26:31 +0000 Received: from localhost ([127.0.0.1]:41679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdLpm-0002I3-Op for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdLpl-0002Hq-3l for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdLpe-0000O5-8l for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdLpe-0000Nn-5I for submit@debbugs.gnu.org; Fri, 26 Aug 2016 14:26:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdLpb-0008TV-5Z for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 14:26:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdLpW-0000Mg-QY for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 14:26:18 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:33650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdLpW-0000ME-Ca for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 14:26:14 -0400 Received: by mail-lf0-x22d.google.com with SMTP id b199so62485435lfe.0 for ; Fri, 26 Aug 2016 11:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:mime-version; bh=sI9fgw/QHFoUHITueJ1Sw0zlwAsJqyPjMasdMJHr/p4=; b=NnRjOctAlS3U//eqQS2RuAbr5HOPmsgh30zNAAKmQs53xWt0JzSSrgS8mwVobLR0BT J/N6DNbdxRuqh9WRpAVVfrSu7ZiT9yzNelMh64vvtBKpd5Ezxn2nId5XZ0VQ5B+v9x4w hqLqtI21VERV4qxhZFJHdBAu8Hv91NmUo/fIpDAqHG0mmwAuNiUIbRLy6PH+vJsKKP5p ALWtltMyK+qSV2fA4xymI/hJYO343H5ldWLRjRxfC4R8aau52G1BpQaHG5ZeZYxTQ6l5 6p2C/jPd3NomZQIrGrYYLxYQzgWlTMZHzamrsDfOZ9Ajn/8oFCGDPOe/R9gzwW5TxlMj 97QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:mime-version; bh=sI9fgw/QHFoUHITueJ1Sw0zlwAsJqyPjMasdMJHr/p4=; b=Fb/in9NO/YHaaZjaM9w5WCpkmlRIgkrrPPoWXJFHRBGed050tI2X1dWuUuoj8gsuYr 1UeeF8U1YFuKwVe5+WiyvPMVhf7TNeIauwWOozBUjDKoCsrnld6d13DYqsP/w2uT9JrZ LA32ZmOcDqHM5SVhKsWpawWgwix92scsxuusWMt099eD6tBmAQ6bub//2PsH4VIZ+Dw5 hM5WDa1QbLsdEBO0W2xcmW3r2eHF+kt4Jg5n1K/JYvKdhApl/ML+dlNXTkvXHVLgUf/a E6efaCkXibc2aP4A13PCVd9AHZMlkSDTqM19Z83S/ksmNPfxPGI6pPznEP62cgcZNrC1 s+yg== X-Gm-Message-State: AE9vXwNE7XiZGln8XUwRTOR1qFyW6Zxomlz4g45erFVKHKRdUb+04yi3Qxfup0W4D/Gitw== X-Received: by 10.25.147.197 with SMTP id v188mr2150164lfd.9.1472235972913; Fri, 26 Aug 2016 11:26:12 -0700 (PDT) Received: from [192.168.100.6] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id g29sm4160435lji.45.2016.08.26.11.26.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Aug 2016 11:26:11 -0700 (PDT) Date: Fri, 26 Aug 2016 20:26:10 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: [PATCH] Add tests for dom.el To: larsi@gnus.org Message-Id: <1472235970.16843.0@smtp.gmail.com> X-Mailer: geary/0.11.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-hRRMDl+vnggg4+zLWihd" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-hRRMDl+vnggg4+zLWihd Content-Type: text/plain; charset=utf-8; format=flowed Hello, I saw that dom.el didn't have any tests, so I wrote some. Do they look okay to add? -- Simen --=-hRRMDl+vnggg4+zLWihd Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tests-for-dom.el.patch Content-Transfer-Encoding: quoted-printable >From c74c0fac972ce235954efc56ff540021f9dd0615 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Simen=3D20Heggest=3DC3=3DB8yl?=3D Date: Sun, 14 Aug 2016 16:03:50 +0200 Subject: [PATCH] Add tests for dom.el * test/lisp/dom-tests.el: New file with tests for dom.el. --- test/lisp/dom-tests.el | 195 +++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 195 insertions(+) create mode 100644 test/lisp/dom-tests.el diff --git a/test/lisp/dom-tests.el b/test/lisp/dom-tests.el new file mode 100644 index 0000000..e3e14b2 --- /dev/null +++ b/test/lisp/dom-tests.el @@ -0,0 +1,195 @@ +;;; dom-tests.el --- Tests for dom.el -*- lexical-binding: t; -*- + +;; Copyright (C) 2016 Free Software Foundation, Inc. + +;; Author: Simen Heggest=C3=B8yl +;; Keywords: + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; + +;;; Code: + +(require 'dom) +(require 'ert) +(require 'subr-x) + +(defun dom-test-tree () + "Return a DOM tree for testing." + (dom-node "html" nil + (dom-node "head" nil + (dom-node "title" nil + "Test")) + (dom-node "body" nil + (dom-node "div" '((class . "foo") + (style . "color: red;")) + (dom-node "p" '((id . "bar")) + "foo")) + (dom-node "div" '((title . "2nd div")) + "bar")))) + +(ert-deftest test-dom-tag () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag dom) "html")) + (should (equal (dom-tag (car (dom-children dom))) "head")))) + +(ert-deftest test-dom-attributes () + (let ((dom (dom-test-tree))) + (should (null (dom-attributes dom))) + (should (equal (dom-attributes (dom-by-class dom "foo")) + '((class . "foo") (style . "color: red;")))))) + +(ert-deftest test-dom-children () + (let ((dom (dom-test-tree))) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body"))) + (should (equal (dom-tag (dom-children (dom-children dom))) + "title")))) + +(ert-deftest test-dom-non-text-children () + (let ((dom (dom-test-tree))) + (should (equal (dom-children dom) (dom-non-text-children dom))) + (should (null (dom-non-text-children + (dom-children (dom-children dom))))))) + +(ert-deftest test-dom-set-attributes () + (let ((dom (dom-test-tree)) + (attributes '((xmlns "http://www.w3.org/1999/xhtml")))) + (should (null (dom-attributes dom))) + (dom-set-attributes dom attributes) + (should (equal (dom-attributes dom) attributes)))) + +(ert-deftest test-dom-set-attribute () + (let ((dom (dom-test-tree)) + (attr 'xmlns) + (value "http://www.w3.org/1999/xhtml")) + (should (null (dom-attributes dom))) + (dom-set-attribute dom attr value) + (should (equal (dom-attr dom attr) value)))) + +(ert-deftest test-dom-attr () + (let ((dom (dom-test-tree))) + (should (null (dom-attr dom 'id))) + (should (equal (dom-attr (dom-by-id dom "bar") 'id) "bar")))) + +(ert-deftest test-dom-text () + (let ((dom (dom-test-tree))) + (should (string-empty-p (dom-text dom))) + (should (equal (dom-text (dom-by-tag dom "title")) "Test")))) + +(ert-deftest test-dom-texts () + (let ((dom (dom-test-tree))) + (should (equal (dom-texts dom) "Test foo bar")) + (should (equal (dom-texts dom ", ") "Test, foo, bar")))) + +(ert-deftest test-dom-child-by-tag () + (let ((dom (dom-test-tree))) + (should (equal (dom-child-by-tag dom "head") + (car (dom-children dom)))) + (should (not (dom-child-by-tag dom "title"))))) + +(ert-deftest test-dom-by-tag () + (let ((dom (dom-test-tree))) + (should (=3D (length (dom-by-tag dom "div")) 2)) + (should (null (dom-by-tag dom "article"))))) + +(ert-deftest test-dom-strings () + (let ((dom (dom-test-tree))) + (should (equal (dom-strings dom) '("Test" "foo" "bar"))) + (should (equal (dom-strings (dom-children dom)) '("Test"))))) + +(ert-deftest test-dom-by-class () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag (dom-by-class dom "foo")) "div")) + (should (null (dom-by-class dom "bar"))))) + +(ert-deftest test-dom-by-style () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag (dom-by-style dom "color")) "div")) + (should (null (dom-by-style dom "width"))))) + +(ert-deftest test-dom-by-id () + (let ((dom (dom-test-tree))) + (should (equal (dom-tag (dom-by-id dom "bar")) "p")) + (should (null (dom-by-id dom "foo"))))) + +(ert-deftest test-dom-elements () + (let ((dom (dom-test-tree))) + (should (equal (dom-elements dom 'class "foo") + (dom-by-class dom "foo"))) + (should (equal (dom-attr (dom-elements dom 'title "2nd") 'title) + "2nd div")))) + +(ert-deftest test-dom-remove-node () + (let ((dom (dom-test-tree))) + (should (not (dom-remove-node dom dom))) + (should (=3D (length (dom-children dom)) 2)) + (dom-remove-node dom (car (dom-children dom))) + (should (=3D (length (dom-children dom)) 1)) + (dom-remove-node dom (car (dom-children dom))) + (should (null (dom-children dom))))) + +(ert-deftest test-dom-parent () + (let ((dom (dom-test-tree))) + (should (not (dom-parent dom dom))) + (should (equal (dom-parent dom (car (dom-children dom))) dom)))) + +(ert-deftest test-dom-previous-sibling () + (let ((dom (dom-test-tree))) + (should (not (dom-previous-sibling dom dom))) + (let ((children (dom-children dom))) + (should (equal (dom-previous-sibling dom (cadr children)) + (car children)))))) + +(ert-deftest test-dom-append-child () + (let ((dom (dom-test-tree))) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body"))) + (dom-append-child dom (dom-node "feet")) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body" "feet"))))) + +(ert-deftest test-dom-add-child-before () + (let ((dom (dom-test-tree))) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "body"))) + (dom-add-child-before dom (dom-node "neck") + (dom-child-by-tag dom "body")) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("head" "neck" "body"))) + (dom-add-child-before dom (dom-node "hat")) + (should (equal (mapcar #'dom-tag (dom-children dom)) + '("hat" "head" "neck" "body"))))) + +(ert-deftest test-dom-ensure-node () + (let ((node (dom-node "foo"))) + (should (equal (dom-ensure-node '("foo")) node)) + (should (equal (dom-ensure-node '(("foo"))) node)) + (should (equal (dom-ensure-node '("foo" nil)) node)) + (should (equal (dom-ensure-node '(("foo") nil)) node)))) + +(ert-deftest test-dom-pp () + (let ((node (dom-node "foo" nil ""))) + (with-temp-buffer + (dom-pp node) + (should (equal (buffer-string) "(\"foo\" nil\n \"\")"))) + (with-temp-buffer + (dom-pp node t) + (should (equal (buffer-string) "(\"foo\" nil)"))))) + +(provide 'dom-tests) +;;; dom-tests.el ends here --=20 2.9.3 = --=-hRRMDl+vnggg4+zLWihd-- ------------=_1472402342-31065-1-- From unknown Sun Jun 22 00:20:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24313: [PATCH] Add tests for dom.el Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2016 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: Lars Ingebrigtsen , Eli Zaretskii , 24313-done@debbugs.gnu.org Received: via spool by 24313-done@debbugs.gnu.org id=D24313.14724060964216 (code D ref 24313); Sun, 28 Aug 2016 17:42:02 +0000 Received: (at 24313-done) by debbugs.gnu.org; 28 Aug 2016 17:41:36 +0000 Received: from localhost ([127.0.0.1]:42997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be45Q-00015w-3n for submit@debbugs.gnu.org; Sun, 28 Aug 2016 13:41:36 -0400 Received: from mout.gmx.net ([212.227.15.19]:58996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be45N-00015i-Qj for 24313-done@debbugs.gnu.org; Sun, 28 Aug 2016 13:41:34 -0400 Received: from detlef.gmx.de ([87.146.62.18]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LmbVT-1b4BAT2bnX-00aEF3; Sun, 28 Aug 2016 19:41:26 +0200 From: Michael Albinus References: <1472235970.16843.0@smtp.gmail.com> <1472374727.3660.0@smtp.gmail.com> <1472402280.5159.0@smtp.gmail.com> Date: Sun, 28 Aug 2016 19:41:24 +0200 In-Reply-To: <1472402280.5159.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sun, 28 Aug 2016 18:38:00 +0200") Message-ID: <8737lox03f.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:bCiCH38Pfq422jqwEsmWYgpWAKx0/hRCidpehlKLMx8N9EbSEbP dBUT5CIX+1q7gsMndNjCnMaZOWdaYAGEJeQ4wnkNvmGozq4C/TH11LfCOZ1C0EzNXfkIlvF 0fCWNdTaXSC9gyreT4s076EpptOF1NK0n+Ll2lRmhOydSyg02TeOP99P0RFPJZdDn0vwMlS ChXHBnsFlyHbhEsW2Zj1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:ba+iZnCnBgQ=:h8h8PXLUkTHw2IuqCFZrIw JtIg66Z8gkVgKVoLWfEpfaZyF3I/6q2ZfQip6wf6C7jI+e8hObekDJ0ihJkpqxvdrqaEyyEt3 KnbcCjUj36/FW10rLT/CyzyxzkZ96Ccd89HrIWmPLjBOWHqxrtFjT/S1G67xjV/9jw8HROTAH IUeNzAJlDpEfxAvgD3d6Lf6INTvhS1hWBliLByfQv9v3nrvxyqnKuqHqO3PphyBLH1FSx+fxI W3TT9bq3qzVdxsOd0RjqfTXg7zaliTTa0tePnPobLcmDeq2eIw8+cNiKrNjLxaWcmFickPKsd M/Q7mmX7fTLoRIl4a55d5ZzfQQ/W42JAVVT4SsZU/BSfdiAaTk7hy4o2pe6q037SlaycBIfji XPdapBstv1TxD42/zT6tV4ysT6PoyxnTs/OGWXBAExJ/RTIz20JjBQFTpiI0HWWG14M5ZfzIL HsqET9bLTHqu3upM2VL9PKPO12C/E/6ghQ4+SIb/f2jPg2svc4Jj+AajcYXxY+93BieLvO3A2 JPnQoztTYz9Ots8DM5dbYBBgAsOjPRFgLYzR2yPXv8Y6Qt9xTPi2dEUKL/BXlNH6btb1EF91P SjV60wTkM4EM0ijg0cZBanWZk7f3w/Uf0hKZLuF7AwIZ9P3LqjwQL+CBhJyk7xTgQMXd7Hp1h DoSyGHDN4gyXEkSMJH2Y8+YbWjX/yOhQGhfSymAKio/XSZB7LoL7BzOUyGX4cQmleUSavQxVo 5ECVi5smMFA48oMebetGc2B8i4ekWhVmEE/cm0nsrbBDtUASQfgkPQDufVNQUptaIzDi0Q/fl wxjXphP X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Simen Heggest=C3=B8yl writes: > I've installed the tests with the changes you suggested last time. Thanks! > Thanks again for your time. > > -- Simen Best regards, Michael.