GNU bug report logs - #24308
25.1.50; Fix back-white <-> black-white typo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24308 in the body.
You can then email your comments to 24308 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 25.1.50; Fix back-white <-> black-white typo
Date: Thu, 25 Aug 2016 15:07:46 +0000

[Message part 1 (text/plain, inline)]

This bug affects printing post-scripts in black and white.

From the documentation of ps-default-fs and ps-default-bg, we get:

> This variable is used only when `ps-print-color-p' (which see) is neither
nil
> nor black-white.

That does not match with the code .. these values affect the postscript
export even when ps-print-color-p is set to 'black-white.

On reviewing the code, the bug was that black-white was written as
back-white (note the typo).

I'll attach the patch in a followup email.

In GNU Emacs 25.1.50.36 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
 of 2016-08-24
Repository revision: 70cfe9df957bd2f0699f62fe5e69176313f7c8f0
Windowing system distributor 'The X.Org Foundation', version 11.0.60900000
System Description: Red Hat Enterprise Linux Workstation release 6.6
(Santiago)


Configured using:
 'configure --with-modules
 --prefix=/home/kmodi/usr_local/apps/6/emacs/master
 'CPPFLAGS=-fgnu89-inline -I/home/kmodi/usr_local/6/include
 -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=-ggdb3 -O0'
 'CXXFLAGS=-ggdb3 -O0' 'LDFLAGS=-L/home/kmodi/usr_local/6/lib
 -L/home/kmodi/usr_local/6/lib64 -ggdb3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK2 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #8 received at 24308 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: 24308 <at> debbugs.gnu.org
Subject: 25.1.50; Fix back-white <-> black-white typo
Date: Thu, 25 Aug 2016 15:14:00 +0000

[Message part 1 (text/plain, inline)]

Patch to fix this bug:

Can you please commit this patch as I do not have commit rights. Thanks.

From f34a420b3b02eeaf816afb793875e2893fcf411c Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi <at> gmail.com>
Date: Thu, 25 Aug 2016 11:06:45 -0400
Subject: [PATCH] Fix back-white <-> black-white typo

* lisp/ps-print.el (ps-begin-job): back-white -> black-white (Bug#24308)
---
 lisp/ps-print.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/ps-print.el b/lisp/ps-print.el
index 2ea0919..54ffe28 100644
--- a/lisp/ps-print.el
+++ b/lisp/ps-print.el
@@ -5828,7 +5828,7 @@ ps-begin-job
  ps-default-background (ps-rgb-color
        (cond
  ((or (member ps-print-color-p
-     '(nil back-white))
+     '(nil black-white))
      (eq genfunc 'ps-generate-postscript))
  nil)
  ((eq ps-default-bg 'frame-parameter)
@@ -5842,7 +5842,7 @@ ps-begin-job
  ps-default-foreground (ps-rgb-color
        (cond
  ((or (member ps-print-color-p
-     '(nil back-white))
+     '(nil black-white))
      (eq genfunc 'ps-generate-postscript))
  nil)
  ((eq ps-default-fg 'frame-parameter)
@@ -5857,12 +5857,12 @@ ps-begin-job
        #'(lambda (arg)
    (ps-rgb-color arg "unspecified-fg" 0.0))
        (append (and (not (member ps-print-color-p
- '(nil back-white)))
+ '(nil black-white)))
     ps-fg-list)
        (list ps-default-foreground
      "black")))
  ps-default-color      (and (not (member ps-print-color-p
- '(nil back-white)))
+ '(nil black-white)))
    ps-default-foreground)
  ps-current-color      ps-default-color
  ;; Set up default functions.
-- 
2.9.2

-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #11 received at 24308 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 24308 <at> debbugs.gnu.org
Subject: Re: bug#24308: 25.1.50; Fix back-white <-> black-white typo
Date: Mon, 05 Sep 2016 19:22:29 -0400

Kaushal Modi <kaushal.modi <at> gmail.com> writes:

> Patch to fix this bug:
>
> Can you please commit this patch as I do not have commit
> rights. Thanks.

The patch doesn't apply, it seems to be missing indentation, can you
resend (maybe as attachment to avoid mangling)?

Message #14 received at 24308 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 24308 <at> debbugs.gnu.org
Subject: Re: bug#24308: 25.1.50; Fix back-white <-> black-white typo
Date: Tue, 06 Sep 2016 16:38:58 +0000

[Message part 1 (text/plain, inline)]

On Mon, Sep 5, 2016 at 7:22 PM <npostavs <at> users.sourceforge.net> wrote:

> Kaushal Modi <kaushal.modi <at> gmail.com> writes:
>
> The patch doesn't apply, it seems to be missing indentation, can you
> resend (maybe as attachment to avoid mangling)?
>

Thanks for the attempt to commit my patch. Can you please try the attached
version (It's the same as the one I had pasted inline earlier.).

I had ensured that I retained tabs and whitespaces as they were. That code
is a mess as it uses tabs on some lines and white spaces on some (the
yellows are the tabs in the below screenshot.. )

[image: pasted1]
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

[pasted1 (image/png, inline)]

[0001-Fix-back-white-black-white-typo.patch (application/octet-stream, attachment)]

Message #17 received at 24308 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 24308 <at> debbugs.gnu.org
Subject: Re: bug#24308: 25.1.50; Fix back-white <-> black-white typo
Date: Wed, 07 Sep 2016 19:27:26 -0400

tags 24308 fixed
close 24308 25.2
quit

Kaushal Modi <kaushal.modi <at> gmail.com> writes:

> On Mon, Sep 5, 2016 at 7:22 PM <npostavs <at> users.sourceforge.net> wrote:
>
> Thanks for the attempt to commit my patch. Can you please try the
> attached version (It's the same as the one I had pasted inline
> earlier.).

Thanks, push as 32078ec8

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.