From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 24 11:34:27 2016 Received: (at submit) by debbugs.gnu.org; 24 Aug 2016 15:34:27 +0000 Received: from localhost ([127.0.0.1]:39244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcaC7-0000Fx-Hf for submit@debbugs.gnu.org; Wed, 24 Aug 2016 11:34:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcYH1-0005VE-Gi for submit@debbugs.gnu.org; Wed, 24 Aug 2016 09:31:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcYGs-0008EZ-W6 for submit@debbugs.gnu.org; Wed, 24 Aug 2016 09:31:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcYGs-0008ET-Sl for submit@debbugs.gnu.org; Wed, 24 Aug 2016 09:31:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcYGn-0001tn-Tb for bug-diffutils@gnu.org; Wed, 24 Aug 2016 09:31:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcYGk-0008Ct-Lk for bug-diffutils@gnu.org; Wed, 24 Aug 2016 09:31:05 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:35804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcYGk-0008Ch-HM for bug-diffutils@gnu.org; Wed, 24 Aug 2016 09:31:02 -0400 Received: by mail-it0-f42.google.com with SMTP id x131so208798477ite.0 for ; Wed, 24 Aug 2016 06:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:subject:to:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=tjMbkwTaNKetUtbSvqZyewejaLgSH/dTANPLxoQ1FxQ=; b=ixvzAeOhMnIsFFHy0FIaqsoqL1xxhn0/MzrFCCCKyNTlJPVcoeRSq68h/8v5UtpWM3 v5KVmObAJunRmKrBcsG8/BbFZf3vvCKnp4chWIV9Au216gNSn1AliFuCpJp8aCDl7xIC DUjPmnL1mJ0t7YsbmP/Y4mHQOK8T60evx96Dwb8+nXJbOCEntZQtEoMEu3mwS8btCeng hoTK1t7eQXet3JlBVO5jGMW3gYu+r7V/lstItyds4QQEF9ryqu2jYcd2GJWDLn8jUfAv qV4x8yjNTH/ZTzfYoFiMrJMBmZ+u9YbTQHRfA7W2kCqkFh7iBQyv3pW2COq6WlHS1atK 3+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:subject:to:message-id:date :user-agent:mime-version:content-transfer-encoding; bh=tjMbkwTaNKetUtbSvqZyewejaLgSH/dTANPLxoQ1FxQ=; b=YjOKBNbriLUJjHP1EXMynMOsmcAjB0/Tt78dfqeKFGWTKmSHKdHnCyG/+JK05t/4ei bYTMcwdc4csHWewHsafQCCSwlP0bjgp9RZeu/N2iflIuh0tXkuilHZM2unFtgc8w30Zz g8U/+K5AVS9I3f3001b1N5hL2y1YVUDybaoIKkViP3QoEf/lVlYYcM27IE7luAeoJJfj i33I1Oy6luFpQ0Ivkp4NybjChX9AG+fZWvPAfhW5Gojt5HsvtBo2ligL0AzFISnIddEj 6QRJo51OV0eaoy7bEjlVS2iC0O1fRinx6wFi/rhGXriOvgPOFSg9LEMPJllobeziJA3m E/kA== X-Gm-Message-State: AE9vXwOZeJnK/Ka8g9sTD5I4YxzcIFTB0POt0BdwmHTB4tKqMFgF1igGfKR13NAbyei1NQ== X-Received: by 10.107.147.138 with SMTP id v132mr4136136iod.27.1472045401423; Wed, 24 Aug 2016 06:30:01 -0700 (PDT) Received: from [192.168.0.101] (173-19-206-191.client.mchsi.com. [173.19.206.191]) by smtp.gmail.com with ESMTPSA id e196sm3408846ioe.3.2016.08.24.06.29.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Aug 2016 06:30:00 -0700 (PDT) From: "John E. Malmberg" Subject: intprops.h GL_INT_OP_WRAPV_LONGISH one too many ")" To: bug-diffutils@gnu.org Message-ID: <9ee68848-bbaf-ce41-697f-ac72b210f46f@qsl.net> Date: Wed, 24 Aug 2016 08:30:24 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 24 Aug 2016 11:34:23 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Greetings, While building diffutils 3.5 on OpenVMS/IA64 8.4, I discovered: I1 5525 # define _GL_INT_OP_WRAPV_LONGISH(a, b, r, op, overflow) \ I1 5526 _GL_INT_OP_CALC (a, b, r, op, overflow, unsigned long int, \ I1 5527 long int, LONG_MIN, LONG_MAX)) This was tripped because the VMS limits.h file does not define LLONG_MIN and LLONG_MAX. I am currently working around this issue by adding: #define LLONG_MAX __INT64_MAX #define LLONG_MIN __INT64_MIN To a pre-include header file on the modules, which works for the OpenVMS Alpha and IA64 builds. Regards, -John From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 24 23:53:39 2016 Received: (at 24300-done) by debbugs.gnu.org; 25 Aug 2016 03:53:39 +0000 Received: from localhost ([127.0.0.1]:39664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcljX-00047R-A4 for submit@debbugs.gnu.org; Wed, 24 Aug 2016 23:53:39 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcljV-00047E-Pe for 24300-done@debbugs.gnu.org; Wed, 24 Aug 2016 23:53:38 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 331F7160972; Wed, 24 Aug 2016 20:53:30 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cF6OM1F4BBOH; Wed, 24 Aug 2016 20:53:29 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2D9BA161128; Wed, 24 Aug 2016 20:53:29 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KbbC5FXv0Dih; Wed, 24 Aug 2016 20:53:29 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0BFD9160972; Wed, 24 Aug 2016 20:53:29 -0700 (PDT) Subject: Re: [bug-diffutils] bug#24300: intprops.h GL_INT_OP_WRAPV_LONGISH one too many ")" To: "John E. Malmberg" , 24300-done@debbugs.gnu.org References: <9ee68848-bbaf-ce41-697f-ac72b210f46f@qsl.net> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <0db84dcb-570e-ba4c-8e5a-54f9a1ebfdcd@cs.ucla.edu> Date: Wed, 24 Aug 2016 20:53:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <9ee68848-bbaf-ce41-697f-ac72b210f46f@qsl.net> Content-Type: multipart/mixed; boundary="------------C4543FCF350F14115A87FEA7" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24300-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) This is a multi-part message in MIME format. --------------C4543FCF350F14115A87FEA7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable John E. Malmberg wrote: > I am currently working around this issue by adding: > > #define LLONG_MAX __INT64_MAX > #define LLONG_MIN __INT64_MIN Thanks, I installed into Gnulib the attached patch, which should be equiv= alent. --------------C4543FCF350F14115A87FEA7 Content-Type: text/x-diff; name="0001-intprops-port-to-OpenVMS.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-intprops-port-to-OpenVMS.patch" =46rom 336a88239dbe436105d1c182e4ecb4495a4a6f83 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 24 Aug 2016 20:48:32 -0700 Subject: [PATCH] intprops: port to OpenVMS Problem reported by John E. Malmberg in: https://bugs.gnu.org/24300 * doc/posix-headers/limits.texi: Document the problem. * lib/intprops.h (LLONG_MAX, LLONG_MIN) [__INT64_MAX]: Define if not already defined. --- ChangeLog | 8 ++++++++ doc/posix-headers/limits.texi | 2 +- lib/intprops.h | 6 ++++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e842a33..7cfd244 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2016-08-24 Paul Eggert + + intprops: port to OpenVMS + Problem reported by John E. Malmberg in: https://bugs.gnu.org/24300 + * doc/posix-headers/limits.texi: Document the problem. + * lib/intprops.h (LLONG_MAX, LLONG_MIN) [__INT64_MAX]: + Define if not already defined. + 2016-08-19 Assaf Gordon =20 parse-datetime: improve debug implementation diff --git a/doc/posix-headers/limits.texi b/doc/posix-headers/limits.tex= i index 9f4ffa5..31207ac 100644 --- a/doc/posix-headers/limits.texi +++ b/doc/posix-headers/limits.texi @@ -18,7 +18,7 @@ Portability problems not fixed by Gnulib: @item The macros @code{LLONG_MIN}, @code{LLONG_MAX}, @code{ULLONG_MAX} are not= defined on some platforms: -AIX 5.1, HP-UX 11, IRIX 6.5, OSF/1 5.1 with gcc. +AIX 5.1, HP-UX 11, IRIX 6.5, OpenVMS, OSF/1 5.1 with gcc. @item The macros @code{WORD_BIT}, @code{LONG_BIT} are not defined on some plat= forms: glibc 2.11 without @code{-D_GNU_SOURCE}, Cygwin, mingw, MSVC 9. diff --git a/lib/intprops.h b/lib/intprops.h index feb02c3..fe6c789 100644 --- a/lib/intprops.h +++ b/lib/intprops.h @@ -67,6 +67,12 @@ #define _GL_SIGNED_INT_MAXIMUM(e) = \ (((_GL_INT_CONVERT (e, 1) << (sizeof ((e) + 0) * CHAR_BIT - 2)) - 1) *= 2 + 1) =20 +/* Work around OpenVMS incompatibility with C99. */ +#if !defined LLONG_MAX && defined __INT64_MAX +# define LLONG_MAX __INT64_MAX +# define LLONG_MIN __INT64_MIN +#endif + /* This include file assumes that signed types are two's complement with= out padding bits; the above macros have undefined behavior otherwise. If this is a problem for you, please let us know how to fix it for yo= ur host. --=20 2.7.4 --------------C4543FCF350F14115A87FEA7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 01:08:29 2016 Received: (at 24300) by debbugs.gnu.org; 25 Aug 2016 05:08:29 +0000 Received: from localhost ([127.0.0.1]:39847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcmtx-0000pN-1G for submit@debbugs.gnu.org; Thu, 25 Aug 2016 01:08:29 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:37857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcmtv-0000pC-IK for 24300@debbugs.gnu.org; Thu, 25 Aug 2016 01:08:27 -0400 Received: by mail-it0-f49.google.com with SMTP id f6so72385994ith.0 for <24300@debbugs.gnu.org>; Wed, 24 Aug 2016 22:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=aFYbVGiy6UT8/TlYMqJOsT89mwOK9+PrO3/qpoNP3KU=; b=x75cUMXXrXk5qwtjKVTQiLj6iZjqBnNWIILs7GVpQNmphj3kwtYu1VSpx4x4frDSAa 8SyayyxbSVwN1d1/zV3/ppZLMqCgnNP5xyjhDU9qgEi+HTPmvIhRcyIh9T4AYbUnyZ8k bUTMfAi0FnOeYsO3vqr692On2IyDazXt8Mmxbt6FAvYJNMKDga65XQNtKv9Xh4zVYKG+ yfsweagfu67Mz/6Wj+AIuEIRc85hs9jbNvnjKTA89rEWIoDiG3MTr1mMAK9LxeNUByXX FUEZTOM1UKvwRgY+DEKEULrHkaho5eJcNc49Yg8UPN8xsJUrwN8yT0GvSwZF8FDiL4yO XWaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-transfer-encoding; bh=aFYbVGiy6UT8/TlYMqJOsT89mwOK9+PrO3/qpoNP3KU=; b=jxh1hlkB0zqnwciVA6bq7ZuyC/649tGor6NdDNgRY/BwB0SxRidajaHBgVOXaSESvm rghr/icRp8OrunpgOqVimMd/G1TDtEfyBd1KHkUvQ9pgu81JSZGvZBhJvJdxre41inZI tebCdl9kjPgWRaNHJi/6tMvFkIfmZOTqJnDzGcHUd3XDQ6g+0kTkKDOrzPfVnHfyBgZ/ 5FQf07bDe1HOUDDyrS+hY1ahItHXkfpiEtWedzwa8QSxls3O9aTRcoYH6EICYRc7tVlD SUIwcOkjHfpNa9xY5EooeKe6hbEOm0f16FmyRp9QXJVilC/0f7N/RRbLOcB7ZYWr/g56 Ui5Q== X-Gm-Message-State: AEkoouvSnzChmV22Yi/9XzReNGZWZExstloRRS/x83I2HZ3WVtaKhfF684Y/BSzDHVF+Sw== X-Received: by 10.36.85.195 with SMTP id e186mr2992459itb.56.1472101701721; Wed, 24 Aug 2016 22:08:21 -0700 (PDT) Received: from [192.168.0.101] (173-19-206-191.client.mchsi.com. [173.19.206.191]) by smtp.gmail.com with ESMTPSA id g2sm4867409ith.8.2016.08.24.22.08.20 for <24300@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Aug 2016 22:08:20 -0700 (PDT) To: 24300@debbugs.gnu.org From: "John E. Malmberg" Subject: intprops.h - _GL_INT_OPT_WRAPV_LONGISH (xxx)) Message-ID: <606e4783-7b52-e632-378e-e8122f826f84@qsl.net> Date: Thu, 25 Aug 2016 00:08:46 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24300 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) The macro _GL_INT_OPT_WRAPV_LONGISH has one more right parenthesis on it than left parenthesis. This causes compiles to fail on platforms with out a long long type. I do not see that fixed in the patch for this bug. Regards, -John From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 01:29:48 2016 Received: (at 24300) by debbugs.gnu.org; 25 Aug 2016 05:29:48 +0000 Received: from localhost ([127.0.0.1]:39872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcnEa-0001Lg-Fk for submit@debbugs.gnu.org; Thu, 25 Aug 2016 01:29:48 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcnEX-0001LQ-U0 for 24300@debbugs.gnu.org; Thu, 25 Aug 2016 01:29:46 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C64C2161118; Wed, 24 Aug 2016 22:29:39 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QtmPhGRzWtOc; Wed, 24 Aug 2016 22:29:37 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AF9B6160E3D; Wed, 24 Aug 2016 22:29:37 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3BM0VKHLmW68; Wed, 24 Aug 2016 22:29:37 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8F9FC160972; Wed, 24 Aug 2016 22:29:37 -0700 (PDT) Subject: Re: [bug-diffutils] bug#24300: intprops.h - _GL_INT_OPT_WRAPV_LONGISH (xxx)) To: "John E. Malmberg" , 24300@debbugs.gnu.org References: <9ee68848-bbaf-ce41-697f-ac72b210f46f@qsl.net> <606e4783-7b52-e632-378e-e8122f826f84@qsl.net> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <026b16eb-2a03-9828-5e15-768abd4dce32@cs.ucla.edu> Date: Wed, 24 Aug 2016 22:29:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <606e4783-7b52-e632-378e-e8122f826f84@qsl.net> Content-Type: multipart/mixed; boundary="------------841B3362796EAE3E1DE39D92" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24300 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) This is a multi-part message in MIME format. --------------841B3362796EAE3E1DE39D92 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit John E. Malmberg wrote: > The macro _GL_INT_OPT_WRAPV_LONGISH has one more right parenthesis on it than > left parenthesis. Ah, sorry, that wasn't obvious in the original bug report. I installed the attached further patch. Apparently this part of the code has never been exercised on any platform before (which means you get to be the brave adventurer :-). It's not often we run into a platform lacking decent 'long long' support these days. --------------841B3362796EAE3E1DE39D92 Content-Type: text/x-diff; name="0001-intprops-fix-paren-typo-on-old-platforms.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-intprops-fix-paren-typo-on-old-platforms.patch" >From 6bd4be58b307b44db2ebc46e9b01c10f65eb83e7 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 24 Aug 2016 22:24:48 -0700 Subject: [PATCH] intprops: fix paren typo on old platforms Problem reported by John E. Malmberg in: https://bugs.gnu.org/24300#13 * lib/intprops.h (_GL_INT_OP_WRAPV_LONGISH) [__GNUC__ < 5 && !__has_builtin (__builtin_add_overflow) && (__STDC_VERSION__ < 201112 || _GL__GENERIC_BOGUS) && !defined LLONG_MAX]: Remove stray paren. --- ChangeLog | 8 ++++++++ lib/intprops.h | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 7cfd244..4a2e641 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2016-08-24 Paul Eggert + intprops: fix paren typo on old platforms + Problem reported by John E. Malmberg in: https://bugs.gnu.org/24300#13 + * lib/intprops.h (_GL_INT_OP_WRAPV_LONGISH) + [__GNUC__ < 5 && !__has_builtin (__builtin_add_overflow) + && (__STDC_VERSION__ < 201112 || _GL__GENERIC_BOGUS) + && !defined LLONG_MAX]: + Remove stray paren. + intprops: port to OpenVMS Problem reported by John E. Malmberg in: https://bugs.gnu.org/24300 * doc/posix-headers/limits.texi: Document the problem. diff --git a/lib/intprops.h b/lib/intprops.h index fe6c789..6030760 100644 --- a/lib/intprops.h +++ b/lib/intprops.h @@ -418,7 +418,7 @@ verify (TYPE_MAXIMUM (long long int) == LLONG_MAX); # else # define _GL_INT_OP_WRAPV_LONGISH(a, b, r, op, overflow) \ _GL_INT_OP_CALC (a, b, r, op, overflow, unsigned long int, \ - long int, LONG_MIN, LONG_MAX)) + long int, LONG_MIN, LONG_MAX) # endif #endif -- 2.7.4 --------------841B3362796EAE3E1DE39D92-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 09:06:32 2016 Received: (at 24300) by debbugs.gnu.org; 25 Aug 2016 13:06:32 +0000 Received: from localhost ([127.0.0.1]:40089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcuMZ-0007Kz-RK for submit@debbugs.gnu.org; Thu, 25 Aug 2016 09:06:32 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:37301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcuMY-0007Km-8P for 24300@debbugs.gnu.org; Thu, 25 Aug 2016 09:06:30 -0400 Received: by mail-it0-f54.google.com with SMTP id f6so88362724ith.0 for <24300@debbugs.gnu.org>; Thu, 25 Aug 2016 06:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=uU3hDd+EmSmCS54auwspN9W1CYssOfJFkpv/t2M1eRw=; b=sdusBHvGhR0E1FGRSQwurZckx/qrBA1uaQyalFHVgXCMl2sw48A4utA9WGxG+eaK1C vIAoIkcEFl51v68GXa2AWI2G47Qx6rLfeEWYLRNsxQxTmhvj+TXp2U8nAC4L9p/6LlA+ eB4HZyJ5HIc7uQSMEQfjMpkq/A63lkvPcZPeYye+XgbfXiGikFKAxSNDIKb4TCuGAtQW TPH0LlbNsmQsA4dbccFYPYAMjAh5pLePPL5uJUmeKuK/dd1MOkZbSSgb3NF/PWf1sypW VPbLhpc82evvOeaP/YA856Q2YpP6m6/gFTrAMKZPtUBIPdwGWKWBCGxgkmrAxSJtj5+9 YE0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-transfer-encoding; bh=uU3hDd+EmSmCS54auwspN9W1CYssOfJFkpv/t2M1eRw=; b=SU7x8Yxn6pSw7Nym92+/DMUvHxLXKno0tL09AWHsc3eqWMsLT4jVSMtwcVXmOsPI5G PQYQijTtCcL4/Qe8u7or339DkMgvOALz6gn2l1eHPq056AA2s8RFKLaUc+R1M2OnVW8L w4S9B6m29gejiOY30DlCUosMipGUt5KX1vzEH92XO72r9jFauhOvk6wUk6LvoKOmiaZJ o+BLaLljfcgYqII4cFBHPsbDFwRHZWRmezr/RbHzP0AX5Bj7zlOOmv8IE3WW/VEK1jo/ NFmzXbk87pyLJeZ4TJc41V1XQnDpZgXSDM2DbNcHP+Bc1lkzYh77WAdaxepp4e3gjjQA zt5A== X-Gm-Message-State: AEkoousmen9IWLoN/YUqOqJ/r4RT+jMuuWeyewJCUYndKRsVxannl25rvha9/VUhAeZ8lA== X-Received: by 10.107.12.34 with SMTP id w34mr11521060ioi.171.1472130384054; Thu, 25 Aug 2016 06:06:24 -0700 (PDT) Received: from [192.168.0.101] (173-19-206-191.client.mchsi.com. [173.19.206.191]) by smtp.gmail.com with ESMTPSA id j16sm5446162iod.25.2016.08.25.06.06.22 for <24300@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Aug 2016 06:06:22 -0700 (PDT) To: 24300@debbugs.gnu.org From: "John E. Malmberg" Subject: intprops.h - _GL_INT_OPT_WRAPV_LONGISH (xxx)) Message-ID: <816cb6e6-d8d7-316d-0329-93e6745392b9@qsl.net> Date: Thu, 25 Aug 2016 08:06:48 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24300 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Apparently this part of the code has never been exercised on any > platform before (which means you get to be the brave adventurer . > It's not often we run into a platform lacking decent 'long long' > support these days. FYI: The port I am working on is in a Mecurial repository at: https://sourceforge.net/p/gnv/diff_utils/ci/default/tree/ It is not related to the Steven Schweda port. It is organized with the unmodified upstream code in one directory tree branch and the OpenVMS specific files in another directory tree. The OpenVMS build procedure overlays the the two directory. In theory, I can change the overlay setup to build against a checkout of a beta release or even master. (OpenVMS can not yet run autotools) This will end up as part of the updated GNV project https://sourceforge.net/projects/gnv/ Building diffutils on OpenVMS for use with GNV was done with the following minimum software versions * HP C 7.x * GNV AR_TOOLS 3.0.2 * GNV Bash 4.3.42 * GNV Coreutils 8.24 * GNV Grep 4.1.3 * GNV LD_TOOLS 3.0.4 * GNV MAKE 3.78.1 - Special Fork, GNU make will not work for this. * GNV SED V4.2.2 ZIP 3.0 available by foreign command. PASS: basic PASS: bignum PASS: binary brief-vs-stat-zero-kernel-lies: skipped test: no /proc/cmdline file SKIP: brief-vs-stat-zero-kernel-lies PASS: colliding-file-names diff3: set-up failure: ERROR: diff3 PASS: excess-slash SKIP: help-version PASS: function-line-vs-leading-space PASS: ignore-matching-lines PASS: label-vs-func FAIL: new-file PASS: no-dereference FAIL: no-newline-at-eof PASS: stdin PASS: strcoll-0-names FAIL: filename-quoting FAIL: colors ============================================================================ Testsuite summary for GNU diffutils 3.5 ============================================================================ # TOTAL: 18 # PASS: 11 # SKIP: 2 # XFAIL: 0 # FAIL: 4 # XPASS: 0 # ERROR: 1 I am still investigating the diff3 test failure, and need to implement a replacement popen() routine on VMS before I can release a fully functional binary kit. The launched editor portion will not be implemented as none of the native interactive OpenVMS editors will run with stdin/stdout not being a terminal device. The rest of the failures/skips appear to be from differences in how OpenVMS works from what the shell scripts expect. No /proc, No /dev except for /dev/null, no mkfifo, etc. Regards, -John From unknown Sun Jun 15 08:53:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 Sep 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator