From unknown Sat Aug 09 15:57:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#2428 <2428@debbugs.gnu.org> To: bug#2428 <2428@debbugs.gnu.org> Subject: Status: 23.0.90; sendmail-send-it not checking for call-process-region's return value properly Reply-To: bug#2428 <2428@debbugs.gnu.org> Date: Sat, 09 Aug 2025 22:57:02 +0000 retitle 2428 23.0.90; sendmail-send-it not checking for call-process-region= 's return value properly reassign 2428 emacs submitter 2428 tcr@freebits.de severity 2428 normal tag 2428 patch thanks From tcr@freebits.de Sat Feb 21 14:46:01 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Feb 2009 22:46:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1LMjuOM017831 for ; Sat, 21 Feb 2009 14:45:59 -0800 Received: from mail.gnu.org ([199.232.76.166]:58595 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Lb0ZV-0003Kc-7q for emacs-pretest-bug@gnu.org; Sat, 21 Feb 2009 17:43:45 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Lb0bX-0003ks-JH for emacs-pretest-bug@gnu.org; Sat, 21 Feb 2009 17:45:53 -0500 Received: from a022.reverse.yawsp.de ([62.27.20.22]:37802 helo=freebits.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lb0bX-0003jE-3B for emacs-pretest-bug@gnu.org; Sat, 21 Feb 2009 17:45:51 -0500 Received: from host145.natpool.mwn.de ([138.246.7.145] helo=thaleron) by freebits.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Lb0bC-00048U-6c for emacs-pretest-bug@gnu.org; Sat, 21 Feb 2009 22:45:30 +0000 Date: Sat, 21 Feb 2009 23:45:02 +0100 Message-Id: <87wsbjs93l.fsf@freebits.de> To: emacs-pretest-bug@gnu.org Subject: 23.0.90; sendmail-send-it not checking for call-process-region's return value properly MIME-Version: 1.0 X-freebits.de-MailScanner-Information: http://freebits.de X-freebits.de-MailScanner: Sauber X-freebits.de-MailScanner-SpamCheck: not spam, SpamAssassin (notcached, Wertung=1.897, benoetigt 6, FROM_NO_LOWER 1.90) X-freebits.de-MailScanner-SpamScore: s X-MailScanner-From: tcr@freebits.de X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) From: tcr@freebits.de `sendmail-send-it' invokes `call-process-region' but doesn't check for the case when the latter returns a string to indicate an error value. This results in a backtrace like Debugger entered--Lisp error: (error "Format specifier doesn't match argument type") format("Sending...failed with exit value %d" "Broken pipe") apply(format ("Sending...failed with exit value %d" "Broken pipe")) error("Sending...failed with exit value %d" "Broken pipe") sendmail-send-it() mail-send() mail-send-and-exit(nil) call-interactively(mail-send-and-exit nil nil) The following patch fixes that --- lisp/mail/sendmail.el 2009-02-07 04:02:39.000000000 +0100 +++ lisp/mail/sendmail.el-hacked 2009-02-21 23:37:44.000000000 +0100 @@ -1168,8 +1168,13 @@ ) ) (exit-value (apply 'call-process-region args))) - (or (null exit-value) (eq 0 exit-value) - (error "Sending...failed with exit value %d" exit-value))) + (cond ((or (null exit-value) (eq 0 exit-value))) + ((numberp exit-value) + (error "Sending...failed with exit value %d" exit-value)) + ((stringp exit-value) + (error "Sending...terminated by signal: %s" exit-value)) + (t + (error "SENDMAIL-SEND-IT -- fall through: %S" exit-value)))) (or fcc-was-found (error "No recipients"))) (if mail-interactive In GNU Emacs 23.0.90.4 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2009-02-21 on thaleron Windowing system distributor `The X.Org Foundation', version 11.0.10400090 configured using `configure '--prefix=/home/tcr/software/emacs-cvs' '--with-x-toolkit=gtk' '--without-gpm' '--with-x' '--without-xpm' '--enable-asserts' 'CFLAGS=-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: gnus-topic-mode: t gnus-undo-mode: t diff-auto-refine-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: L S-SPC T R H O U G H . M-l M-l r : SPC % S SPC e x i t - v a l u e u C-M-k ( o r C-) C-M-f SPC C-y C-a C-k C-k C-x C-s C-M-x C-x b C-g C-x C-b C-x o q C-x o M-x r e p o r t - e m f o o y C-k t c r @ f r e e b i t s . d e C-c C-c y e s C-x C-s M-x g n u s y C-x C-f M-x M-x r e p o r t - e m a c s - b u g s b F o o y C-k t c r @ f r e e b i t s d e . d e C-c C-c y e s C-a C-SPC M-> C-w C-y C-x b M-x r e p r o r t Recent messages: gnus-all-windows-visible-p: Invalid buffer type: if Auto-saving... ffap-read-file-or-url: Command attempted to use minibuffer while in minibuffer Unsent message being composed; erase it? (y or n) Auto save file for draft message exists; consider M-x mail-recover Sending... smtpmail-open-stream: Autoloading failed to define function starttls-any-program-available Auto-saving...done Mark set [2 times] Auto-saving... -- Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht und ist - aktuelle Virenscanner vorausgesetzt - sauber. Freebits E-Mail Virus Scanner From lekktu@gmail.com Sat Feb 21 18:15:20 2009 Received: (at control) by emacsbugs.donarmstrong.com; 22 Feb 2009 02:15:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1M2FHwQ006897 for ; Sat, 21 Feb 2009 18:15:19 -0800 Received: by ey-out-2122.google.com with SMTP id 25so246244eya.13 for ; Sat, 21 Feb 2009 18:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=cGuer3VzInLnTmMTnTuPsv6jK5us16XFl9ZQIzr2bTY=; b=IenSuDQ3ZntHqIzrhzDS/PP/WTURc2kh5sWorcbv6OcliWLDIF/27YW7KBG99bXkcX JHGc8/Hyu2qmJ58hEpu/8OWN8n0vTJknrvOQAcycRU1g6OLENM5/6IHkDPbzziP/Xd4d 23sFs1kwYj9LOXTNgNe5RqBepOsZvKNiK90AQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=i/R72dOLREIg3zTaneear7/GGRgMQTwabPwG4dq9vSRWjOTXhknBciuH4zzlPLhnrb 9woKhNaIUqqihl36RY0dXb/FjmtFMdWiW1638m5/+FIN3RFJwMIpaWTP/rdF3Mtsj1js kBinQ4sWwtC2KQ0ZfDAp1n/qAdKL7adY/WQV8= MIME-Version: 1.0 Received: by 10.210.70.14 with SMTP id s14mr2094542eba.86.1235268917006; Sat, 21 Feb 2009 18:15:17 -0800 (PST) Date: Sun, 22 Feb 2009 03:15:16 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit tags 2428 + patch reassign 2427 spam quit From rgm@gnu.org Tue Feb 24 20:02:22 2009 Received: (at 2428) by emacsbugs.donarmstrong.com; 25 Feb 2009 04:02:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1P42JVC025997 for <2428@emacsbugs.donarmstrong.com>; Tue, 24 Feb 2009 20:02:21 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LcAwD-0001gD-Vj; Tue, 24 Feb 2009 23:00:01 -0500 From: Glenn Morris To: tcr@freebits.de Cc: 2428@debbugs.gnu.org Subject: Re: bug#2428: 23.0.90; sendmail-send-it not checking for call-process-region's return value properly References: <87wsbjs93l.fsf@freebits.de> X-Spook: data haven NSA S Key ISEC Ermes Soviet Uzbekistan KGB X-Ran: 6gQ%zsGpVONTc,bilKV(-ZcjC-_RFg#"%0{,2\20`H}eYM~L{^r"Qz&9H(\j;rg?{\gt={ X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 24 Feb 2009 23:00:01 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii tcr@freebits.de wrote: > The following patch fixes that OK. Do you have a name for the ChangeLog entry? From tcr@freebits.de Wed Feb 25 03:09:38 2009 Received: (at 2428) by emacsbugs.donarmstrong.com; 25 Feb 2009 11:09:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from freebits.de (a022.reverse.yawsp.de [62.27.20.22]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PB9YgP003392 for <2428@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 03:09:36 -0800 Received: from host145.natpool.mwn.de ([138.246.7.145] helo=thaleron) by freebits.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44) id 1LcHdm-0004HF-LT; Wed, 25 Feb 2009 11:09:26 +0000 From: "Tobias C. Rittweiler" To: Glenn Morris Cc: 2428@debbugs.gnu.org Subject: Re: bug#2428: 23.0.90; sendmail-send-it not checking for call-process-region's return value properly References: <87wsbjs93l.fsf@freebits.de> Date: Wed, 25 Feb 2009 12:08:57 +0100 In-Reply-To: (Glenn Morris's message of "Tue, 24 Feb 2009 23:00:01 -0500") Message-ID: <87r61mzsc6.fsf@freebits.de> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-freebits.de-MailScanner-Information: http://freebits.de X-freebits.de-MailScanner: Sauber X-freebits.de-MailScanner-SpamCheck: not spam, SpamAssassin (notcached, Wertung=0, benoetigt 6, autolearn=not spam) X-MailScanner-From: tcr@freebits.de Glenn Morris writes: > tcr@freebits.de wrote: > >> The following patch fixes that > > OK. Do you have a name for the ChangeLog entry? Tobias C. Rittweiler. -- Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht und ist - aktuelle Virenscanner vorausgesetzt - sauber. Freebits E-Mail Virus Scanner From rgm@gnu.org Wed Feb 25 19:55:12 2009 Received: (at 2428-done) by emacsbugs.donarmstrong.com; 26 Feb 2009 03:55:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1Q3t8FB008266 for <2428-done@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 19:55:09 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LcXIo-0006rk-Nr; Wed, 25 Feb 2009 22:52:50 -0500 From: Glenn Morris To: 2428-done@debbugs.gnu.org Subject: Re: bug#2428: 23.0.90; sendmail-send-it not checking for call-process-region's return value properly References: <87wsbjs93l.fsf@freebits.de> <87r61mzsc6.fsf@freebits.de> X-Spook: South Africa digicash embassy Abbas lock picking Armani X-Ran: x?2?'Fjogq+" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thank you; installed. From unknown Sat Aug 09 15:57:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 26 Mar 2009 14:24:13 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator