From unknown Sat Aug 16 16:22:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24248: [patch] avoid duplicate definition of global variable presume_output_tty Resent-From: Hanno =?UTF-8?Q?B=C3=B6ck?= Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Wed, 17 Aug 2016 01:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24248 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: 24248@debbugs.gnu.org X-Debbugs-Original-To: bug-diffutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14713966965292 (code B ref -1); Wed, 17 Aug 2016 01:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Aug 2016 01:18:16 +0000 Received: from localhost ([127.0.0.1]:59596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpUm-0001NH-IG for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpUk-0001N4-CR for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZpUZ-0002Pa-FL for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpUZ-0002PW-CJ for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpUX-0003aj-4Y for bug-diffutils@gnu.org; Tue, 16 Aug 2016 21:18:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZpUS-0002PB-1t for bug-diffutils@gnu.org; Tue, 16 Aug 2016 21:18:00 -0400 Received: from zucker2.schokokeks.org ([178.63.68.90]:46534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpUR-0002P7-Ry for bug-diffutils@gnu.org; Tue, 16 Aug 2016 21:17:55 -0400 Received: from pc1 (p2003006A623D9D00B82D8DCF02FEDD63.dip0.t-ipconnect.de [2003:6a:623d:9d00:b82d:8dcf:2fe:dd63]) (AUTH: LOGIN hanno-default@schokokeks.org, TLS: TLSv1/SSLv3, 256bits, ECDHE-RSA-AES256-GCM-SHA384) by zucker.schokokeks.org with ESMTPSA; Wed, 17 Aug 2016 03:17:54 +0200 id 0000000000000012.0000000057B3BB43.00003F37 Date: Wed, 17 Aug 2016 03:17:52 +0200 From: Hanno =?UTF-8?Q?B=C3=B6ck?= Message-ID: <20160817031752.72abbf42@pc1> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-16186-1471396676-0001-2" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_zucker.schokokeks.org-16186-1471396676-0001-2 Content-Type: multipart/mixed; boundary="MP_/61uK5A+.p7C+3QnM+xDp.Th" --MP_/61uK5A+.p7C+3QnM+xDp.Th Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, The variable presume_output_tty is defined both in the diff.h header and the file util.c (which includes diff.h). The diff.h file makes sure that the variable is declared as external except when it's included by the main program diff.c. But as it's also declared in util.c we end up having two non-external declarations of it. Traditionally gcc has allowed this behavior, which is probably the reason it has not been spottet before, but it's not correct C. One can get a more strict behavior here by passing -fno-common to the CFLAGS and LDFLAGS and then linking will fail. The solution is simple: Remove the superfluous declaration in util.c, see attached patch. Please apply. --=20 Hanno B=C3=B6ck https://hboeck.de/ mail/jabber: hanno@hboeck.de GPG: FE73757FA60E4E21B937579FA5880072BBB51E42 --MP_/61uK5A+.p7C+3QnM+xDp.Th Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=diffutils-duplicate-definition-presume_output_tty.patch diff --git a/src/util.c b/src/util.c index d7b8925..76872cb 100644 --- a/src/util.c +++ b/src/util.c @@ -44,8 +44,6 @@ =20 char const pr_program[] =3D PR_PROGRAM; =20 -bool presume_output_tty; - /* Queue up one-line messages to be printed at the end, when -l is specified. Each message is recorded with a 'struct msg'. */ =20 --MP_/61uK5A+.p7C+3QnM+xDp.Th-- --=_zucker.schokokeks.org-16186-1471396676-0001-2 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXs7tBAAoJEKWIAHK7tR5CDPsQAK1CMLts9gDfF5LXOt1pEW6J 7BMBV+BEuX1ftB4TZqGeXTnJ3D56xzMLQRgs96GdW3M2ivWCQmQ+7NLH9hqP8AuW NvcRcsK90UEHSHxwfL3TSCw/et3vIeiwS9sRh1vAeZbViMz/PFGi0nFAnJy9PL/x 1s/OCfg2cWIqx7FctoV/Tx8G6FhNFoN6Tj8s5vbR4l4y2dxQ1GpCmZheoeG93Z4v wqcLQ4K5JqF2Uco4aABZLesytSWQSdwOSUxpFHZkD+k6uqTS+hwWfaRTDwdjO+Gr /sHeueBgS1FEXg++hqlpFRVBxCvHnQiO3yqzOgmmkpyhklKYQa6LyN2u7pO6lcsK rv1q8cLdy10slw6tu7IZu8oXVu7UuwWQpxuFan5A85XIJ5s5tLLstYvmcidXF5pk 5CgujSLwDidQY1E8uXnbm5yamTwLYK6nFHFxe4eOlckaqcil9i8A1K25aXkvyxtH YgMvJpI3sgEgxnQrGd3QlOy7dcV2Y4yWcYOQij7ieVzrc6GsdYMSh1fZDfIYyKpc 5tcd929evIeltRRw9lk9Xu1/W4z6GxBW99DXWusL9I55q58K8GPRMqyy6P5wBsZG +HLI4HP+JIOZP1BzMhQuJoMJSDVO5NgApWk2sALFjy6jUoUc7Jf4Fc1zFLoVZDMe wsHUFJXyNLTKeLtNn3td =tBNS -----END PGP SIGNATURE----- --=_zucker.schokokeks.org-16186-1471396676-0001-2-- From unknown Sat Aug 16 16:22:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Hanno =?UTF-8?Q?B=C3=B6ck?= Subject: bug#24248: closed (Re: [bug-diffutils] bug#24248: [patch] avoid duplicate definition of global variable presume_output_tty) Message-ID: References: <20160817031752.72abbf42@pc1> X-Gnu-PR-Message: they-closed 24248 X-Gnu-PR-Package: diffutils X-Gnu-PR-Keywords: patch Reply-To: 24248@debbugs.gnu.org Date: Wed, 17 Aug 2016 05:10:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1471410602-1079-1" This is a multi-part message in MIME format... ------------=_1471410602-1079-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24248: [patch] avoid duplicate definition of global variable presume_outpu= t_tty which was filed against the diffutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24248@debbugs.gnu.org. --=20 24248: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24248 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1471410602-1079-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24248-done) by debbugs.gnu.org; 17 Aug 2016 05:09:46 +0000 Received: from localhost ([127.0.0.1]:59666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZt6o-0000Gl-8I for submit@debbugs.gnu.org; Wed, 17 Aug 2016 01:09:46 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:36853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZt6l-0000GX-Rx for 24248-done@debbugs.gnu.org; Wed, 17 Aug 2016 01:09:45 -0400 Received: by mail-ua0-f194.google.com with SMTP id 74so8118706uau.3 for <24248-done@debbugs.gnu.org>; Tue, 16 Aug 2016 22:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3Q0aM8k6UZgzIucKRA1Rqb5nhPDi03t1mmq/nVumE7Q=; b=PR6sNYQiqR46N3kavHiT9DHqyxPorIHZp/9B54CjqO4Wz3usJ0PqUMCOGeqXqFJGjt UtpdLwdaN9vFBv3sYRMYjoOf0oCWDrBdQBLeHnGgZwMXCP2qM5lt5tU/TnwfnijvC2pz QM1QPjrova+I0ibl9N3GoAnzW5747K8SNJyJ8sqXA5XNC5d1Sz0xLLpqiwnVTTD2UndQ a7EoNFJGcXIu0A3U9jkQTjCfuRAxi2nQUBZz8xokJx55n5EhPLJvbbZbmiteC+TOt/qO EUcTSeUofbx036HCDOrLrMD1dyQ0fni5pMBNBVNp0yHRpvBYd9BR6ItQ/qEGcqCjb+DW rsWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3Q0aM8k6UZgzIucKRA1Rqb5nhPDi03t1mmq/nVumE7Q=; b=abSni/zc1AVDj+HOjuMHo6S1yFawcl3PdvO6+s7DnmS23TQ+xYJaTsFSaJRcIKbzmV hYoM5JChEar3wSueo5fY0esHJj32Dqkz+5HBUetX2ObxQaiGieprtkLeM1tFr86R7iZs J4ucHNrgkpYcH27lUGr9FQ/1qD595QpIRvwq5U0m5MQGBI3Dxl9YWyygIFfokRwP3Hmh cXwMKSg8AfnSrMOfzblPVU1C61/RaONGjzdClYRQyEH1pSTgEaHCshyl5BK6qf0o2O3M IAbS80xLpZhXfHGWErUz/xe3S2PO0Z+HLBkmGr8Sj4JxTegN5dEDdeew3BMgrHsi6hKQ xpJA== X-Gm-Message-State: AEkoousbNLbZCKXQwP3p31UV5x8QgrXgqfQUrqJa9H3falW9EOugA4l/tQWeO4irzkDNGxp9cqzmnFNHb47LuA== X-Received: by 10.176.82.139 with SMTP id v11mr19483163uav.4.1471410578512; Tue, 16 Aug 2016 22:09:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.80.143 with HTTP; Tue, 16 Aug 2016 22:09:18 -0700 (PDT) In-Reply-To: <20160817031752.72abbf42@pc1> References: <20160817031752.72abbf42@pc1> From: Jim Meyering Date: Tue, 16 Aug 2016 22:09:18 -0700 X-Google-Sender-Auth: WS7PjzBvpw5GM4Wz-WPOMFOjIcA Message-ID: Subject: Re: [bug-diffutils] bug#24248: [patch] avoid duplicate definition of global variable presume_output_tty To: =?UTF-8?Q?Hanno_B=C3=B6ck?= Content-Type: multipart/mixed; boundary=94eb2c19201ada150e053a3d780b X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24248-done Cc: 24248-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c19201ada150e053a3d780b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Aug 16, 2016 at 6:17 PM, Hanno B=C3=B6ck wrote: > Hi, > > The variable presume_output_tty is defined both in the diff.h header > and the file util.c (which includes diff.h). > > The diff.h file makes sure that the variable is declared as external > except when it's included by the main program diff.c. But as it's also > declared in util.c we end up having two non-external declarations of it. > > Traditionally gcc has allowed this behavior, which is probably the > reason it has not been spottet before, but it's not correct C. One can > get a more strict behavior here by passing -fno-common to the CFLAGS and > LDFLAGS and then linking will fail. > > The solution is simple: Remove the superfluous declaration in util.c, > see attached patch. Please apply. Good catch. Thank you! I will look into adding -fno-common when it is accepted. Here's the patch I expect to push soon: --94eb2c19201ada150e053a3d780b Content-Type: text/plain; charset=US-ASCII; name="duplicate-defn-of-presume_output_tty.diff" Content-Disposition: attachment; filename="duplicate-defn-of-presume_output_tty.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iryftsna2 RnJvbSBjMmRjOTFmMTk2OGM2Y2NkOGJhNjIzZjlmYTM5MWY1MjlhYjgwMGFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SGFubm89MjBCPUMzPUI2Y2s/PSA8aGFubm9A aGJvZWNrLmRlPgpEYXRlOiBUdWUsIDE2IEF1ZyAyMDE2IDIyOjAyOjEzIC0wNzAwClN1YmplY3Q6 IFtQQVRDSF0gZGlmZjogYXZvaWQgZHVwbGljYXRlIGRlZmluaXRpb24gb2YgcHJlc3VtZV9vdXRw dXRfdHR5CgoqIHNyYy91dGlsLmMgKHByZXN1bWVfb3V0cHV0X3R0eSk6IFJlbW92ZSB0aGlzIGRl ZmluaXRpb24uClRoZSBvdGhlciBpcyBpbiBkaWZmLmguICBSZXBvcnRlZCBpbiBodHRwczovL2J1 Z3MuZ251Lm9yZy8yNDI0OAotLS0KIHNyYy91dGlsLmMgfCAyIC0tCiAxIGZpbGUgY2hhbmdlZCwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvdXRpbC5jIGIvc3JjL3V0aWwuYwppbmRl eCBkN2I4OTI1Li43Njg3MmNiIDEwMDY0NAotLS0gYS9zcmMvdXRpbC5jCisrKyBiL3NyYy91dGls LmMKQEAgLTQ0LDggKzQ0LDYgQEAKCiBjaGFyIGNvbnN0IHByX3Byb2dyYW1bXSA9IFBSX1BST0dS QU07CgotYm9vbCBwcmVzdW1lX291dHB1dF90dHk7Ci0KIC8qIFF1ZXVlIHVwIG9uZS1saW5lIG1l c3NhZ2VzIHRvIGJlIHByaW50ZWQgYXQgdGhlIGVuZCwKICAgIHdoZW4gLWwgaXMgc3BlY2lmaWVk LiAgRWFjaCBtZXNzYWdlIGlzIHJlY29yZGVkIHdpdGggYSAnc3RydWN0IG1zZycuICAqLwoKLS0g CjIuOC4wLXJjMgoK --94eb2c19201ada150e053a3d780b-- ------------=_1471410602-1079-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Aug 2016 01:18:16 +0000 Received: from localhost ([127.0.0.1]:59596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpUm-0001NH-IG for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpUk-0001N4-CR for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZpUZ-0002Pa-FL for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpUZ-0002PW-CJ for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:18:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpUX-0003aj-4Y for bug-diffutils@gnu.org; Tue, 16 Aug 2016 21:18:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZpUS-0002PB-1t for bug-diffutils@gnu.org; Tue, 16 Aug 2016 21:18:00 -0400 Received: from zucker2.schokokeks.org ([178.63.68.90]:46534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpUR-0002P7-Ry for bug-diffutils@gnu.org; Tue, 16 Aug 2016 21:17:55 -0400 Received: from pc1 (p2003006A623D9D00B82D8DCF02FEDD63.dip0.t-ipconnect.de [2003:6a:623d:9d00:b82d:8dcf:2fe:dd63]) (AUTH: LOGIN hanno-default@schokokeks.org, TLS: TLSv1/SSLv3, 256bits, ECDHE-RSA-AES256-GCM-SHA384) by zucker.schokokeks.org with ESMTPSA; Wed, 17 Aug 2016 03:17:54 +0200 id 0000000000000012.0000000057B3BB43.00003F37 Date: Wed, 17 Aug 2016 03:17:52 +0200 From: Hanno =?UTF-8?B?QsO2Y2s=?= To: bug-diffutils@gnu.org Subject: [patch] avoid duplicate definition of global variable presume_output_tty Message-ID: <20160817031752.72abbf42@pc1> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-16186-1471396676-0001-2" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_zucker.schokokeks.org-16186-1471396676-0001-2 Content-Type: multipart/mixed; boundary="MP_/61uK5A+.p7C+3QnM+xDp.Th" --MP_/61uK5A+.p7C+3QnM+xDp.Th Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, The variable presume_output_tty is defined both in the diff.h header and the file util.c (which includes diff.h). The diff.h file makes sure that the variable is declared as external except when it's included by the main program diff.c. But as it's also declared in util.c we end up having two non-external declarations of it. Traditionally gcc has allowed this behavior, which is probably the reason it has not been spottet before, but it's not correct C. One can get a more strict behavior here by passing -fno-common to the CFLAGS and LDFLAGS and then linking will fail. The solution is simple: Remove the superfluous declaration in util.c, see attached patch. Please apply. --=20 Hanno B=C3=B6ck https://hboeck.de/ mail/jabber: hanno@hboeck.de GPG: FE73757FA60E4E21B937579FA5880072BBB51E42 --MP_/61uK5A+.p7C+3QnM+xDp.Th Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=diffutils-duplicate-definition-presume_output_tty.patch diff --git a/src/util.c b/src/util.c index d7b8925..76872cb 100644 --- a/src/util.c +++ b/src/util.c @@ -44,8 +44,6 @@ =20 char const pr_program[] =3D PR_PROGRAM; =20 -bool presume_output_tty; - /* Queue up one-line messages to be printed at the end, when -l is specified. Each message is recorded with a 'struct msg'. */ =20 --MP_/61uK5A+.p7C+3QnM+xDp.Th-- --=_zucker.schokokeks.org-16186-1471396676-0001-2 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXs7tBAAoJEKWIAHK7tR5CDPsQAK1CMLts9gDfF5LXOt1pEW6J 7BMBV+BEuX1ftB4TZqGeXTnJ3D56xzMLQRgs96GdW3M2ivWCQmQ+7NLH9hqP8AuW NvcRcsK90UEHSHxwfL3TSCw/et3vIeiwS9sRh1vAeZbViMz/PFGi0nFAnJy9PL/x 1s/OCfg2cWIqx7FctoV/Tx8G6FhNFoN6Tj8s5vbR4l4y2dxQ1GpCmZheoeG93Z4v wqcLQ4K5JqF2Uco4aABZLesytSWQSdwOSUxpFHZkD+k6uqTS+hwWfaRTDwdjO+Gr /sHeueBgS1FEXg++hqlpFRVBxCvHnQiO3yqzOgmmkpyhklKYQa6LyN2u7pO6lcsK rv1q8cLdy10slw6tu7IZu8oXVu7UuwWQpxuFan5A85XIJ5s5tLLstYvmcidXF5pk 5CgujSLwDidQY1E8uXnbm5yamTwLYK6nFHFxe4eOlckaqcil9i8A1K25aXkvyxtH YgMvJpI3sgEgxnQrGd3QlOy7dcV2Y4yWcYOQij7ieVzrc6GsdYMSh1fZDfIYyKpc 5tcd929evIeltRRw9lk9Xu1/W4z6GxBW99DXWusL9I55q58K8GPRMqyy6P5wBsZG +HLI4HP+JIOZP1BzMhQuJoMJSDVO5NgApWk2sALFjy6jUoUc7Jf4Fc1zFLoVZDMe wsHUFJXyNLTKeLtNn3td =tBNS -----END PGP SIGNATURE----- --=_zucker.schokokeks.org-16186-1471396676-0001-2-- ------------=_1471410602-1079-1-- From unknown Sat Aug 16 16:22:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24248: [bug-diffutils] bug#24248: [patch] avoid duplicate definition of global variable presume_output_tty Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Wed, 17 Aug 2016 05:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24248 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: Hanno =?UTF-8?Q?B=C3=B6ck?= Cc: 24248@debbugs.gnu.org Received: via spool by 24248-submit@debbugs.gnu.org id=B24248.14714113762321 (code B ref 24248); Wed, 17 Aug 2016 05:23:01 +0000 Received: (at 24248) by debbugs.gnu.org; 17 Aug 2016 05:22:56 +0000 Received: from localhost ([127.0.0.1]:59674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZtJY-0000bM-Fe for submit@debbugs.gnu.org; Wed, 17 Aug 2016 01:22:56 -0400 Received: from mail-ua0-f196.google.com ([209.85.217.196]:35202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZtJW-0000b8-5P for 24248@debbugs.gnu.org; Wed, 17 Aug 2016 01:22:54 -0400 Received: by mail-ua0-f196.google.com with SMTP id 109so8107813uat.2 for <24248@debbugs.gnu.org>; Tue, 16 Aug 2016 22:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3PBObSUbC7BgpC5g8bWf7K+Qg8W9+0fgwvXfRDNBAVI=; b=nNI3QnJjjHTwjfXf5ke2iluTIX172zC9uBoG7IgE0cXsguy8t2mV9WEALEcRkL0SDF Zb2OEm74pclZKvIeEkD6Yz49+2r/lH6mZqLOBL8Eg+mUBd3Li0xMyt2o6NbsyMUPSG1e tgf7iHbajtjkemkC2CPNY/mUgbyq05ZvioKQ38CnEoX/7e3Iiw6vyGo2vezrQjfc7cYU 8Fs3iIORmr5J/LHuto9yuyJ0OoZ0JxQ0N5G8/Blf4TSINPginqBgOrlhZorB7Xynb4ei vl1+B6a1/sjAzjdfhBqL0q9NXQzszfq6sYU//GQqlvVM/oXxs8nUNWXVGFQOmt2zPLRE 14BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3PBObSUbC7BgpC5g8bWf7K+Qg8W9+0fgwvXfRDNBAVI=; b=K2c/yfbQ1Dg+qP4u8LRw4o8eaqYMkM645Nb/l0UzoUGFqzFcdtN5H/HSi+s0A0uTAQ 6LexL018NmiiW2YU0EtIhT0MYpDHsTMvDEkrlD6WwYx9qizf4+3oOQffXcwy0RG3DOxW n6rFaZue3Ix0ZkxXxGu336lnNg0bfgOXqw1nSwxt7s1F2p/xAJtl5AAlsM0yvVO5kNbd SP86glHlQ4jVbuZ8XO0luOxW/b/H+rj2yBnt4Ae7On+6+TEyo2gEFV5YV8DwUSmTI4PC gZ1zxG7Zf0rRt8AfbR1pjaUrtcepzmbcKhvQpN0iCbMgcBMvBeu+hCWSzh5pf7mxQ60w eojw== X-Gm-Message-State: AEkooutZp3J4/P7sBVw7MFRiP7415+4msZzhRIwxTzlVa5pJo48nyZ05UcklWBJVKkdDf09GTcGT4zpllrBMDA== X-Received: by 10.176.80.200 with SMTP id d8mr19255928uaa.90.1471411368771; Tue, 16 Aug 2016 22:22:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.80.143 with HTTP; Tue, 16 Aug 2016 22:22:28 -0700 (PDT) In-Reply-To: References: <20160817031752.72abbf42@pc1> From: Jim Meyering Date: Tue, 16 Aug 2016 22:22:28 -0700 X-Google-Sender-Auth: Hgm-hYpqSQRbfjlJJwmVPAeu7HQ Message-ID: Content-Type: multipart/mixed; boundary=94eb2c1911daf45864053a3da758 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c1911daf45864053a3da758 Content-Type: text/plain; charset=UTF-8 On Tue, Aug 16, 2016 at 10:09 PM, Jim Meyering wrote: ... > I will look into adding -fno-common when it is accepted. Here's the patch for that: --94eb2c1911daf45864053a3da758 Content-Type: text/plain; charset=US-ASCII; name="diff-fno-common.diff" Content-Disposition: attachment; filename="diff-fno-common.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irygaeny1 RnJvbSAyNDc5MjY2OGYwMmNiOTE1YTE3MGE4MDk4ZDk0NWRhMzI1Mjg3Mjg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog VHVlLCAxNiBBdWcgMjAxNiAyMjoyMDoyOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGJ1aWxkOiBh cnJhbmdlIHRvIGJ1aWxkIHdpdGggLWZuby1jb21tb24sIHdoZW4gcG9zc2libGUKCiogY29uZmln dXJlLmFjIChXRVJST1JfQ0ZMQUdTKTogQWRkIC1mbm8tY29tbW9uLCB3aGVuIHBvc3NpYmxlLgpU aGlzIHdvdWxkIGhhdmUgcHJldmVudGVkIHRoZSBkdXBsaWNhdGUgZGVmaW5pdGlvbiBvZgpwcmVz dW1lX291dHB1dF90dHkgdGhhdCB3YXMgZml4ZWQgaW4gdjMuNC0xMC1nYzJkYzkxZi4KLS0tCiBj b25maWd1cmUuYWMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAt LWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBhNDczZDY2Li45MzYzMzhm IDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0xMDksNiAr MTA5LDcgQEAgaWYgdGVzdCAiJGdsX2djY193YXJuaW5ncyIgPSB5ZXM7IHRoZW4KCiAgIGdsX1dB Uk5fQUREKFstZmRpYWdub3N0aWNzLXNob3ctb3B0aW9uXSkKICAgZ2xfV0FSTl9BREQoWy1mdW5p dC1hdC1hLXRpbWVdKQorICBnbF9XQVJOX0FERChbLWZuby1jb21tb25dKQoKICAgQUNfU1VCU1Qo W1dBUk5fQ0ZMQUdTXSkKCi0tIAoyLjguMC1yYzIKCg== --94eb2c1911daf45864053a3da758--