From unknown Thu Aug 14 21:45:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24246 <24246@debbugs.gnu.org> To: bug#24246 <24246@debbugs.gnu.org> Subject: Status: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. Reply-To: bug#24246 <24246@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:45:00 +0000 retitle 24246 25.0.95; (c++-mode) custom/extra types not getting highlighte= d (as a type) after a wrapper::type argument. reassign 24246 emacs,cc-mode submitter 24246 Arash severity 24246 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 16 16:54:59 2016 Received: (at submit) by debbugs.gnu.org; 16 Aug 2016 20:54:59 +0000 Received: from localhost ([127.0.0.1]:59528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZlNz-000275-Ac for submit@debbugs.gnu.org; Tue, 16 Aug 2016 16:54:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZlNu-00026r-Nf for submit@debbugs.gnu.org; Tue, 16 Aug 2016 16:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZlNg-0002No-FR for submit@debbugs.gnu.org; Tue, 16 Aug 2016 16:54:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, HK_RANDOM_ENVFROM,HK_RANDOM_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZlNg-0002Nd-Cs for submit@debbugs.gnu.org; Tue, 16 Aug 2016 16:54:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZlNY-0004Zc-J2 for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 16:54:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZlNN-0002MH-Ar for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 16:54:30 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZlNN-0002M6-4B for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 16:54:21 -0400 Received: by mail-wm0-x244.google.com with SMTP id i5so18420270wmg.2 for ; Tue, 16 Aug 2016 13:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=MoMiVLNBXJsY6qVHqW31TsPJV2vhfk5mvbmTP4BN7ok=; b=cPZC4pQLHDYsi4L20STIDHOlXK1xEWmdGHS4MlY47D6MJ0dYc4R36FH6rZrPWh3wMV CvpnSB2GKm8REIx9EH8k66KGJKov0KN5cDmKzGNCpUB/gjk3mhgiMWoHk6KzkjXtzK9h DEIe/NqmnCSErIWaIl8wfSifAjf2hNfVIZtG2T44J91gbPu/Tz36PwOHbai4HlvaLT72 oarAPJf6bHLcUMslgYQy0BGZJlAGnlzYGwi1s/IuWSzcYewUhGkFfcsAO37G5k8SiwIc Jp0HLowy12feDtBCyBdlNRVF2gntEk/ki2UpDGVIpXfWIFRQrJpciSXmTtR/uDEnE+va VPGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=MoMiVLNBXJsY6qVHqW31TsPJV2vhfk5mvbmTP4BN7ok=; b=kSv+oPQQAb3dQ4tZKYj2eG35y/41vwXCwF6M+VzwPv/3x5jSLRxQ/3Q13cbWFuk5Ma 8vRxKtjSmWpIBrehkVNPNaBXXpKpCOHMs+7U2KJ8M90y4oAx89g/CcTT+amWm1Q9CYMa f0+E6Qdx+f6tzhD+WZ3v6U4fyIPalw+5zu1bF4TwuvsTKkoQPw7x2gfrqGvD8F8SElKF /SI/Pfh5OqtbqugEC586p2Z+3jpPBnlPKa9rTPHQfHhq1wdbN4BX0DPVm+jqepvoPbbw qJX0/2ZxwZL5yuBC/Ed3PFSbUome9m3K1zeUZ1GFWATjKzg/IN8EUdhgdGpstspWy6Y9 L+ww== X-Gm-Message-State: AEkooutcyVUsRD2pCA2ZD7MZuKvSiqjTKTT5O4lcYpfWoGZbchVxNG9uYW/1rmSf1eJMaw== X-Received: by 10.28.211.10 with SMTP id k10mr22397593wmg.16.1471380859737; Tue, 16 Aug 2016 13:54:19 -0700 (PDT) Received: from lo ([37.254.105.22]) by smtp.gmail.com with ESMTPSA id 207sm23366978wmb.7.2016.08.16.13.54.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2016 13:54:19 -0700 (PDT) Received: by lo (Postfix, from userid 1001) id 96850143ADB; Wed, 17 Aug 2016 01:24:17 +0430 (IRDT) From: Arash To: bug-gnu-emacs@gnu.org Subject: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. Date: Wed, 17 Aug 2016 01:24:17 +0430 Message-ID: <86inv0ph8m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) $ emacs -Q ab.cc typedef int int32; namespace wrapper { enum type { a, b, c }; } // int32 doesn't get highlighted as a type. void test(wrapper::type A, int32 B); typedef wrapper::type wtype; // here it works, so double colon is the problem? void test(wtype A, int32 B); From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 08:30:16 2016 Received: (at 24246) by debbugs.gnu.org; 17 Aug 2016 12:30:16 +0000 Received: from localhost ([127.0.0.1]:59892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZzz6-0007L4-0Y for submit@debbugs.gnu.org; Wed, 17 Aug 2016 08:30:16 -0400 Received: from mail.muc.de ([193.149.48.3]:42739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZzz4-0007Kw-Qu for 24246@debbugs.gnu.org; Wed, 17 Aug 2016 08:30:15 -0400 Received: (qmail 14005 invoked by uid 3782); 17 Aug 2016 12:30:13 -0000 Received: from acm.muc.de (p548C62EC.dip0.t-ipconnect.de [84.140.98.236]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 17 Aug 2016 14:30:12 +0200 Received: (qmail 5262 invoked by uid 1000); 17 Aug 2016 12:29:44 -0000 Date: Wed, 17 Aug 2016 12:29:44 +0000 To: Arash Subject: Re: bug#24246: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. Message-ID: <20160817122944.GA5258@acm.fritz.box> References: <86inv0ph8m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86inv0ph8m.fsf@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 24246 Cc: 24246@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hello, Arash. On Wed, Aug 17, 2016 at 01:24:17AM +0430, Arash wrote: > $ emacs -Q ab.cc > typedef int int32; > namespace wrapper { > enum type { a, b, c }; > } > // int32 doesn't get highlighted as a type. > void test(wrapper::type A, int32 B); > typedef wrapper::type wtype; > // here it works, so double colon is the problem? > void test(wtype A, int32 B); Yes, it looks like the double colon exposes the problem. I'll look into it soon. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 14:21:52 2016 Received: (at 24246) by debbugs.gnu.org; 17 Aug 2016 18:21:52 +0000 Received: from localhost ([127.0.0.1]:60517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba5TM-0007tT-FH for submit@debbugs.gnu.org; Wed, 17 Aug 2016 14:21:52 -0400 Received: from mail.muc.de ([193.149.48.3]:43790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba5TL-0007tL-AI for 24246@debbugs.gnu.org; Wed, 17 Aug 2016 14:21:51 -0400 Received: (qmail 26416 invoked by uid 3782); 17 Aug 2016 18:21:50 -0000 Received: from acm.muc.de (p548C62EC.dip0.t-ipconnect.de [84.140.98.236]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 17 Aug 2016 20:21:49 +0200 Received: (qmail 9070 invoked by uid 1000); 17 Aug 2016 18:21:21 -0000 Date: Wed, 17 Aug 2016 18:21:21 +0000 To: Arash Subject: Re: bug#24246: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. Message-ID: <20160817182121.GB5258@acm.fritz.box> References: <86inv0ph8m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86inv0ph8m.fsf@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 24246 Cc: 24246@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hello again, Arash. On Wed, Aug 17, 2016 at 01:24:17AM +0430, Arash wrote: > $ emacs -Q ab.cc > typedef int int32; > namespace wrapper { > enum type { a, b, c }; > } > // int32 doesn't get highlighted as a type. > void test(wrapper::type A, int32 B); > typedef wrapper::type wtype; > // here it works, so double colon is the problem? > void test(wtype A, int32 B); Thanks indeed for this bug report, and thanks even more for cutting it down to a nice, crisp, manageable file. The fontification code was not handling "::" in declarations correctly. I think I have corrected this, and I have committed it to our master branch at savannah. I see you're on the emacs-25 branch. Could you please patch your Emacs with the following patch (the file is in directory .../lisp/progmodes), rebuild CC Mode (a single $ emacs -Q -batch -f batch-byte-compile .../lisp/progmodes/cc-engine.el should suffice), reload CC Mode into your Emacs (or restart Emacs), then try out the new system on your real code. Then please let me know whether the problem has been truly fixed, and if not, what is still wrong. If everything is OK, I will close the bug. Here's the patch: # HG changeset patch # User Alan Mackenzie # Date 1471456447 0 # Wed Aug 17 17:54:07 2016 +0000 # Node ID 85afa8e79cc145c4ab61d8c8f180587d85c71bec # Parent 0e89dd90ade9cd6f5f4ca07cb57cba6f8e1335a5 Fontify constructs following "::" in C++ argument lists correctly. This fixes bug #24246. * cc-engine.el (c-find-decl-prefix-search): In the "pseudo match" loop, test a found string for a match with c-opt-identifier-concat-key (e.g. with "::"). * arglist-23.{cc,face}: New test files. diff -r 0e89dd90ade9 -r 85afa8e79cc1 cc-engine.el --- a/cc-engine.el Wed Aug 17 17:53:10 2016 +0000 +++ b/cc-engine.el Wed Aug 17 17:54:07 2016 +0000 @@ -5171,6 +5171,13 @@ (and (< (point) cfd-limit) (c-got-face-at (point) c-literal-faces)))) t) ; Continue the loop over pseudo matches. + ((and c-opt-identifier-concat-key + (match-string 1) + (save-excursion + (goto-char (match-beginning 1)) + (looking-at c-opt-identifier-concat-key))) + ;; Found, e.g., "::" in C++ + t) ((and (match-string 1) (string= (match-string 1) ":") (save-excursion -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 16:03:44 2016 Received: (at 24246) by debbugs.gnu.org; 17 Aug 2016 20:03:44 +0000 Received: from localhost ([127.0.0.1]:60534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba73v-0001zX-Hz for submit@debbugs.gnu.org; Wed, 17 Aug 2016 16:03:44 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba73u-0001zK-0U for 24246@debbugs.gnu.org; Wed, 17 Aug 2016 16:03:42 -0400 Received: by mail-wm0-f50.google.com with SMTP id f65so214277208wmi.0 for <24246@debbugs.gnu.org>; Wed, 17 Aug 2016 13:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gWFW5zbgMhjfi0/epyUnG608v+A85RWqc1Kp2pWDHQ4=; b=isOlYymOaFDDEcUrOgCVolvTxeD1uz9AtcFuZkyxMFU6QVVckHEbZPtvad74SCs/WJ nHHkdgqwbvWlTuVTJfa7BBjaFIIvFQy6gsQyWQdDDFQYOPB4SMcl+zIY4/OiR4hE9XXr 085hTn7CILsU9JU89xzX0wEgaeSHcXZeggb8XOZ6FB3lyUYIbUQcmEyulYupH3tVZ4gI HNbDaFvWgmfGnqTVVsVkRkyTwW2RgNApSGHVsH9Zvjg31dDv8vavMnWGOuhcIReEoRav fS8Qna3cXW2FQw3pkcA/ITShg21P1TDgfKyFimJCVqvXnChWijCaa6KAasI0q8XzrMrS /cSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gWFW5zbgMhjfi0/epyUnG608v+A85RWqc1Kp2pWDHQ4=; b=NZVUMSmteYq67tWxQ7UH2FgvEd9C/Q2M91vY//KFoa+xXBm83KfeuUpBmWUVCW8P/S s243nAw32nbpBMFhZTJh4GIy5aB6TCOKytyNsKtaC7OrvImFx26/+O2nSco0D2Qwkn6v LTImosNTZtPkdcd3kYmXTo/d6nxsteF5HSIzdyDzUjo3p7PkXuOsefD+nAeZVZR3HyMX EsIA7lpj3uha5W4mmreizZstuxKk2kVvdSgxFvWFWClFVDRG4WSh5ceqPfwrREKULYK2 R60WkNhhIGl6q3X359T3wuB/gjwCQ+7ZMfcPryo9j+8NGgZfTTMfna4o2VzBp6akCgT8 Dbcw== X-Gm-Message-State: AEkoousp8ukounlykbI/0JZ7KxRkUot0eqyPtCNI2x+RTlhtbXTN7RyLaCE01OUR6/WQvg== X-Received: by 10.194.120.129 with SMTP id lc1mr43516612wjb.131.1471464216241; Wed, 17 Aug 2016 13:03:36 -0700 (PDT) Received: from lo ([37.254.105.22]) by smtp.gmail.com with ESMTPSA id i3sm33125302wjd.31.2016.08.17.13.03.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Aug 2016 13:03:35 -0700 (PDT) Received: by lo (Postfix, from userid 1001) id 90641141D90; Thu, 18 Aug 2016 00:33:33 +0430 (IRDT) From: Arash To: Alan Mackenzie Subject: Re: bug#24246: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. References: <86inv0ph8m.fsf@gmail.com> <20160817182121.GB5258@acm.fritz.box> Date: Thu, 18 Aug 2016 00:33:33 +0430 In-Reply-To: <20160817182121.GB5258@acm.fritz.box> (Alan Mackenzie's message of "Wed, 17 Aug 2016 18:21:21 +0000") Message-ID: <8660qzkvsa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 24246 Cc: 24246@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) Thanks, fontification for function decs/defs got fixed but the problem still exists in e.g. init step of a for loop... for (wrapper::type a = 0, int32 b = 0; ; ) { ... } From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 18 05:50:05 2016 Received: (at 24246-done) by debbugs.gnu.org; 18 Aug 2016 09:50:05 +0000 Received: from localhost ([127.0.0.1]:60811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baJxd-0006t6-62 for submit@debbugs.gnu.org; Thu, 18 Aug 2016 05:50:05 -0400 Received: from mail.muc.de ([193.149.48.3]:29413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baJxb-0006sw-Db for 24246-done@debbugs.gnu.org; Thu, 18 Aug 2016 05:50:03 -0400 Received: (qmail 32803 invoked by uid 3782); 18 Aug 2016 09:50:02 -0000 Received: from acm.muc.de (p548C63BB.dip0.t-ipconnect.de [84.140.99.187]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 18 Aug 2016 11:50:00 +0200 Received: (qmail 3607 invoked by uid 1000); 18 Aug 2016 09:49:33 -0000 Date: Thu, 18 Aug 2016 09:49:33 +0000 To: Arash , 24246-done@debbugs.gnu.org Subject: Re: bug#24246: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. Message-ID: <20160818094932.GB3030@acm.fritz.box> References: <86inv0ph8m.fsf@gmail.com> <20160817182121.GB5258@acm.fritz.box> <8660qzkvsa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8660qzkvsa.fsf@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 24246-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hello, Arash. On Thu, Aug 18, 2016 at 12:33:33AM +0430, Arash wrote: > Thanks, fontification for function decs/defs got fixed but the problem > still exists in e.g. init step of a for loop... > for (wrapper::type a = 0, int32 b = 0; ; ) { > ... > } This is actually a different bug - if you delete the "::", the problem is still there. I've submitted bug #24258 for this problem, and I'm working on it. I'm closing the original bug now, since it appears to be fixed. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 18:34:46 2016 Received: (at 24246) by debbugs.gnu.org; 23 Aug 2016 22:34:46 +0000 Received: from localhost ([127.0.0.1]:38269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcKHO-0005pd-IR for submit@debbugs.gnu.org; Tue, 23 Aug 2016 18:34:46 -0400 Received: from md5i.com ([75.151.244.229]:47670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcKHN-0005pW-Ax for 24246@debbugs.gnu.org; Tue, 23 Aug 2016 18:34:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7H46DCd8+RJ+wSm1ebWMtdmhTBd81yXaGF4+W1CLgAs=; b=v+DPIOSbEV3ZXJcwUnVkUDlGjT HdnitaGx7oOe/SRKYYAN9zw5AZwSoaGVNJHFmBil4bwizh+2dwOxwutpKQ5aNR41z3xcQ7vlNA7Yp FbbduGXADHGVN+Aw/eqmWNooy; Received: from md5i by md5i.com with local (Exim 4.87) (envelope-from ) id 1bcKHI-0001Qj-6g; Tue, 23 Aug 2016 18:34:40 -0400 From: Michael Welsh Duggan To: Arash Subject: Re: bug#24246: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. References: <86inv0ph8m.fsf@gmail.com> <20160817182121.GB5258@acm.fritz.box> <8660qzkvsa.fsf@gmail.com> Date: Tue, 23 Aug 2016 18:34:40 -0400 In-Reply-To: <8660qzkvsa.fsf@gmail.com> (Arash's message of "Thu, 18 Aug 2016 00:33:33 +0430") Message-ID: <877fb76rnj.fsf@md5i.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24246 Cc: Alan Mackenzie , 24246@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Arash writes: > Thanks, fontification for function decs/defs got fixed but the problem > still exists in e.g. init step of a for loop... > > for (wrapper::type a = 0, int32 b = 0; ; ) { > ... > } I don't believe that is legal C++. The for-init-statement must be a single statement. Since "wrapper::type a = 0, int32 b = 0;" is not a legal statement, it is not a legal for-init-statement. The following, however, is legal: for (struct{wrapper::type a; int32 b;} var = {0, 0}; ; ) { } -- Michael Welsh Duggan (md5i@md5i.com) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 11:18:24 2016 Received: (at 24246) by debbugs.gnu.org; 8 Sep 2016 15:18:24 +0000 Received: from localhost ([127.0.0.1]:53765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi15r-0005Lb-R6 for submit@debbugs.gnu.org; Thu, 08 Sep 2016 11:18:24 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi15q-0005LI-8b for 24246@debbugs.gnu.org; Thu, 08 Sep 2016 11:18:22 -0400 Received: by mail-wm0-f51.google.com with SMTP id w12so95600691wmf.0 for <24246@debbugs.gnu.org>; Thu, 08 Sep 2016 08:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YdtFJhcX+BMcBKmZBD1fDmSeWsUUDvNwtoymryWFSYk=; b=l5XyB4KX+pwes1IbmDPRttnxAkwdt06a50fpCp/fdhLOo2SFRC/hp/+wsTRmxdVE+i lVIGwC9xY58K0Rx8CXMbLbCdrskwqvpu/JyjWTdXUbhvK5rxWhfSiTC7E68n+urpEqzI HxyspgxCioCvESRcRZagtbiZH5J+vMRoLYuciY+PpE8n6PG8XENGF2Fla4zDQuYLceKu uFYLUb2TuYHV3Tsvf1gxrVW8i1vrWyEVGpz7JmkThj/LtZVdCyoNSuUx4NPb+m07kUtG 8eSOvq6FQR9AxKpZ9BweCGSM585ogwxI2oULC2WIov7ep+GHA6kxY4AIRSXJMaVvARfj xOAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YdtFJhcX+BMcBKmZBD1fDmSeWsUUDvNwtoymryWFSYk=; b=EklsCvXl9hnJrLFzF/xRgY1NaVhMOnndhAuPkKbVruhVlpvZEACZQS3pQAITeHqYK2 4z/wT4UqCyvLlg3vcgnSXfYe0aV3Qxn89P2OO5F3+3lT2aukCo9nGgClwB11tHtT7+rH Mm1QXHhJ2kAKNomKRyDsKuF3nJKkVQhx7mI8VML0isXq4Px8NV7Ow2K4gHELz1lSk7BM 2taR6blxmhYbGFE0bkLWDfeYgIacFFeOzmkCsCp6kdGbSxkRbC374HfVUc7M0YQ3Hjf+ EpVXseOlXeVixXHVuFFCvflAC/FVBSpsZG6emeGmrxDu5wYWuy2c/OpdPrge7T9Bevg3 o0UQ== X-Gm-Message-State: AE9vXwNC2XrZN08OSzUIgBp13+UG5xhj5V0GpQaS6AwXDFwBcivVm2ORZ31gwRBwRiDTqA== X-Received: by 10.194.41.35 with SMTP id c3mr188588wjl.90.1473347896156; Thu, 08 Sep 2016 08:18:16 -0700 (PDT) Received: from lo ([37.254.181.221]) by smtp.gmail.com with ESMTPSA id o2sm44732724wjo.3.2016.09.08.08.18.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2016 08:18:14 -0700 (PDT) Received: by lo (Postfix, from userid 1001) id B08231433C1; Thu, 8 Sep 2016 19:48:12 +0430 (IRDT) From: Arash To: Alan Mackenzie Subject: Re: bug#24246: 25.0.95; (c++-mode) custom/extra types not getting highlighted (as a type) after a wrapper::type argument. References: <86inv0ph8m.fsf@gmail.com> <20160817182121.GB5258@acm.fritz.box> Date: Thu, 08 Sep 2016 19:48:12 +0430 In-Reply-To: <20160817182121.GB5258@acm.fritz.box> (Alan Mackenzie's message of "Wed, 17 Aug 2016 18:21:21 +0000") Message-ID: <86eg4us9mz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.3 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Alan Mackenzie wrote: > Hello again, Arash. > > On Wed, Aug 17, 2016 at 01:24:17AM +0430, Arash wrote: >> $ emacs -Q ab.cc > >> typedef int int32; > >> namespace wrapper { >> enum type { a, b, c }; >> } > >> // int32 doesn't get highlighted as a type. >> void test(wrapper::type A, int32 B); > > >> typedef wrapper::type wtype; > >> // here it works, so double colon is the problem? >> void test(wtype A, int32 B); > > Thanks indeed for this bug report, and thanks even more for cutting it > down to a nice, crisp, manageable file. > > The fontification code was not handling "::" in declarations correctly. > I think I have corrected this, and I have committed it to our master > branch at savannah. > > I see you're on the emacs-25 branch. Could you please patch your Emacs > with the following patch (the file is in directory .../lisp/progmodes), > rebuild CC Mode (a single $ emacs -Q -batch -f batch-byte-compile > .../lisp/progmodes/cc-engine.el should suffice), reload CC Mode into > your Emacs (or restart Emacs), then try out the new system on your real > code. > > Then please let me know whether the problem has been truly fixed, and > if not, what is still wrong. If everything is OK, I will close the bug. [...] Content analysis details: (3.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.6 HK_RANDOM_ENVFROM Envelope sender username looks random 1.0 HK_RANDOM_FROM From username looks random 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pbqbqp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.51 listed in list.dnswl.org] 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [74.125.82.51 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.51 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 24246 Cc: 24246@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.3 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Alan Mackenzie wrote: > Hello again, Arash. > > On Wed, Aug 17, 2016 at 01:24:17AM +0430, Arash wrote: >> $ emacs -Q ab.cc > >> typedef int int32; > >> namespace wrapper { >> enum type { a, b, c }; >> } > >> // int32 doesn't get highlighted as a type. >> void test(wrapper::type A, int32 B); > > >> typedef wrapper::type wtype; > >> // here it works, so double colon is the problem? >> void test(wtype A, int32 B); > > Thanks indeed for this bug report, and thanks even more for cutting it > down to a nice, crisp, manageable file. > > The fontification code was not handling "::" in declarations correctly. > I think I have corrected this, and I have committed it to our master > branch at savannah. > > I see you're on the emacs-25 branch. Could you please patch your Emacs > with the following patch (the file is in directory .../lisp/progmodes), > rebuild CC Mode (a single $ emacs -Q -batch -f batch-byte-compile > .../lisp/progmodes/cc-engine.el should suffice), reload CC Mode into > your Emacs (or restart Emacs), then try out the new system on your real > code. > > Then please let me know whether the problem has been truly fixed, and > if not, what is still wrong. If everything is OK, I will close the bug. [...] Content analysis details: (3.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [74.125.82.51 listed in dnsbl.sorbs.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.51 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.51 listed in wl.mailspike.net] 0.6 HK_RANDOM_ENVFROM Envelope sender username looks random 1.0 HK_RANDOM_FROM From username looks random 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pbqbqp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Alan Mackenzie wrote: > Hello again, Arash. > > On Wed, Aug 17, 2016 at 01:24:17AM +0430, Arash wrote: >> $ emacs -Q ab.cc > >> typedef int int32; > >> namespace wrapper { >> enum type { a, b, c }; >> } > >> // int32 doesn't get highlighted as a type. >> void test(wrapper::type A, int32 B); > > >> typedef wrapper::type wtype; > >> // here it works, so double colon is the problem? >> void test(wtype A, int32 B); > > Thanks indeed for this bug report, and thanks even more for cutting it > down to a nice, crisp, manageable file. > > The fontification code was not handling "::" in declarations correctly. > I think I have corrected this, and I have committed it to our master > branch at savannah. > > I see you're on the emacs-25 branch. Could you please patch your Emacs > with the following patch (the file is in directory .../lisp/progmodes), > rebuild CC Mode (a single $ emacs -Q -batch -f batch-byte-compile > .../lisp/progmodes/cc-engine.el should suffice), reload CC Mode into > your Emacs (or restart Emacs), then try out the new system on your real > code. > > Then please let me know whether the problem has been truly fixed, and > if not, what is still wrong. If everything is OK, I will close the bug. Hi Alan. This is a bit late, sry. // Here, first double colon causes the same problem. void test(::base::string S, int32 test) { } // and here, even "string" doesn't get highlighted. void test(::base::string &S) { } From unknown Thu Aug 14 21:45:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 07 Oct 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator