From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 16 11:15:00 2016 Received: (at submit) by debbugs.gnu.org; 16 Aug 2016 15:15:01 +0000 Received: from localhost ([127.0.0.1]:59410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZg4y-0007k7-Nh for submit@debbugs.gnu.org; Tue, 16 Aug 2016 11:15:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZg4x-0007jr-Ti for submit@debbugs.gnu.org; Tue, 16 Aug 2016 11:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZg4r-0007mx-Ph for submit@debbugs.gnu.org; Tue, 16 Aug 2016 11:14:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZg4r-0007lk-MN for submit@debbugs.gnu.org; Tue, 16 Aug 2016 11:14:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZg4p-0000T6-Lv for bug-grep@gnu.org; Tue, 16 Aug 2016 11:14:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZg4n-0007kn-PQ for bug-grep@gnu.org; Tue, 16 Aug 2016 11:14:50 -0400 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]:33735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZg4n-0007kR-KV for bug-grep@gnu.org; Tue, 16 Aug 2016 11:14:49 -0400 Received: by mail-io0-x22c.google.com with SMTP id 38so110139429iol.0 for ; Tue, 16 Aug 2016 08:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=NNnYwQ/SfXrjRb/zbMdu8m+2ihwYH0S/YZWl3rQOAao=; b=pDPmM6Jf4pR4LHRTF5AbT8xMZ+IeA63MsO85es5AAzqClqopX+QaDzMP756L9imm2x 9B3NCP3ltHfyZedJgzJXBIIzF8FC6AXbcC8XQdo7boBfO5IIWrUtT4EtgTs3aPVdRGJB LIIbKpg1nzDAK43rtmi+8FQJsl/e1DKZTw0WKDIpmOVzL0suHbRb3w7c6xctczly3yzM vPUky7eb9x/UQ2H9CLLSYFYNaZUkl8Lb4NOPJHlmzqMJ1mV7HzmHthFhT72x3X1l1Jjl uJVLS8mUgUma5BcJhqKSXNMBf9r0H/5fxPn8vC9WOcv5Whal2n58ZaxHiuGC6bliuVp6 RQtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NNnYwQ/SfXrjRb/zbMdu8m+2ihwYH0S/YZWl3rQOAao=; b=KvJ+Fwtvi7HuB7buJfOB3hTkS32LSt5ci4Am4WBS3AvBcmeqqd1dFBQN8eIZIVp3lt 3IHH1pukIWjepKtnHBYttMnHseWm2dSN9JbGlSG+24PG00Ua7m3hmZAkPOaDNp/+XgHw QU7H6KCu0R5TzZsKq9JVTO2byMIvY5yz3iB6bxYGDPG5kPMX3Oqzpl8Ftabr23UW5mqO /HQ7ZpA0myK0JGKdxJvZZPtOGYnBQKnuJ4qNyfUOJ17YFIy4R7K8EkqHcWtBbRTOvueb frsNomh6xsA8teKNhtSmduSOPsZsmDhNTI/lKdeDxCnO4WgzQUUyMnEOtUsaxtM4b8bQ We2A== X-Gm-Message-State: AEkooutxE0WquwAOCXSHJARqzm8thPiC3suDih7mLyE3oDFINhsR5NZ+Ojdea5mAx6tWt7Keg4+OWYHAPgP0+Q== X-Received: by 10.107.198.147 with SMTP id w141mr40939779iof.146.1471360488804; Tue, 16 Aug 2016 08:14:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.158.137 with HTTP; Tue, 16 Aug 2016 08:14:48 -0700 (PDT) From: Jack Howarth Date: Tue, 16 Aug 2016 11:14:48 -0400 Message-ID: Subject: fix for pcre-jitstack failure on Mac OS X To: bug-grep@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The pcre-jitstack test case fails on Mac OS X due to the system base64 expecting either '-D or --decode' rather than '-d or --decode'. The trivial fix is to use the common '--decode' option rather than '-d'... diff -uNr grep-2.25/tests/pcre-jitstack grep-2.25-patched/tests/pcre-jitstack --- grep-2.25/tests/pcre-jitstack 2016-01-01 17:45:41.000000000 -0500 +++ grep-2.25-patched/tests/pcre-jitstack 2016-08-16 10:53:58.000000000 -0400 @@ -17,7 +17,7 @@ fail=0 -base64 -d >pcrejit.txt.gz <<'EOF' +base64 --decode >pcrejit.txt.gz <<'EOF' H4sIAAAAAAACA+2bUU4DMQxE/7mMz5T7XwKE+IBKVLue58yk0B9EtX6xJxN7t4VaH69a6+tHrW+/ r4e3n75KARWShSOFTtiumE3FPVyo79ATIJ0Ry0No/yXe99UIUqTGKKUzYHFJHJoaCONQDCnDSCDS IPAvGCVeXNsZ7lpbWFfdaZtgPos5LeK2C1TBKzD09V3HFlCOsbFT/hNbz4HzJaRjnjdam9FXw/o6 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 16 18:07:56 2016 Received: (at control) by debbugs.gnu.org; 16 Aug 2016 22:07:56 +0000 Received: from localhost ([127.0.0.1]:59558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZmWa-0003qQ-JN for submit@debbugs.gnu.org; Tue, 16 Aug 2016 18:07:56 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZmWZ-0003qD-79 for control@debbugs.gnu.org; Tue, 16 Aug 2016 18:07:55 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8F66416112C for ; Tue, 16 Aug 2016 15:07:49 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kgqTTqoRf-5o for ; Tue, 16 Aug 2016 15:07:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E812C161168 for ; Tue, 16 Aug 2016 15:07:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tizOJnRIusPy for ; Tue, 16 Aug 2016 15:07:48 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CFC8F16112C for ; Tue, 16 Aug 2016 15:07:48 -0700 (PDT) To: control@debbugs.gnu.org From: Paul Eggert Subject: 24243 has a patch Organization: UCLA Computer Science Department Message-ID: Date: Tue, 16 Aug 2016 15:07:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 24243 patch From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 00:40:07 2016 Received: (at 24243) by debbugs.gnu.org; 17 Aug 2016 04:40:07 +0000 Received: from localhost ([127.0.0.1]:59659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZse6-0007zP-OS for submit@debbugs.gnu.org; Wed, 17 Aug 2016 00:40:07 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:34999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZse5-0007yr-8l for 24243@debbugs.gnu.org; Wed, 17 Aug 2016 00:40:05 -0400 Received: by mail-ua0-f194.google.com with SMTP id 109so8056403uat.2 for <24243@debbugs.gnu.org>; Tue, 16 Aug 2016 21:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=JqO/x+Nf0MtY5sHGS5SLZMSZNBMYSSpbWnHlKMQ/hg4=; b=O0DRRuKMwZ85FCmg3avvnBze1wc8BhbLpp/Up0uyO7c3fyu5ve6DXIESE0lPIAakC3 bkdtFKHS+5UxfsciCTJkhVv2LFTPGoSphxKQMsRpw+sF0/hamwCbOELce3v/kbEA913B 3gyu0zKwk+5DoeTRdTxJxVDsonPFv2v3sJsW6wiYSb4ISZXpAZccjhQcDDN0AT/JUxc4 f0UF1DqmkxVE4PpnZ3PKfBd9xBF6eQlBXBhfkliQeODODxHRyK+c9nKevr+bc0YDUD6G SbZFxDMk6PXPfBSq2WQ4cjE8FaToYThxT/A04kgEiEufcRPnVCzuO/p0gfIdctPPCLnL BmlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=JqO/x+Nf0MtY5sHGS5SLZMSZNBMYSSpbWnHlKMQ/hg4=; b=Z4odrPHtc22cPqYTrExglALmBP2G/ApEnyorBhjCKFRD2vWIPbG33eIEmDFzTg/5Gl wtN89+DqEt5odmaoSFduM1k3cqHyGeyemRwBRcgrdPJm6de2OlEFGZslwitqRa6Ujrt4 Ncxu1c/gXbYJX0rsFp8JLvg6ei9GMvpV/kD5BxSnOawKLaOGLB4vt0Lk7mnZN+X/w81F EoS4uJxuulkj/+tVQWVWM4H8pvVMokwSfeETnfAxw2kQ99fWvNNNk5HnOSlz/YO16Yvs tenTmObjO8UW7YIk7walEi/GVQ6vu5YLkNm4hM4iCC1rkeHw2HRZQslliCUsuy2kxb7C nnRA== X-Gm-Message-State: AEkoousDoz2BFl6YiW6TSPCLAi3q5tLh4r4XtvO3ztaZs20eINFR45RHlVE+ceU6ULyuMstHLbOFh0XcK9BuBQ== X-Received: by 10.176.80.200 with SMTP id d8mr19194906uaa.90.1471408799562; Tue, 16 Aug 2016 21:39:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.80.143 with HTTP; Tue, 16 Aug 2016 21:39:39 -0700 (PDT) In-Reply-To: References: From: Jim Meyering Date: Tue, 16 Aug 2016 21:39:39 -0700 X-Google-Sender-Auth: SJZ2H5Sn2_ADZLaoIX2Ya3XU_m0 Message-ID: Subject: Re: bug#24243: fix for pcre-jitstack failure on Mac OS X To: Jack Howarth Content-Type: multipart/mixed; boundary=94eb2c1911dad158a0053a3d0e98 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24243 Cc: 24243@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c1911dad158a0053a3d0e98 Content-Type: text/plain; charset=UTF-8 On Tue, Aug 16, 2016 at 8:14 AM, Jack Howarth wrote: > The pcre-jitstack test case fails on Mac OS X due to the system base64 > expecting either '-D or --decode' rather than '-d or --decode'. The > trivial fix is to use the common '--decode' option rather than '-d'... > > diff -uNr grep-2.25/tests/pcre-jitstack grep-2.25-patched/tests/pcre-jitstack > --- grep-2.25/tests/pcre-jitstack 2016-01-01 17:45:41.000000000 -0500 > +++ grep-2.25-patched/tests/pcre-jitstack 2016-08-16 > 10:53:58.000000000 -0400 > @@ -17,7 +17,7 @@ > > fail=0 > > -base64 -d >pcrejit.txt.gz <<'EOF' > +base64 --decode >pcrejit.txt.gz <<'EOF' Thank you for the report and the patch. However, there are plenty of systems for which base64 --decode would not work either, so I've done this, which should work on a superset: tests: avoid unnecessary "skip" without base64 -d support * tests/pcre-jitstack: Try harder to find a base64 decoder: Try 'base64 -d', 'base64 -D', 'openssl base64 -d' and perl's MIME::Base64 decode_base64. The old code would skip at least on OS X, for which base64 expects -D or --decode. Reported by Jack Howarth in http://bugs.gnu.org/24243. --94eb2c1911dad158a0053a3d0e98 Content-Type: text/plain; charset=US-ASCII; name="grep-test-vs-base64-d.diff" Content-Disposition: attachment; filename="grep-test-vs-base64-d.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iryer9jr0 RnJvbSA1NzU2ZmY5N2FhOWUwMDQ4ZmNhZWYwOTMzMjliMjdiYzY0YTkzZTg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog VHVlLCAxNiBBdWcgMjAxNiAyMTozNTowMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHRlc3RzOiBh dm9pZCB1bm5lY2Vzc2FyeSAic2tpcCIgd2l0aG91dCBiYXNlNjQgLWQgc3VwcG9ydAoKKiB0ZXN0 cy9wY3JlLWppdHN0YWNrOiBUcnkgaGFyZGVyIHRvIGZpbmQgYSBiYXNlNjQgZGVjb2RlcjoKVHJ5 ICdiYXNlNjQgLWQnLCAnYmFzZTY0IC1EJywgJ29wZW5zc2wgYmFzZTY0IC1kJyBhbmQgcGVybCdz Ck1JTUU6OkJhc2U2NCBkZWNvZGVfYmFzZTY0LiAgVGhlIG9sZCBjb2RlIHdvdWxkIHNraXAgYXQg bGVhc3Qgb24KT1MgWCwgZm9yIHdoaWNoIGJhc2U2NCBleHBlY3RzIC1EIG9yIC0tZGVjb2RlLgpS ZXBvcnRlZCBieSBKYWNrIEhvd2FydGggaW4gaHR0cDovL2J1Z3MuZ251Lm9yZy8yNDI0My4KLS0t CiB0ZXN0cy9wY3JlLWppdHN0YWNrIHwgMjAgKysrKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rl c3RzL3BjcmUtaml0c3RhY2sgYi90ZXN0cy9wY3JlLWppdHN0YWNrCmluZGV4IGJkYWUzN2IuLjAw MDA5MDIgMTAwNzU1Ci0tLSBhL3Rlc3RzL3BjcmUtaml0c3RhY2sKKysrIGIvdGVzdHMvcGNyZS1q aXRzdGFjawpAQCAtMTAsMTQgKzEwLDIyIEBACiAuICIke3NyY2Rpcj0ufS9pbml0LnNoIjsgcGF0 aF9wcmVwZW5kXyAuLi9zcmMKIHJlcXVpcmVfcGNyZV8KCi1ubF9iYXNlNjQ9JChlY2hvIHwgKGJh c2U2NCkgMj4vZGV2L251bGwpICYmIHRlc3QgIlgkbmxfYmFzZTY0IiA9IFhDZz09IHx8Ci0gIHNr aXBfICJ5b3VyIHN5c3RlbSBsYWNrcyB0aGUgYmFzZTY0IHByb2dyYW0iCi1mb289JCggKGVjaG8g Zm9vIHwgZ3ppcCB8IGd6aXAgLWQpIDI+L2Rldi9udWxsKSAmJiB0ZXN0ICJYJGZvbyIgPSBYZm9v IHx8Ci0gIHNraXBfICJ5b3VyIHN5c3RlbSBsYWNrcyB0aGUgZ3ppcCBwcm9ncmFtIgorZm9yIHAg aW4gJ2Jhc2U2NCAtZCcgJ2Jhc2U2NCAtRCcgJ29wZW5zc2wgYmFzZTY0IC1kJyBcCisgICAgICAi cGVybCAtTU1JTUU6OkJhc2U2NCAtMDc3N25lICdwcmludCBkZWNvZGVfYmFzZTY0KFwkXyknIiBG QUlMOyBkbworICAgIHRlc3QgIiRwIiA9IEZBSUwgJiYgc2tpcF8gInlvdXIgc3lzdGVtIGxhY2tz IGEgYmFzZTY0IGRlY29kZXIiCisgICAgeD0kKGVjaG8gZUE9PXwgKCBzZXQgLXg7IGV2YWwgIiRw IiApIDI+L2Rldi9udWxsKSAmJiB0ZXN0ICJYJHgiID0gWHggJiYKKyAgICAgIHsKKyAgICAgICAg ZXZhbCAiYjY0X2RlY29kZSgpIHsgJHA7IH0iCisgICAgICAgIGJyZWFrCisgICAgICB9Citkb25l CisKK2Zvbz0kKCAoZWNobyBmb28gfCBnemlwIHwgZ3ppcCAtZCkgMj4vZGV2L251bGwpICYmIHRl c3QgIlgkZm9vIiA9IFhmb28gXAorICB8fCBza2lwXyAieW91ciBzeXN0ZW0gbGFja3MgdGhlIGd6 aXAgcHJvZ3JhbSIKCiBmYWlsPTAKCi1iYXNlNjQgLWQgPnBjcmVqaXQudHh0Lmd6IDw8J0VPRicK K2I2NF9kZWNvZGUgPnBjcmVqaXQudHh0Lmd6IDw8J0VPRicKIEg0c0lBQUFBQUFBQ0ErMmJVVTRE TVF4RS83bU16NVQ3WHdLRStJQktWTHVlNTh5azBCOUV0WDZ4SnhON3Q0VmFINjlhNit0SHJXKy8K IHI0ZTNuNzVLQVJXU2hTT0ZUdGl1bUUzRlBWeW83OUFUSUowUnkwTm8veVhlOTlVSVVxVEdLS1V6 WUhGSkhKb2FDT05RRENuRFNDRFMKIElQQXZHQ1ZlWE5zWjdscGJXRmZkYVp0Z1BvczVMZUsyQzFU Qkt6RDA5VjNIRmxDT3NiRlQvaE5iejRIekphUmpuamRhbTlGWHcvbzYKQEAgLTM2LDcgKzQ0LDcg QEAgZ3ppcCAtZCBwY3Jlaml0LnR4dCB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KIExDX0FMTD1DIGdy ZXAgLVAgLW4gJ14oWy9dKD8hLyl8W14vXSkqfi8uKicgcGNyZWppdC50eHQKIGlmIHRlc3QgJD8g IT0gMTsgdGhlbgogICAgICMgVGhlIGFib3ZlIG9mdGVuIG1ha2VzIGdyZXAgYXR0ZW1wdCB0byB1 c2UgYW4gaW5vcmRpbmF0ZSBhbW91bnQKLSAgICAjIG9mIHN0YWNrIHNwYWNlLiAgSWYgZ3JlcCBm YWlscyB3aXRoICQ/ICE9IDEsIHRyeSBnYWluLCBidXQgdGhpcworICAgICMgb2Ygc3RhY2sgc3Bh Y2UuICBJZiBncmVwIGZhaWxzIHdpdGggJD8gIT0gMSwgdHJ5IGFnYWluLCBidXQgdGhpcwogICAg ICMgdGltZSB3aXRoIG5vIHNvZnQgbGltaXQ6CgogICAgICMgVXNlIHVsaW1pdCB0byByZW1vdmUg dGhhdCBsaW1pdCwgaWYgcG9zc2libGUuCi0tIAoyLjguMC1yYzIKCg== --94eb2c1911dad158a0053a3d0e98-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 16:17:32 2016 Received: (at 24243) by debbugs.gnu.org; 17 Aug 2016 20:17:32 +0000 Received: from localhost ([127.0.0.1]:60545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba7HE-0002L4-6j for submit@debbugs.gnu.org; Wed, 17 Aug 2016 16:17:32 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:33638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba7H8-0002Kl-I4 for 24243@debbugs.gnu.org; Wed, 17 Aug 2016 16:17:26 -0400 Received: by mail-ua0-f193.google.com with SMTP id u13so12367650uau.0 for <24243@debbugs.gnu.org>; Wed, 17 Aug 2016 13:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jefU4LlzsLWd8lj5XdUGehXcNk085ldRoMRqrGDoCVU=; b=YxywWlKP3QsSQRQCBeI8JAlWCn/d82oFw3j5rIlvXLGDmQ5H4oFIb8CDq8qLVeZC/Y 5ygANJltkdQ1p69Gncxo+q6CqFJBtRG8n3CNt+2oNOLIV2UZYTHx9WSY+0eq3edFnd9I FwtO8OYortUEQH/SiIKyfQZ/ZKEb/hCKjPZHztnXfwCvxi3+WiaKslSyOsfxlikVUx5N rlCm5vL44hA7a2G6elFZUsCPVc8M/wJvf89pkzltqBCnNkPTL/gskKDFfmY3ahbqUUet wwuprbiVPLxU8p27YqIXweJg77Rnn+yNxrXJXCMALMpX3uFpLQftGQSvWejQyI5+jLuH vVqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jefU4LlzsLWd8lj5XdUGehXcNk085ldRoMRqrGDoCVU=; b=WC5z7hOKOwAkUrvx1xQfzA2iDGkn1P/WZMW0BDrZ4G5FzGQAHbHGRW3rlpBVmFBFH9 z34Ydnl7SRVcFpFv115QikQ6wpM+ietYQ3mw6ASJ2I3eDnzqezZvJMWl6f3TYKs+Mkab nIUqybUyOxWeUWDR3KkwK4WKzaypBU24gxUl70+cTZ46CETDfr0T5Ha0VjlKPzS2edrn 6x3qHN8t1sQVSSKCaCwE3PX8aQoGUTxvzGpG2n0YyXSbbzTKwEcoS45Sauz3p971OZgv HQPvjGRFpn2xT94yE/TD5WuJK/Cx44mKg8UrII707HpBPR7hyqLutr0jisCsZkJsJkAo VIWA== X-Gm-Message-State: AEkoouuVKxCV1R/Z12QaVdAz+zFBmbkAGHaIW8+QTo61icR4RqebAUqnFRPebdP15jn5Yc/3uI5XYyKiDHcP1Q== X-Received: by 10.31.148.147 with SMTP id w141mr2261861vkd.1.1471465036933; Wed, 17 Aug 2016 13:17:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.80.143 with HTTP; Wed, 17 Aug 2016 13:16:56 -0700 (PDT) In-Reply-To: References: From: Jim Meyering Date: Wed, 17 Aug 2016 13:16:56 -0700 X-Google-Sender-Auth: thKRkQGUkQZnj312JHV9WE3apnI Message-ID: Subject: Re: bug#24243: fix for pcre-jitstack failure on Mac OS X To: Jack Howarth Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24243 Cc: 24243@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Aug 16, 2016 at 9:39 PM, Jim Meyering wrote: > On Tue, Aug 16, 2016 at 8:14 AM, Jack Howarth > wrote: >> The pcre-jitstack test case fails on Mac OS X due to the system base64 >> expecting either '-D or --decode' rather than '-d or --decode'. The >> trivial fix is to use the common '--decode' option rather than '-d'... >> >> diff -uNr grep-2.25/tests/pcre-jitstack grep-2.25-patched/tests/pcre-jitstack >> --- grep-2.25/tests/pcre-jitstack 2016-01-01 17:45:41.000000000 -0500 >> +++ grep-2.25-patched/tests/pcre-jitstack 2016-08-16 >> 10:53:58.000000000 -0400 >> @@ -17,7 +17,7 @@ >> >> fail=0 >> >> -base64 -d >pcrejit.txt.gz <<'EOF' >> +base64 --decode >pcrejit.txt.gz <<'EOF' > > Thank you for the report and the patch. > However, there are plenty of systems for which base64 --decode would > not work either, so I've done this, which should work on a superset: > > tests: avoid unnecessary "skip" without base64 -d support > > * tests/pcre-jitstack: Try harder to find a base64 decoder: > Try 'base64 -d', 'base64 -D', 'openssl base64 -d' and perl's > MIME::Base64 decode_base64. The old code would skip at least on > OS X, for which base64 expects -D or --decode. > Reported by Jack Howarth in http://bugs.gnu.org/24243. Pushed. Before pushing, I adjusted the commit log to reflect that this avoids a false failure, not a skip. Also adjusted the patch slightly and included a little more clean-up in the vicinity. I also pushed a separate fix to avoid a new "make syntax-check" failure. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 16:54:45 2016 Received: (at 24243-done) by debbugs.gnu.org; 17 Aug 2016 20:54:45 +0000 Received: from localhost ([127.0.0.1]:60566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba7rJ-0003Dz-6T for submit@debbugs.gnu.org; Wed, 17 Aug 2016 16:54:45 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba7rI-0003Dn-8x for 24243-done@debbugs.gnu.org; Wed, 17 Aug 2016 16:54:44 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DF6FF161325; Wed, 17 Aug 2016 13:54:38 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MY2wEu4sZkok; Wed, 17 Aug 2016 13:54:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3BB9F16132A; Wed, 17 Aug 2016 13:54:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TDD8ZFIcAhVQ; Wed, 17 Aug 2016 13:54:38 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 13DA2161326; Wed, 17 Aug 2016 13:54:38 -0700 (PDT) Subject: Re: bug#24243: fix for pcre-jitstack failure on Mac OS X To: Jim Meyering , Jack Howarth References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Wed, 17 Aug 2016 13:54:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 24243-done Cc: 24243-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Thanks for doing all that, Jim. I'm closing the bug report. From unknown Mon Jun 23 15:00:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Sep 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator