GNU bug report logs - #24238
25.1.50; error in capf in sh-script if imenu-index is empty

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24238 in the body.
You can then email your comments to 24238 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; error in capf in sh-script if imenu-index is empty  
Date: Mon, 15 Aug 2016 20:19:16 +0200

[Message part 1 (text/plain, inline)]

The completion function sh--cmd-completion-table in sh-script.el may use
imenu--make-index-alist to create a list of candidates.  But this
function signals the error imenu-unavailable, if the index is empty.
This is a commonly the case, e.g. if the scripts is new.

Solution: Catch the error condition.

[sh-script.diff (text/x-diff, inline)]

diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 7a9e6c7..5d362e4 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1744,7 +1744,10 @@ sh--vars-before-point
 (defun sh--cmd-completion-table (string pred action)
   (let ((cmds
          (append (when (fboundp 'imenu--make-index-alist)
-                   (mapcar #'car (imenu--make-index-alist)))
+                   (mapcar #'car
+                           (condition-case nil
+                               (imenu--make-index-alist)
+                             (imenu-unavailable nil))))
                  (mapcar (lambda (v) (concat v "="))
                          (sh--vars-before-point))
                  (locate-file-completion-table

[Message part 3 (text/plain, inline)]

-ap

Message #8 received at 24238 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andreas Politz <politza <at> hochschule-trier.de>, 24238 <at> debbugs.gnu.org
Subject: Re: bug#24238: 25.1.50; error in capf in sh-script if imenu-index is
 empty
Date: Sun, 16 Oct 2016 12:02:15 +0300

On 15.08.2016 21:19, Andreas Politz wrote:
>
> The completion function sh--cmd-completion-table in sh-script.el may use
> imenu--make-index-alist to create a list of candidates.  But this
> function signals the error imenu-unavailable, if the index is empty.
> This is a commonly the case, e.g. if the scripts is new.
>
> Solution: Catch the error condition.

Looks good to me. Do you have commit access?

Message #11 received at 24238 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 24238 <at> debbugs.gnu.org
Subject: Re: bug#24238: 25.1.50;
 error in capf in sh-script if imenu-index is empty
Date: Sun, 16 Oct 2016 13:29:41 +0200

No, I don't.

Message #16 received at 24238-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andreas Politz <politza <at> hochschule-trier.de>
Cc: 24238-done <at> debbugs.gnu.org
Subject: Re: bug#24238: 25.1.50; error in capf in sh-script if imenu-index is
 empty
Date: Sun, 16 Oct 2016 16:57:11 +0300

Version: 25.2

On 16.10.2016 14:29, Andreas Politz wrote:
>
> No, I don't.

OK, I pushed it to emacs-25. Thanks for the patch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.