GNU bug report logs - #24232
ls --color cannot be interrupted by a signal

Previous Next

Full log

Message #28 received at 24232 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 24232 <at> debbugs.gnu.org, Kamil Dudka <kdudka <at> redhat.com>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#24232: [PATCH] ls: postpone installation of signal handlers
Date: Tue, 6 Sep 2016 10:18:45 -0700

On Tue, Sep 6, 2016 at 10:05 AM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> On 09/06/2016 08:59 AM, Pádraig Brady wrote:
>>
>> Will push later.
>
>
> Before pushing, can you please change the name of "sigs" back to "sig"? I
> prefer the old name, as "sig[i]" clearly means "signal i", whereas "sigs[i]"
> is more confusing. (This is one of my pet peeves about array names.) Thanks.

I agree.
A good argument for "why?" is that we optimize for readability of the
more frequent use with an index, sig[i], rather than for the sole
declaration, or the less frequent uses of the array name without an
index.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.