GNU bug report logs - #24227
new snapshot available: diffutils-3.4.8-c06c

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24227 in the body.
You can then email your comments to 24227 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-diffutils <at> gnu.org
Cc: TP coordinator <coordinator <at> translationproject.org>,
 platform-testers <at> gnu.org
Subject: new snapshot available: diffutils-3.4.8-c06c
Date: Sun, 14 Aug 2016 18:30:35 -0700

I expect to make a new release soon, so please test this snapshot.

Other than the two bug fixes, this also includes new dash-excluding
code in init.sh's shell-selection logic, so let us know if you find a
system for which /bin/dash was the only usable shell for
diffutils-3.4. Now, that code will find no usable shell and "skip"
nearly all tests.

================================
Here are the two NEWS entries-to-be for the upcoming diffutils-3.5:

** Bug fixes

  diff3 no longer malfunctions due to use-after-free [bug introduced in 3.4]
  diff --color no longer colorizes when TERM=dumb

================================
diffutils snapshot:
  http://meyering.net/diff/diffutils-ss.tar.xz      1.4 MB
  http://meyering.net/diff/diffutils-ss.tar.xz.sig
  http://meyering.net/diff/diffutils-3.4.8-c06c.tar.xz

Changes in diffutils since v3.4:

Bastian Beischer (1):
      diff3: fix heap use-after-free; add minimal diff3 test coverage

Jim Meyering (7):
      maint: post-release administrivia
      diff: disable colorization for TERM=dumb
      maint: diff3: remove an unreachable statement
      build: ignore texinfo build artifacts
      maint: require that commit messages be of a certain form
      diff3: fix leaks, for real
      gnulib: update to latest


Changes in gnulib since v3.4:

* gnulib e4f1a4a...1eb82ad (5):
  > update from texinfo
  > parse-datetime: add optional debug printing
  > update from texinfo
  > tests/init.sh: exclude dash with bad "local" semantics
  > update from texinfo

Message #8 received at 24227 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 24227 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#24227: new snapshot available:
 diffutils-3.4.8-c06c
Date: Sun, 14 Aug 2016 23:16:51 -0400

[Message part 1 (text/plain, inline)]

Hello,

> On Aug 14, 2016, at 21:30, Jim Meyering <jim <at> meyering.net> wrote:
> 
> http://meyering.net/diff/diffutils-3.4.8-c06c.tar.xz

On AIX, SunOS 5.10, OpenBSD-5.8, the 'diff3' test fails, likely due to missing 'seq'.
Log attached (for one of them).

Otherwise, no failures on:
  Mac OS X, 10.9.5, 10.10.4,
  Fedora 20 (ppc64), 21 (ppc64le)
  Fedora 24, 23, 22 (x86_64)
  Ubuntu 14.05, 15.04
  CentOS 7.0, 6.5
  Debian 8.1, 7.6
  FreeBSD 10.3, 9.3
  SUSE 42.1
  GNU Hurd 0.7
  OpenSolaris 5.11 (sparc, i86pc)
  Trisquel 7.0, 6.0.1

regards,
 - assaf

[test-suite.0.log (application/octet-stream, attachment)]

Message #11 received at 24227 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 24227 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#24227: new snapshot available:
 diffutils-3.4.8-c06c
Date: Sun, 14 Aug 2016 22:21:38 -0700

On Sun, Aug 14, 2016 at 8:16 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> Hello,
>
>> On Aug 14, 2016, at 21:30, Jim Meyering <jim <at> meyering.net> wrote:
>>
>> http://meyering.net/diff/diffutils-3.4.8-c06c.tar.xz
>
> On AIX, SunOS 5.10, OpenBSD-5.8, the 'diff3' test fails, likely due to missing 'seq'.
> Log attached (for one of them).
>
> Otherwise, no failures on:
>   Mac OS X, 10.9.5, 10.10.4,
>   Fedora 20 (ppc64), 21 (ppc64le)
>   Fedora 24, 23, 22 (x86_64)
>   Ubuntu 14.05, 15.04
>   CentOS 7.0, 6.5
>   Debian 8.1, 7.6
>   FreeBSD 10.3, 9.3
>   SUSE 42.1
>   GNU Hurd 0.7
>   OpenSolaris 5.11 (sparc, i86pc)
>   Trisquel 7.0, 6.0.1

Wow. Great. Thanks for such quick and thorough testing.
missing seq is indeed the cause. It should be easy to work around the
lack of seq: I'll simply include this replacement function from gzip's
tests/zgrep-context:

# A limited replacement for seq: handle 1 or 2 args; increment must be 1
seq()
{
  case $# in
    1) start=1  final=$1;;
    2) start=$1 final=$2;;
    *) echo you lose 1>&2; exit 1;;
  esac
  awk 'BEGIN{for(i='$start';i<='$final';i++) print i}' < /dev/null
}

Message #14 received at 24227 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 24227 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#24227: new snapshot available:
 diffutils-3.4.8-c06c
Date: Sun, 14 Aug 2016 22:27:50 -0700

[Message part 1 (text/plain, inline)]

On Sun, Aug 14, 2016 at 10:21 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Sun, Aug 14, 2016 at 8:16 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
>> Hello,
>>
>>> On Aug 14, 2016, at 21:30, Jim Meyering <jim <at> meyering.net> wrote:
>>>
>>> http://meyering.net/diff/diffutils-3.4.8-c06c.tar.xz
>>
>> On AIX, SunOS 5.10, OpenBSD-5.8, the 'diff3' test fails, likely due to missing 'seq'.
>> Log attached (for one of them).
>>
>> Otherwise, no failures on:
>>   Mac OS X, 10.9.5, 10.10.4,
>>   Fedora 20 (ppc64), 21 (ppc64le)
>>   Fedora 24, 23, 22 (x86_64)
>>   Ubuntu 14.05, 15.04
>>   CentOS 7.0, 6.5
>>   Debian 8.1, 7.6
>>   FreeBSD 10.3, 9.3
>>   SUSE 42.1
>>   GNU Hurd 0.7
>>   OpenSolaris 5.11 (sparc, i86pc)
>>   Trisquel 7.0, 6.0.1
>
> Wow. Great. Thanks for such quick and thorough testing.
> missing seq is indeed the cause. It should be easy to work around the
> lack of seq: I'll simply include this replacement function from gzip's
> tests/zgrep-context:
>
> # A limited replacement for seq: handle 1 or 2 args; increment must be 1
> seq()
> {
>   case $# in
>     1) start=1  final=$1;;
>     2) start=$1 final=$2;;
>     *) echo you lose 1>&2; exit 1;;
>   esac
>   awk 'BEGIN{for(i='$start';i<='$final';i++) print i}' < /dev/null
> }

Here's the patch.
New snapshot in a moment.

[diff3-test-vs-seq.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.