GNU bug report logs - #24213
25.1.50; Fishy use of delete-window in register.el

Previous Next

Package: emacs;

Reported by: Andreas Politz <politza <at> hochschule-trier.de>

Date: Fri, 12 Aug 2016 20:23:02 UTC

Severity: wishlist

Tags: fixed, patch

Found in version 25.1.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 24213 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Andreas Politz <politza <at> hochschule-trier.de>, Leo Liu <sdl.web <at> gmail.com>
Cc: 24213 <at> debbugs.gnu.org
Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el
Date: Sat, 13 Aug 2016 10:25:24 +0200
> Maybe the documentation of delte-window should be amended, stating that
> it is almost always preferable to use quit-window instead;

‘delete-window’ is primarily a command bound to C-x 0.  It should be
used only sparingly in Elisp code.  Nevertheless, I think that any
advice to use ‘quit-window’ instead should go to the ‘display-buffer’
group functions because ‘quit-window’ (now) inherently belongs there.

> unless the
> window was created by using primitives like split-window.

‘split-window’ should not be used in Elisp code either unless it's done
on a separate, special purpose frame.  Standard settings are usually too
restrictive to make ‘split-window’ behave decently.

martin





This bug report was last modified 5 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.