From unknown Thu Aug 14 18:37:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24213 <24213@debbugs.gnu.org> To: bug#24213 <24213@debbugs.gnu.org> Subject: Status: 25.1.50; Fishy use of delete-window in register.el Reply-To: bug#24213 <24213@debbugs.gnu.org> Date: Fri, 15 Aug 2025 01:37:41 +0000 retitle 24213 25.1.50; Fishy use of delete-window in register.el reassign 24213 emacs submitter 24213 Andreas Politz severity 24213 wishlist tag 24213 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 16:22:35 2016 Received: (at submit) by debbugs.gnu.org; 12 Aug 2016 20:22:35 +0000 Received: from localhost ([127.0.0.1]:55451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYIyQ-0001xr-RY for submit@debbugs.gnu.org; Fri, 12 Aug 2016 16:22:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYIyO-0001xd-Nb for submit@debbugs.gnu.org; Fri, 12 Aug 2016 16:22:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYIyH-0006rk-Bk for submit@debbugs.gnu.org; Fri, 12 Aug 2016 16:22:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYIyH-0006rZ-8e for submit@debbugs.gnu.org; Fri, 12 Aug 2016 16:22:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYIyF-0000ES-6F for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 16:22:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYIyB-0006rG-5A for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 16:22:23 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:46200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYIyA-0006qx-Rt for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 16:22:19 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (ip5f5bdf4d.dynamic.kabel-deutschland.de [95.91.223.77]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id A0FCE17983A9 for ; Fri, 12 Aug 2016 22:22:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1471033325; bh=sJl9r0FSAHv6xQ6mre4blAgpLCE=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=hpRLzABFfDbHKNF8Z4rVCizepZL2PY2CBOwpAqFtnafbcOE+U6ZX0ihoxcwLmjLSB qSySp35lLXGnGCxdLnB6kkJd/ErVNj9fayIj+7ZXzhxlqIVDttYb/vnRzXQnJZhkhQ mjChZ+RX+giZ4qysmngePrxOG37pDpdwlZRf7uDs= From: Andreas Politz To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Fishy use of delete-window in register.el Date: Fri, 12 Aug 2016 22:22:05 +0200 Message-ID: <87mvkhivpu.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The register.el commands display a preview of register contents, using display-buffer in register-preview. Later, when some register was chosen by the user, the window showing this preview is closed via delete-window. It seems to me, that this call should be replaced by a call to quit-window, because this function does the right thing: It only deletes the window if it was previously created and otherwise shows the previous buffer in that window. If that analysis can be agreed upon: Grepping through lisp/*, I found 62 uses of delete-window outside window.el. I assume that most of those applications are problematic in the same way (e.g. finder.el). -Andreas From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 22:40:04 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 02:40:04 +0000 Received: from localhost ([127.0.0.1]:55618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYOrk-0000ae-JW for submit@debbugs.gnu.org; Fri, 12 Aug 2016 22:40:04 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYOri-0000a4-Sd for 24213@debbugs.gnu.org; Fri, 12 Aug 2016 22:40:03 -0400 Received: by mail-wm0-f47.google.com with SMTP id i5so6090697wmg.0 for <24213@debbugs.gnu.org>; Fri, 12 Aug 2016 19:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=CY6E8YxDberqoHNwS3X0v+QjPRyrkaceyOK4KB+Yebw=; b=szxX+ADMRv9MtbQXQ4RmlTvThokJ0t/M8xn/iR0+nZk8jTvt7RrASjalQoyn2JRL2W k2T9fvZQJlFSASOet7qgcfcwo1lB2cd5rRWM2t8o0wpSW926bNDNl9u9zyUuuSuBrUfn UEhvxMVFQl5Xa5d7e0vBpDYhNKovl3MoFUSW3cTR6IRk988GofTOGjR2WjT0f5/5CuMd EGDnLtqMSHh3gJCzqVljlt5kNQPVLW4ZV2p5VPqCPvXxjXlAg0ae+09cnvnZi4ztHJNU WCpY1ojyZbxmY2SbiH4yRJrJhIquUCkYd0uP2u/+tcy70dkRVaK9Z0fq9mJGogsTC25V Xrlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=CY6E8YxDberqoHNwS3X0v+QjPRyrkaceyOK4KB+Yebw=; b=djLOPInVO5vpLJDBlEzG7nL46nOhzK900EttKv283q2W9TIgxk1kORN2hRKtr+us+i JPqq1IMcbq4esH1DlyrFHMUXX2P5ULNrrBnC0eiw0iR2Yug379pmQYQsWOZFlxphvLcE 6x10YA1jMVXg0sagJtHFPoNeWVajWXj8eeFy+WmKs4T6fR+EMjjSo2ALemIxF8WllDQp Nip2mcYzioH0BYCfIsHO9UQWIPmSXtHqo8vF/TTQdocxnk5UzttKX/1Q+5fglX3QEdBQ C3+bavOELkk1gOZC/GzBBlpj3LErEzhyev8Apr4gF6IP0UF896z55frCUSVzUQkmiI51 lbnw== X-Gm-Message-State: AEkoousFHp1hHKzVIORSueynVYxGawgeSePwfwVjCSfdOLEPNeIyJA8mDAki85DhQcJ0cw== X-Received: by 10.28.223.9 with SMTP id w9mr1626129wmg.65.1471055996848; Fri, 12 Aug 2016 19:39:56 -0700 (PDT) Received: from zeuss-MacBook-Pro.local ([46.101.90.246]) by smtp.gmail.com with ESMTPSA id gg10sm10008533wjd.4.2016.08.12.19.39.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Aug 2016 19:39:56 -0700 (PDT) From: Leo Liu To: Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Sat, 13 Aug 2016 10:39:49 +0800 In-Reply-To: <87mvkhivpu.fsf@hochschule-trier.de> (Andreas Politz's message of "Fri, 12 Aug 2016 22:22:05 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (OS X 10.11.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24213 Cc: Martin Rudalics , 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-08-12 22:22 +0200, Andreas Politz wrote: > The register.el commands display a preview of register contents, using > display-buffer in register-preview. Later, when some register was > chosen by the user, the window showing this preview is closed via > delete-window. The window is created by `display-buffer-below-selected' so we know its ours and thus delete-window is technically safe here. Use quit-window/quit-windows-on is ok as well for being defensive. Martin, it seems the documentation of display-buffer-below-selected isn't clear that it only reuses a window if it displays BUFFER already. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 02:44:19 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 06:44:19 +0000 Received: from localhost ([127.0.0.1]:55645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYSg7-0006bC-I3 for submit@debbugs.gnu.org; Sat, 13 Aug 2016 02:44:19 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:58038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYSg5-0006aw-KN for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 02:44:18 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (ip5f5bdf4d.dynamic.kabel-deutschland.de [95.91.223.77]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 5686C1798BFF; Sat, 13 Aug 2016 08:44:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1471070640; bh=9tQPEI/kTxjYSwyTqvGSdN1RQWI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=aG1JbxOolM1ZvpC2xCoSG+85SnEpZgWg9+Wx5uJcVxxoAJHapAnjv1lhqVrasGWa5 ZkF9E2LSE3Q1EbyRLeNco8vCNgUzMZcsZkzzvhPnV3Owu8jvwCEB8Mj9jullXDFE7k ldl4Mjm8/Dnt1GBgavOyL2BlBG79t1nl3nR2aA98= From: Andreas Politz To: Leo Liu Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> Date: Sat, 13 Aug 2016 08:43:59 +0200 In-Reply-To: (Leo Liu's message of "Sat, 13 Aug 2016 10:39:49 +0800") Message-ID: <87d1ldkw28.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 24213 Cc: Martin Rudalics , 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Leo Liu writes: > The window is created by `display-buffer-below-selected' so we know its > ours [...] No, the window is created by display-buffer, which is not obligated to use it's action argument, e.g. if the buffer triggers a match in display-buffer-alist. Maybe the documentation of delte-window should be amended, stating that it is almost always preferable to use quit-window instead; unless the window was created by using primitives like split-window. Thanks, Andreas From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 04:24:42 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 08:24:43 +0000 Received: from localhost ([127.0.0.1]:55698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFG-0000Zh-N4 for submit@debbugs.gnu.org; Sat, 13 Aug 2016 04:24:42 -0400 Received: from mout.gmx.net ([212.227.15.18]:50053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFF-0000ZU-9O for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 04:24:41 -0400 Received: from [192.168.1.100] ([212.95.7.38]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MCcvy-1bPApo2jAI-009OvQ; Sat, 13 Aug 2016 10:24:30 +0200 Message-ID: <57AED93A.4090902@gmx.at> Date: Sat, 13 Aug 2016 10:24:26 +0200 From: martin rudalics MIME-Version: 1.0 To: Andreas Politz , 24213@debbugs.gnu.org Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> In-Reply-To: <87mvkhivpu.fsf@hochschule-trier.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:zu+ov45ETJ9D93eJKI+aAnefl6qtABhZ2xnqazEoic2T2SJnTXt XtJ82BpEL03sfZM+6Z7m63wV14sSKhIOCybfpYRc4/Du2fuRcqiwmSCez9bozjsmKVlTtET Ir/foKe74v5wxvwfyxDhXd11ipGzw2DRFS6s8TMuuCalGBm8FZBDTQnNwSL088yHZyhCoos /4grPKTKfndw3I5QbN4xA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Gq2FHZG47VM=:Dmk6emHgnbcrk/ckzGFkSJ 1mZpFZcHO3DtnBDKLvdOGamF9mD6kqVl843a02lWV14pfMbMk0LyVvpET9I2vC0AHWcP+I++w ZIT5a2xzGnyfvrAjNetYf/qkr5NqIz1Q2d9/rBusHecUhghLrN7HiIj9a0r05TYRF+I+HGnjW hRy6IK0tF6/dMfYNAFKKdYgp/iFcAjYQ/XjUkhiq364uCzPgkl8WENJUv/KxpDx50KrmbB0T/ T6Z+Lii5wR/jxEfTNxZne1Du7H73VmlsyVQlotDSfB2bMnTvw4nGTBDAli1k4epvQwruRu4MS 4VhKk7qGzLhiRqL+oxG6oHCHAkDYWt6tLVEco3XjK4Y7lz7x4x/TG7gzLUYNzhyE730KeCx/+ sqtWUb5fflxKvSdCkOSY799PJoWE+4mkmucERkm+CaNFfSWpneuwIkT6el6GxDIJp4148xXgy 8ueA/5VKvv3YC36l9eYurCgpzsWbq/oDfDr5erh/+NpAMv8ub6YUfp5W0V8HJsoxLxlAWfjzY RA2bBMgdsqTdlvgprMc7yC9ndhrC39EuPP7KchnIyyXcRaaw6L8DDNeCHe5kgjTumH5079NvE kJtmyf0oA8ufp0sd3urt6rMACs8yfALD7EIrpB3b49iGOEz4LArVvTTOQSfRlF3ahxgSHp+bb oTrtaad/PvP/bVc7QrFt0F9jRaTZv2/Q67kZeXbPl53p1QVSGnkNExrzTb9ZiMpPuhojioMMs 5F8ML+CUES9lEKPX8t8v5T50pCurVSUbGwD9XVt/se6pKtcKmL7A3C2G/6hLrrU4ZyWj7w37a PC8hsu4BgA4F807QI9pi8YK2keqjg== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 24213 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > The register.el commands display a preview of register contents, using= > display-buffer in register-preview. Later, when some register was > chosen by the user, the window showing this preview is closed via > delete-window. > > It seems to me, that this call should be replaced by a call to > quit-window, because this function does the right thing: It only delet= es > the window if it was previously created and otherwise shows the previo= us > buffer in that window. > > If that analysis can be agreed upon: Grepping through lisp/*, I found = 62 > uses of delete-window outside window.el. I assume that most of those > applications are problematic in the same way (e.g. finder.el). I agree on that analysis. At least for every window created or used by =E2=80=98display-buffer=E2=80=99 the appropriate action should be =E2=80=98= quit-window=E2=80=99. Could you provide a patch fixing the (about ten) most obvious cases first? Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 04:25:01 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 08:25:01 +0000 Received: from localhost ([127.0.0.1]:55702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFY-0000aG-VL for submit@debbugs.gnu.org; Sat, 13 Aug 2016 04:25:01 -0400 Received: from mout.gmx.net ([212.227.15.15]:64497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFX-0000a3-Qf for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 04:25:00 -0400 Received: from [192.168.1.100] ([212.95.7.38]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MTCDO-1bfbmO0gVy-00S5LN; Sat, 13 Aug 2016 10:24:50 +0200 Message-ID: <57AED94E.4020803@gmx.at> Date: Sat, 13 Aug 2016 10:24:46 +0200 From: martin rudalics MIME-Version: 1.0 To: Leo Liu , Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:uexxM2bh5gVY77wGrfS2fmZkyyNrjU56FSEcjpLin+O8/BIpaEW uQbyQQGGNXPs6Rna1eN2XwI4jmM/DSNr4O1gORKnmp+ZoiFBtySNdBsxXBYmbzKI4MMg4Hr Pcocele+dkn1uiBcQjNdiSiZGiEWdW8zEeweS7QpPH4R1qFF07SRKEE+iKioaxynXdaGeOr oF+mh0U+VXsZ795TwU7xg== X-UI-Out-Filterresults: notjunk:1;V01:K0:93mGYnA6oEY=:5WJIkqCmoLq1L+Q8nFFiTv HDHRvcllq4//JKK5SnjXlWyMGA8UJaP6O2mPSjTCgBKHcKSXE2RLnkVzKQLs0aRKpdIqbGlU1 Lqt9WI8prl8+ZGAetfeLvC/KIgDoCQGZ8ZCXl3U5rysREiJvVgpiwnBGJgrg24Li2bf76m0l2 jLSiZgKM+kDkEYdrNHhi2OqYvCRyrbBgSPzRcQRraucFPB+MYq5lxcXQbQFG6pl9GFSIXbea3 h44du0m/s7ieypYterGI1HyIDOeboHEZUjJ2tprRwlZ1gTJzuAYl4GjUYFWi3JmHm5OYO9hoG 5RIkNOYbUav40eytlVPfI3j4jC6Lj3n/n7YO/mRNrB3dzRXrB70oPQ23t/0VFLe2DOTE9V4Rk O+9YRNtX+krWLfcM3SQ6Ow4GI5CNez2KE6W09h7VnXhvoXUECrEGGBZcTvC5K9o31lTIcvXoN y+fx8QYAzjzBHmONrJYngobZS6X2ZVTP7yRLgZYyxylv4e/du94nxwTLxmoKNHiZSuXXO52nj nHpkSqhJJrQqPnIRCW1gqB1yEUxi6SL/EauikphFNiMFz43RSVid7JziMh1ozZp5X2D7NHIkE Oo1JMTFOe5Ag/Iw5wwFO+EmomrUGVguSsB9RfMY97+OIFiX9aMW+uwJoSYXZHV+b8K6Iw37Jw Wu5BKNRscKnadHAD5Ljn1qvLcP7lrW33lh/quJhq5UpgZ+OQuVgZAViUOoZCyGt6t2N59MBxV vEXIXaPxy4g8DJmzD2pPTpnq5gWh15SWxHm7EiBEYMMeaxPtaxxSgTYemLCZ8jLKAggjTTaXV L8vNMTAE5h+7+oTQVUs9gYyOEYnoA== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > The window is created by `display-buffer-below-selected' so we know it= s > ours and thus delete-window is technically safe here. Use > quit-window/quit-windows-on is ok as well for being defensive. > > Martin, > > it seems the documentation of display-buffer-below-selected isn't clea= r > that it only reuses a window if it displays BUFFER already. Indeed. I tried to correct that on master, please have a look. Note that if there is a non-dedicated window below the selected one showing some other buffer, that window may get used and is strictly spoken not "ours". Hopefully, =E2=80=98quit-window=E2=80=99 does not delete it. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 04:25:36 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 08:25:36 +0000 Received: from localhost ([127.0.0.1]:55707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUG8-0000bc-8L for submit@debbugs.gnu.org; Sat, 13 Aug 2016 04:25:36 -0400 Received: from mout.gmx.net ([212.227.15.15]:56453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUG6-0000bQ-9v for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 04:25:34 -0400 Received: from [192.168.1.100] ([212.95.7.38]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lhwt0-1auDoL3a54-00n7nb; Sat, 13 Aug 2016 10:25:27 +0200 Message-ID: <57AED974.4030900@gmx.at> Date: Sat, 13 Aug 2016 10:25:24 +0200 From: martin rudalics MIME-Version: 1.0 To: Andreas Politz , Leo Liu Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <87d1ldkw28.fsf@hochschule-trier.de> In-Reply-To: <87d1ldkw28.fsf@hochschule-trier.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:ggLOO/oRymiyumppfzTN3hRYxVdpdp4aQZS76Na6hcHvqKL+5hm 2fVycxcS4m5Z0GAfKNTEccWeoS5ZcQrAVelNdo+sDS2g6Sy3nrYeU2fxTBGoUoEfqoeBNMF XAJoaGOMFQ+k/1fe7sE766wzGDSgh/C3evSflwVBH821tOklzzkxm11CqgqP+tnDAvYtHDM hINlMCz7UvFvGpSmRiufA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Qd5gAqjaKGc=:8qwmlyyFc6s+c4+1svsuEx YRb7XwVwLnXBmBA0Qe02T20w5l6Ye33LOUrUxguU272H2VcDNmsx7FF6VKz5esCqueeUGojBP x3CYV5+Slu3wjxZ+9Jykuhm383xOR/lFikjGyE7hkRjbGHhpNOTviiFz7DyT+K0MDn/sanNXM x/qWw2goiM1Z4UibJhLIy0iJ/F49mvVTUhsi7pmlPzp+u57a1+54QIILm5G316011QYYIiVXp t5dKG14ssgue4WYpeQ0S8cR3m9dZlB/VLJgIQn8vwisN1RYOzDgUVL0czsiqRVhv7v84yY5IE WFgwF1zBFh+ARVy87JHh3t/gEIHfjna38aefpweLXjq78JhvOgvd8yqmfd02aXuC3Rp7kBTi2 945u8n/sWd0WHits/mraSRWdG0okIVqvksWR/PtR9S/V42Mq4gnaRd2ejR9lfM4Lr/mr+tFEG QBc0ySZQvdHfokbyYfVZ28Nyyju+KlXVjpxqrYGirPbpwl9m8jWbpLnycRZImVki2Sop+NoZX RXlB6uTW9AmJVbpha7RTvypt2gwJKcvNTWr62Q3CqTJPnkS/y4zgmE6E1nnsS7aMnd2MJKnFv DTx1bHDOMaQcXs2kqi5AVZeWYD1rgdVo0wV5z3W+eF52FRZypgjliTPP0tt/RCNaP9Tqe3c8R 9Xs7zu5g/8jmedlzE/gBIDLVgK0v3rm4BhcvMljavBAXKGI6uHpFHBfP8YZ4HvHq4r/A9YD9O 8b8ENnOJCaWqH+UppXxXa6EVbV2Z3LGWLLMt2M+OTbAigEkxvLewXqTbhL9ClkEanabZZ6P6y V1FCc9Ln0JmN1MZ1osuOQjBY4ulrw== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > Maybe the documentation of delte-window should be amended, stating tha= t > it is almost always preferable to use quit-window instead; =E2=80=98delete-window=E2=80=99 is primarily a command bound to C-x 0. I= t should be used only sparingly in Elisp code. Nevertheless, I think that any advice to use =E2=80=98quit-window=E2=80=99 instead should go to the =E2=80= =98display-buffer=E2=80=99 group functions because =E2=80=98quit-window=E2=80=99 (now) inherently be= longs there. > unless the > window was created by using primitives like split-window. =E2=80=98split-window=E2=80=99 should not be used in Elisp code either un= less it's done on a separate, special purpose frame. Standard settings are usually too restrictive to make =E2=80=98split-window=E2=80=99 behave decently. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 04:48:05 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 08:48:05 +0000 Received: from localhost ([127.0.0.1]:55720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUbs-00018Q-Ou for submit@debbugs.gnu.org; Sat, 13 Aug 2016 04:48:04 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:60202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUbr-00017u-5s for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 04:48:03 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (ip5f5bdf4d.dynamic.kabel-deutschland.de [95.91.223.77]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id EC37A17982F3; Sat, 13 Aug 2016 10:47:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1471078066; bh=2LKi8fXqPtO/3B5NQZW0ftRmsVA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=kyXkVmxmaPLYuGcl4qhWLcwPSAYbh35HiDgjyoyw9BgpsFPFMO3AZPKSbVcqB7tUa 2BNPEJxulQSn+RyGv7DH7OMZeFK/CDowPjhUOqAZJvI6DftIJZt4yk2qeBNNoqkqGT dBBLh97daTL7FK6d8aLQAXoKA6h8OC+QkhPv1ONo= From: Andreas Politz To: martin rudalics Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> Date: Sat, 13 Aug 2016 10:47:45 +0200 In-Reply-To: <57AED93A.4090902@gmx.at> (martin rudalics's message of "Sat, 13 Aug 2016 10:24:26 +0200") Message-ID: <878tw1kqby.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) martin rudalics writes: > Could you provide a patch fixing the (about ten) most obvious cases > first? Yes, will do. I'm going to write a series of independent patches each with around 10 substitutions; till it's all done. Would that work for you ? -ap From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 05:50:31 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 09:50:31 +0000 Received: from localhost ([127.0.0.1]:55740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYVaJ-0002bL-1d for submit@debbugs.gnu.org; Sat, 13 Aug 2016 05:50:31 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:35457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYVaH-0002b9-1i for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 05:50:29 -0400 Received: by mail-pf0-f175.google.com with SMTP id x72so3499690pfd.2 for <24213@debbugs.gnu.org>; Sat, 13 Aug 2016 02:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=WuK0RuxZPlLXdBV353xt257s2kVbswXry5u1Y9b/DmI=; b=VXkmvqCQCP6cWveiOZMjyyy9siH3+j5fSQpIoGOZa97xu8rkzZ+Uxi4sgnj8OszW+k 7FHeQc6C+rRWl158Vl7VkVrVxw8OwjOg/sOM1TwZKc2jecYoW6LQHCoCioc7Avdmuh40 iFnAyXA6WSLZCV50jR7+lSa/jVToLypiWem8erwuQfxGou3RjqTLl7EJNRpTkvEjpijm B7S7+q8On5/DfZsy57pGVx1QwOE3Ju0B8vdf902ZeYl93hIxMkjgXsYKqbvTUk+h0XpX mBOTGkPId8RMKOsh3Rzk3XX0HE1dONqqJowumcZnFvOeZd+Mp+iwvXyzLBamCYd2rHLX MRnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=WuK0RuxZPlLXdBV353xt257s2kVbswXry5u1Y9b/DmI=; b=cVlTtM5U9yEH4j+0I7EV8IN4YsxutaYf1KIiqaiDaXgSnT1UB1u+V24sSyHAzL3e30 uUswRncWLnBNb318xsqT2UQ4jfnPiK0K7sCofdc67ffuxDzxtDoGQZoBR+UamjDVbh3B UalSb8AIXg4TwoC8TOyxnbtgg6v0KuyN49WUqTiHTbYlyfH1eyHpuM+43Khx94xLQjcy kGaG3gEYtnVCHLuNiiUX/84lRve+AGXuuERmPZ8rIrafAQpnYhv5s+ZBHqm883tie0tp 0s6etJ/i6Jtj4zKF6yNFbqZhlRPpUao5wnidCTHmJK7n1xtevHkdW1QxI4tyeKGSmNZ2 tyHg== X-Gm-Message-State: AEkooutbvTGMpb3g/bMLEDuPrglBzOKLnGt/vF1EWoP/10ftu19yAMa7IzA+Jp9KfOnRGA== X-Received: by 10.98.216.199 with SMTP id e190mr34942678pfg.123.1471081823019; Sat, 13 Aug 2016 02:50:23 -0700 (PDT) Received: from zeuss-MacBook-Pro.local ([128.199.175.219]) by smtp.gmail.com with ESMTPSA id e187sm18975782pfg.43.2016.08.13.02.50.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Aug 2016 02:50:22 -0700 (PDT) From: Leo Liu To: martin rudalics Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED94E.4020803@gmx.at> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Sat, 13 Aug 2016 17:50:16 +0800 In-Reply-To: <57AED94E.4020803@gmx.at> (martin rudalics's message of "Sat, 13 Aug 2016 10:24:46 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (OS X 10.11.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-08-13 10:24 +0200, martin rudalics wrote: > Indeed. I tried to correct that on master, please have a look. Thanks, the doc looks clear to me. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 06:03:28 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 10:03:28 +0000 Received: from localhost ([127.0.0.1]:55744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYVmq-0002vY-Gs for submit@debbugs.gnu.org; Sat, 13 Aug 2016 06:03:28 -0400 Received: from mout.gmx.net ([212.227.15.19]:56080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYVmo-0002vF-QF for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 06:03:27 -0400 Received: from [192.168.1.100] ([212.95.7.38]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M5cpk-1bItkV0urY-00xcEG; Sat, 13 Aug 2016 12:03:19 +0200 Message-ID: <57AEF063.6070907@gmx.at> Date: Sat, 13 Aug 2016 12:03:15 +0200 From: martin rudalics MIME-Version: 1.0 To: Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> In-Reply-To: <878tw1kqby.fsf@hochschule-trier.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:F944+U+T40zUfu7OS32pXTkgSkgRSRwtGsBF55PCmbWIXb0+1EV NvTkhbTNrgZnu3pigEXdHhoWWui3boFqVpVgcfnVCWoWMfDu6VjtoaocE2ZlbjLRsfz6fwX RcuzhW/nE9ZqD7XC3vEdeGyyKozbtpkJlkOwe8/gmOTH05A3ZxkZH4YwZFOujMyfvcGXJ55 s9ZCDSvoENqmdQRpGLEbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:g1eRLwVfQzY=:rD44RsOuB+B1CdHcKrHVen EB7AiV+qnaZQ1w4dUxg19pPbMNAeQ7gkml/HC6PAngLsY9HisDc13Tbjx84j1Dbb+ofJFfcHZ fz8rJM8LlzhRTRrBspf3p8/FHbLzzBM4Fxqme0u5cbStj2pycaQ9p/sSrFyBFfDF1tkfGa/WU iIX0DwoZ279Xy2fH9wmy6F4tFMMh8rOjC6DbApC5AZUwxiSvU4xs4NU5Z1i6fhwJWY/shHO8s ojgAbXxeUxLvYd8+25sQRHqNQoQsbgHKkrH3By8TQKm4BGecYE8wz+Mp+2FMU1tziZnQygHLd 4fSm+mWbPwjmDxNY26KJ4ZKl/DnraEANQ/7aTQjidvmfDW6s17k09mSu9aURdKgDFYl3gNEnf pHeOSl6O3CYp3FghvDbmtBOuBYdmG1EUMbnsLArVd+NavD6asSi4SylNtPZXffp8Wv2JhGHDU qN8zWfP3EoYyYJiIV781e9ezgw9wpJTch2A6Yph8XOk+pYzCa2xvmHiWk5DoHB92LKV3lJ5Td msCH17kjDRDP4Uxo/vVmJZnL5/gyl4PTy63qKlDUEAcBOUBGEEUfn/D7zOiPLldW9OO6w7cFY N8yWc6HYpnbB47ypQjxTHJ31f6t0obenHtfYvFY4CNuDqY8YAo8fSP40o+YBJQwaBuHnWDrXI bvJ7KSdgSkthAojqjFF7qcDrdk7W4qJWDUDMir3tA1B7HiyfY0LtGRAEr/a96ePjmzT+Zcr8V lWSILCc09cBPrX/Pa3NGBjU3oX7o46sRf+UcU+kXD3nOMxMfAWGI7TRaogmsMGVgXyUOlAx2a h0tbP4nmb9i48yJfGX8u/+SP3vmzA== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > I'm going to write a series of independent patches each > with around 10 substitutions; till it's all done. Would that work for > you ? Yes. Thanks for working on this, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 08:44:53 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 12:44:53 +0000 Received: from localhost ([127.0.0.1]:55790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYYJ3-0000En-2N for submit@debbugs.gnu.org; Sat, 13 Aug 2016 08:44:53 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:34345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYYJ1-0000Ea-DU for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 08:44:51 -0400 Received: by mail-io0-f173.google.com with SMTP id q83so46911355iod.1 for <24213@debbugs.gnu.org>; Sat, 13 Aug 2016 05:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=DTJnI9j36K6KVBhgNi5eUUCDA2tkmk057LThyxUK38I=; b=eQzNBrB1YojecyOI2XzUOWN0rhC7bGJTcjUZRpEP/IjgrsyeybFGQHgmapt1SM8NEl 4X0ttdah9t2IssyfxQPXfL31tpKUmADilaZId2VEtA1aTvAMlrF0oVtyPKyL5VBYaXiM 6EcxH8fKCQlEbRkTwLGL0FNP7gZaxZk0nyixmlOiDOfhRxSkzq7xAyYWgvZrm9YIXaef Z4SDdkLSTdZhNgO8Xh4Je5d5AfcSrJHCSHCel6gJQ4LacXGdo995Q/jzhqlgS1FZQ04R VQIo1Q1mqgo5VkEfLi5eYeqQLj1+f5jRUdJoS1BLBwjLwM9Ait8EJdI3lljDhQhsqgbw myLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=DTJnI9j36K6KVBhgNi5eUUCDA2tkmk057LThyxUK38I=; b=Y8J03FIg/p31kAtTT6PLDIeaxpT5Me/9mMKEXke6JrthvPbJPbCkeLEvjFn5dwvK0o iMOfwuLIwMJbLCETEKDYWoxp9/87Uh72XS4MByf/929W0ZHBRqVVIBcFkOzVRsNO+AxH 7Nqd0UT922NwjYGPzPkFAMKn9sKqi+kSEbiyC/IcwV2grCW1nwGYxcuUgccUOvHLEaLL wmv9DrO/UqvYSY/7tu28wdwbinTC/0dKlmfWGXtUQ1juFzcnwqou9bLDjjp5m8z2IW1r 9LfSgcrv8l1iADdpf3TwnKjaZCDazjJP4Bi/vci0fV/Imo6p3t8LkMuKP5sjFl0j/M3H Tr5Q== X-Gm-Message-State: AEkoouvAxEBTWXb4KFb9IEdlm4qXwm4iSKa3W+8M6TpeA/1MF3HqbVnAnvZtUX5RwsMQaA== X-Received: by 10.107.142.129 with SMTP id q123mr23991273iod.84.1471092285842; Sat, 13 Aug 2016 05:44:45 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id q1sm3069841itb.2.2016.08.13.05.44.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Aug 2016 05:44:45 -0700 (PDT) From: npostavs@users.sourceforge.net To: martin rudalics Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <87d1ldkw28.fsf@hochschule-trier.de> <57AED974.4030900@gmx.at> Date: Sat, 13 Aug 2016 08:44:54 -0400 In-Reply-To: <57AED974.4030900@gmx.at> (martin rudalics's message of "Sat, 13 Aug 2016 10:25:24 +0200") Message-ID: <87r39sx2gp.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org, Leo Liu , Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) martin rudalics writes: >> Maybe the documentation of delte-window should be amended, stating that >> it is almost always preferable to use quit-window instead; > > =E2=80=98delete-window=E2=80=99 is primarily a command bound to C-x 0. I= t should be > used only sparingly in Elisp code. Nevertheless, I think that any > advice to use =E2=80=98quit-window=E2=80=99 instead should go to the =E2= =80=98display-buffer=E2=80=99 > group functions because =E2=80=98quit-window=E2=80=99 (now) inherently be= longs there. Wouldn't it then make sense to add the usual "if you are thinking of using this function from Lisp code, it's probably a mistake, try `quit-window' instead" warning to the delete-window's docstring? (also, doc fixes should go to emacs-25, right?) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 08:52:22 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 12:52:22 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYYQI-0000QW-0g for submit@debbugs.gnu.org; Sat, 13 Aug 2016 08:52:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYYQG-0000QI-2N for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 08:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYYQA-00040K-7w for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 08:52:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYYQ2-0003yd-Q0; Sat, 13 Aug 2016 08:52:06 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1518 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bYYQ0-0006cK-AY; Sat, 13 Aug 2016 08:52:05 -0400 Date: Sat, 13 Aug 2016 15:51:52 +0300 Message-Id: <83y440de6v.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87r39sx2gp.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <87d1ldkw28.fsf@hochschule-trier.de> <57AED974.4030900@gmx.at> <87r39sx2gp.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 24213 Cc: rudalics@gmx.at, 24213@debbugs.gnu.org, sdl.web@gmail.com, politza@hochschule-trier.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) > From: npostavs@users.sourceforge.net > Date: Sat, 13 Aug 2016 08:44:54 -0400 > Cc: 24213@debbugs.gnu.org, Leo Liu , > Andreas Politz > > (also, doc fixes should go to emacs-25, right?) Yes. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 09:30:38 2016 Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 13:30:38 +0000 Received: from localhost ([127.0.0.1]:55824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYZ1K-00033I-BT for submit@debbugs.gnu.org; Sat, 13 Aug 2016 09:30:38 -0400 Received: from mout.gmx.net ([212.227.17.21]:62877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYZ1I-000335-Fx for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 09:30:36 -0400 Received: from [192.168.1.100] ([212.95.7.38]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M8JyQ-1bL2VZ3WUc-00vxNP; Sat, 13 Aug 2016 15:30:15 +0200 Message-ID: <57AF20E3.3030607@gmx.at> Date: Sat, 13 Aug 2016 15:30:11 +0200 From: martin rudalics MIME-Version: 1.0 To: npostavs@users.sourceforge.net Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <87d1ldkw28.fsf@hochschule-trier.de> <57AED974.4030900@gmx.at> <87r39sx2gp.fsf@users.sourceforge.net> In-Reply-To: <87r39sx2gp.fsf@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:YDNQHlDqb08sBppVx4HAOlPr0JKt0Rf9FvKeiSStnJqlGmIsXZr G2kWJFbQTpL+3pTGKIXJHB6/T3Wr91dqwk5C/ijqiSkK3ntAKZGre1IrM44Fizc4kiFcyI4 E1UrVP2BNDdSyFleptq7fcZgd2eGHZsDHC8lVVTavaAGDoheVoOXGb4YSfWSMO3hjv8TgOn xHyjSVynWJ6ZpHQRk4SBQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:f+Fm6u+JZfo=:rrnAcEvhK4AYr3Tu7WGLNY OG7Lyi8cgQNUq0JRBeYNuPwn83hhIuLosF3IlNM7NVzSxNu4Kd1i1Azbe1JOxvfzo5tmwtFAg NXzFpFlqbirM6e57iM8d4tXQrnMSIWMAHiwm+APnQJOTXzzmnaDmyAU8rRqQ12yI24/ZmiCfX Du1iMfY2h18wAP4Wo/tKcbCkgBCsX4s4TqfRgdrjZpYmnGca8ZuISCdeS2QY7pEOan7Xnwt3g 7Iaw62h1JZ0tv05b1M7UQqDBATjxpWJU+Ks4FS70oAe0qiXPy8hExPX4aTcB3QqACf2G1JLh0 C12lyo8TUq73Le0er+5E9ap9cZpZptd8O2ICSmi+hmD/F5H6GyDlRWB9h17vbTxwJKch6BDIu bPzMXNRfO6nOC/ULZBX1V8ZOBHdtXV9+6Ck1D2h2wCsG9sq2xz4YtFNo7ToC/+jXDWM56bu/7 NEt3ukicgfCg/4pUoVspBuBgrCJHt/gSgUt134hZ4xZqUbERYr2h1HcOA6OYvKmCADtEWN7HO JqRZ19jYre8GwFCQe1IqqKJzDHURfkIQy7u1iAglh9Gdx6GCXb6sN7Uh9/SMq3NG+ZaIxpg+G umMdMPqPah94sZ2o9mHqPeB5wJbLAYkTkqHyimnVXgMm0e6RFo1r5F+qUaS++AlwDV6kO4sn9 RHk7fzukKZeGi6+JuRvYSyROkeNf449QAdBqdHhh3KuOrcOQAvz7l2YIPCrxhLg8g/vVKrbWZ 858XeQCwjwLAozIVoW6IQzIdEoMZLoV3r5kFglIS7/h2rGc3Ntnp7bek3GXpIzSzywzdQxdcI jZ4gaXeuNneXnXhmLrJBbst5gSWcQ== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org, Leo Liu , Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) >> =E2=80=98delete-window=E2=80=99 is primarily a command bound to C-x 0= =2E It should be >> used only sparingly in Elisp code. Nevertheless, I think that any >> advice to use =E2=80=98quit-window=E2=80=99 instead should go to the = =E2=80=98display-buffer=E2=80=99 >> group functions because =E2=80=98quit-window=E2=80=99 (now) inherentl= y belongs there. > > Wouldn't it then make sense to add the usual "if you are thinking of > using this function from Lisp code, it's probably a mistake, try > `quit-window' instead" warning to the delete-window's docstring? Then readers might think that they should replace =E2=80=98delete-window=E2= =80=99 with =E2=80=98quit-window=E2=80=99 indiscriminately. That would be incorrect = because without an accompanying =E2=80=98quit-restore=E2=80=99 parameter, =E2=80=98quit-w= indow=E2=80=99 is not very useful. (The history of =E2=80=98quit-window=E2=80=99 and =E2=80=98quit-= restore-window=E2=80=99 is a convoluted one - I never wanted to commingle these but Chong overruled me, if my memory doesn't fail). Paired with =E2=80=98split-window=E2=80=99, =E2=80=98delete-window=E2=80=99= is the correct choice to undo the former. So any warning should go to =E2=80=98split-window=E2=80= =99 instead. But then readers might be tempted to replace =E2=80=98split-window=E2=80=99= calls with =E2=80=98display-buffer=E2=80=99 calls indiscriminately and I don't want = to think of the consequences of this. > (also, doc fixes should go to emacs-25, right?) I was tempted to do that. But please let's postpone further changes in this area to the time when Andreas has posted his first patch. I'm glad that someone has started looking into this and suppose that further doc fixes will be necessary. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 17 03:46:27 2016 Received: (at submit) by debbugs.gnu.org; 17 Aug 2016 07:46:27 +0000 Received: from localhost ([127.0.0.1]:59719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZvYQ-0005Rk-Nu for submit@debbugs.gnu.org; Wed, 17 Aug 2016 03:46:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZvYP-0005Li-E1 for submit@debbugs.gnu.org; Wed, 17 Aug 2016 03:46:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZvYJ-0006Dt-NZ for submit@debbugs.gnu.org; Wed, 17 Aug 2016 03:46:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZvYJ-0006Dj-KF for submit@debbugs.gnu.org; Wed, 17 Aug 2016 03:46:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZvYH-0005eZ-DT for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 03:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZvYB-0006CN-Dh for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 03:46:16 -0400 Received: from [195.159.176.226] (port=48355 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZvYB-0006C5-6r for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 03:46:11 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bYVar-0003qE-AJ for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2016 11:51:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el Date: Sat, 13 Aug 2016 17:50:59 +0800 Lines: 8 Message-ID: References: <87mvkhivpu.fsf@hochschule-trier.de> <87d1ldkw28.fsf@hochschule-trier.de> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (OS X 10.11.6) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Cancel-Lock: sha1:xgEo1MnCuGlR/ofk2HXyYCoEzr4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 2016-08-13 08:43 +0200, Andreas Politz wrote: > No, the window is created by display-buffer, which is not obligated to > use it's action argument, e.g. if the buffer triggers a match in > display-buffer-alist. OK, sounds like quit-window is better. Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 31 15:04:57 2016 Received: (at 24213) by debbugs.gnu.org; 31 Aug 2016 19:04:57 +0000 Received: from localhost ([127.0.0.1]:45642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfAoi-0006r2-Qm for submit@debbugs.gnu.org; Wed, 31 Aug 2016 15:04:57 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:58392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfAog-0006ql-IV for 24213@debbugs.gnu.org; Wed, 31 Aug 2016 15:04:55 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (ip5f5bdf67.dynamic.kabel-deutschland.de [95.91.223.103]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 3098F1798E8B; Wed, 31 Aug 2016 21:04:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1472670277; bh=qmViV1nooElrs08sePAjKQNn/M0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=FV4P1JlSB7aAeuv+uUEOw2Dv43BcrZb6RnebT+PxpSV82KEzs9ZRj6erSdKZvMH5z xCJdBZiBbvppWVC5JSwNXH/tk67oljXaHwGNhf6umrCCSzO5bPM6vKXM0AnTBLU3LQ QPejn4KtZQYukll75vJ7w1ferowwrW357C5hQzV0= From: Andreas Politz To: martin rudalics Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> Date: Wed, 31 Aug 2016 21:04:36 +0200 In-Reply-To: <57AEF063.6070907@gmx.at> (martin rudalics's message of "Sat, 13 Aug 2016 12:03:15 +0200") Message-ID: <8760qg69q3.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I finally got around to this. The changes in the following diff seem to be all clear cut cases, where the window is created by display-buffer/pop-to-buffer without any special window-handling logic attached. Let me know what you think. diff --git a/lisp/finder.el b/lisp/finder.el index da537a5..7f08024 100644 --- a/lisp/finder.el +++ b/lisp/finder.el @@ -455,7 +455,7 @@ finder-exit "Exit Finder mode. Delete the window and kill all Finder-related buffers." (interactive) - (ignore-errors (delete-window)) + (quit-window) (let ((buf "*Finder*")) (and (get-buffer buf) (kill-buffer buf)))) diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 67b023d..36f148b 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -2445,13 +2445,9 @@ image-dired-gallery-generate (insert "")))) (defun image-dired-kill-buffer-and-window () - "Kill the current buffer and, if possible, also the window." + "Kill the current buffer and quit it's window." (interactive) - (let ((buffer (current-buffer))) - (condition-case nil - (delete-window (selected-window)) - (error nil)) - (kill-buffer buffer))) + (quit-window t)) (defvar image-dired-widget-list nil "List to keep track of meta data in edit buffer.") diff --git a/lisp/progmodes/idlwave.el b/lisp/progmodes/idlwave.el index 9cb2ca7..2215e52 100644 --- a/lisp/progmodes/idlwave.el +++ b/lisp/progmodes/idlwave.el @@ -8272,7 +8272,7 @@ idlwave-quit-help (select-window olh-window) (idlwave-help-quit)) (when (window-live-p ri-window) - (delete-window ri-window)))) + (quit-window nil ri-window)))) (defun idlwave-display-calling-sequence (name type class &optional initial-class) diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el index fd2e96a..a96ddae 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -7486,8 +7486,7 @@ verilog-complete-word (display-completion-list allcomp)) ;; Wait for a key press. Then delete *Completion* window (momentary-string-display "" (point)) - (delete-window (get-buffer-window (get-buffer "*Completions*"))) - ))))) + (quit-window nil (get-buffer-window "*Completions*"))))))) (defun verilog-show-completions () "Show all possible completions at current point." @@ -7506,7 +7505,7 @@ verilog-show-completions (display-completion-list allcomp)) ;; Wait for a key press. Then delete *Completion* window (momentary-string-display "" (point)) - (delete-window (get-buffer-window (get-buffer "*Completions*"))))) + (quit-window nil (get-buffer-window "*Completions*")))) (defun verilog-get-default-symbol () diff --git a/lisp/startup.el b/lisp/startup.el index fcdc376..0b21f4f 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -1765,9 +1765,7 @@ fancy-startup-tail (customize-set-variable 'inhibit-startup-screen t) (customize-mark-to-save 'inhibit-startup-screen) (custom-save-all)) - (let ((w (get-buffer-window "*GNU Emacs*"))) - (and w (not (one-window-p)) (delete-window w))) - (kill-buffer "*GNU Emacs*"))) + (quit-windows-on "*GNU Emacs*" t))) " ") (when (or user-init-file custom-file) (let ((checked (create-image "checked.xpm" diff --git a/lisp/strokes.el b/lisp/strokes.el index 5a2020d..215f24b 100644 --- a/lisp/strokes.el +++ b/lisp/strokes.el @@ -1216,9 +1216,7 @@ strokes-xpm-for-stroke ;;(defun strokes-edit-quit () ;; (interactive) -;; (or (one-window-p t 0) -;; (delete-window)) -;; (kill-buffer "*Strokes List*")) +;; (quit-windows-on "*Strokes List*" t)) ;;(define-derived-mode edit-strokes-mode list-mode ;; "Edit-Strokes" From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 03:40:25 2016 Received: (at 24213) by debbugs.gnu.org; 1 Sep 2016 07:40:25 +0000 Received: from localhost ([127.0.0.1]:45848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfMbo-0008MK-VZ for submit@debbugs.gnu.org; Thu, 01 Sep 2016 03:40:25 -0400 Received: from mout.gmx.net ([212.227.17.20]:57117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfMbn-0008M4-2m for 24213@debbugs.gnu.org; Thu, 01 Sep 2016 03:40:23 -0400 Received: from [192.168.1.100] ([212.95.7.81]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Lh7M3-1bHJzk2pb5-00oaqh; Thu, 01 Sep 2016 09:40:15 +0200 Message-ID: <57C7DB54.6000605@gmx.at> Date: Thu, 01 Sep 2016 09:40:04 +0200 From: martin rudalics MIME-Version: 1.0 To: Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> In-Reply-To: <8760qg69q3.fsf@hochschule-trier.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:N6AY1yNUSoNcOyqHma5FMImkPq1WCq4hOnPjKkNIuZfAa/rIKMC Q2u62pzooy9NceeQ2Jqvf+AY1STo636Do1BcBJSIfdBLjsBv1pe+KYkSWRZtUIt/bezB7NB dK7gP4THAOYYjMtFVKMTWxxK9T94loJdGk7YWgY1iY1tfLo/kFUus+mj/k6oyRWZmZDE6lc Scm9N4o4wa/NNMqf920oA== X-UI-Out-Filterresults: notjunk:1;V01:K0:mBN7egn4BrQ=:sETpExzi5m7UJYnRrr8Csm XE/i1Q4QQPs2zKe5ZmKwNqKz0Aubk624kZ5V00G5mGhESH9LNrbw7doiLmkRi9AFFmbF1ZizG U9IfHPhrZuYwbbz/8UHRbdFUah109FxupSUyRUP1GU+Il3IO0MCD7R9r/SVNdJd95iYEE2d43 pS07eoD3sB2A4Eq3CwaodK3VZUMDHeOBQOqPxeAtZskTm4Bda68JCjGyeqDOdT/PHgzl1Z/En OLR1TxP0QEZsaGy8j0avfj4nG76LkaRKsE0lSlxyyzx/a882WKB1ZpdcxMoDvCDTsImZDod1U PFoUbOXELis4e+bXkKZ0eW68FvptV1ga8ybH37zXBcwVqYnahU4UcdoED+iYaw++1F5Waw4kX vsqf92fEl3aqUW81bygMuF5OjEx8rxDsCrTR/xHGfnBPXcK9j4j6R+90OCSK1rUrFiG990Jwn Kqo4Fc4lvm3ZE1kdpy0hOy/DYOIxlUwd4lVeVT6In4CUJey8uWOp8+WJ9WN1ebHxhNmw2+ns+ 8xdAK06J9veAYpk/REhG2MuxFvpDYa6Aap4MWgxQMiXYagTLaw9pnko9PvVFgiK0JB8Yv/qZ4 DyjY0rc1xV+Lp9mY4wkUlJC958V62p9JpgAmJQPGh7YYww3hgwxi6P4MUjbPCv12P0CslHxTc 6EPtl+aRpzOUGWqLcqgFKmwAFRPUNoTeHm8biUo325DSuZ3N1L/Mkt6axgqlhAacBbUekedD0 0R4EB7wRzndN+RYJn8fETCZ4HebwgbgpCQUsxwL5mwwCn1Wpusl0Cc/YFuk5L8bULzIoj2Xpo YYTrIZAXu5viQuELkYY2nXYGqt/LA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > I finally got around to this. The changes in the following diff seem to > be all clear cut cases, where the window is created by > display-buffer/pop-to-buffer without any special window-handling logic > attached. Let me know what you think. Thank you. > "Exit Finder mode. > Delete the window and kill all Finder-related buffers." Maybe we should say that we "Quit" the window and "kill the Finder buffer" here. > (interactive) > - (ignore-errors (delete-window)) > + (quit-window) > (let ((buf "*Finder*")) > (and (get-buffer buf) (kill-buffer buf)))) How about using (quit-window t) right away as in the next case? > diff --git a/lisp/image-dired.el b/lisp/image-dired.el > index 67b023d..36f148b 100644 > --- a/lisp/image-dired.el > +++ b/lisp/image-dired.el > @@ -2445,13 +2445,9 @@ image-dired-gallery-generate > (insert "")))) > > (defun image-dired-kill-buffer-and-window () > - "Kill the current buffer and, if possible, also the window." > + "Kill the current buffer and quit it's window." "its" not "it's". The remainder looks OK. If no-one objects, please provide a ChangeLog entry and I'll install the changes. Thanks again, martin From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 07:22:36 2016 Received: (at 24213) by debbugs.gnu.org; 1 Sep 2016 11:22:37 +0000 Received: from localhost ([127.0.0.1]:45935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfQ4m-0005LL-Gy for submit@debbugs.gnu.org; Thu, 01 Sep 2016 07:22:36 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:39638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfQ4f-0005L0-OK for 24213@debbugs.gnu.org; Thu, 01 Sep 2016 07:22:30 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (ip5f5bdf67.dynamic.kabel-deutschland.de [95.91.223.103]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 44F881798AB0; Thu, 1 Sep 2016 13:22:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1472728929; bh=GQHdfcjFFA7JSSORvT8XYgb4U3c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=but0PimMANGtUHPpA2eRh/DDU5GN0hkx47tm5dtKfbM8fIMypCd5hyrhtWMCMACFk R8BahwSLf+dMmHPvlp92QLa/jOYTEF8BwGhsdNbsuSWK4jbP7ClmAK/fMubtVZ0K9K iwUcs/KDGzyMUdPZTTVVVGafdvSWBM1+qMt014fQ= From: Andreas Politz To: martin rudalics Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> <57C7DB54.6000605@gmx.at> Date: Thu, 01 Sep 2016 13:22:08 +0200 In-Reply-To: <57C7DB54.6000605@gmx.at> (martin rudalics's message of "Thu, 01 Sep 2016 09:40:04 +0200") Message-ID: <87mvjreufz.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) martin rudalics writes: >> "Exit Finder mode. >> Delete the window and kill all Finder-related buffers." > > Maybe we should say that we "Quit" the window [...] Yes, I missed that. >> (interactive) >> - (ignore-errors (delete-window)) >> + (quit-window) >> (let ((buf "*Finder*")) >> (and (get-buffer buf) (kill-buffer buf)))) > > How about using (quit-window t) right away as in the next case? The resulting function would be quite murderous and try to kill any buffer regardless of Finder. I tried to modify the functions semantics as little as possible. Who knows in what way people are using them, right ? >> diff --git a/lisp/image-dired.el b/lisp/image-dired.el >> index 67b023d..36f148b 100644 >> --- a/lisp/image-dired.el >> +++ b/lisp/image-dired.el >> @@ -2445,13 +2445,9 @@ image-dired-gallery-generate >> (insert "")))) >> >> (defun image-dired-kill-buffer-and-window () >> - "Kill the current buffer and, if possible, also the window." >> + "Kill the current buffer and quit it's window." > > "its" not "it's". I think I'm using this false possessive apostrophe for years, without realizing its ambiguity. Thank you. More to come. -ap From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 08:58:16 2016 Received: (at 24213) by debbugs.gnu.org; 1 Sep 2016 12:58:16 +0000 Received: from localhost ([127.0.0.1]:45990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfRZM-0000ju-44 for submit@debbugs.gnu.org; Thu, 01 Sep 2016 08:58:16 -0400 Received: from mout.gmx.net ([212.227.15.15]:54363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfRZF-0000j4-K4 for 24213@debbugs.gnu.org; Thu, 01 Sep 2016 08:58:10 -0400 Received: from [192.168.1.100] ([212.95.7.102]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lh6sJ-1bLUDw0N9j-00oXDd; Thu, 01 Sep 2016 14:57:59 +0200 Message-ID: <57C825D5.9080403@gmx.at> Date: Thu, 01 Sep 2016 14:57:57 +0200 From: martin rudalics MIME-Version: 1.0 To: Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> <57C7DB54.6000605@gmx.at> <87mvjreufz.fsf@hochschule-trier.de> In-Reply-To: <87mvjreufz.fsf@hochschule-trier.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fG2SN65nkj0rBTn7dW4u0qKLoMIoRIC9cnhPX+NXa+PffIE5Tc1 nbXFaoTI0jiWDMU7cH8Zmb+8VRN9ENSkv9q+Jl6kWBIpyvZ2qjn3b3Aq1L8GBZALv1mEG+Q +bjkvltlfgzlsXjMnQpNzWTqMdY+3rc3TpyMx6QZ72BVbp6fgUKM8wLJqFWotcxoV/3ZiGA z+pS65bYJeZYb2lx4U+Pw== X-UI-Out-Filterresults: notjunk:1;V01:K0:7TdSyFD0uNw=:26veyhqisajrLlpBJwlLKl mf3LsARUv2kVXHrc3f2xDSYKzXqzoiz7Y5ZUvr7SyhhyHkCzAHeKKlvOFi1n8L+hYg3qAztuf wdpV09PhVoMx3CfwetzbNg+s6ELm+0k0sq1EMnOD2vr64sUZBMWBMK+irIlif/7x3t8w/i56O 0y7H34lGgOCobppgF/tJMnOorIwE4cCp0GVa2LMTMMmhoKuGvAO4Q4pkjBUI9sDbGkDPe7pfG j3lVaDBxedwiH1bjdVh/IXGjGtjuW43qkWYA53KUsZ0UrlU12RfgJ9GUvQzVQagVNSjWEj0Ft 1yrxEgBa9DLMZWxY19Cu4C5LujHj/1aj8FZ+FqBPl+faqBeEGiN9NBJlZdlYfqTr4ygxhcfAV HG5CG/e0XTMD9EcXa3Tkqx3NQRhZx1JYRmAaqGUp8cVO3Ej6A/Xv+1aAlKAABFXN62MGimbqO NpBm8S+9QTodHoidULnsKesLUAXcrkyBxE5f7uEj7xiUE9ash+hQkrP4s2BxSKbD+Nx7/iqmI aagAgOhj0HbLtBhfMiiKihy9kWjwRwpEfOiAEb937slWx1zuaGvTT8ipnmkcCPdu0QVRVr4MZ wX3HhVjXsRlKDo50D4Mo8galb0n81UaLPlzFVEW9Q+T1+6Jhu50UlJxpkEjuGhY/NniUdvIH2 LZZHbkhoE6fbgAWw8Tlsq2mhbhXBN5220HZKEOrrELdYldIytZLo67Li1I0+cZFSDIwa3rThW TL1qBGsLvtwPabWf7Cm8H1N03Lm9A1Dpsftsb0UvMNlE7aH7y97gOhK7fU2ResMr+5UAo1woY +ZuxFr2FHr++RGr4DjnprQXG44w2Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24213 Cc: 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> How about using (quit-window t) right away as in the next case? > > The resulting function would be quite murderous and try to kill any > buffer regardless of Finder. I tried to modify the functions semantics > as little as possible. Who knows in what way people are using them, > right ? Right. Let's stick to your version. > More to come. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 10:58:44 2019 Received: (at 24213) by debbugs.gnu.org; 29 Sep 2019 14:58:44 +0000 Received: from localhost ([127.0.0.1]:55436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEaeq-00038a-70 for submit@debbugs.gnu.org; Sun, 29 Sep 2019 10:58:44 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEaeo-00038P-2l for 24213@debbugs.gnu.org; Sun, 29 Sep 2019 10:58:42 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEaej-00027e-G6; Sun, 29 Sep 2019 16:58:39 +0200 From: Lars Ingebrigtsen To: Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> Date: Sun, 29 Sep 2019 16:58:37 +0200 In-Reply-To: <8760qg69q3.fsf@hochschule-trier.de> (Andreas Politz's message of "Wed, 31 Aug 2016 21:04:36 +0200") Message-ID: <87ftkfgndu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andreas Politz writes: > I finally got around to this. The changes in the following diff seem to > be all clear cut cases, where the window is created by > display-buffer/pop-to-buffer without any special window-handling lo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24213 Cc: martin rudalics , 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Politz writes: > I finally got around to this. The changes in the following diff seem to > be all clear cut cases, where the window is created by > display-buffer/pop-to-buffer without any special window-handling logic > attached. Let me know what you think. Apparently the patch was not applied at the time, and many of the instances have later been fixed. I've respun the patch for Emacs 27, and the remaining fixups (replacing delete-window with quit-window look logical to me. Does anybody have any comments? diff --git a/lisp/progmodes/idlwave.el b/lisp/progmodes/idlwave.el index 1b4b55c94f..3535a7b4aa 100644 --- a/lisp/progmodes/idlwave.el +++ b/lisp/progmodes/idlwave.el @@ -8271,7 +8271,7 @@ idlwave-quit-help (select-window olh-window) (idlwave-help-quit)) (when (window-live-p ri-window) - (delete-window ri-window)))) + (quit-window nil ri-window)))) (defun idlwave-display-calling-sequence (name type class &optional initial-class) diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el index baeaf8b95d..5bfa5f837a 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -7598,8 +7598,7 @@ verilog-complete-word (display-completion-list allcomp)) ;; Wait for a key press. Then delete *Completion* window (momentary-string-display "" (point)) - (delete-window (get-buffer-window (get-buffer "*Completions*"))) - ))))) + (quit-window nil (get-buffer-window "*Completions*"))))))) (defun verilog-show-completions () "Show all possible completions at current point." @@ -7611,7 +7610,8 @@ verilog-show-completions (display-completion-list (nth 2 (verilog-completion-at-point)))) ;; Wait for a key press. Then delete *Completion* window (momentary-string-display "" (point)) - (delete-window (get-buffer-window (get-buffer "*Completions*")))) + (quit-window nil (get-buffer-window "*Completions*"))) + (defun verilog-get-default-symbol () "Return symbol around current point as a string." diff --git a/lisp/startup.el b/lisp/startup.el index 52d4dbb05c..7eb0180d41 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -1853,9 +1853,7 @@ fancy-startup-tail (customize-set-variable 'inhibit-startup-screen t) (customize-mark-to-save 'inhibit-startup-screen) (custom-save-all)) - (let ((w (get-buffer-window "*GNU Emacs*"))) - (and w (not (one-window-p)) (delete-window w))) - (kill-buffer "*GNU Emacs*"))) + (quit-windows-on "*GNU Emacs*" t))) " ") (when (or user-init-file custom-file) (let ((checked (create-image "checked.xpm" diff --git a/lisp/strokes.el b/lisp/strokes.el index 6edf58c7b6..2c88b1eefd 100644 --- a/lisp/strokes.el +++ b/lisp/strokes.el @@ -1216,9 +1216,7 @@ strokes-xpm-for-stroke ;;(defun strokes-edit-quit () ;; (interactive) -;; (or (one-window-p t 0) -;; (delete-window)) -;; (kill-buffer "*Strokes List*")) +;; (quit-windows-on "*Strokes List*" t)) ;;(define-derived-mode edit-strokes-mode list-mode ;; "Edit-Strokes" -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 10:58:47 2019 Received: (at control) by debbugs.gnu.org; 29 Sep 2019 14:58:47 +0000 Received: from localhost ([127.0.0.1]:55439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEaet-00038q-J6 for submit@debbugs.gnu.org; Sun, 29 Sep 2019 10:58:47 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEaes-00038i-Ei for control@debbugs.gnu.org; Sun, 29 Sep 2019 10:58:46 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEaep-00027n-Kd for control@debbugs.gnu.org; Sun, 29 Sep 2019 16:58:45 +0200 Date: Sun, 29 Sep 2019 16:58:43 +0200 Message-Id: <87eezzgndo.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24213 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 24213 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24213 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 23:09:13 2019 Received: (at 24213) by debbugs.gnu.org; 13 Oct 2019 03:09:13 +0000 Received: from localhost ([127.0.0.1]:34675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUFs-0004ar-O0 for submit@debbugs.gnu.org; Sat, 12 Oct 2019 23:09:12 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUFq-0004ae-GF for 24213@debbugs.gnu.org; Sat, 12 Oct 2019 23:09:10 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJUFk-0003mr-Vs; Sun, 13 Oct 2019 05:09:08 +0200 From: Lars Ingebrigtsen To: Andreas Politz Subject: Re: bug#24213: 25.1.50; Fishy use of delete-window in register.el References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> <87ftkfgndu.fsf@gnus.org> Date: Sun, 13 Oct 2019 05:09:04 +0200 In-Reply-To: <87ftkfgndu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Sep 2019 16:58:37 +0200") Message-ID: <87zhi5cpf3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Apparently the patch was not applied at the time, and many of the > instances have later been fixed. > > I've respun the patch for Emacs 27, and the remaining fixups (replacing > delete-window with [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24213 Cc: martin rudalics , 24213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Apparently the patch was not applied at the time, and many of the > instances have later been fixed. > > I've respun the patch for Emacs 27, and the remaining fixups (replacing > delete-window with quit-window look logical to me. > > Does anybody have any comments? There were no comments in two weeks, so I've now applied the patch, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 23:09:18 2019 Received: (at control) by debbugs.gnu.org; 13 Oct 2019 03:09:18 +0000 Received: from localhost ([127.0.0.1]:34678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUFy-0004bC-0m for submit@debbugs.gnu.org; Sat, 12 Oct 2019 23:09:18 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUFw-0004b1-4f for control@debbugs.gnu.org; Sat, 12 Oct 2019 23:09:16 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJUFt-0003n4-G4 for control@debbugs.gnu.org; Sun, 13 Oct 2019 05:09:15 +0200 Date: Sun, 13 Oct 2019 05:09:13 +0200 Message-Id: <87y2xpcpeu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24213 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 24213 fixed close 24213 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24213 fixed close 24213 27.1 quit From unknown Thu Aug 14 18:37:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Nov 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator