GNU bug report logs - #24193
25.1; `window-min-size' fails for horizontal width when margins >= body text

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24193: closed (25.1; `window-min-size' fails for horizontal
 width when margins >= body text)
Date: Fri, 04 Sep 2020 13:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 04 Sep 2020 16:41:22 +0300
with message-id <83ft7xu0al.fsf <at> gnu.org>
and subject line Re: bug#24193: 25.1; `window-min-size' fails for horizontal width when margins >= body text
has caused the debbugs.gnu.org bug report #24193,
regarding 25.1; `window-min-size' fails for horizontal width when margins >= body text
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24193: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24193
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Rankin <hello <at> paulwrankin.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1;
 `window-min-size' fails for horizontal width when margins >= body text
Date: Tue, 09 Aug 2016 19:14:27 +1000

There appears to be a change to `window-min-size' that gives an erroneously large minimum horizontal window size when the combined size of window margins exceed that of the body text, e.g. in a frame 80 columns wide, with left margin 20 columns and right margin 20 columns, would return a minimum horizontal size of 42, when body text would be 40. This causes `split-window-right' to fail.

To reproduce:

1. emacs -Q
2. in a frame 80 columns wide...
3. M-: (set-window-margins nil 20 20)
4. C-x 3
    => "Window #<window 1 on *scratch*> too small for splitting (2)"
5. M-: (window-min-size nil t)
    => 42

Expected results:

Window should split horizontally. Minimum window width should not be dictated by margin width.

Actual results:

Margin width dictates minimum window width and prevents window splitting.

Configuration:

GNU Emacs 25.1.1 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G31)) of 2016-08-09

MacBook Pro (Retina, 15-inch, Mid 2014)
2.2 GHz Intel Core i7
16 GB 1600 MHz DDR3
Intel Iris Pro 1536 MB

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 24193-done <at> debbugs.gnu.org, rudalics <at> gmx.at, hello <at> paulwrankin.com
Subject: Re: bug#24193: 25.1; `window-min-size' fails for horizontal width
 when margins >= body text
Date: Fri, 04 Sep 2020 16:41:22 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  24193 <at> debbugs.gnu.org,  martin rudalics
>  <rudalics <at> gmx.at>
> Date: Fri, 04 Sep 2020 15:09:59 +0200
> 
> > Turns out there is a better solution, so the patch can be removed
> > before stable 25.1 release if you prefer :)
> 
> Skimming this thread, Martin's patch was applied (which seemed to fix
> the issue?), but then Paul said there's a better solution?  (But not
> what it was.)
> 
> So I'm not sure whether there's more to do here, or whether the bug
> report should be closed.  Anybody?

It should be closed; done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.