GNU bug report logs - #24191
diff: disable colorization for TERM=dumb

Previous Next

Package: diffutils;

Reported by: Jim Meyering <jim <at> meyering.net>

Date: Tue, 9 Aug 2016 01:56:01 UTC

Severity: normal

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24191: closed (diff: disable colorization for TERM=dumb)
Date: Sun, 14 Aug 2016 02:12:02 +0000

[Message part 1 (text/plain, inline)]
Your message dated Sat, 13 Aug 2016 19:10:57 -0700
with message-id <CA+8g5KGZwbmTS8V4VanDnfgpCQrN_Gn1aShZY1nJ9mK=PZ2DQA <at> mail.gmail.com>
and subject line Re: [bug-diffutils] bug#24191: diff: disable colorization for TERM=dumb
has caused the debbugs.gnu.org bug report #24191,
regarding diff: disable colorization for TERM=dumb
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24191: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24191
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Jim Meyering <jim <at> meyering.net>
To: bug-diffutils <at> gnu.org
Cc: Daniel Colascione <dancol <at> dancol.org>
Subject: diff: disable colorization for TERM=dumb
Date: Mon, 8 Aug 2016 18:54:51 -0700

[Message part 3 (text/plain, inline)]
    diff: disable colorization for TERM=dumb

    * src/diff.c (main): With --color or --color=auto, when TERM is
    "dumb", disable colorization.  Suggested by Daniel Colascione.
    * NEWS (Bug fixes): Mention it.
    * tests/colors: Add a test that would fail without this change,
    yet passes with it.

[0001-diff-disable-colorization-for-TERM-dumb.diff (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Jim Meyering <jim <at> meyering.net>
To: 24191-done <at> debbugs.gnu.org
Cc: Daniel Colascione <dancol <at> dancol.org>
Subject: Re: [bug-diffutils] bug#24191: diff: disable colorization for
 TERM=dumb
Date: Sat, 13 Aug 2016 19:10:57 -0700

On Mon, Aug 8, 2016 at 6:54 PM, Jim Meyering <jim <at> meyering.net> wrote:
>     diff: disable colorization for TERM=dumb
>
>     * src/diff.c (main): With --color or --color=auto, when TERM is
>     "dumb", disable colorization.  Suggested by Daniel Colascione.
>     * NEWS (Bug fixes): Mention it.
>     * tests/colors: Add a test that would fail without this change,
>     yet passes with it.

Pushed.
This bug report was last modified 8 years and 285 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.