GNU bug report logs - #24166
With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!)

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: 24166 <at> debbugs.gnu.org, clement.pitclaudel <at> live.com
Subject: bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!)
Date: Sun, 07 Aug 2016 17:12:18 +0300

> From: npostavs <at> users.sourceforge.net
> Cc: 24166 <at> debbugs.gnu.org,  clement.pitclaudel <at> live.com
> Date: Sat, 06 Aug 2016 08:25:17 -0400
> 
> Here's the new patch.

Thanks.  I have one minor comment below.

> Is it correct to put the DEFSYM next to the DEFVAR_LISP?

It isn't incorrect, and even eval.c already does that.

> +  /* If we are debugging an error within a call to `string-match-p',
> +     then make sure debugger code can still use match data.  */

Please mention in the comment that string-match-p binds
inhibit-changing-match-data, and that it is only one example of that.

Otherwise, LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.