Subject: Re: bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!)

From: Eli Zaretskii <[email-masked]>
Date: Sun, 07 Aug 2016 17:12:18 +0300

> From: [email-masked]
> Cc: [email-masked],  [email-masked]
> Date: Sat, 06 Aug 2016 08:25:17 -0400
> 
> Here's the new patch.

Thanks.  I have one minor comment below.

> Is it correct to put the DEFSYM next to the DEFVAR_LISP?

It isn't incorrect, and even eval.c already does that.

> +  /* If we are debugging an error within a call to `string-match-p',
> +     then make sure debugger code can still use match data.  */

Please mention in the comment that string-match-p binds
inhibit-changing-match-data, and that it is only one example of that.

Otherwise, LGTM, thanks.