GNU bug report logs - #24161
[PATCH 2/2] sed: speed up matching by reguler expression with dfa matcher

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Assaf Gordon <assafgordon <at> gmail.com>, 24161 <at> debbugs.gnu.org
Subject: bug#24161: [PATCH 2/2] sed: speed up matching by reguler expression with dfa matcher
Date: Sat, 6 Aug 2016 19:20:22 -0700

[Message part 1 (text/plain, inline)]

On Sat, Aug 6, 2016 at 5:50 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
> On Fri, 5 Aug 2016 10:51:40 -0400
> Assaf Gordon <assafgordon <at> gmail.com> wrote:
>
>> Hello Norihiro,
>>
>> On 08/05/2016 10:03 AM, Norihiro Tanaka wrote:
>> > We can speeds up sed by using dfa matcher brought from grep.  gawk users
>> > it, sed does not uses it yet.  It will speed up matching for typical
>> > cases.
>> [...]
>> > I believe that this patch can greatly improve performance of matching by
>> > sed, however I worry about the maintenance as updates for dfa is always
>> > done in grep.
>>
>> Nice improvement, thank you for the patch!

Thanks again.
I've revised it as follows and expect to push tomorrow:
  - remove the abort and comment from dfaerror -- should is not
necessary, given the _Noreturn attribute.
  - adjusted commit log and NEWS entry, also moving the "Improvements"
section to the top
  - sorted source file names in local.mk (they were not sorted before, either)
  - added the "make syntax-check"-required mention of sed/dfa.c in
po/POTFILES.in

[0001-sed-use-grep-s-DFA-matcher-to-speed-up-regular-expre.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.