From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 07:31:12 2016 Received: (at submit) by debbugs.gnu.org; 5 Aug 2016 11:31:12 +0000 Received: from localhost ([127.0.0.1]:56197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVdLM-0006Or-L2 for submit@debbugs.gnu.org; Fri, 05 Aug 2016 07:31:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVdLL-0006J4-FS for submit@debbugs.gnu.org; Fri, 05 Aug 2016 07:31:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVdLF-0000Lo-AS for submit@debbugs.gnu.org; Fri, 05 Aug 2016 07:31:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVdLF-0000LT-7D for submit@debbugs.gnu.org; Fri, 05 Aug 2016 07:31:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVdLC-0001KW-Fv for bug-grep@gnu.org; Fri, 05 Aug 2016 07:31:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVdL7-0000Kj-EN for bug-grep@gnu.org; Fri, 05 Aug 2016 07:31:02 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:58792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVdL7-0000Jd-4L for bug-grep@gnu.org; Fri, 05 Aug 2016 07:30:57 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 8EF7980616 for ; Fri, 5 Aug 2016 20:30:47 +0900 (JST) X-matriXscan-loop-detect: 9212771b8289570d209176f874d7fae50b1744e5 Received: from mail07.kcn.ne.jp ([61.86.6.186]) by mxs01-s with ESMTP; Fri, 05 Aug 2016 20:30:46 +0900 (JST) Received: from [10.120.1.35] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id 5870BD5009A for ; Fri, 5 Aug 2016 20:30:46 +0900 (JST) Date: Fri, 05 Aug 2016 20:30:49 +0900 From: Norihiro Tanaka To: Subject: [PATCH] dfa: minor fix for whether dfa is fast or not Message-Id: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_57A477250000000070F2_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_57A477250000000070F2_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit dfaoptimize() is not set fast flag even if it is success, but it is wrong. If success, dfa matcher uses algorithm for single byte, and it is so fast. I think this bug does not affect for grep, but it will affect with the patch that I just sent to gawk. --------_57A477250000000070F2_MULTIPART_MIXED_ Content-Type: application/octet-stream; name="0001-dfa-minor-fix-for-whether-dfa-is-fast-or-not.patch" Content-Disposition: attachment; filename="0001-dfa-minor-fix-for-whether-dfa-is-fast-or-not.patch" Content-Transfer-Encoding: base64 RnJvbSBhZjQzZjE3NGU1MGMzYzE0MTJkOGFiMzM2MGJkZTNiNmJkMDdiZWViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBGcmksIDUgQXVnIDIwMTYgMjA6MTU6MjQgKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IG1pbm9yIGZpeCBmb3Igd2hldGhlciBkZmEgaXMgZmFzdCBvciBub3QKCmRmYSBpcyBmYXN0IGlm IG9wdGltaXphdGlvbiBmb3IgdXRmLTggaXMgc3VjY2VzcywgYXMgZGZhIG1hdGNoZXIgdXNlcwph bGdvcml0aG0gZm9yIHNpbmdsZSBieXRlLgoKKiBzcmMvZGZhLmMgKGRmYW9wdGltaXplKTogVHVy biBmYXN0IGZsYWcgb24gaWYgb3B0aW1pemF0aW9uIGZvciB1dGYtOAppcyBzdWNjZXNzLgotLS0K IHNyYy9kZmEuYyB8ICAgIDEgKwogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2RmYS5jIGIvc3JjL2RmYS5jCmluZGV4IDU5 NmNjMTMuLjU1ZDc0MWMgMTAwNjQ0Ci0tLSBhL3NyYy9kZmEuYworKysgYi9zcmMvZGZhLmMKQEAg LTMzNjUsNiArMzM2NSw3IEBAIGRmYW9wdGltaXplIChzdHJ1Y3QgZGZhICpkKQogICBmcmVlX21i ZGF0YSAoZCk7CiAgIGQtPm11bHRpYnl0ZSA9IGZhbHNlOwogICBkLT5kZmFleGVjID0gZGZhZXhl Y19zYjsKKyAgZC0+ZmFzdCA9IHRydWU7CiB9CiAKIHN0YXRpYyB2b2lkCi0tIAoxLjcuMQoK --------_57A477250000000070F2_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 16:30:12 2016 Received: (at 24159) by debbugs.gnu.org; 5 Aug 2016 20:30:12 +0000 Received: from localhost ([127.0.0.1]:56869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVlky-00036S-2k for submit@debbugs.gnu.org; Fri, 05 Aug 2016 16:30:12 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:36316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVlkw-00035P-3x for 24159@debbugs.gnu.org; Fri, 05 Aug 2016 16:30:11 -0400 Received: by mail-oi0-f48.google.com with SMTP id f189so104231934oig.3 for <24159@debbugs.gnu.org>; Fri, 05 Aug 2016 13:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PesS+EksyOKYbJb5tam/0ugYLFMBB/VVbmGlHJMOKH0=; b=dSjX+9FigPEY3cO5L+1PlaziBAZ3MnBs7Aewap0kSv+TVs71EBBj1OD8JDIEo/5YId 9bq89uVj9sdbk6oJ8sAnYeSFcrHgPrYQm4qmO52prcfIAgyx68f9koH5CYvHL7fGC+ju AqVFPCt61x4SU1+QxIr2yIAAzszvGkHtJH05ivyUAyjWHXAwdT7eH9SERl8HFhkJdzJJ 5jyG/scKUn74v1HsYRfVxZ9Ph57sf3W28BwA8XWOhhmdqItx1YkTPU4PeoauG1CCrytn Bp640H2AlxmowJvN1Mnc7T0IdAkfFUsfXetZrCPba2CQg0MgIESiw1fl1vIDR3A8Luec vZxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PesS+EksyOKYbJb5tam/0ugYLFMBB/VVbmGlHJMOKH0=; b=BAXGex6i5x9yQvn2HOknk3OFYC/tjLt3aVEmPiGjLUkynjVLCOUY1gzXUOr27iCjwg NYpzcKFp8KJaUzQy/MAL6kH29QHa1qpNMTzvsuNrfUc3iL1ABHO7GfzOqb/on/K1T8S+ KPszCJfomKJ6ZroxCeRjrjrlfa95xp/VnbewmVUELjLvuR5R1bDNfJXOIevj6syiVstl H9LLVPXwMtKCY+y/kPPTwr9NdicuXAmXbck9k9nHRyxIWXuK5IRiI1RlThgA6tKkQH8k RZBiPs6rq7hwC6ZlRKQvCPuyaSFFgdk/tHyBRpMn9lTFRcAg8Su9REjff0ZQOqzh78Nc ZrPw== X-Gm-Message-State: AEkoouse6G1gR1wjGA+MBgPhyJIXZkvFCBKcLI2qbUJA9kZKFk1hQhE46IqeYJbA+Kjdvt6rZ+8G0cpgILg4Fg== X-Received: by 10.157.47.106 with SMTP id h97mr6765812otb.140.1470429004295; Fri, 05 Aug 2016 13:30:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.236.146 with HTTP; Fri, 5 Aug 2016 13:29:43 -0700 (PDT) In-Reply-To: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> References: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Fri, 5 Aug 2016 13:29:43 -0700 X-Google-Sender-Auth: CrXb74HHIHHEFAek90Gep32GiuM Message-ID: Subject: Re: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=94eb2c032d547808e8053958ee97 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24159 Cc: 24159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c032d547808e8053958ee97 Content-Type: text/plain; charset=UTF-8 On Fri, Aug 5, 2016 at 4:30 AM, Norihiro Tanaka wrote: > dfaoptimize() is not set fast flag even if it is success, but it is wrong. > If success, dfa matcher uses algorithm for single byte, and it is so fast. > > I think this bug does not affect for grep, but it will affect with the > patch that I just sent to gawk. Thank you for the patch. I was going to push it with the attached slightly updated log message. Note however that grep does use that -> fast member via dfasearch.c's use of the dfaisfast function. But then I realized I should at least verify with "make check", and found that this makes grep's dfa-match test fail. Thus, I will not be pushing it as-is. --94eb2c032d547808e8053958ee97 Content-Type: text/plain; charset=US-ASCII; name="0001-dfa-minor-fix-for-whether-dfa-is-fast.diff" Content-Disposition: attachment; filename="0001-dfa-minor-fix-for-whether-dfa-is-fast.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iri7a5vh1 RnJvbSA2MWUwNjYxZTFiMDg2Yzg5MzMxOTdmNDk4MTM5ZGIyNmYxNTdiNzEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBGcmksIDUgQXVnIDIwMTYgMjA6MTU6MjQgKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IG1pbm9yIGZpeCBmb3Igd2hldGhlciBkZmEgaXMgImZhc3QiCgoqIHNyYy9kZmEuYyAoZGZhb3B0 aW1pemUpOiBXaGVuIGEgVVRGLTggb3B0aW1pemF0aW9uIHN1Y2NlZWRzIGZvcgphIERGQSAoaXQg Y2FuIHVzZSBzaW5nbGUtYnl0ZSBjb2RlIHBhdGhzKSwgcmVjb3JkIHRoYXQgYnkgc2V0dGluZwpp dHMgLT5mYXN0IGZsYWcuCi0tLQogc3JjL2RmYS5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9zcmMvZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXggNTk2 Y2MxMy4uNTVkNzQxYyAxMDA2NDQKLS0tIGEvc3JjL2RmYS5jCisrKyBiL3NyYy9kZmEuYwpAQCAt MzM2NSw2ICszMzY1LDcgQEAgZGZhb3B0aW1pemUgKHN0cnVjdCBkZmEgKmQpCiAgIGZyZWVfbWJk YXRhIChkKTsKICAgZC0+bXVsdGlieXRlID0gZmFsc2U7CiAgIGQtPmRmYWV4ZWMgPSBkZmFleGVj X3NiOworICBkLT5mYXN0ID0gdHJ1ZTsKIH0KCiBzdGF0aWMgdm9pZAotLSAKMi44LjAtcmMyCgo= --94eb2c032d547808e8053958ee97-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 22:32:52 2016 Received: (at 24159) by debbugs.gnu.org; 6 Aug 2016 02:32:52 +0000 Received: from localhost ([127.0.0.1]:57035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVrPw-0004R6-Es for submit@debbugs.gnu.org; Fri, 05 Aug 2016 22:32:52 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:34839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVrPu-0004Qr-Le for 24159@debbugs.gnu.org; Fri, 05 Aug 2016 22:32:51 -0400 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id BD266F800D for <24159@debbugs.gnu.org>; Sat, 6 Aug 2016 11:32:44 +0900 (JST) X-matriXscan-loop-detect: 364e1be489672789129277892664b654f671f172 Received: from mail04.kcn.ne.jp ([61.86.6.183]) by mxs02-s with ESMTP; Sat, 06 Aug 2016 11:32:43 +0900 (JST) Received: from [10.120.1.17] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail04.kcn.ne.jp (Postfix) with ESMTPA id A1EE8129009A; Sat, 6 Aug 2016 11:32:43 +0900 (JST) Date: Sat, 06 Aug 2016 11:32:46 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not In-Reply-To: References: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> Message-Id: <20160806113245.E606.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 24159 Cc: 24159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) On Fri, 5 Aug 2016 13:29:43 -0700 Jim Meyering wrote: > On Fri, Aug 5, 2016 at 4:30 AM, Norihiro Tanaka wrote: > > dfaoptimize() is not set fast flag even if it is success, but it is wrong. > > If success, dfa matcher uses algorithm for single byte, and it is so fast. > > > > I think this bug does not affect for grep, but it will affect with the > > patch that I just sent to gawk. > > Thank you for the patch. > I was going to push it with the attached slightly updated log message. > Note however that grep does use that -> fast member via dfasearch.c's > use of the dfaisfast function. > But then I realized I should at least verify with "make check", and > found that this makes grep's dfa-match test fail. > Thus, I will not be pushing it as-is. Thanks for review and adjustment. I re-ran all tests including dfa-match, and they were passwd again in my machine. Next, I will re-run them on Fedora24, as my machine is RHEL 6.8 and GCC 4.4.7 which is too old. However, I do not know why dfa-match test fails on your machine. dfa-match test does not use grep. It directly calls dfa functions through dfa-match-aux executable in order to test codes of dfa which grep does not use. dfa-match-aux does not referer to the ->fast member. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 06 01:03:00 2016 Received: (at 24159-done) by debbugs.gnu.org; 6 Aug 2016 05:03:00 +0000 Received: from localhost ([127.0.0.1]:57059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVtlD-0007qR-UO for submit@debbugs.gnu.org; Sat, 06 Aug 2016 01:03:00 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:36592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVtlB-0007qB-QY for 24159-done@debbugs.gnu.org; Sat, 06 Aug 2016 01:02:58 -0400 Received: by mail-oi0-f52.google.com with SMTP id f189so114464024oig.3 for <24159-done@debbugs.gnu.org>; Fri, 05 Aug 2016 22:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GmyjwVeqbW1N6aJgslgZgMMUdp/FqT6IBW/Xt0Bi6Ic=; b=GzQ0EtWEYHj5MX89BAKvJFaH8bGvXLaoPLq9yPjd2FtTTFMDzDui7GvFhMSW0yuVYR 0kYg2jF64FWBlzg58DiitZ++XqQsuNtBagE9Cu2eo0Nj6CpyZA9zupueK48Xzfi7QqB6 TE+UFgHu2D2AcWFQfbgewI1qKj9qdb1/bLnoTBSxxI1p2nGani91zGvQvHAWUq+QBvsL /an1++V+Q9eG5b831t5VRJoSNVIlkKihmRqqLhKpRHc0bbXJ3bidnZYyUqElNcvgckEj biisXOGCFgjoOAL97jwkWkT2NzeJWW7zXRuKvf+mO7eebMQOcT0E9dFkWs+e0K8nE7x4 VOKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GmyjwVeqbW1N6aJgslgZgMMUdp/FqT6IBW/Xt0Bi6Ic=; b=HygiZ21uG4NkmeAozDMYahoTc7Qo62xkZrwXV7lD3AfpUNVHwRTxP7bxmktcqK37r4 yycM61yOMIQ1r16MJaENLsru7fx3gyutTDfkJmUAJK+rNDbqp34nWAvq3ZmJLixm/hEt ArBCRdK+++Cewb0gBU4h6MylOh/1Wtw+UteS3Wc+UB2oJ5NgfpivvX/zD+KeSaqVZu9W wR7CqpB5TCpUhBzPQNKoDJ61u46gaIOGPxGfxcrZErg4GtDxiquVOnZr1G/w0ZzKNEDj w/6MY3ycBDeTaZpOOAlpDk//TaGc5ub8x4HF/0f92zIBYzCr4r4Wm5/BRxdT3YT/aT6G XKDQ== X-Gm-Message-State: AEkoouspPhXMNm1DLIkv2Hqyp4HBNEm5EHmjuwUnxc51tsmmmm3GHLN9/Wo2jp6aMES7bGS1AbC1EzjeiAfYdA== X-Received: by 10.202.85.19 with SMTP id j19mr44060500oib.18.1470459772060; Fri, 05 Aug 2016 22:02:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.236.146 with HTTP; Fri, 5 Aug 2016 22:02:31 -0700 (PDT) In-Reply-To: <20160806113245.E606.27F6AC2D@kcn.ne.jp> References: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> <20160806113245.E606.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Fri, 5 Aug 2016 22:02:31 -0700 X-Google-Sender-Auth: sLmNElP1a4x7-x-Xt-L--mSuDKA Message-ID: Subject: Re: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=001a113d2bc05edaf30539601810 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24159-done Cc: 24159-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113d2bc05edaf30539601810 Content-Type: text/plain; charset=UTF-8 On Fri, Aug 5, 2016 at 7:32 PM, Norihiro Tanaka wrote: > > On Fri, 5 Aug 2016 13:29:43 -0700 > Jim Meyering wrote: > >> On Fri, Aug 5, 2016 at 4:30 AM, Norihiro Tanaka wrote: >> > dfaoptimize() is not set fast flag even if it is success, but it is wrong. >> > If success, dfa matcher uses algorithm for single byte, and it is so fast. >> > >> > I think this bug does not affect for grep, but it will affect with the >> > patch that I just sent to gawk. >> >> Thank you for the patch. >> I was going to push it with the attached slightly updated log message. >> Note however that grep does use that -> fast member via dfasearch.c's >> use of the dfaisfast function. >> But then I realized I should at least verify with "make check", and >> found that this makes grep's dfa-match test fail. >> Thus, I will not be pushing it as-is. > > Thanks for review and adjustment. I re-ran all tests including dfa-match, > and they were passwd again in my machine. Next, I will re-run them on > Fedora24, as my machine is RHEL 6.8 and GCC 4.4.7 which is too old. > > However, I do not know why dfa-match test fails on your machine. > dfa-match test does not use grep. It directly calls dfa functions through > dfa-match-aux executable in order to test codes of dfa which grep does > not use. dfa-match-aux does not referer to the ->fast member. I have examined the logs, which suggest it was a false positive in a parallelized "make check" run, due to that test's 3-second timeout. I have tried repeatedly to reproduce that failure, so far without success, but in coreutils development, with parallelized tests, we fixed many hard-to-reproduce tests with small timeout limits like this -- most of them now use 10 seconds as the limit, so I will change this one, too (and several others) with the attached patch. I have pushed your patch. --001a113d2bc05edaf30539601810 Content-Type: text/plain; charset=US-ASCII; name="0001-tests-standardize-on-10-second-timeouts-to-avoid-rar.diff" Content-Disposition: attachment; filename="0001-tests-standardize-on-10-second-timeouts-to-avoid-rar.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iripqsed1 RnJvbSBkZjhjMmI2NjJiNjhiYzgxY2E2OTQxZGE0NWY2MzlmZjgwNmEzMDM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog RnJpLCA1IEF1ZyAyMDE2IDIxOjUzOjQ1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdHM6IHN0 YW5kYXJkaXplIG9uIDEwLXNlY29uZCB0aW1lb3V0cyB0byBhdm9pZCByYXJlIGZhbHNlCiBmYWls dXJlCgpJbiBhIHBhcmFsbGVsIHRlc3QgcnVuLCBpdCBpcyBub3QgdW51c3VhbCB0byBleGNlZWQg YSB0aW1lb3V0IG9mCjEtMyBzZWNvbmRzLiAgSW5jcmVhc2Ugc2V2ZXJhbCBmcm9tIDMgb3IgZmV3 ZXIgdG8gMTAgc2Vjb25kcy4KKiB0ZXN0cy9za2lwLWRldmljZTogSW5jcmVhc2UgdGltZW91dCBm cm9tIDIgdG8gMTAgc2Vjb25kcy4KKiB0ZXN0cy9ncmVwLWRldi1udWxsLW91dDogTGlrZXdpc2Us IGJ1dCBzLzEvMTAvLgoqIHRlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0OiBMaWtld2lzZSwg YnV0IHMvMy8xMC8uCiogdGVzdHMvZGZhLW1hdGNoOiBMaWtld2lzZS4KKiB0ZXN0cy9wY3JlLWlu dmFsaWQtdXRmOC1pbmZsb29wOiBMaWtld2lzZS4KKiB0ZXN0cy9wY3JlLWluZmxvb3A6IExpa2V3 aXNlLgoqIHRlc3RzL21heC1jb3VudC1vdmVycmVhZDogTGlrZXdpc2UuCiogdGVzdHMvaW52YWxp ZC1tdWx0aWJ5dGUtaW5mbG9vcDogTGlrZXdpc2UuClByb21wdGVkIGJ5IGh0dHA6Ly9idWdzLmdu dS5vcmcvMjQxNTkuCi0tLQogdGVzdHMvZGZhLW1hdGNoICAgICAgICAgICAgICAgICB8IDIgKy0K IHRlc3RzL2dyZXAtZGV2LW51bGwtb3V0ICAgICAgICAgfCAyICstCiB0ZXN0cy9pbnZhbGlkLW11 bHRpYnl0ZS1pbmZsb29wIHwgNCArKy0tCiB0ZXN0cy9tYXgtY291bnQtb3ZlcnJlYWQgICAgICAg IHwgMiArLQogdGVzdHMvcGNyZS1pbmZsb29wICAgICAgICAgICAgICB8IDIgKy0KIHRlc3RzL3Bj cmUtaW52YWxpZC11dGY4LWluZmxvb3AgfCAyICstCiB0ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1p bnB1dCAgIHwgOCArKysrLS0tLQogdGVzdHMvc2tpcC1kZXZpY2UgICAgICAgICAgICAgICB8IDIg Ky0KIDggZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvdGVzdHMvZGZhLW1hdGNoIGIvdGVzdHMvZGZhLW1hdGNoCmluZGV4IDM3M2M4 M2MuLjg0NmFiMWYgMTAwNzU1Ci0tLSBhL3Rlc3RzL2RmYS1tYXRjaAorKysgYi90ZXN0cy9kZmEt bWF0Y2gKQEAgLTM1LDcgKzM1LDcgQEAgZmkKCiBmYWlsMj0wCiBpbj0kKHByaW50ZiAiYmJcbmJi IikKLXRpbWVvdXQgMyBkZmEtbWF0Y2gtYXV4IGEgIiRpbiIgMSA+IG91dCB8fCBmYWlsMj0xCit0 aW1lb3V0IDEwIGRmYS1tYXRjaC1hdXggYSAiJGluIiAxID4gb3V0IHx8IGZhaWwyPTEKIGNvbXBh cmUgL2Rldi9udWxsIG91dCB8fCBmYWlsMj0xCiBpZiB0ZXN0ICRmYWlsMiAtbmUgMDsgdGhlbgog ICB3YXJuXyAnZGZhLW1hdGNoIHRlc3QgIzIgZmFpbGVkXG4nCmRpZmYgLS1naXQgYS90ZXN0cy9n cmVwLWRldi1udWxsLW91dCBiL3Rlc3RzL2dyZXAtZGV2LW51bGwtb3V0CmluZGV4IGYzMDcwMGQu LjdmMGUxYzUgMTAwNzU1Ci0tLSBhL3Rlc3RzL2dyZXAtZGV2LW51bGwtb3V0CisrKyBiL3Rlc3Rz L2dyZXAtZGV2LW51bGwtb3V0CkBAIC02LDYgKzYsNiBAQAogcmVxdWlyZV90aW1lb3V0XwoKICR7 QVdLLWF3a30gJ0JFR0lOIHt3aGlsZSAoMSkgcHJpbnQgIngifScgPC9kZXYvbnVsbCB8Ci0gIHRp bWVvdXQgMSBncmVwIHggPi9kZXYvbnVsbCB8fCBmYWlsPTEKKyAgdGltZW91dCAxMCBncmVwIHgg Pi9kZXYvbnVsbCB8fCBmYWlsPTEKCiBFeGl0ICRmYWlsCmRpZmYgLS1naXQgYS90ZXN0cy9pbnZh bGlkLW11bHRpYnl0ZS1pbmZsb29wIGIvdGVzdHMvaW52YWxpZC1tdWx0aWJ5dGUtaW5mbG9vcApp bmRleCBkN2M2MTY1Li41YjNiZGZjIDEwMDc1NQotLS0gYS90ZXN0cy9pbnZhbGlkLW11bHRpYnl0 ZS1pbmZsb29wCisrKyBiL3Rlc3RzL2ludmFsaWQtbXVsdGlieXRlLWluZmxvb3AKQEAgLTE0LDcg KzE0LDcgQEAgZW5jb2RlIEFBID4gaW5wdXQKIGZhaWw9MAoKICMgQmVmb3JlIDIuMTUsIHRoaXMg d291bGQgaW5mbG9vcC4KLUxDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDMgZ3JlcCAtYUYgJChl bmNvZGUgQSkgaW5wdXQgPiBvdXQKK0xDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDEwIGdyZXAg LWFGICQoZW5jb2RlIEEpIGlucHV0ID4gb3V0CiBzdGF0dXM9JD8KIGlmIHRlc3QgJHN0YXR1cyAt ZXEgMDsgdGhlbgogICBjb21wYXJlIGlucHV0IG91dApAQCAtMjYsNyArMjYsNyBAQCBmaSB8fCBm YWlsPTEKCiBlY2hvICdCaW5hcnkgZmlsZSBpbnB1dCBtYXRjaGVzJyA+YmluYXJ5LWZpbGUtbWF0 Y2hlcwoKLUxDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDMgZ3JlcCAtRiAkKGVuY29kZSBBKSBp bnB1dCA+IG91dAorTENfQUxMPWVuX1VTLlVURi04IHRpbWVvdXQgMTAgZ3JlcCAtRiAkKGVuY29k ZSBBKSBpbnB1dCA+IG91dAogc3RhdHVzPSQ/CiBpZiB0ZXN0ICRzdGF0dXMgLWVxIDA7IHRoZW4K ICAgY29tcGFyZSBiaW5hcnktZmlsZS1tYXRjaGVzIG91dApkaWZmIC0tZ2l0IGEvdGVzdHMvbWF4 LWNvdW50LW92ZXJyZWFkIGIvdGVzdHMvbWF4LWNvdW50LW92ZXJyZWFkCmluZGV4IGQ3YWFmZDYu LjIzYzQ1Y2IgMTAwNzU1Ci0tLSBhL3Rlc3RzL21heC1jb3VudC1vdmVycmVhZAorKysgYi90ZXN0 cy9tYXgtY291bnQtb3ZlcnJlYWQKQEAgLTksNyArOSw3IEBAIGZhaWw9MAoKIGVjaG8geCA+IGV4 cCB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KCi15ZXMgeCB8IHRpbWVvdXQgMyBncmVwIC1tMSB4ID4g b3V0IHx8IGZhaWw9MQoreWVzIHggfCB0aW1lb3V0IDEwIGdyZXAgLW0xIHggPiBvdXQgfHwgZmFp bD0xCiBjb21wYXJlIGV4cCBvdXQgfHwgZmFpbD0xCgogRXhpdCAkZmFpbApkaWZmIC0tZ2l0IGEv dGVzdHMvcGNyZS1pbmZsb29wIGIvdGVzdHMvcGNyZS1pbmZsb29wCmluZGV4IDJmOTNlNzAuLjE3 OWJmODYgMTAwNzU1Ci0tLSBhL3Rlc3RzL3BjcmUtaW5mbG9vcAorKysgYi90ZXN0cy9wY3JlLWlu Zmxvb3AKQEAgLTI3LDcgKzI3LDcgQEAgcHJpbnRmICdhXDIwMWJccicgPiBpbiB8fCBmcmFtZXdv cmtfZmFpbHVyZV8KCiBmYWlsPTAKCi1MQ19BTEw9ZW5fVVMuVVRGLTggdGltZW91dCAzIGdyZXAg LVAgJ2EuPy4uYicgaW4KK0xDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDEwIGdyZXAgLVAgJ2Eu Py4uYicgaW4KIHRlc3QgJD8gPSAxIHx8IGZhaWxfICJsaWJwY3JlJ3MgbWF0Y2ggZnVuY3Rpb24g YXBwZWFycyB0byBpbmZsb29wIgoKIEV4aXQgJGZhaWwKZGlmZiAtLWdpdCBhL3Rlc3RzL3BjcmUt aW52YWxpZC11dGY4LWluZmxvb3AgYi90ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1pbmZsb29wCmlu ZGV4IGU5NmYxZjUuLmUwNTAzYmMgMTAwNzU1Ci0tLSBhL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4 LWluZmxvb3AKKysrIGIvdGVzdHMvcGNyZS1pbnZhbGlkLXV0ZjgtaW5mbG9vcApAQCAtMTgsNyAr MTgsNyBAQCBmYWlsPTAKIHByaW50ZiAnXDIwMV9cMCcgPiBpbiB8fCBmcmFtZXdvcmtfZmFpbHVy ZV8KIHByaW50ZiAnX1xuJyA+IGV4cCB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KCi1MQ19BTEw9ZW5f VVMuVVRGLTggdGltZW91dCAzIGdyZXAgLWFvUCBfIGluID4gb3V0IDI+IGVyciB8fCBmYWlsPTEK K0xDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDEwIGdyZXAgLWFvUCBfIGluID4gb3V0IDI+IGVy ciB8fCBmYWlsPTEKCiBjb21wYXJlIGV4cCBvdXQgfHwgZmFpbD0xCiBjb21wYXJlIC9kZXYvbnVs bCBlcnIgfHwgZmFpbD0xCmRpZmYgLS1naXQgYS90ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1pbnB1 dCBiL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0CmluZGV4IGZlYzIzYWUuLjE3YzFkNGUg MTAwNzU1Ci0tLSBhL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0CisrKyBiL3Rlc3RzL3Bj cmUtaW52YWxpZC11dGY4LWlucHV0CkBAIC0xLDUgKzEsNSBAQAogIyEgL2Jpbi9zaAotIyBFbnN1 cmUgdGhhdCBncmVwIC1QIGRvZXNuJ3QgYWJvcnQgZm9yIGludmFsaWQgbXVsdGktYnl0ZSBpbnB1 dAorIyBFbnN1cmUgdGhhdCBncmVwIC1QIGRvZXNuJ3QgYWJvcnQgb3IgaW5mbG9vcCBmb3IgaW52 YWxpZCBtdWx0aS1ieXRlIGlucHV0CiAjCiAjIENvcHlyaWdodCAoQykgMjAxMy0yMDE2IEZyZWUg U29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgogIwpAQCAtMTcsMTUgKzE3LDE1IEBAIGZhaWw9MAoK IHByaW50ZiAnalwyMDJqXG5qXG5rXDIwMlxuJyA+IGluIHx8IGZyYW1ld29ya19mYWlsdXJlXwoK LUxDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDMgZ3JlcCAtUCBqIGluCitMQ19BTEw9ZW5fVVMu VVRGLTggdGltZW91dCAxMCBncmVwIC1QIGogaW4KIHRlc3QgJD8gLWVxIDAgfHwgZmFpbD0xCgot TENfQUxMPWVuX1VTLlVURi04IHRpbWVvdXQgMyBncmVwIC1QICdrJCcgaW4KK0xDX0FMTD1lbl9V Uy5VVEYtOCB0aW1lb3V0IDEwIGdyZXAgLVAgJ2skJyBpbgogdGVzdCAkPyAtZXEgMSB8fCBmYWls PTEKCiBlY2hvIGsgPmV4cAoKLUxDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDMgZ3JlcCAtYW9Q ICdrKicgaW4gPm91dCB8fCBmYWlsPTEKK0xDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDEwIGdy ZXAgLWFvUCAnayonIGluID5vdXQgfHwgZmFpbD0xCiBjb21wYXJlIGV4cCBvdXQgfHwgZmFpbD0x CgogRXhpdCAkZmFpbApkaWZmIC0tZ2l0IGEvdGVzdHMvc2tpcC1kZXZpY2UgYi90ZXN0cy9za2lw LWRldmljZQppbmRleCBlNzNiYWQzLi5kNjM2OGYxIDEwMDc1NQotLS0gYS90ZXN0cy9za2lwLWRl dmljZQorKysgYi90ZXN0cy9za2lwLWRldmljZQpAQCAtMTAsNyArMTAsNyBAQCBlY2hvIGZvbyB8 IGdyZXAgLS1kZXZpY2VzPXNraXAgZm9vIHx8IGZhaWw9MQoKIHJlcXVpcmVfdGltZW91dF8KIG1r ZmlmbyBteWZpZm8gfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCi10aW1lb3V0IDJzIGdyZXAgLUQgc2tp cCBmb28gbXlmaWZvCit0aW1lb3V0IDEwIGdyZXAgLUQgc2tpcCBmb28gbXlmaWZvCiB0ZXN0ICQ/ IC1lcSAxIHx8IGZhaWw9MQoKIEV4aXQgJGZhaWwKLS0gCjIuOC4wLXJjMgoK --001a113d2bc05edaf30539601810-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 06 01:06:06 2016 Received: (at 24159-done) by debbugs.gnu.org; 6 Aug 2016 05:06:06 +0000 Received: from localhost ([127.0.0.1]:57066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVtoE-0007vf-Iv for submit@debbugs.gnu.org; Sat, 06 Aug 2016 01:06:06 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:33897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVtoD-0007vB-2x for 24159-done@debbugs.gnu.org; Sat, 06 Aug 2016 01:06:05 -0400 Received: by mail-oi0-f41.google.com with SMTP id l203so54764841oib.1 for <24159-done@debbugs.gnu.org>; Fri, 05 Aug 2016 22:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=KP8I1EVFmhxDpYbk7KYbyNNlOTHp1xLe7jN1fMyLS2Q=; b=VOAHD6PpbI6PVCKeAJkYRqhYmEKpDgcLk/pXj+nirTwCHtccGFAsXScj6WWRfjGDAo h5v7+hNy5C4rDjJeBmXih0nu7hF9RDlamipKpU3WWZi+FnSjkfLDtK7AsUl/PtZDtyUF bwPs7D+cZ1cfePf7BBsv1/WQS60he6/wTuu66b+I1+nFvkd80CBGCK8sXLkitsSwy9J8 VV2xY26W87+X+T7+lD9dPWwwt5MWvb4i6e/qBiA2QL8Ub4X61VR9uyFT3SLTf2TfkUbw dOKvqJCcts1Q6ZiUYOPX7jknnNjLp+SCS/OJesECcc66ag/8TxzUyiwxYp/ufwx/S7Dr nF8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=KP8I1EVFmhxDpYbk7KYbyNNlOTHp1xLe7jN1fMyLS2Q=; b=Uaab/9WOhGLb4VjanQPb7dBrMe9m9pVt/EILsBTyGzlmx7Y/p+oi0/HGfexKMUljtM KztU5Ej0OoShLF5fRqw5qq7qaj1SSq98H/KgNonGSVcxoNlC+lZRlaxsOq5OFfAgQm4+ e11p74vyTDMzSlTijlL9DnEpjMOH4dmurpjZEEMIxwZbdr0k6Bsy1XsLjOvszbCkaCZg Z8x8Ui59Rsy6r4PDiTOGrnRLWLhK0LQyfTBKzA27hB64MqggFEyMbiios8U7YwEZojOS k52TVrWCwVD9nr+EZK2NWRfZIYvITuVP7/BXMW8/2tycBNxeRqklG7nWEELbia9VdZj+ Ky6Q== X-Gm-Message-State: AEkooutuFTfF9yzDBp2KYWYFkzp0OuSAZYaAkdVvhaHSrDb+CqGct4wQBc0fYWZHrgIG1NVe4rkD2AMQaelZvQ== X-Received: by 10.157.47.106 with SMTP id h97mr7500467otb.140.1470459959698; Fri, 05 Aug 2016 22:05:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.236.146 with HTTP; Fri, 5 Aug 2016 22:05:38 -0700 (PDT) In-Reply-To: References: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> <20160806113245.E606.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Fri, 5 Aug 2016 22:05:38 -0700 X-Google-Sender-Auth: s1tmeVTnwx5BTziHSpx5O1gYe1s Message-ID: Subject: Re: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=94eb2c032d548e01da05396023d5 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24159-done Cc: 24159-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c032d548e01da05396023d5 Content-Type: text/plain; charset=UTF-8 On Fri, Aug 5, 2016 at 10:02 PM, Jim Meyering wrote: > On Fri, Aug 5, 2016 at 7:32 PM, Norihiro Tanaka wrote: >> >> On Fri, 5 Aug 2016 13:29:43 -0700 >> Jim Meyering wrote: >> >>> On Fri, Aug 5, 2016 at 4:30 AM, Norihiro Tanaka wrote: >>> > dfaoptimize() is not set fast flag even if it is success, but it is wrong. >>> > If success, dfa matcher uses algorithm for single byte, and it is so fast. >>> > >>> > I think this bug does not affect for grep, but it will affect with the >>> > patch that I just sent to gawk. >>> >>> Thank you for the patch. >>> I was going to push it with the attached slightly updated log message. >>> Note however that grep does use that -> fast member via dfasearch.c's >>> use of the dfaisfast function. >>> But then I realized I should at least verify with "make check", and >>> found that this makes grep's dfa-match test fail. >>> Thus, I will not be pushing it as-is. >> >> Thanks for review and adjustment. I re-ran all tests including dfa-match, >> and they were passwd again in my machine. Next, I will re-run them on >> Fedora24, as my machine is RHEL 6.8 and GCC 4.4.7 which is too old. >> >> However, I do not know why dfa-match test fails on your machine. >> dfa-match test does not use grep. It directly calls dfa functions through >> dfa-match-aux executable in order to test codes of dfa which grep does >> not use. dfa-match-aux does not referer to the ->fast member. > > I have examined the logs, which suggest it was a false positive in a > parallelized "make check" run, due to that test's 3-second timeout. I > have tried repeatedly to reproduce that failure, so far without > success, but in coreutils development, with parallelized tests, we > fixed many hard-to-reproduce tests with small timeout limits like this > -- most of them now use 10 seconds as the limit, so I will change this > one, too (and several others) with the attached patch. > > I have pushed your patch. While trying to reproduce that, I ran some tests on OS X and saw frequent failure of one of the tests, so wrote the attached to work around what I assume is an aggressive write-to-/dev/null optimization: --94eb2c032d548e01da05396023d5 Content-Type: text/plain; charset=US-ASCII; name="0001-tests-avoid-occasional-false-positive-on-OS-X.diff" Content-Disposition: attachment; filename="0001-tests-avoid-occasional-false-positive-on-OS-X.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iripv0n01 RnJvbSA0MjhhNDMzY2EwYTE5NjI4OTIyNTU0ZjEwZTU1YTVkOTE1NDBjMTVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog RnJpLCA1IEF1ZyAyMDE2IDIxOjM4OjMwIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdHM6IGF2 b2lkIG9jY2FzaW9uYWwgZmFsc2UgcG9zaXRpdmUgb24gT1MgWAoKKiB0ZXN0cy9iYWNrcmVmLW11 bHRpYnl0ZS1zbG93OiBXaGVuIHJlZGlyZWN0aW5nIHRoZSAiZmFzdCIKTENfQUxMPUMgcnVuJ3Mg b3V0cHV0IHRvIC9kZXYvbnVsbCwgd2UgZ290IGFuIGFydGlmaWNpYWxseSBsb3cKdGltaW5nIChv ZiAwKSwgYmVjYXVzZSBvZiBob3cgc29tZSBzeXN0ZW1zIGlnbm9yZSB3cml0ZXMgdG8KL2Rldi9u dWxsLiAgV2l0aCBhbiBpbml0aWFsIHRpbWluZyBvZiAwIG9uIHRoYXQgZmlyc3QgcnVuLCB0aGUK ZGVyaXZlZCB0aW1lb3V0IGZvciB0aGUgVVRGLTggcnVuICh3aGljaCByZWRpcmVjdHMgdG8gYSBm aWxlKQp3b3VsZCBiZSBhIG1lcmUgMSBzZWNvbmQuICBUaGUgZml4OiBhbHNvIHJlZGlyZWN0IHRo YXQgZmlyc3QgcnVuJ3MKb3V0cHV0IHRvIGEgZmlsZSwgbm90IHRvIC9kZXYvbnVsbC4KLS0tCiB0 ZXN0cy9iYWNrcmVmLW11bHRpYnl0ZS1zbG93IHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvdGVzdHMvYmFja3JlZi1tdWx0 aWJ5dGUtc2xvdyBiL3Rlc3RzL2JhY2tyZWYtbXVsdGlieXRlLXNsb3cKaW5kZXggZDQ0N2E0YS4u MDViYjYyZSAxMDA3NTUKLS0tIGEvdGVzdHMvYmFja3JlZi1tdWx0aWJ5dGUtc2xvdworKysgYi90 ZXN0cy9iYWNrcmVmLW11bHRpYnl0ZS1zbG93CkBAIC0xNCw3ICsxNCw3IEBAICRBV0sgJ0JFR0lO IHtmb3IgKGk9MDsgaTwxMzAwMDsgaSsrKSBwcmludCAiYWJhIn0nIC9kZXYvbnVsbCA+IGluIHx8 IGZhaWw9MQogIyB3aGVuIHJ1bm5pbmcgaW4gZW5fVVMuVVRGLTguICBSb3VuZCB1cCB0byB3aG9s ZSBzZWNvbmRzLCBzaW5jZSB0aW1lb3V0CiAjIGNhbid0IGRlYWwgd2l0aCBmcmFjdGlvbmFsIHNl Y29uZHMuCiBtYXhfc2Vjb25kcz0kKExDX0FMTD1DIHBlcmwgLWxlICd1c2UgVGltZTo6SGlSZXMg cXcodGltZSk7IG15ICRzID0gdGltZSgpOwotICAgICAgICAgICAgICBzeXN0ZW0gcSxncmVwIC1F ICdcJydeKFthLXpdKS5cMSQnXCcnIGluID4gL2Rldi9udWxsLDsKKyAgICAgICAgICAgICAgc3lz dGVtIHEsZ3JlcCAtRSAnXCcnXihbYS16XSkuXDEkJ1wnJyBpbiA+IGp1bmssOwogICAgICAgICAg ICAgICBteSAkZWxhcHNlZCA9IHRpbWUoKSAtICRzOyBwcmludCBpbnQgKDEgKyAxMCAqICRlbGFw c2VkKScpIFwKICAgfHwgeyBtYXhfc2Vjb25kcz01OwogICAgICAgIHdhcm5fICIkTUVfOiB3YXJu aW5nOiBubyBwZXJsPyB1c2luZyBkZWZhdWx0IG9mIDVzIHRpbWVvdXQiOyB9Ci0tIAoyLjguMC1y YzIKCg== --94eb2c032d548e01da05396023d5-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 06 04:20:45 2016 Received: (at 24159-done) by debbugs.gnu.org; 6 Aug 2016 08:20:45 +0000 Received: from localhost ([127.0.0.1]:57125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVwqb-0005ma-Cr for submit@debbugs.gnu.org; Sat, 06 Aug 2016 04:20:45 -0400 Received: from mailgw05.kcn.ne.jp ([61.86.7.212]:41696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVwqZ-0005mM-7r for 24159-done@debbugs.gnu.org; Sat, 06 Aug 2016 04:20:43 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw05.kcn.ne.jp (Postfix) with ESMTP id 0F10A8806AD for <24159-done@debbugs.gnu.org>; Sat, 6 Aug 2016 17:20:36 +0900 (JST) X-matriXscan-loop-detect: 3b4b5e1390e9f2de9b031d41071bf5a4678a97f2 Received: from mail08.kcn.ne.jp ([61.86.6.187]) by mxs01-s with ESMTP; Sat, 06 Aug 2016 17:20:34 +0900 (JST) Received: from [10.120.1.17] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail08.kcn.ne.jp (Postfix) with ESMTPA id 2298012B8098; Sat, 6 Aug 2016 17:20:34 +0900 (JST) Date: Sat, 06 Aug 2016 17:20:35 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not In-Reply-To: References: <20160806113245.E606.27F6AC2D@kcn.ne.jp> Message-Id: <20160806172034.E61F.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 24159-done Cc: 24159-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) On Fri, 5 Aug 2016 22:02:31 -0700 Jim Meyering wrote: > I have examined the logs, which suggest it was a false positive in a > parallelized "make check" run, due to that test's 3-second timeout. I > have tried repeatedly to reproduce that failure, so far without > success, but in coreutils development, with parallelized tests, we > fixed many hard-to-reproduce tests with small timeout limits like this > -- most of them now use 10 seconds as the limit, so I will change this > one, too (and several others) with the attached patch. > > I have pushed your patch. Thanks for exampination and push. I ran tests on fedora 24 (GCC 6.1.1), and all tests are passwd with before and after patch, and after patching your 10 seconds patch in addition. Norihiro From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 06 12:29:41 2016 Received: (at 24159-done) by debbugs.gnu.org; 6 Aug 2016 16:29:41 +0000 Received: from localhost ([127.0.0.1]:58098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW4Tl-0002Pl-Cd for submit@debbugs.gnu.org; Sat, 06 Aug 2016 12:29:41 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:36275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW4Tj-0002PY-Ee for 24159-done@debbugs.gnu.org; Sat, 06 Aug 2016 12:29:40 -0400 Received: by mail-oi0-f42.google.com with SMTP id f189so126258800oig.3 for <24159-done@debbugs.gnu.org>; Sat, 06 Aug 2016 09:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=2/WyKRu5hlr0p6E12R5vs9+O7PXYcBuMljbTfzw7V9Y=; b=qvZH196Ev6msZ0usdPqdrZg4OxgG6CZPCS+d/EGU9fGdVtV/ePBaffocgdt9lpfQ9n ZjUj8Ow0y0DU8ewIZlW8M2+WIO67uhe/9npWcheWPQpOqQ6kR2JXEW9wzEUAsZ0waXSM YkSB0ypEbCEogMjHe4EZmj7xep6qVOPzbShJnIERuAEGQ+DEJpokM95kYpQBmDyOHVie qpAnv7aoGq5Bm9pVY9q/HTFTFBcRXiFBeQqJfLMy9/MRGVPXq3Of0b4J22tWGuHagTOl ZUvh7elaEROU1EZosVi2n4TDMK+bhEgWpwKIHw/U9FfHIQXgQIAfmOlE1BhwqVO0bHsj 02uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=2/WyKRu5hlr0p6E12R5vs9+O7PXYcBuMljbTfzw7V9Y=; b=Yu9dEG7pvDYD/l874zOplUJXHmDd9sZiNV1jzKLLMik5Qtjzw7oghWjZtcAc894R92 R09TCG6RPNNhV81AWgDHjAoAuv1K3xUKerVgpi0lVKQ5I+Z/tcdQTHG576LAz0Zny5wg QCnRTeEQR7PjrLta461zQ8u+PcNS9AwlSQYrrA0sCTbTh/had4TMxjZcRr3jTmTnGvRx NfI5Vk7qGPPVRvLEIALJTHsLiXF4cxnYdRAhEccCsThnTZoCR6E4bGDfpmCvy2NOGkHP kV4Ht8P5o9MzkFta1SRNb5nW1btnO/wTSqiE/TMQ1MjAcyx0ncpepPczvWkTtXpZMR2x vFVQ== X-Gm-Message-State: AEkoouuPTUSSxnqUxRtLmmLfLdTLoSSW5sx/ttzdAGfOjqpZxYyxOnqM7MkBVoINCbKp9VZS2IOCj8VhWcM1Iw== X-Received: by 10.202.88.196 with SMTP id m187mr50528446oib.39.1470500973756; Sat, 06 Aug 2016 09:29:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.236.146 with HTTP; Sat, 6 Aug 2016 09:29:12 -0700 (PDT) In-Reply-To: References: <20160805203048.70DE.27F6AC2D@kcn.ne.jp> <20160806113245.E606.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sat, 6 Aug 2016 09:29:12 -0700 X-Google-Sender-Auth: hN2sfyFJCRhBsXp1ze_Ir7FPHSk Message-ID: Subject: Re: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=001a113d3c462ee65d053969b089 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24159-done Cc: 24159-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113d3c462ee65d053969b089 Content-Type: text/plain; charset=UTF-8 On Fri, Aug 5, 2016 at 10:05 PM, Jim Meyering wrote: > On Fri, Aug 5, 2016 at 10:02 PM, Jim Meyering wrote: >> On Fri, Aug 5, 2016 at 7:32 PM, Norihiro Tanaka wrote: >>> >>> On Fri, 5 Aug 2016 13:29:43 -0700 >>> Jim Meyering wrote: >>> >>>> On Fri, Aug 5, 2016 at 4:30 AM, Norihiro Tanaka wrote: >>>> > dfaoptimize() is not set fast flag even if it is success, but it is wrong. >>>> > If success, dfa matcher uses algorithm for single byte, and it is so fast. >>>> > >>>> > I think this bug does not affect for grep, but it will affect with the >>>> > patch that I just sent to gawk. >>>> >>>> Thank you for the patch. >>>> I was going to push it with the attached slightly updated log message. >>>> Note however that grep does use that -> fast member via dfasearch.c's >>>> use of the dfaisfast function. >>>> But then I realized I should at least verify with "make check", and >>>> found that this makes grep's dfa-match test fail. >>>> Thus, I will not be pushing it as-is. >>> >>> Thanks for review and adjustment. I re-ran all tests including dfa-match, >>> and they were passwd again in my machine. Next, I will re-run them on >>> Fedora24, as my machine is RHEL 6.8 and GCC 4.4.7 which is too old. >>> >>> However, I do not know why dfa-match test fails on your machine. >>> dfa-match test does not use grep. It directly calls dfa functions through >>> dfa-match-aux executable in order to test codes of dfa which grep does >>> not use. dfa-match-aux does not referer to the ->fast member. >> >> I have examined the logs, which suggest it was a false positive in a >> parallelized "make check" run, due to that test's 3-second timeout. I >> have tried repeatedly to reproduce that failure, so far without >> success, but in coreutils development, with parallelized tests, we >> fixed many hard-to-reproduce tests with small timeout limits like this >> -- most of them now use 10 seconds as the limit, so I will change this >> one, too (and several others) with the attached patch. >> >> I have pushed your patch. > > While trying to reproduce that, I ran some tests on OS X and saw > frequent failure of one of the tests, so wrote the attached to work > around what I assume is an aggressive write-to-/dev/null optimization: Dug deeper and saw it was due to grep's own new stdout-vs-/dev/null optimization. I've updated the comment and pushed this: --001a113d3c462ee65d053969b089 Content-Type: text/plain; charset=US-ASCII; name="0001-tests-backref-multibyte-slow-avoid-false-positive.diff" Content-Disposition: attachment; filename="0001-tests-backref-multibyte-slow-avoid-false-positive.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irjealul1 RnJvbSBhMmEzZGY5NTNhOTFmODk4YmQ5NGYwNWEyNjA4OGNjZGMzNTFmYjNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog RnJpLCA1IEF1ZyAyMDE2IDIxOjM4OjMwIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdHMvYmFj a3JlZi1tdWx0aWJ5dGUtc2xvdzo6IGF2b2lkIGZhbHNlIHBvc2l0aXZlCgoqIHRlc3RzL2JhY2ty ZWYtbXVsdGlieXRlLXNsb3c6IFdoZW4gcmVkaXJlY3RpbmcgdGhlICJmYXN0IiBMQ19BTEw9Qwpy dW4ncyBvdXRwdXQgdG8gL2Rldi9udWxsLCB3ZSBnb3QgYW4gYXJ0aWZpY2lhbGx5IGxvdyB0aW1p bmcgKG9mIDApLApkdWUgdG8gZ3JlcCdzIG93biBzdGRvdXQtdnMtL2Rldi9udWxsIG9wdGltaXph dGlvbi4gIFdpdGggYW4gaW5pdGlhbAp0aW1pbmcgb2YgMCBvbiB0aGF0IGZpcnN0IHJ1biwgdGhl IGRlcml2ZWQgdGltZW91dCBmb3IgdGhlIFVURi04IHJ1bgood2hpY2ggcmVkaXJlY3RzIHRvIGEg ZmlsZSkgd291bGQgYmUgYSBtZXJlIDEgc2Vjb25kLiAgVGhlIGZpeDogYWxzbwpyZWRpcmVjdCB0 aGF0IGZpcnN0IHJ1bidzIG91dHB1dCB0byBhIGZpbGUsIG5vdCB0byAvZGV2L251bGwuCi0tLQog dGVzdHMvYmFja3JlZi1tdWx0aWJ5dGUtc2xvdyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3Rlc3RzL2JhY2tyZWYtbXVs dGlieXRlLXNsb3cgYi90ZXN0cy9iYWNrcmVmLW11bHRpYnl0ZS1zbG93CmluZGV4IGQ0NDdhNGEu LjA1YmI2MmUgMTAwNzU1Ci0tLSBhL3Rlc3RzL2JhY2tyZWYtbXVsdGlieXRlLXNsb3cKKysrIGIv dGVzdHMvYmFja3JlZi1tdWx0aWJ5dGUtc2xvdwpAQCAtMTQsNyArMTQsNyBAQCAkQVdLICdCRUdJ TiB7Zm9yIChpPTA7IGk8MTMwMDA7IGkrKykgcHJpbnQgImFiYSJ9JyAvZGV2L251bGwgPiBpbiB8 fCBmYWlsPTEKICMgd2hlbiBydW5uaW5nIGluIGVuX1VTLlVURi04LiAgUm91bmQgdXAgdG8gd2hv bGUgc2Vjb25kcywgc2luY2UgdGltZW91dAogIyBjYW4ndCBkZWFsIHdpdGggZnJhY3Rpb25hbCBz ZWNvbmRzLgogbWF4X3NlY29uZHM9JChMQ19BTEw9QyBwZXJsIC1sZSAndXNlIFRpbWU6OkhpUmVz IHF3KHRpbWUpOyBteSAkcyA9IHRpbWUoKTsKLSAgICAgICAgICAgICAgc3lzdGVtIHEsZ3JlcCAt RSAnXCcnXihbYS16XSkuXDEkJ1wnJyBpbiA+IC9kZXYvbnVsbCw7CisgICAgICAgICAgICAgIHN5 c3RlbSBxLGdyZXAgLUUgJ1wnJ14oW2Etel0pLlwxJCdcJycgaW4gPiBqdW5rLDsKICAgICAgICAg ICAgICAgbXkgJGVsYXBzZWQgPSB0aW1lKCkgLSAkczsgcHJpbnQgaW50ICgxICsgMTAgKiAkZWxh cHNlZCknKSBcCiAgIHx8IHsgbWF4X3NlY29uZHM9NTsKICAgICAgICB3YXJuXyAiJE1FXzogd2Fy bmluZzogbm8gcGVybD8gdXNpbmcgZGVmYXVsdCBvZiA1cyB0aW1lb3V0IjsgfQotLSAKMi44LjAt cmMyCgo= --001a113d3c462ee65d053969b089-- From unknown Tue Jun 17 01:48:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 04 Sep 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator