From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 02 11:20:42 2016 Received: (at submit) by debbugs.gnu.org; 2 Aug 2016 15:20:42 +0000 Received: from localhost ([127.0.0.1]:53766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUbUo-000488-7v for submit@debbugs.gnu.org; Tue, 02 Aug 2016 11:20:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUTot-000864-9d for submit@debbugs.gnu.org; Tue, 02 Aug 2016 03:09:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUTof-0004A1-Ag for submit@debbugs.gnu.org; Tue, 02 Aug 2016 03:08:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUTof-00049v-8A for submit@debbugs.gnu.org; Tue, 02 Aug 2016 03:08:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUToY-0001qd-6O for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 03:08:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUToR-00047x-CI for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 03:08:32 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUToR-00047q-5J for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 03:08:27 -0400 Received: by mail-wm0-x236.google.com with SMTP id o80so275055922wme.1 for ; Tue, 02 Aug 2016 00:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=NK0myPTgZSjlkck2Hv90iBauSxO/HMDizEbEpvIVTw8=; b=A4M5Cw3G43LFMnxFJmdCfHOvLCCeNaBU9rHDDykEpzOJNm2OmFt8ShE0vW+1GNsslV lqaiJS70YYt35BqMP/yt6jSULcNx0kvltEOKiWS/6uOwnKeCup40p9nmnkuwx81p7NmX WI83e1A/xEUEWnDERnLAjhCFrfbaDRTB+e7lztXwD0+aHRS4GgbH2lbnzeOHVUCqW2R/ 6FLrarUMQ6IWX8mASKeXm8nUVWK36F1CTImv3aAM6xo6DH4XDSKNF1y5bKavZV3BlbFk lcMM+zsnCAzEYJK7XffVTPFtSZl8H0Sxe/2jSiW4b7N1oHQKuw26UprGJV6RVnkXQ2fQ JCaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=NK0myPTgZSjlkck2Hv90iBauSxO/HMDizEbEpvIVTw8=; b=bXoxDEV+J3h5/1z4BEyIkOb+XHSDgN9ilDbvw+cnDk7dn6uv+B5tBpRqszUovA+Pg9 8KdRtrXU1z36zuqNSuCzUpd8S7w7PGI6ZPIIs55LFrGg7n0KrEh9Am2RWbWq6LbVJFkX s2uqbMqtgkJQbRbn2G4IYeh9lnHIZxCI1ed72d2/Ti5y++kuLU/KgVmGBxz4ETcafYCW 67AxJHkxHQ7vkTifoREatP71x46dTYf5tT9XiXuSsWI2AicfHY2TZl1mA7DOjlUyOvsK bz14Q7ansrqhJ7ir9URW6nF/2iVYLJU0Yzvzd/4AUE9bpy064kdmTD53kan37UvMz/hc PfsQ== X-Gm-Message-State: AEkoousD9U3e+SxNGbTL6Z64i4h/2Z85SEWTS/mDNgOILFoCELE1bhZTqnsM4gndhDlU6Q== X-Received: by 10.194.27.202 with SMTP id v10mr60370346wjg.140.1470121705968; Tue, 02 Aug 2016 00:08:25 -0700 (PDT) Received: from [192.168.0.7] (cpc95918-rdng25-2-0-cust1000.15-3.cable.virginm.net. [82.1.19.233]) by smtp.gmail.com with ESMTPSA id p1sm1058100wjd.37.2016.08.02.00.08.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Aug 2016 00:08:25 -0700 (PDT) From: Matthew Malcomson Subject: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly To: bug-gnu-emacs@gnu.org Message-ID: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> Date: Tue, 2 Aug 2016 08:08:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 02 Aug 2016 11:20:40 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) There are a few checkdoc.el functions that pass `current-prefix-arg' as the third argument (KEYS) to `call-interactively'. When running any of these with a prefix argument (whether numeric or a cons cell) gives an error about the argument to `call-interactively' not being a vector. e.g. emacs -Q C-u M-x checkdoc-ispell checkdoc-ispell: Wrong type argument: vectorp, (4) I see this with any emacs version I've tried. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 19 21:25:07 2016 Received: (at 24133) by debbugs.gnu.org; 20 Aug 2016 01:25:07 +0000 Received: from localhost ([127.0.0.1]:34588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bav23-0001gD-Ha for submit@debbugs.gnu.org; Fri, 19 Aug 2016 21:25:07 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:55615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bav22-0001g4-6m for 24133@debbugs.gnu.org; Fri, 19 Aug 2016 21:25:07 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=syljZifn4lSpYl2ViRyuN2DAu2E=; b=L0u1H B+mVfKFs8ifGK953JgDheDQ7m67rBn9b0XLJRyfskTnsc30400D2Or+mqyww7bkU a842a8kc7JI/f0QiFpCoBPJ7uQBFpV13/Qy/1BcleOq96ZV0rr6Z20v1b1iGoqr2 U1lHPzHRLf4t/hszdrI80X6FgkiDKq7M+W5DbRH1O0HD6azp31jhyBlvDrxA0sXK L9MfXWOfUhgQFDFThOPAeeWJiWwIIHjb1Dsni4n24f9JmBJynG5wuhwQeEDkRtKZ 64hNRnS1hRJWtowERzNiIdkwX4IJSJKOuCYrMhzdDcRjM5zfiUhLIidmatQFbTNK 2H2XEA6l5AlwvINsQ== Received: (qmail 21456 invoked by uid 0); 20 Aug 2016 01:25:03 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=iffx25zHZmdB/2HMATVC0/MkyYnP4uy0Pz4FKxFSzDWRMJiru3wCbl94ed6bDGQSYQpKVZQ7gOod5o+tadgS+Q==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 20 Aug 2016 01:25:03 -0000 From: Robert Cochran To: Matthew Malcomson Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> Date: Fri, 19 Aug 2016 18:24:40 -0700 In-Reply-To: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> (Matthew Malcomson's message of "Tue, 2 Aug 2016 08:08:24 +0100") Message-ID: <87bn0oqlk7.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24133 Cc: 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Matthew Malcomson writes: > There are a few checkdoc.el functions that pass `current-prefix-arg' > as the third argument (KEYS) to `call-interactively'. > When running any of these with a prefix argument (whether numeric or > a cons cell) gives an error about the argument to `call-interactively' > not being a vector. > e.g. > > emacs -Q > > C-u M-x checkdoc-ispell > > checkdoc-ispell: Wrong type argument: vectorp, (4) > > > I see this with any emacs version I've tried. As it turns out, whoever wrote that wasn't paying close enough attention, as the third argument is supposed to be for events (to satisfy commands that ask for "e", "k", "K", or "U"). It seems that `call-interactively' propagates the prefix argument to the called function automatically (it did with a test command that printed its arg in my git emacs -Q), so you should be able to remove the last 2 arguments to each call and it should Just Work(tm). I have a patch, attached, that does just that. ----- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-uses-of-call-interactively-in-lisp-emacs-lisp-ch.patch Content-Description: checkdoc.el call-interactively fixup patch >From 77b83195d234efe1e8876733067548d7e9c17271 Mon Sep 17 00:00:00 2001 From: Robert Cochran Date: Fri, 19 Aug 2016 18:03:24 -0700 Subject: [PATCH] Fix uses of (call-interactively) in lisp/emacs-lisp/checkdoc.el * lisp/emacs-lisp/checkdoc.el (checkdoc-ispell) (checkdoc-ispell-current-buffer) (checkdoc-ispell-interactive) (checkdoc-ispell-message-text) (checkdoc-ispell-start) (checkdoc-ispell-continue) (checkdoc-ispell-comments) (checkdoc-ispell-defun): Do not pass 'current-prefix-arg' to 'call-interactively' as an event vector; merely allow it to propagate forward to the interactive call. Passing the prefix argument as the 3rd argument to 'call-interactively' causes the prefix argument to be interpreted as events, which is not only wrong, but also causes a type error, as 'current-prefix-arg' can never be a vector as 'call-interactively' expects. 'call-interactively' automatically passes its prefix argument to the called function, so just do that, eliminating faulty behavior. --- lisp/emacs-lisp/checkdoc.el | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 3a81ade..769c2fe 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1062,7 +1062,7 @@ checkdoc-ispell Prefix argument is the same as for `checkdoc'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc nil current-prefix-arg))) + (call-interactively #'checkdoc))) ;;;###autoload (defun checkdoc-ispell-current-buffer () @@ -1071,7 +1071,7 @@ checkdoc-ispell-current-buffer Prefix argument is the same as for `checkdoc-current-buffer'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-current-buffer nil current-prefix-arg))) + (call-interactively #'checkdoc-current-buffer))) ;;;###autoload (defun checkdoc-ispell-interactive () @@ -1080,7 +1080,7 @@ checkdoc-ispell-interactive Prefix argument is the same as for `checkdoc-interactive'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-interactive nil current-prefix-arg))) + (call-interactively #'checkdoc-interactive))) ;;;###autoload (defun checkdoc-ispell-message-interactive () @@ -1099,7 +1099,7 @@ checkdoc-ispell-message-text Prefix argument is the same as for `checkdoc-message-text'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-message-text nil current-prefix-arg))) + (call-interactively #'checkdoc-message-text))) ;;;###autoload (defun checkdoc-ispell-start () @@ -1108,7 +1108,7 @@ checkdoc-ispell-start Prefix argument is the same as for `checkdoc-start'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-start nil current-prefix-arg))) + (call-interactively #'checkdoc-start))) ;;;###autoload (defun checkdoc-ispell-continue () @@ -1117,7 +1117,7 @@ checkdoc-ispell-continue Prefix argument is the same as for `checkdoc-continue'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-continue nil current-prefix-arg))) + (call-interactively #'checkdoc-continue))) ;;;###autoload (defun checkdoc-ispell-comments () @@ -1126,7 +1126,7 @@ checkdoc-ispell-comments Prefix argument is the same as for `checkdoc-comments'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-comments nil current-prefix-arg))) + (call-interactively #'checkdoc-comments))) ;;;###autoload (defun checkdoc-ispell-defun () @@ -1135,7 +1135,7 @@ checkdoc-ispell-defun Prefix argument is the same as for `checkdoc-defun'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-defun nil current-prefix-arg))) + (call-interactively #'checkdoc-defun))) ;;; Error Management ;; -- 2.7.4 --=-=-= Content-Type: text/plain ----- HTH, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 26 12:15:00 2016 Received: (at 24133) by debbugs.gnu.org; 26 Aug 2016 16:15:00 +0000 Received: from localhost ([127.0.0.1]:41641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdJmW-000624-5N for submit@debbugs.gnu.org; Fri, 26 Aug 2016 12:15:00 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:49962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdJmT-00061u-DS for 24133@debbugs.gnu.org; Fri, 26 Aug 2016 12:14:58 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=fZcEktRESgS0Bl7Hn8DPxbZD3QQ=; b=e6xTA H0BfvXyteYygKZrUQ3NrMOz3j+mXxLzNnf77o3KRbUmIoOVViIs3GNO62nxoteTi UIiM1bFm+MJW4Dpv1TyhFnELcgqUTAjyG6TUAmrFfOMLrzxuAHAck1UH8D58iEKD XnyGuqvkUmeuW7hn3OjsStMRQOMH/AgDpKz/bxQhur5liZ+uzT+UsywN8aVFldUH AZ3Twg+rO4JPmmIqTfLzpMSDob06frlYKYw1DyLWxAgjgCB4KrrcWgnLeJt5nvxF i2LB3vChFvjgtPK5OsOeh6GgscBy+NsDbT2EGTHe4V2CWcxfQnvHJMLbmCfvmczP bsjol9Gxvg+ag8TsA== Received: (qmail 1793 invoked by uid 0); 26 Aug 2016 16:14:54 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=Mx5AK76FwLYJmD8YcXOClFGYiy9Hr0Jqy0UIiNannksPvc2AtQXaqIiT2Cvikdg7uhon9ezLLJLHMh8EZNrL9Q==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 26 Aug 2016 16:14:54 -0000 From: Robert Cochran To: Robert Cochran Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> Date: Fri, 26 Aug 2016 09:14:48 -0700 In-Reply-To: <87bn0oqlk7.fsf@cochranmail.com> (Robert Cochran's message of "Fri, 19 Aug 2016 18:24:40 -0700") Message-ID: <87eg5bo6br.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24133 Cc: Matthew Malcomson , 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ping! Has anyone had a chance to look this over yet? -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 26 22:58:49 2016 Received: (at 24133) by debbugs.gnu.org; 27 Aug 2016 02:58:49 +0000 Received: from localhost ([127.0.0.1]:41789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdTpZ-0007jo-4S for submit@debbugs.gnu.org; Fri, 26 Aug 2016 22:58:49 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:34872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdTpX-0007jb-RB for 24133@debbugs.gnu.org; Fri, 26 Aug 2016 22:58:48 -0400 Received: by mail-it0-f53.google.com with SMTP id x131so22875513ite.0 for <24133@debbugs.gnu.org>; Fri, 26 Aug 2016 19:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KdcIH8WRc3Ga04MPH//HzXS5fxyuABtk8w/F4vjEcdc=; b=ngAsz3e2Pxi/tOCW5OdVP98jPT0RYbQo8duUgLtP5EIADJXP1GuymvjSTvGWHDltmD fpSs/xpAlg08Z8F3mTtkS2UnX8i3WiGiWi6vdGR3EoDHuHe1Kzd6h1bDkzEIUh2D5T0t TvC7ErdSVdvpSrpsVaP4nOSRAK6lJN6C70TOJxXQR226XBsgdpRf7yndbpZqNgiK49uQ +Gy+NwTIPXuPqmUCulCjjh37J62LieN2TUBRL5+6a+AsjZY14zTXHV0Pa/bZKXqlEY6l XMApozuSaVYVYj5+c+A6t9LsSIbrzpDAPd4i2ilBnyAOFOkLHEbPvH92agKjcNUPB4Cw tWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=KdcIH8WRc3Ga04MPH//HzXS5fxyuABtk8w/F4vjEcdc=; b=dOJa6UxCYjJCJ5ltHAQlaUf+RmKH+svhtYN/yBAjDui2xPR6XqufEdmN7+R0pXnLaw //YTAPng+mZfkdKF4HrnBHDmXxB2xyfFP/Ek6ktJ3+FT5WrQF0LHm2TZrmNTZGTKSDYf oaZd71j6cvMLBCsd4+NRl4mOKfFLRE15XRpHH+VnpilVFe+ZdxnSF2zda3f+UJFp9sjh aoutucLNIHp7N09ZwdC2LG+6cALspBkK7JVijvKslVCdqmsytS3D4fDbBNRoFTTjVFUk ujHtZZSbMkRgGHg8sYYyXXHm4ZpX7Mwd4+Nmw2zaZqfois5m6reb1kbt/qcPy6iv0E9Z o1uA== X-Gm-Message-State: AE9vXwNMIo4mET9XlFpzFOxNSUryt2rX24dlB9DhnkMkPhZoZT14kskPbCM3ZnTm+zXsNA== X-Received: by 10.36.190.201 with SMTP id i192mr2489327itf.98.1472266722243; Fri, 26 Aug 2016 19:58:42 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id g78sm864058itb.12.2016.08.26.19.58.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Aug 2016 19:58:41 -0700 (PDT) From: npostavs@users.sourceforge.net To: Robert Cochran Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> Date: Fri, 26 Aug 2016 22:58:59 -0400 In-Reply-To: <87bn0oqlk7.fsf@cochranmail.com> (Robert Cochran's message of "Fri, 19 Aug 2016 18:24:40 -0700") Message-ID: <87wpj2syrw.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24133 Cc: Matthew Malcomson , 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Robert Cochran writes: > It seems that `call-interactively' propagates the prefix argument to the > called function automatically (it did with a test command that printed > its arg in my git emacs -Q), so you should be able to remove the last 2 > arguments to each call and it should Just Work(tm). > > I have a patch, attached, that does just that. Looks good, except for some minor format problems in the commit message (refer to etc/CONTRIBUTE "** Commit messages", and https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html). > Subject: [PATCH] Fix uses of (call-interactively) in > lisp/emacs-lisp/checkdoc.el > > * lisp/emacs-lisp/checkdoc.el (checkdoc-ispell) > (checkdoc-ispell-current-buffer) The lines in a changelog entry should be not indented (i.e., they should in the same column as the "*"). > (checkdoc-ispell-interactive) > (checkdoc-ispell-message-text) > (checkdoc-ispell-start) > (checkdoc-ispell-continue) > (checkdoc-ispell-comments) > (checkdoc-ispell-defun): > Do not pass 'current-prefix-arg' to 'call-interactively' as an event > vector; merely allow it to propagate forward to the interactive call. > The explanatory part of the message should go before the changelog entry, not after. > Passing the prefix argument as the 3rd argument to 'call-interactively' > causes the prefix argument to be interpreted as events, which is not > only wrong, but also causes a type error, as 'current-prefix-arg' can > never be a vector as 'call-interactively' expects. 'call-interactively' Sentences should end with a double space (set `sentence-end-double-space' to t). > automatically passes its prefix argument to the called function, so just > do that, eliminating faulty behavior. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 27 14:38:14 2016 Received: (at 24133) by debbugs.gnu.org; 27 Aug 2016 18:38:14 +0000 Received: from localhost ([127.0.0.1]:42202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdiUg-00070x-4J for submit@debbugs.gnu.org; Sat, 27 Aug 2016 14:38:14 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:53884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdiUe-00070o-3I for 24133@debbugs.gnu.org; Sat, 27 Aug 2016 14:38:13 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=kO+cXAaOegyprEBWzh3hZgaAZcU=; b=1N+WI NGtN/7ywX/rxp80h+mhyyBZtOQeu8BTgn6kAAf/3E9JAhdx7iZzWMO+xciq1lnrk /92En6q4DYjOCmR8yZXmBzGtfDlSzOWEVWh8B0DeKm2DMavao13S9i1WTbF/D+f9 EqxRv6uPQf0wfL/Iy86gML1MwC7LusNJz/wA5FAaus2n+pJqZtluObjOVMNXCh9B 9qcNQZGnqB/HGgifXtnC+us+cfek0MlAahuAFeghQSShBYn/4gvbzX7gRADwGx+A G/szfgspi4I2SloLA3oZQigMOwC8uSB+XRU+YYKj6levlXwmGervqK5JI/3k6mT1 yGnl2VimZodCcBjfg== Received: (qmail 30926 invoked by uid 0); 27 Aug 2016 18:38:08 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=XPHXXGLotcFakSjdsbHed7Xuw2UbYidEvkYbSl+QxGpWTG3jSyEtOraXrIPLIYe/P/6H87OwHaxJWB8+HHX4aQ==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 27 Aug 2016 18:38:08 -0000 From: Robert Cochran To: npostavs@users.sourceforge.net Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> <87wpj2syrw.fsf@users.sourceforge.net> Date: Sat, 27 Aug 2016 11:38:06 -0700 In-Reply-To: <87wpj2syrw.fsf@users.sourceforge.net> (npostavs's message of "Fri, 26 Aug 2016 22:58:59 -0400") Message-ID: <87lgzif46p.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24133 Cc: Matthew Malcomson , Robert Cochran , 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain I believe I've fixed all of the mentioned issues in this new patch. Apologies for having not gotten it correct the first time; I'll keep in mind to better review before sending in the future. ----- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-uses-of-call-interactively-in-lisp-emacs-lisp-ch.patch Content-Description: Patch to fix checkdoc's misuse of call-interactively >From 335663f3d9ba0de2f970f2c32626aa5acef17118 Mon Sep 17 00:00:00 2001 From: Robert Cochran Date: Fri, 19 Aug 2016 18:03:24 -0700 Subject: [PATCH] Fix uses of (call-interactively) in lisp/emacs-lisp/checkdoc.el Passing the prefix argument as the 3rd argument to 'call-interactively' causes the prefix argument to be interpreted as events, which is not only wrong, but also causes a type error, as 'current-prefix-arg' can never be a vector as 'call-interactively' expects. 'call-interactively' automatically passes its prefix argument to the called function, so just do that, eliminating faulty behavior. * lisp/emacs-lisp/checkdoc.el (checkdoc-ispell) (checkdoc-ispell-current-buffer) (checkdoc-ispell-interactive) (checkdoc-ispell-message-text) (checkdoc-ispell-start) (checkdoc-ispell-continue) (checkdoc-ispell-comments) (checkdoc-ispell-defun): Do not pass 'current-prefix-arg' to 'call-interactively' as an event vector; merely allow it to propagate forward to the interactive call. --- lisp/emacs-lisp/checkdoc.el | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 3a81ade..769c2fe 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1062,7 +1062,7 @@ checkdoc-ispell Prefix argument is the same as for `checkdoc'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc nil current-prefix-arg))) + (call-interactively #'checkdoc))) ;;;###autoload (defun checkdoc-ispell-current-buffer () @@ -1071,7 +1071,7 @@ checkdoc-ispell-current-buffer Prefix argument is the same as for `checkdoc-current-buffer'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-current-buffer nil current-prefix-arg))) + (call-interactively #'checkdoc-current-buffer))) ;;;###autoload (defun checkdoc-ispell-interactive () @@ -1080,7 +1080,7 @@ checkdoc-ispell-interactive Prefix argument is the same as for `checkdoc-interactive'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-interactive nil current-prefix-arg))) + (call-interactively #'checkdoc-interactive))) ;;;###autoload (defun checkdoc-ispell-message-interactive () @@ -1099,7 +1099,7 @@ checkdoc-ispell-message-text Prefix argument is the same as for `checkdoc-message-text'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-message-text nil current-prefix-arg))) + (call-interactively #'checkdoc-message-text))) ;;;###autoload (defun checkdoc-ispell-start () @@ -1108,7 +1108,7 @@ checkdoc-ispell-start Prefix argument is the same as for `checkdoc-start'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-start nil current-prefix-arg))) + (call-interactively #'checkdoc-start))) ;;;###autoload (defun checkdoc-ispell-continue () @@ -1117,7 +1117,7 @@ checkdoc-ispell-continue Prefix argument is the same as for `checkdoc-continue'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-continue nil current-prefix-arg))) + (call-interactively #'checkdoc-continue))) ;;;###autoload (defun checkdoc-ispell-comments () @@ -1126,7 +1126,7 @@ checkdoc-ispell-comments Prefix argument is the same as for `checkdoc-comments'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-comments nil current-prefix-arg))) + (call-interactively #'checkdoc-comments))) ;;;###autoload (defun checkdoc-ispell-defun () @@ -1135,7 +1135,7 @@ checkdoc-ispell-defun Prefix argument is the same as for `checkdoc-defun'" (interactive) (let ((checkdoc-spellcheck-documentation-flag t)) - (call-interactively #'checkdoc-defun nil current-prefix-arg))) + (call-interactively #'checkdoc-defun))) ;;; Error Management ;; -- 2.7.4 --=-=-= Content-Type: text/plain ----- Thanks, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 22:55:50 2016 Received: (at 24133) by debbugs.gnu.org; 2 Sep 2016 02:55:50 +0000 Received: from localhost ([127.0.0.1]:46797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfedy-0000eK-CD for submit@debbugs.gnu.org; Thu, 01 Sep 2016 22:55:50 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:37133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfedw-0000e5-CY for 24133@debbugs.gnu.org; Thu, 01 Sep 2016 22:55:48 -0400 Received: by mail-it0-f47.google.com with SMTP id e124so15637120ith.0 for <24133@debbugs.gnu.org>; Thu, 01 Sep 2016 19:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FEt1dg070RRC/BGTogrud2mXM/4ZVf4xX9XmZf5ap20=; b=l8mmInFMoCox1RoIz8LYXFfiYS4mjjhYfVx/21otaXpXqiw9LN0OVX7L+KhoGjZz4G /Y2zIql0+jJ0cdKB4O2HZlcXd7thXDs+LMU5db3QqQgvTpQITmH3L5pohjJdw6HgCGmd JWOr1+YopfSQH70ciNIsLDR2CMwpNWUva4d0WXL7sEfNSzQTILSZrglyAaOhf+cpBEVp /v8S7jYx+lU7agaWA4HPE5yMeQ/b2+ObedrtkttVY0XboWq69gG7M5J0bA4lzUuIPjGd fPoGo7Lfbqg9+vHmLGVcbdDKqZq6WIzrIFsihHK5U8TQ64tg2oJEVHKMN3ZnqokdPtMK +bRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FEt1dg070RRC/BGTogrud2mXM/4ZVf4xX9XmZf5ap20=; b=XUbQe3AQNvkdZVpeDtRrGNLWVs4Zw6Bmc58dlEIMQz7tS8gh3wPzHG7P7535sAAVMM iNJhrkRrmzOlOS4ek2pnZO9FFrF7NmkZgQR14eM2vp4alW2RCPz8fesQSjRGgXQYQiUg joN+8aumCoNIwJzvbgiMgb1LWGIic7SFHZMAYr2vyvzBwY4wq7mu/3RMb3gwaXEzZ2W/ XpwjKDbuVyeaVEFov07nR5YvJbVYO/IVU8EKUBxQkfYyxh1JEJXo9BQFUQBHvO6rco2X bHZIIuRkbGYBS6my5Mk7La1wr+xWq4v8ZKdEY6EcWh9VL99ta2uwIHAD0X8/AQZHoyTT 6nxg== X-Gm-Message-State: AE9vXwPuY/9tQuAIIKhFk8ImbpyoLrffyc50/crviZJ3YjPpWii9DIDyDu+4bbfEbm8oxQ== X-Received: by 10.36.0.130 with SMTP id 124mr1588280ita.15.1472784942851; Thu, 01 Sep 2016 19:55:42 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id q1sm1098564itb.2.2016.09.01.19.55.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Sep 2016 19:55:42 -0700 (PDT) From: npostavs@users.sourceforge.net To: Robert Cochran Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> <87wpj2syrw.fsf@users.sourceforge.net> <87lgzif46p.fsf@cochranmail.com> Date: Thu, 01 Sep 2016 22:55:58 -0400 In-Reply-To: <87lgzif46p.fsf@cochranmail.com> (Robert Cochran's message of "Sat, 27 Aug 2016 11:38:06 -0700") Message-ID: <87a8frovr5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 24133 Cc: Matthew Malcomson , 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Robert Cochran writes: > I believe I've fixed all of the mentioned issues in this new > patch. Yup, looks ready for master. What's your copyright status? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 03:01:44 2016 Received: (at 24133) by debbugs.gnu.org; 2 Sep 2016 07:01:44 +0000 Received: from localhost ([127.0.0.1]:46904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfiTw-0005Ih-FZ for submit@debbugs.gnu.org; Fri, 02 Sep 2016 03:01:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfiTv-0005IU-62 for 24133@debbugs.gnu.org; Fri, 02 Sep 2016 03:01:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfiTl-0007ze-4O for 24133@debbugs.gnu.org; Fri, 02 Sep 2016 03:01:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfiTl-0007zU-1m; Fri, 02 Sep 2016 03:01:33 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bfiTi-0003BV-TP; Fri, 02 Sep 2016 03:01:31 -0400 Date: Fri, 02 Sep 2016 10:01:34 +0300 Message-Id: <83r392eqep.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87a8frovr5.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> <87wpj2syrw.fsf@users.sourceforge.net> <87lgzif46p.fsf@cochranmail.com> <87a8frovr5.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 24133 Cc: hardenedapple@gmail.com, robert-emacs@cochranmail.com, 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.5 (------) > From: npostavs@users.sourceforge.net > Date: Thu, 01 Sep 2016 22:55:58 -0400 > Cc: Matthew Malcomson , 24133@debbugs.gnu.org > > Robert Cochran writes: > > > I believe I've fixed all of the mentioned issues in this new > > patch. > > Yup, looks ready for master. What's your copyright status? Robert's assignment is on file. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 03 12:04:30 2016 Received: (at 24133) by debbugs.gnu.org; 3 Sep 2016 16:04:31 +0000 Received: from localhost ([127.0.0.1]:48848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgDQk-0001ye-LK for submit@debbugs.gnu.org; Sat, 03 Sep 2016 12:04:30 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:32969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgDQi-0001yJ-A3; Sat, 03 Sep 2016 12:04:28 -0400 Received: by mail-it0-f46.google.com with SMTP id e124so16266499ith.0; Sat, 03 Sep 2016 09:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HHQr9xbdkL/niJb4keG+QcvGgJwH+j0ywS/9+7W6DAo=; b=Mz/imzOQD6wmwCdLidRIxHs5YDGNytZSsHhCGAmSCVd/61HCx63/p6VZUiQXm79BvG O0ffzxUXts4m7zUq/aWIgF9RTju90TILU7441GXUAaUSYxfC49XqezFw5TNrAdzOo22F ltNBBO5Ee3KrsG62GFQuSVzC03+BLPQwOsvVyU/oY0HuabgZu+VGiOqVKC0yqK1UEJXr 1/ExFR/+lTzSvpr8wQ+oYvWtr9EmQEsWP4b9iHs13nJ2BRBso8ISYe5gj54pyH8O01jA Z/PFkJ1uPjharvv+Exv6h2CK+UTexIYBGuxIvhkZSI65yfPtM+chrJehOkYHOPRdKn3r MqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=HHQr9xbdkL/niJb4keG+QcvGgJwH+j0ywS/9+7W6DAo=; b=MddWpCtLAn0XrYEwTTdYpoYAJr8cFNEwIO7jAb5fOcByEUC4OJL0ckFwO1Sc4J7PzR POzW9szI1b8DUL6Gasud3VAnxPVKu2/mO2HcF1yuhuC5mQEIcA3LY3gSACDSW0SdGYaB OQaxaxcBrWJnzK/sD+kxt1Y1a5bw/I5XtiXFsV4oWQ6vbmUUbuq0qVbvxGUiNmZ5JpX0 vNkv72yz0LnMRWEkI5iAYiAifHw6ycQe2qlfCrE+JA4MKu4W+D6irw+5t5eSfW6z1NU2 Yc9Km8mKCMuO7kBeaSXazFbxWxpNTNZEWzSdKYICm7jHjQwCZo5L1U+xvYxCCkR5OAF6 gZog== X-Gm-Message-State: AE9vXwMdEu/RKBY6P3oBE7+xi8Cd2sQGNSvXlWiGM2PpnWHuaiawu5nDK2vRUCzu/3imRg== X-Received: by 10.36.238.134 with SMTP id b128mr10993371iti.72.1472918662855; Sat, 03 Sep 2016 09:04:22 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id j76sm1241375itb.2.2016.09.03.09.04.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Sep 2016 09:04:22 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> <87wpj2syrw.fsf@users.sourceforge.net> <87lgzif46p.fsf@cochranmail.com> <87a8frovr5.fsf@users.sourceforge.net> <83r392eqep.fsf@gnu.org> Date: Sat, 03 Sep 2016 12:04:43 -0400 In-Reply-To: <83r392eqep.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Sep 2016 10:01:34 +0300") Message-ID: <87bn05nf50.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24133 Cc: hardenedapple@gmail.com, robert-emacs@cochranmail.com, 24133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 24133 fixed close 24133 25.2 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Date: Thu, 01 Sep 2016 22:55:58 -0400 >> Cc: Matthew Malcomson , 24133@debbugs.gnu.org >> >> Robert Cochran writes: >> >> > I believe I've fixed all of the mentioned issues in this new >> > patch. >> >> Yup, looks ready for master. What's your copyright status? > > Robert's assignment is on file. I've pushed as ea015641 (I added colons to the commit message which I hadn't noticed were missing before). From unknown Wed Aug 20 01:20:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Oct 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 03 21:49:42 2016 Received: (at control) by debbugs.gnu.org; 4 Dec 2016 02:49:42 +0000 Received: from localhost ([127.0.0.1]:51761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDMs2-0004Js-AJ for submit@debbugs.gnu.org; Sat, 03 Dec 2016 21:49:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDMrz-0004JW-G1 for control@debbugs.gnu.org; Sat, 03 Dec 2016 21:49:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDMrs-0001yx-95 for control@debbugs.gnu.org; Sat, 03 Dec 2016 21:49:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDMrs-0001yr-52 for control@debbugs.gnu.org; Sat, 03 Dec 2016 21:49:32 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cDMrr-0005b2-Kh; Sat, 03 Dec 2016 21:49:31 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <22595.33851.293095.70553@gnu.org> Date: Sat, 3 Dec 2016 21:49:31 -0500 From: Glenn Morris To: control@debbugs.gnu.org Subject: Clean up predictable issues due to Emacs version number change X-Debbugs-No-Ack: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) # Ref: # http://lists.gnu.org/archive/html/emacs-devel/2016-11/msg00238.html # http://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00692.html # http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01215.html # Some attempt has been made to check for things backported after the fact. # Erring on the side of a later version number seems preferable anyway. unarchive 10 fixed 10 26.1 notfixed 10 25.2 unarchive 96 fixed 96 26.1 notfixed 96 25.2 unarchive 1149 fixed 1149 26.1 notfixed 1149 25.2 unarchive 1150 fixed 1150 26.1 notfixed 1150 25.2 unarchive 2270 fixed 2270 26.1 notfixed 2270 25.2 unarchive 2405 fixed 2405 26.1 notfixed 2405 25.2 unarchive 2589 fixed 2589 26.1 notfixed 2589 25.2 unarchive 3137 fixed 3137 26.1 notfixed 3137 25.2 unarchive 3393 fixed 3393 26.1 notfixed 3393 25.2 unarchive 4589 fixed 4589 26.1 notfixed 4589 25.2 unarchive 4920 fixed 4920 26.1 notfixed 4920 25.2 unarchive 5001 fixed 5001 26.1 notfixed 5001 25.2 unarchive 5262 fixed 5262 26.1 notfixed 5262 25.2 unarchive 5305 fixed 5305 26.1 notfixed 5305 25.2 unarchive 5314 fixed 5314 26.1 notfixed 5314 25.2 unarchive 5479 fixed 5479 26.1 notfixed 5479 25.2 unarchive 5650 fixed 5650 26.1 notfixed 5650 25.2 unarchive 5661 fixed 5661 26.1 notfixed 5661 25.2 unarchive 5727 fixed 5727 26.1 notfixed 5727 25.2 unarchive 6817 fixed 6817 26.1 notfixed 6817 25.2 unarchive 7385 fixed 7385 26.1 notfixed 7385 25.2 unarchive 7522 fixed 7522 26.1 notfixed 7522 25.2 unarchive 7751 fixed 7751 26.1 notfixed 7751 25.2 unarchive 8634 fixed 8634 26.1 notfixed 8634 25.2 unarchive 8693 fixed 8693 26.1 notfixed 8693 25.2 unarchive 8925 fixed 8925 26.1 notfixed 8925 25.2 unarchive 9342 fixed 9342 26.1 notfixed 9342 25.2 unarchive 9730 fixed 9730 26.1 notfixed 9730 25.2 unarchive 10487 fixed 10487 26.1 notfixed 10487 25.2 unarchive 10540 fixed 10540 26.1 notfixed 10540 25.2 unarchive 10723 fixed 10723 26.1 notfixed 10723 25.2 unarchive 10794 fixed 10794 26.1 notfixed 10794 25.2 unarchive 10980 fixed 10980 26.1 notfixed 10980 25.2 unarchive 11357 fixed 11357 26.1 notfixed 11357 25.2 unarchive 11400 fixed 11400 26.1 notfixed 11400 25.2 unarchive 11788 fixed 11788 26.1 notfixed 11788 25.2 unarchive 12048 fixed 12048 26.1 notfixed 12048 25.2 unarchive 12377 fixed 12377 26.1 notfixed 12377 25.2 unarchive 12378 fixed 12378 26.1 notfixed 12378 25.2 unarchive 12636 fixed 12636 26.1 notfixed 12636 25.2 unarchive 12939 fixed 12939 26.1 notfixed 12939 25.2 unarchive 13269 fixed 13269 26.1 notfixed 13269 25.2 unarchive 13571 fixed 13571 26.1 notfixed 13571 25.2 unarchive 13745 fixed 13745 26.1 notfixed 13745 25.2 unarchive 13949 fixed 13949 26.1 notfixed 13949 25.2 unarchive 14256 fixed 14256 26.1 notfixed 14256 25.2 unarchive 14341 fixed 14341 26.1 notfixed 14341 25.2 unarchive 14484 fixed 14484 26.1 notfixed 14484 25.2 unarchive 14554 fixed 14554 26.1 notfixed 14554 25.2 unarchive 14577 fixed 14577 26.1 notfixed 14577 25.2 unarchive 14687 fixed 14687 26.1 notfixed 14687 25.2 unarchive 14844 fixed 14844 26.1 notfixed 14844 25.2 unarchive 14854 fixed 14854 26.1 notfixed 14854 25.2 unarchive 14915 fixed 14915 26.1 notfixed 14915 25.2 unarchive 14919 fixed 14919 26.1 notfixed 14919 25.2 unarchive 15021 fixed 15021 26.1 notfixed 15021 25.2 unarchive 15047 fixed 15047 26.1 notfixed 15047 25.2 unarchive 15171 fixed 15171 26.1 notfixed 15171 25.2 unarchive 15324 fixed 15324 26.1 notfixed 15324 25.2 unarchive 15445 fixed 15445 26.1 notfixed 15445 25.2 unarchive 15506 fixed 15506 26.1 notfixed 15506 25.2 unarchive 15909 fixed 15909 26.1 notfixed 15909 25.2 unarchive 16136 fixed 16136 26.1 notfixed 16136 25.2 unarchive 16200 fixed 16200 26.1 notfixed 16200 25.2 unarchive 16276 fixed 16276 26.1 notfixed 16276 25.2 unarchive 16294 fixed 16294 26.1 notfixed 16294 25.2 unarchive 16345 fixed 16345 26.1 notfixed 16345 25.2 unarchive 16390 fixed 16390 26.1 notfixed 16390 25.2 unarchive 16406 fixed 16406 26.1 notfixed 16406 25.2 unarchive 16483 fixed 16483 26.1 notfixed 16483 25.2 unarchive 16513 fixed 16513 26.1 notfixed 16513 25.2 unarchive 16579 fixed 16579 26.1 notfixed 16579 25.2 unarchive 16746 fixed 16746 26.1 notfixed 16746 25.2 unarchive 16891 fixed 16891 26.1 notfixed 16891 25.2 unarchive 16904 fixed 16904 26.1 notfixed 16904 25.2 unarchive 17039 fixed 17039 26.1 notfixed 17039 25.2 unarchive 17067 fixed 17067 26.1 notfixed 17067 25.2 unarchive 17119 fixed 17119 26.1 notfixed 17119 25.2 unarchive 17582 fixed 17582 26.1 notfixed 17582 25.2 unarchive 17707 fixed 17707 26.1 notfixed 17707 25.2 unarchive 17716 fixed 17716 26.1 notfixed 17716 25.2 unarchive 17738 fixed 17738 26.1 notfixed 17738 25.2 unarchive 17989 fixed 17989 26.1 notfixed 17989 25.2 unarchive 17999 fixed 17999 26.1 notfixed 17999 25.2 unarchive 18008 fixed 18008 26.1 notfixed 18008 25.2 unarchive 18024 fixed 18024 26.1 notfixed 18024 25.2 unarchive 18026 fixed 18026 26.1 notfixed 18026 25.2 unarchive 18028 fixed 18028 26.1 notfixed 18028 25.2 unarchive 18089 fixed 18089 26.1 notfixed 18089 25.2 unarchive 18092 fixed 18092 26.1 notfixed 18092 25.2 unarchive 18110 fixed 18110 26.1 notfixed 18110 25.2 unarchive 18202 fixed 18202 26.1 notfixed 18202 25.2 unarchive 18203 fixed 18203 26.1 notfixed 18203 25.2 unarchive 18204 fixed 18204 26.1 notfixed 18204 25.2 unarchive 18211 fixed 18211 26.1 notfixed 18211 25.2 unarchive 18279 fixed 18279 26.1 notfixed 18279 25.2 unarchive 18527 fixed 18527 26.1 notfixed 18527 25.2 unarchive 18587 fixed 18587 26.1 notfixed 18587 25.2 unarchive 18634 fixed 18634 26.1 notfixed 18634 25.2 unarchive 18635 fixed 18635 26.1 notfixed 18635 25.2 unarchive 18686 fixed 18686 26.1 notfixed 18686 25.2 unarchive 18692 fixed 18692 26.1 notfixed 18692 25.2 unarchive 18809 fixed 18809 26.1 notfixed 18809 25.2 unarchive 18810 fixed 18810 26.1 notfixed 18810 25.2 unarchive 18829 fixed 18829 26.1 notfixed 18829 25.2 unarchive 19114 fixed 19114 26.1 notfixed 19114 25.2 unarchive 19152 fixed 19152 26.1 notfixed 19152 25.2 unarchive 19209 fixed 19209 26.1 notfixed 19209 25.2 unarchive 19214 fixed 19214 26.1 notfixed 19214 25.2 unarchive 19215 fixed 19215 26.1 notfixed 19215 25.2 unarchive 19255 fixed 19255 26.1 notfixed 19255 25.2 unarchive 19368 fixed 19368 26.1 notfixed 19368 25.2 unarchive 19424 fixed 19424 26.1 notfixed 19424 25.2 unarchive 19497 fixed 19497 26.1 notfixed 19497 25.2 unarchive 19587 fixed 19587 26.1 notfixed 19587 25.2 unarchive 19638 fixed 19638 26.1 notfixed 19638 25.2 unarchive 19722 fixed 19722 26.1 notfixed 19722 25.2 unarchive 19754 fixed 19754 26.1 notfixed 19754 25.2 unarchive 19801 fixed 19801 26.1 notfixed 19801 25.2 unarchive 19851 fixed 19851 26.1 notfixed 19851 25.2 unarchive 20038 fixed 20038 26.1 notfixed 20038 25.2 unarchive 20158 fixed 20158 26.1 notfixed 20158 25.2 unarchive 20181 fixed 20181 26.1 notfixed 20181 25.2 unarchive 20304 fixed 20304 26.1 notfixed 20304 25.2 unarchive 20408 fixed 20408 26.1 notfixed 20408 25.2 unarchive 20460 fixed 20460 26.1 notfixed 20460 25.2 unarchive 20485 fixed 20485 26.1 notfixed 20485 25.2 unarchive 20520 fixed 20520 26.1 notfixed 20520 25.2 unarchive 20654 fixed 20654 26.1 notfixed 20654 25.2 unarchive 20702 fixed 20702 26.1 notfixed 20702 25.2 unarchive 20724 fixed 20724 26.1 notfixed 20724 25.2 unarchive 20878 fixed 20878 26.1 notfixed 20878 25.2 unarchive 21002 fixed 21002 26.1 notfixed 21002 25.2 unarchive 21014 fixed 21014 26.1 notfixed 21014 25.2 unarchive 21024 fixed 21024 26.1 notfixed 21024 25.2 unarchive 21155 fixed 21155 26.1 notfixed 21155 25.2 unarchive 21169 fixed 21169 26.1 notfixed 21169 25.2 unarchive 21171 fixed 21171 26.1 notfixed 21171 25.2 unarchive 21225 fixed 21225 26.1 notfixed 21225 25.2 unarchive 21231 fixed 21231 26.1 notfixed 21231 25.2 unarchive 21252 fixed 21252 26.1 notfixed 21252 25.2 unarchive 21269 fixed 21269 26.1 notfixed 21269 25.2 unarchive 21359 fixed 21359 26.1 notfixed 21359 25.2 unarchive 21427 fixed 21427 26.1 notfixed 21427 25.2 unarchive 21552 fixed 21552 26.1 notfixed 21552 25.2 unarchive 21576 fixed 21576 26.1 notfixed 21576 25.2 unarchive 21577 fixed 21577 26.1 notfixed 21577 25.2 unarchive 21601 fixed 21601 26.1 notfixed 21601 25.2 unarchive 21678 fixed 21678 26.1 notfixed 21678 25.2 unarchive 21679 fixed 21679 26.1 notfixed 21679 25.2 unarchive 21684 fixed 21684 26.1 notfixed 21684 25.2 unarchive 21706 fixed 21706 26.1 notfixed 21706 25.2 unarchive 21759 fixed 21759 26.1 notfixed 21759 25.2 unarchive 21851 fixed 21851 26.1 notfixed 21851 25.2 unarchive 21852 fixed 21852 26.1 notfixed 21852 25.2 unarchive 21853 fixed 21853 26.1 notfixed 21853 25.2 unarchive 21881 fixed 21881 26.1 notfixed 21881 25.2 unarchive 21936 fixed 21936 26.1 notfixed 21936 25.2 unarchive 21962 fixed 21962 26.1 notfixed 21962 25.2 unarchive 22117 fixed 22117 26.1 notfixed 22117 25.2 unarchive 22140 fixed 22140 26.1 notfixed 22140 25.2 unarchive 22170 fixed 22170 26.1 notfixed 22170 25.2 unarchive 22172 fixed 22172 26.1 notfixed 22172 25.2 unarchive 22227 fixed 22227 26.1 notfixed 22227 25.2 unarchive 22315 fixed 22315 26.1 notfixed 22315 25.2 unarchive 22325 fixed 22325 26.1 notfixed 22325 25.2 unarchive 22329 fixed 22329 26.1 notfixed 22329 25.2 unarchive 22348 fixed 22348 26.1 notfixed 22348 25.2 unarchive 22478 fixed 22478 26.1 notfixed 22478 25.2 unarchive 22530 fixed 22530 26.1 notfixed 22530 25.2 unarchive 22531 fixed 22531 26.1 notfixed 22531 25.2 unarchive 22576 fixed 22576 26.1 notfixed 22576 25.2 unarchive 22583 fixed 22583 26.1 notfixed 22583 25.2 unarchive 22586 fixed 22586 26.1 notfixed 22586 25.2 unarchive 22592 fixed 22592 26.1 notfixed 22592 25.2 unarchive 22594 fixed 22594 26.1 notfixed 22594 25.2 unarchive 22595 fixed 22595 26.1 notfixed 22595 25.2 unarchive 22596 fixed 22596 26.1 notfixed 22596 25.2 unarchive 22627 fixed 22627 26.1 notfixed 22627 25.2 unarchive 22632 fixed 22632 26.1 notfixed 22632 25.2 unarchive 22648 fixed 22648 26.1 notfixed 22648 25.2 unarchive 22664 fixed 22664 26.1 notfixed 22664 25.2 unarchive 22720 fixed 22720 26.1 notfixed 22720 25.2 unarchive 22724 fixed 22724 26.1 notfixed 22724 25.2 unarchive 22764 fixed 22764 26.1 notfixed 22764 25.2 unarchive 22799 fixed 22799 26.1 notfixed 22799 25.2 unarchive 22800 fixed 22800 26.1 notfixed 22800 25.2 unarchive 22814 fixed 22814 26.1 notfixed 22814 25.2 unarchive 22824 fixed 22824 26.1 notfixed 22824 25.2 unarchive 22827 fixed 22827 26.1 notfixed 22827 25.2 unarchive 22837 fixed 22837 26.1 notfixed 22837 25.2 unarchive 22841 fixed 22841 26.1 notfixed 22841 25.2 unarchive 22890 fixed 22890 26.1 notfixed 22890 25.2 unarchive 22928 fixed 22928 26.1 notfixed 22928 25.2 unarchive 22940 fixed 22940 26.1 notfixed 22940 25.2 unarchive 22964 fixed 22964 26.1 notfixed 22964 25.2 unarchive 22968 fixed 22968 26.1 notfixed 22968 25.2 unarchive 23020 fixed 23020 26.1 notfixed 23020 25.2 unarchive 23071 fixed 23071 26.1 notfixed 23071 25.2 unarchive 23116 fixed 23116 26.1 notfixed 23116 25.2 unarchive 23139 fixed 23139 26.1 notfixed 23139 25.2 unarchive 23159 fixed 23159 26.1 notfixed 23159 25.2 unarchive 23167 fixed 23167 26.1 notfixed 23167 25.2 unarchive 23262 fixed 23262 26.1 notfixed 23262 25.2 unarchive 23290 fixed 23290 26.1 notfixed 23290 25.2 unarchive 23374 fixed 23374 26.1 notfixed 23374 25.2 unarchive 23390 fixed 23390 26.1 notfixed 23390 25.2 unarchive 23401 fixed 23401 26.1 notfixed 23401 25.2 unarchive 23411 fixed 23411 26.1 notfixed 23411 25.2 unarchive 23459 fixed 23459 26.1 notfixed 23459 25.2 unarchive 23608 fixed 23608 26.1 notfixed 23608 25.2 unarchive 23703 fixed 23703 26.1 notfixed 23703 25.2 unarchive 23730 fixed 23730 26.1 notfixed 23730 25.2 unarchive 23829 fixed 23829 26.1 notfixed 23829 25.2 unarchive 23850 fixed 23850 26.1 notfixed 23850 25.2 unarchive 23863 fixed 23863 26.1 notfixed 23863 25.2 unarchive 23883 fixed 23883 26.1 notfixed 23883 25.2 unarchive 23914 fixed 23914 26.1 notfixed 23914 25.2 unarchive 23949 fixed 23949 26.1 notfixed 23949 25.2 unarchive 23998 fixed 23998 26.1 notfixed 23998 25.2 unarchive 24122 fixed 24122 26.1 notfixed 24122 25.2 unarchive 24133 fixed 24133 26.1 notfixed 24133 25.2 unarchive 24166 fixed 24166 26.1 notfixed 24166 25.2 unarchive 24257 fixed 24257 26.1 notfixed 24257 25.2 unarchive 24308 fixed 24308 26.1 notfixed 24308 25.2 unarchive 24432 fixed 24432 26.1 notfixed 24432 25.2 From unknown Wed Aug 20 01:20:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Jan 2017 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator