GNU bug report logs - #24117
25.1; url-http-create-request: Multibyte text in HTTP request

Previous Next

Package: emacs;

Reported by: Sho Takemori <stakemorii <at> gmail.com>

Date: Sun, 31 Jul 2016 08:28:02 UTC

Severity: normal

Found in version 25.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: stakemorii <at> gmail.com, larsi <at> gnus.org, schwab <at> linux-m68k.org, 24117 <at> debbugs.gnu.org
Subject: bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request
Date: Thu, 11 Aug 2016 21:07:50 +0300
On 08/11/2016 06:31 PM, Eli Zaretskii wrote:

>> Not the values we pass to url-http--encode-string in this patch, no. As
>> you said, when the request hits the wire, it has to be unibyte.
>
> Unibyte != ASCII.

Indeed. And the above function converts the latter to the former.

>> Thanks. Can we designate this bug as a blocker?
>
> Why not just push the fix to emacs-25?

Because John likes to question commits in emacs-25 that do not reference 
bugs marked as blocking. See also the recent message in the emacs-devel 
thread.

Anyway, pushed. I'll add some tests to master a bit later.




This bug report was last modified 8 years and 12 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.