GNU bug report logs - #24117
25.1; url-http-create-request: Multibyte text in HTTP request

Previous Next

Full log

Message #140 received at 24117 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: stakemorii <at> gmail.com, larsi <at> gnus.org, schwab <at> linux-m68k.org,
 24117 <at> debbugs.gnu.org
Subject: Re: bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP
 request
Date: Thu, 11 Aug 2016 17:47:37 +0300

> Cc: stakemorii <at> gmail.com, larsi <at> gnus.org, schwab <at> linux-m68k.org,
>  24117 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Thu, 11 Aug 2016 05:52:42 +0300
> 
> >> On the master branch, host is passed through IDNA encoding, but
> >> real-fname is untouched. On emacs-25, I think we should convert both
> >> to unibyte.
> >
> > Not sure I understand why there should be a difference between the two
> > branches.  Encoding an ASCII string doesn't do any harm.
> 
> Since it's ASCII, using utf-8 there seems misleading to me. It's a 
> question of readability.

But AFAIU it doesn't have to be ASCII, it could include non-ASCII
characters, no?

> As a bonus, using us-ascii will validate that the strings indeed do
> not contain any unexpected characters.

If we did allow non-ASCII characters until now, we will definitely
hear from someone who'd say this is a regression.

> Thanks. Attaching a patch, it seems to work well enough.

LGTM, modulo the considerations about the encoding.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.