From unknown Sat Aug 16 23:42:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24105: git package misses man pages Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 29 Jul 2016 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24105 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 24105@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14697964035376 (code B ref -1); Fri, 29 Jul 2016 12:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jul 2016 12:46:43 +0000 Received: from localhost ([127.0.0.1]:50088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7Bb-0001Oe-89 for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7BZ-0001OS-Lw for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7BT-0001mA-PK for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7BT-0001m6-MT for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7BP-0006s8-QI for bug-guix@gnu.org; Fri, 29 Jul 2016 08:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7BM-0001la-22 for bug-guix@gnu.org; Fri, 29 Jul 2016 08:46:30 -0400 Received: from mailrelay2.public.one.com ([91.198.169.125]:65515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7BL-0001lK-KM for bug-guix@gnu.org; Fri, 29 Jul 2016 08:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=enge.fr; s=20140924; h=from:subject:date:message-id:to:mime-version:content-type; bh=mbWQkVzD+tATvlUGPOwlHvDDPawaBmIDX6T6mxO+2UA=; b=Yo1xpH+nLZz4cGl9BwqN85fls9+qa+kMDH+rXPx/X1GwPMPnoCA/nAWhtfkpv0IB7TiEdf4hTgHQz gV8MbOmPhRxCHw8AdmwT1iMt+eqgT6HXgJVAlTV4c4wKv6+fYjszBCACra/P2BrM4xTpi5CKnLUUE8 dzuftqVlP0WlRyWk= X-HalOne-Cookie: e9b3a58fde19724af8e10f352eaec224f4c4993c X-HalOne-ID: 75f81412-558a-11e6-b476-b82a72d03b9b Received: from solar (unknown [92.89.73.211]) by smtpfilter2.public.one.com (Halon Mail Gateway) with ESMTPSA; Fri, 29 Jul 2016 12:46:25 +0000 (UTC) Date: Fri, 29 Jul 2016 14:46:23 +0200 From: Andreas Enge Message-ID: <20160729124623.GA31006@solar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, wondering why "git log --help" does not work, I thought that maybe there was a different doc output. But the man pages are actually hidden in a separate package called "git-manpages". This is surprising for the user. Also, the resulting package is quite small with only 2.3 MB. The reason for the separate package is given as this: ;; Granted, we could build the man pages from the 'git' package itself, ;; which contains the real source. However, it would add a dependency on a ;; full XML tool chain, and building it actually takes ages. So we use this ;; lazy approach. Building will most of the time happen on the build farm, so the time it takes should not be an issue. I suppose that the xml tool chain will only be a native and not a normal input, so it should not be too much of a problem. I suggest to include the man pages into the git package itself. If building them is a real issue, adding a source and the build phase of git-manpages to the git package itself could also be an option. Thanks! Andreas From unknown Sat Aug 16 23:42:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24105: git package misses man pages Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 29 Jul 2016 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24105 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Andreas Enge Cc: 24105@debbugs.gnu.org Received: via spool by 24105-submit@debbugs.gnu.org id=B24105.146981226830441 (code B ref 24105); Fri, 29 Jul 2016 17:12:01 +0000 Received: (at 24105) by debbugs.gnu.org; 29 Jul 2016 17:11:08 +0000 Received: from localhost ([127.0.0.1]:50890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTBJT-0007uv-SK for submit@debbugs.gnu.org; Fri, 29 Jul 2016 13:11:08 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTBJR-0007un-Kx for 24105@debbugs.gnu.org; Fri, 29 Jul 2016 13:11:06 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 555C720853; Fri, 29 Jul 2016 13:11:05 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Fri, 29 Jul 2016 13:11:05 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=i2paV pdF5nXisHjrvM1dJYxtb2M=; b=F5agD2TYssbsk47okiNFmEyz/OBzIhUU7o1bL WQOvG9EIZ1OKkNxufkziZgXMELXejggaCzojp1rokReEoT3ZoVhYTLbAelvfgWxX T1Ynf7TuXcMqJbGDyNjN/s2Zfbv0iC+wVe0i6mLaBKEwD3ZyH0CYRyFtiz1JdROO X6z2BA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=i2paVpdF5nXisHjrvM1dJYxtb2M=; b=Sl9n1 qYUa+j24c+9Pu8Tw3zL38ZmgB++6JCy0xn7nKWifiMNSNxl/WDj4tbSEtd1YQwVI LkPf6Ki/etHqHipEVuPB6muKqQYgpe+WJ4Nr8fuktTLdUeHJNSuHjWkikVHBObAu ZABVF8Bpkexj2F6BGdCopoUbtNIhHusqpG3qrk= X-Sasl-enc: df4VwlOmYJZD1AYM0i/UQg1CAXqJLIkrWuHhsdZUAdiC 1469812265 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 05BF3CCDC1; Fri, 29 Jul 2016 13:11:05 -0400 (EDT) Date: Fri, 29 Jul 2016 13:10:59 -0400 From: Leo Famulari Message-ID: <20160729171059.GA14354@jasmine> References: <20160729124623.GA31006@solar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160729124623.GA31006@solar> User-Agent: Mutt/1.6.0 (2016-04-01) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Jul 29, 2016 at 02:46:23PM +0200, Andreas Enge wrote: > Also, the resulting package is quite small with only 2.3 MB. Not much, considering how often I consult these manpages. > The reason for the separate package is given as this: > ;; Granted, we could build the man pages from the 'git' package itself, > ;; which contains the real source. However, it would add a dependency on a > ;; full XML tool chain, and building it actually takes ages. So we use this > ;; lazy approach. > Building will most of the time happen on the build farm, so the time it > takes should not be an issue. I suppose that the xml tool chain will only > be a native and not a normal input, so it should not be too much of a problem. Our git-manpages package doesn't build the manpages from source anyways. It simply unpacks a tarball of pre-built manpages. > I suggest to include the man pages into the git package itself. If building > them is a real issue, adding a source and the build phase of git-manpages > to the git package itself could also be an option. I agree. If we continue to not build them from source, it won't make the Git package any more "expensive". We could add the pre-built source tarball as a native-input to the Git package, and re-use the unpack phase from git-manpages. I think the current arrangement offers a bad experience for new users who can't find the manpages. From unknown Sat Aug 16 23:42:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24105: git package misses man pages Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 30 Jul 2016 13:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24105 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Famulari Cc: Andreas Enge , 24105@debbugs.gnu.org Received: via spool by 24105-submit@debbugs.gnu.org id=B24105.146988640524225 (code B ref 24105); Sat, 30 Jul 2016 13:47:01 +0000 Received: (at 24105) by debbugs.gnu.org; 30 Jul 2016 13:46:45 +0000 Received: from localhost ([127.0.0.1]:51268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTUbF-0006If-A3 for submit@debbugs.gnu.org; Sat, 30 Jul 2016 09:46:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTUbD-0006IT-R3 for 24105@debbugs.gnu.org; Sat, 30 Jul 2016 09:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTUb3-0000tN-Mw for 24105@debbugs.gnu.org; Sat, 30 Jul 2016 09:46:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTUb3-0000t6-Jk; Sat, 30 Jul 2016 09:46:33 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:60066 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bTUb1-0004E0-Qg; Sat, 30 Jul 2016 09:46:32 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20160729124623.GA31006@solar> <20160729171059.GA14354@jasmine> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Thermidor an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 30 Jul 2016 15:46:29 +0200 In-Reply-To: <20160729171059.GA14354@jasmine> (Leo Famulari's message of "Fri, 29 Jul 2016 13:10:59 -0400") Message-ID: <87vaznb5my.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) Leo Famulari skribis: > On Fri, Jul 29, 2016 at 02:46:23PM +0200, Andreas Enge wrote: [...] >> I suggest to include the man pages into the git package itself. If build= ing >> them is a real issue, adding a source and the build phase of git-manpages >> to the git package itself could also be an option. > > I agree. If we continue to not build them from source, it won't make the > Git package any more "expensive". We could add the pre-built source > tarball as a native-input to the Git package, and re-use the unpack > phase from git-manpages. I agree too, this sounds like a good idea. Thanks, Ludo=E2=80=99. From unknown Sat Aug 16 23:42:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24105: git package misses man pages Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 09 Aug 2016 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24105 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Andreas Enge , 24105@debbugs.gnu.org Received: via spool by 24105-submit@debbugs.gnu.org id=B24105.147076939125032 (code B ref 24105); Tue, 09 Aug 2016 19:04:01 +0000 Received: (at 24105) by debbugs.gnu.org; 9 Aug 2016 19:03:11 +0000 Received: from localhost ([127.0.0.1]:33378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXCIt-0006Va-IX for submit@debbugs.gnu.org; Tue, 09 Aug 2016 15:03:11 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXCIr-0006VP-S3 for 24105@debbugs.gnu.org; Tue, 09 Aug 2016 15:03:06 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3D57220237; Tue, 9 Aug 2016 15:03:05 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Tue, 09 Aug 2016 15:03:05 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=lE/a/0RbPKmorOeALuqcwe/3ag4=; b=OJtl3h DFSM6OFqzf4zmr29tcsuQyx3nIauN3aA6cbyGTTM3L71N5v0qQ5drokRWBjF+2OX nAB7uHR+COUkyskazOWQgHKCWjvJbTp9/fqOK5CJtVbolKPw+aWybTC0EZclziCE UHf7GtqZf2H6ljfsBjIw7Gq3OVEN2wvezc8UE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=lE/a/0RbPKmorOe ALuqcwe/3ag4=; b=uHOasjeGhRfCNB/SoUCZ5p/97FWBSnfeLEwOII9v6tWa3Iq UwHCZ27FskxraH8Xg7PXz3lT57TMSOPj80KfncCOrLz1V6whad8P42rIVk5HUDS2 zsnD8vzY9Mu9T3kcyRfCP9G6DwPBMKNL2Mo0/mu+zLAKXaCz7JJLEBDrv7yY= X-Sasl-enc: 8MzQoEaqad2UWyvL/GNFsDfyBh8BB/xb2ixYNQ/MkMLR 1470769384 Received: from localhost (c-68-81-58-201.hsd1.pa.comcast.net [68.81.58.201]) by mail.messagingengine.com (Postfix) with ESMTPA id DD7D0CCE66; Tue, 9 Aug 2016 15:03:04 -0400 (EDT) Date: Tue, 9 Aug 2016 15:03:02 -0400 From: Leo Famulari Message-ID: <20160809190302.GA13796@jasmine> References: <20160729124623.GA31006@solar> <20160729171059.GA14354@jasmine> <87vaznb5my.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87vaznb5my.fsf@gnu.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --T4sUOijqQbZv57TR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Jul 30, 2016 at 03:46:29PM +0200, Ludovic Courtès wrote: > Leo Famulari skribis: > > > On Fri, Jul 29, 2016 at 02:46:23PM +0200, Andreas Enge wrote: > > [...] > > >> I suggest to include the man pages into the git package itself. If building > >> them is a real issue, adding a source and the build phase of git-manpages > >> to the git package itself could also be an option. > > > > I agree. If we continue to not build them from source, it won't make the > > Git package any more "expensive". We could add the pre-built source > > tarball as a native-input to the Git package, and re-use the unpack > > phase from git-manpages. > > I agree too, this sounds like a good idea. I've attached a patch. Your thoughts? --T4sUOijqQbZv57TR Content-Type: text/x-diff; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-git-Provide-man-pages-in-main-Git-package.patch" Content-Transfer-Encoding: 8bit >From 2407216eac19e5a7a3376efc497f7047dc0c8299 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Tue, 9 Aug 2016 14:55:37 -0400 Subject: [PATCH] gnu: git: Provide man-pages in main Git package. * gnu/packages/version-control.scm (git-manpages): Remove variable. (git)[native-inputs]: Add GIT-MANPAGES. [arguments]: Add 'install-man-pages' phase. --- gnu/packages/version-control.scm | 69 ++++++++++++---------------------------- 1 file changed, 20 insertions(+), 49 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 767715d..dd0195d 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2015, 2016 Efraim Flashner ;;; Copyright © 2015 Kyle Meyer ;;; Copyright © 2015 Ricardo Wurmus +;;; Copyright © 2016 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -110,7 +111,6 @@ as well as the classic centralized workflow.") (license gpl2+))) (define-public git - ;; Keep in sync with 'git-manpages'! (package (name "git") (version "2.9.2") @@ -124,7 +124,16 @@ as well as the classic centralized workflow.") (build-system gnu-build-system) (native-inputs `(("native-perl" ,perl) - ("gettext" ,gnu-gettext))) + ("gettext" ,gnu-gettext) + ("git-manpages" + ,(origin + (method url-fetch) + (uri (string-append + "mirror://kernel.org/software/scm/git/git-manpages-" + version ".tar.xz")) + (sha256 + (base32 + "08y38w6yfvrpgj10dl3vghp05xjpl8jj37kkfna2nhf0wip52p2c")))))) (inputs `(("curl" ,curl) ("expat" ,expat) @@ -260,7 +269,15 @@ as well as the classic centralized workflow.") ;; specify a single directory, not a search path. (wrap-program (string-append out "/bin/git") `("PATH" ":" prefix - ("$HOME/.guix-profile/libexec/git-core"))))))))) + ("$HOME/.guix-profile/libexec/git-core")))))) + (add-after 'split 'install-man-pages + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (man (string-append out "/share/man")) + (manpages (assoc-ref inputs "git-manpages"))) + (mkdir-p man) + (with-directory-excursion man + (zero? (system* "tar" "xvf" manpages))))))))) (native-search-paths ;; For HTTPS access, Git needs a single-file certificate bundle, specified @@ -278,52 +295,6 @@ everything from small to very large projects with speed and efficiency.") (license gpl2) (home-page "http://git-scm.com/"))) -(define-public git-manpages - ;; Keep in sync with 'git'! - - ;; Granted, we could build the man pages from the 'git' package itself, - ;; which contains the real source. However, it would add a dependency on a - ;; full XML tool chain, and building it actually takes ages. So we use this - ;; lazy approach. - (package - (name "git-manpages") - (version (package-version git)) - (source (origin - (method url-fetch) - (uri (string-append - "mirror://kernel.org/software/scm/git/git-manpages-" - version ".tar.xz")) - (sha256 - (base32 - "08y38w6yfvrpgj10dl3vghp05xjpl8jj37kkfna2nhf0wip52p2c")))) - (build-system trivial-build-system) - (arguments - '(#:modules ((guix build utils)) - #:builder - (begin - (use-modules (guix build utils)) - - (let* ((xz (assoc-ref %build-inputs "xz")) - (tar (assoc-ref %build-inputs "tar")) - (out (assoc-ref %outputs "out")) - (man (string-append out "/share/man"))) - (setenv "PATH" (string-append tar "/bin:" xz "/bin")) - - (mkdir-p man) - (with-directory-excursion man - (zero? (system* "tar" "xvf" - (assoc-ref %build-inputs "source")))))))) - - (native-inputs `(("tar" ,tar) - ("xz" ,xz))) - (home-page (package-home-page git)) - (license (package-license git)) - (synopsis "Man pages of the Git version control system") - (description - "This package provides the man pages of the Git version control system. -This is the documentation displayed when using the '--help' option of a 'git' -command."))) - (define-public libgit2 (package (name "libgit2") -- 2.9.2 --T4sUOijqQbZv57TR-- From unknown Sat Aug 16 23:42:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24105: git package misses man pages Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 17 Aug 2016 09:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24105 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Famulari Cc: Andreas Enge , 24105@debbugs.gnu.org Received: via spool by 24105-submit@debbugs.gnu.org id=B24105.147142643931476 (code B ref 24105); Wed, 17 Aug 2016 09:34:01 +0000 Received: (at 24105) by debbugs.gnu.org; 17 Aug 2016 09:33:59 +0000 Received: from localhost ([127.0.0.1]:59755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZxEU-0008Bb-Qf for submit@debbugs.gnu.org; Wed, 17 Aug 2016 05:33:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZxET-0008BQ-S3 for 24105@debbugs.gnu.org; Wed, 17 Aug 2016 05:33:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZxEM-0001qy-6Y for 24105@debbugs.gnu.org; Wed, 17 Aug 2016 05:33:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZxEM-0001qu-41; Wed, 17 Aug 2016 05:33:50 -0400 Received: from adijon-655-1-77-167.w92-130.abo.wanadoo.fr ([92.130.140.167]:57066 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1bZxEL-0000gr-6Q; Wed, 17 Aug 2016 05:33:49 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20160729124623.GA31006@solar> <20160729171059.GA14354@jasmine> <87vaznb5my.fsf@gnu.org> <20160809190302.GA13796@jasmine> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 1 Fructidor an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Wed, 17 Aug 2016 11:33:54 +0200 In-Reply-To: <20160809190302.GA13796@jasmine> (Leo Famulari's message of "Tue, 9 Aug 2016 15:03:02 -0400") Message-ID: <87pop7u4cd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Leo Famulari skribis: > On Sat, Jul 30, 2016 at 03:46:29PM +0200, Ludovic Court=C3=A8s wrote: >> Leo Famulari skribis: >>=20 >> > On Fri, Jul 29, 2016 at 02:46:23PM +0200, Andreas Enge wrote: >>=20 >> [...] >>=20 >> >> I suggest to include the man pages into the git package itself. If bu= ilding >> >> them is a real issue, adding a source and the build phase of git-manp= ages >> >> to the git package itself could also be an option. >> > >> > I agree. If we continue to not build them from source, it won't make t= he >> > Git package any more "expensive". We could add the pre-built source >> > tarball as a native-input to the Git package, and re-use the unpack >> > phase from git-manpages. >>=20 >> I agree too, this sounds like a good idea. > > I've attached a patch. Your thoughts? > > From 2407216eac19e5a7a3376efc497f7047dc0c8299 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Tue, 9 Aug 2016 14:55:37 -0400 > Subject: [PATCH] gnu: git: Provide man-pages in main Git package. > > * gnu/packages/version-control.scm (git-manpages): Remove variable. > (git)[native-inputs]: Add GIT-MANPAGES. > [arguments]: Add 'install-man-pages' phase. LGTM! :-) Thank you! Ludo'. From unknown Sat Aug 16 23:42:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Andreas Enge Subject: bug#24105: closed (Re: bug#24105: git package misses man pages) Message-ID: References: <20160818024254.GA9101@jasmine> <20160729124623.GA31006@solar> X-Gnu-PR-Message: they-closed 24105 X-Gnu-PR-Package: guix Reply-To: 24105@debbugs.gnu.org Date: Thu, 18 Aug 2016 02:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1471488242-11745-1" This is a multi-part message in MIME format... ------------=_1471488242-11745-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24105: git package misses man pages which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24105@debbugs.gnu.org. --=20 24105: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24105 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1471488242-11745-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24105-done) by debbugs.gnu.org; 18 Aug 2016 02:43:04 +0000 Received: from localhost ([127.0.0.1]:60657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baDIO-00031x-EN for submit@debbugs.gnu.org; Wed, 17 Aug 2016 22:43:04 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baDIK-00031X-Uo for 24105-done@debbugs.gnu.org; Wed, 17 Aug 2016 22:43:03 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 638D420892; Wed, 17 Aug 2016 22:43:00 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Wed, 17 Aug 2016 22:43:00 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=MB1wB+97sffAY9p8zwhtlr6qkVk=; b=Lo5qZm 0YW2iAxkuIUva10kvPCXSkXYlaekI0RYZxlt2Xh1xemCPMp13N6HXpipsaYbPDWn 0eXMxf/CR5baMusIy29ZBlYEI00rSWM+jgW0HtZBWs7J7bAO8tV0eHlQ2vvll0a9 ZAzIGW+tGMYq9Z8HWQKbdv4bPeZOqniqzyBuY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=MB1wB+97sffAY9p 8zwhtlr6qkVk=; b=GzJ4Ivll0DO1jlFcDujQ7qjP5VnyqTscfEwoLdT1ovt+qJ1 sgmI1IOlfwTtnfnx/NWV4gLDon7lhg1E66R5KlGBR0ixuIfu4rBIAvfNXlqr4GKS JHcfPimqpbKtLrlsEXNYZVKWniAdm9BdzsT10Tq1P4o6WRxf+RnjmKm74mUg= X-Sasl-enc: 6eLi30DQCUxckQ7xrplb/NlNNb4d4N0arjUJSKVLfoZh 1471488180 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 17A2BCCE67; Wed, 17 Aug 2016 22:43:00 -0400 (EDT) Date: Wed, 17 Aug 2016 22:42:54 -0400 From: Leo Famulari To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#24105: git package misses man pages Message-ID: <20160818024254.GA9101@jasmine> References: <20160729124623.GA31006@solar> <20160729171059.GA14354@jasmine> <87vaznb5my.fsf@gnu.org> <20160809190302.GA13796@jasmine> <87pop7u4cd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pop7u4cd.fsf@gnu.org> User-Agent: Mutt/1.6.2hg (2016-07-01) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24105-done Cc: Andreas Enge , 24105-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Aug 17, 2016 at 11:33:54AM +0200, Ludovic Courtès wrote: > Leo Famulari skribis: > > * gnu/packages/version-control.scm (git-manpages): Remove variable. > > (git)[native-inputs]: Add GIT-MANPAGES. > > [arguments]: Add 'install-man-pages' phase. > > LGTM! :-) Pushed as d1cada045. ------------=_1471488242-11745-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jul 2016 12:46:43 +0000 Received: from localhost ([127.0.0.1]:50088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7Bb-0001Oe-89 for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7BZ-0001OS-Lw for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7BT-0001mA-PK for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7BT-0001m6-MT for submit@debbugs.gnu.org; Fri, 29 Jul 2016 08:46:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7BP-0006s8-QI for bug-guix@gnu.org; Fri, 29 Jul 2016 08:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7BM-0001la-22 for bug-guix@gnu.org; Fri, 29 Jul 2016 08:46:30 -0400 Received: from mailrelay2.public.one.com ([91.198.169.125]:65515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7BL-0001lK-KM for bug-guix@gnu.org; Fri, 29 Jul 2016 08:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=enge.fr; s=20140924; h=from:subject:date:message-id:to:mime-version:content-type; bh=mbWQkVzD+tATvlUGPOwlHvDDPawaBmIDX6T6mxO+2UA=; b=Yo1xpH+nLZz4cGl9BwqN85fls9+qa+kMDH+rXPx/X1GwPMPnoCA/nAWhtfkpv0IB7TiEdf4hTgHQz gV8MbOmPhRxCHw8AdmwT1iMt+eqgT6HXgJVAlTV4c4wKv6+fYjszBCACra/P2BrM4xTpi5CKnLUUE8 dzuftqVlP0WlRyWk= X-HalOne-Cookie: e9b3a58fde19724af8e10f352eaec224f4c4993c X-HalOne-ID: 75f81412-558a-11e6-b476-b82a72d03b9b Received: from solar (unknown [92.89.73.211]) by smtpfilter2.public.one.com (Halon Mail Gateway) with ESMTPSA; Fri, 29 Jul 2016 12:46:25 +0000 (UTC) Date: Fri, 29 Jul 2016 14:46:23 +0200 From: Andreas Enge To: bug-guix@gnu.org Subject: git package misses man pages Message-ID: <20160729124623.GA31006@solar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, wondering why "git log --help" does not work, I thought that maybe there was a different doc output. But the man pages are actually hidden in a separate package called "git-manpages". This is surprising for the user. Also, the resulting package is quite small with only 2.3 MB. The reason for the separate package is given as this: ;; Granted, we could build the man pages from the 'git' package itself, ;; which contains the real source. However, it would add a dependency on a ;; full XML tool chain, and building it actually takes ages. So we use this ;; lazy approach. Building will most of the time happen on the build farm, so the time it takes should not be an issue. I suppose that the xml tool chain will only be a native and not a normal input, so it should not be too much of a problem. I suggest to include the man pages into the git package itself. If building them is a real issue, adding a source and the build phase of git-manpages to the git package itself could also be an option. Thanks! Andreas ------------=_1471488242-11745-1--