From unknown Mon Jun 16 23:47:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24103 <24103@debbugs.gnu.org> To: bug#24103 <24103@debbugs.gnu.org> Subject: Status: 25.1.50; dired-copy-filename-as-kill: Copy just non-empty strings Reply-To: bug#24103 <24103@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:47:43 +0000 retitle 24103 25.1.50; dired-copy-filename-as-kill: Copy just non-empty str= ings reassign 24103 emacs submitter 24103 Tino Calancha severity 24103 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 29 05:58:26 2016 Received: (at submit) by debbugs.gnu.org; 29 Jul 2016 09:58:26 +0000 Received: from localhost ([127.0.0.1]:49972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT4Yk-00042W-LU for submit@debbugs.gnu.org; Fri, 29 Jul 2016 05:58:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT4Yj-00042L-Vu for submit@debbugs.gnu.org; Fri, 29 Jul 2016 05:58:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT4Yd-0004df-MF for submit@debbugs.gnu.org; Fri, 29 Jul 2016 05:58:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT4Yd-0004cM-J4 for submit@debbugs.gnu.org; Fri, 29 Jul 2016 05:58:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT4Yb-0002qy-Bm for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 05:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT4YX-0004am-A4 for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 05:58:17 -0400 Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]:33666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT4YX-0004aW-2w for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 05:58:13 -0400 Received: by mail-pf0-x22c.google.com with SMTP id y134so31441843pfg.0 for ; Fri, 29 Jul 2016 02:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version; bh=yORdLJhQ5Ia93EjOLdEjWnKu39qy5ak+pFPNjkdHw0Y=; b=F89mdqE4WS/CEHdjubqUFRdxFf+6xYDVoWjlUyijNNoFzKahj9d8xh5k9se9NO801F JrnA91gQftfkGK6JxdSgi+abwkXQoeTyBFifk66EBzs0jMgcoh2Sx9NMKpIrM0OWNIdF gj106cWsA3eOxwV+BS1pqwUmRAmPE8UppZN8NxO7Sd8q6y011Jofirmy0hrcpCcIxFrF I4ABdytXvH0c4FqtqsOE4n7TzpybXLWc3QjFyd+gDBdZ+VBsQCkmCXuxLOQw0wf8dn66 aSUZlkgKSgoLIJCO+ELg7AJk++H192jS0h16u0c6bjctVlDf36DHwNq7eElQMvc0HCaP 1qHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:user-agent :mime-version; bh=yORdLJhQ5Ia93EjOLdEjWnKu39qy5ak+pFPNjkdHw0Y=; b=Ac76cekmfdjl+BbCzNXIYqYjFDlL+ENqWuz/Zb2PiYY8KtUibMllq4iLQPcUkg9QhX pNIwt4ov7rLQj0Y6lwuCU9hV2gLpDxxqznEcSn5+E5U+uyesLoK0H6sKlvzL2DRrym7y 0GOEVJ0CCLxZATwBGT9UnVrk/yxf7hslYF01uwstU14d3cwY+sKYLdoB3eiTHZAgLEfb 9Pux0Liyj8jypVpBoo+SQe/oo82wzV7KTrZ3WIuZ0sIpwV/YpF/KnmoXrXpxush73F0h 1TVRjJd7RFAP70+sZmiEtZTyML+zazQUp2VNIKYixrY+T2P1C9BGAK8uVxnEPGOVxyU/ +63g== X-Gm-Message-State: AEkoouujivTkJ4/VqmyjiboutFX+ZFbRWEWFUPynVKw4rtkKoPQ868zryw1Otwsn72dITw== X-Received: by 10.98.80.29 with SMTP id e29mr67333907pfb.76.1469786291898; Fri, 29 Jul 2016 02:58:11 -0700 (PDT) Received: from calancha-pc ([103.5.140.132]) by smtp.gmail.com with ESMTPSA id yp10sm10786433pab.25.2016.07.29.02.58.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jul 2016 02:58:11 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 29 Jul 2016 18:57:41 +0900 (JST) X-X-Sender: calancha@calancha-pc To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Add white space separator when appending string Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I) emacs -Q ~ M-: (goto-char (dired-subdir-min)) RET M-: (dired-goto-next-file) RET w ;; copied first file name into kill-ring M-: (dired-next-line 1) RET C-M-w w ;; This append second file name to the kill-ring. ;; Note that there is no separator between the first/second file name. II) emacs -Q ~ M-: (goto-char (dired-subdir-min)) RET w ;; dir name copied into kill-ring M-: (goto-char (dired-subdir-max)) RET w ;; copied '' into kill-ring ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 80e9eb3fc790148a70dbf1da5d12e22681180bee Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Fri, 29 Jul 2016 18:53:38 +0900 Subject: [PATCH] Add white space separator when appending string * lisp/dired.el (dired-copy-filename-as-kill): Add white space before string when command is appending. Copy just non-empty strings (Bug#24103). --- lisp/dired.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/dired.el b/lisp/dired.el index 5d14291..095ab14 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -2467,10 +2467,11 @@ dired-copy-filename-as-kill 'no-dir (prefix-numeric-value arg)))) (dired-get-marked-files 'no-dir)) " ")))) - (if (eq last-command 'kill-region) - (kill-append string nil) - (kill-new string)) - (message "%s" string))) + (unless (string= string "") + (if (eq last-command 'kill-region) + (kill-append (concat " " string) nil) + (kill-new string)) + (message "%s" string)))) ;; Keeping Dired buffers in sync with the filesystem and with each other -- 2.8.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; GNU Emacs 25.1.50 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6) of 2016-07-28 Repository revision: 4a5b6e621c68172bb69d60fe8a76932f7c779f81 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 29 06:16:20 2016 Received: (at 24103) by debbugs.gnu.org; 29 Jul 2016 10:16:21 +0000 Received: from localhost ([127.0.0.1]:49989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT4q4-0004TX-OU for submit@debbugs.gnu.org; Fri, 29 Jul 2016 06:16:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT4q2-0004TI-HG for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 06:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT4pu-00087w-Aj for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 06:16:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT4pu-00087n-7c; Fri, 29 Jul 2016 06:16:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1464 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bT4ps-0004nT-FI; Fri, 29 Jul 2016 06:16:08 -0400 Date: Fri, 29 Jul 2016 13:16:03 +0300 Message-Id: <83h9b8rbq4.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Fri, 29 Jul 2016 18:57:41 +0900 (JST)) Subject: Re: bug#24103: 25.1.50; Add white space separator when appending string References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Tino Calancha > Date: Fri, 29 Jul 2016 18:57:41 +0900 (JST) > > > I) > emacs -Q ~ > M-: (goto-char (dired-subdir-min)) RET > M-: (dired-goto-next-file) RET > w > ;; copied first file name into kill-ring > M-: (dired-next-line 1) RET > C-M-w w > ;; This append second file name to the kill-ring. > ;; Note that there is no separator between the first/second file name. > > II) > emacs -Q ~ > M-: (goto-char (dired-subdir-min)) RET > w > ;; dir name copied into kill-ring > M-: (goto-char (dired-subdir-max)) RET > w > ;; copied '' into kill-ring > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > >From 80e9eb3fc790148a70dbf1da5d12e22681180bee Mon Sep 17 00:00:00 2001 > From: Tino Calancha > Date: Fri, 29 Jul 2016 18:53:38 +0900 > Subject: [PATCH] Add white space separator when appending string > > * lisp/dired.el (dired-copy-filename-as-kill): > Add white space before string when command is appending. > Copy just non-empty strings (Bug#24103). Isn't this second-guessing what the user means? What if the kill ring has "/foo/bar/" and the user wants to append a file name to that, thus creating a valid absolute file name? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 29 06:27:41 2016 Received: (at 24103) by debbugs.gnu.org; 29 Jul 2016 10:27:41 +0000 Received: from localhost ([127.0.0.1]:49997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT513-0004nq-KQ for submit@debbugs.gnu.org; Fri, 29 Jul 2016 06:27:41 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT511-0004nf-Qu for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 06:27:40 -0400 Received: by mail-pf0-f170.google.com with SMTP id h186so31528197pfg.3 for <24103@debbugs.gnu.org>; Fri, 29 Jul 2016 03:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=EWHUDNaj1/8rYNMFVjBzVAKyUEPPIwoYsIYJ5oS9BG8=; b=v0IzECP8UoOA975UWM5cG8DFHBdU+vz3PA7JKytFpuJYB5XgsHkIsfIU7bUaU+n4Rn 9T0x6yziI5nlfn7KsZUUr1gPU7Nkw/TkAk9f10cprnM1nHnWLh52XxJmBSHSGeRzLfdw +wR+nxgWKuC8OZcdVFiKjn4xvflwyO8H/JVCWpXn6H5RpeLG4W4+dmsdXFf7pCw7WNWu x9cDdbIeA44spJ1OPkDRg7FJKuxXfARIRqbZ5c2I3YftebIVY+xMc9t5SAc2j+T9wHGs mKPH/8C7Q8wfGksOi2jcHS4uONTBE6KZXFpxuVHnr4O74IDN6nnVTM9EEYVRk8Aj58xF dspQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=EWHUDNaj1/8rYNMFVjBzVAKyUEPPIwoYsIYJ5oS9BG8=; b=f7ZLEe2DEBZn2E9JpYu9aILrcjG34/7AQtNa4EmTzsY+/mvR3WBq21CkKrqfOHe8t8 11iPDr6BygTxYUY0TnTapxNWo759GaLsoXoJJBgnJBLwVt6xPAmmipwJob/xz3lUSIHX 4K4PtXsNUF3cIWXH0xnDcW5fmfOKqV1Qm9s0QTc81r7CsUX3rOdh4+E5GMfDo5sJLOn5 7IoQqDORtr76zWeyif3BlhPEBhTI8caM0uv02nL6qaFGsnk9NE8z1hmJ3iigyHZdfzKj WKgGfmX09c8wQ5WZ66pNCKWFi5TAsLiKm0zXB5cow7KCJ4QOo/JQQ74sN4oDf0JZmCeR BHVQ== X-Gm-Message-State: AEkooutUGFYSRtsGXX2qxdY9HtVi2WBG5PmXmL9VwC4+bfsvbdkC7hzx5l7ARJqNsYXqIg== X-Received: by 10.98.208.1 with SMTP id p1mr67603870pfg.10.1469788054021; Fri, 29 Jul 2016 03:27:34 -0700 (PDT) Received: from calancha-pc ([103.5.140.176]) by smtp.gmail.com with ESMTPSA id r21sm23737743pfi.52.2016.07.29.03.27.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jul 2016 03:27:33 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 29 Jul 2016 19:27:30 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#24103: 25.1.50; Add white space separator when appending string In-Reply-To: <83h9b8rbq4.fsf@gnu.org> Message-ID: References: <83h9b8rbq4.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, 29 Jul 2016, Tino Calancha wrote: >> emacs -Q ~ Please, require dired-aux to do my example, as follows: emacs -Q ~ --eval="(require 'dired-aux)" ;; for 'dired-subdir-min' On Fri, 29 Jul 2016, Eli Zaretskii wrote: > Isn't this second-guessing what the user means? What if the kill ring > has "/foo/bar/" and the user wants to append a file name to that, thus > creating a valid absolute file name? Maybe, but not so standard way; we can skip that part of the fix, though. The command provide a nice way to do that as mentioned in the doc string: C-u 0 w From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 29 09:26:03 2016 Received: (at 24103) by debbugs.gnu.org; 29 Jul 2016 13:26:03 +0000 Received: from localhost ([127.0.0.1]:50148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7nf-0002RX-GX for submit@debbugs.gnu.org; Fri, 29 Jul 2016 09:26:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT7nc-0002RD-Sy for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 09:26:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT7nV-0001hN-1c for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 09:25:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT7nU-0001h3-Uf; Fri, 29 Jul 2016 09:25:52 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1552 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bT7nR-0001xR-2I; Fri, 29 Jul 2016 09:25:51 -0400 Date: Fri, 29 Jul 2016 16:25:32 +0300 Message-Id: <83eg6cr2yb.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Fri, 29 Jul 2016 19:27:30 +0900 (JST)) Subject: Re: bug#24103: 25.1.50; Add white space separator when appending string References: <83h9b8rbq4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Tino Calancha > Date: Fri, 29 Jul 2016 19:27:30 +0900 (JST) > cc: Tino Calancha , 24103@debbugs.gnu.org > > On Fri, 29 Jul 2016, Eli Zaretskii wrote: > > Isn't this second-guessing what the user means? What if the kill ring > > has "/foo/bar/" and the user wants to append a file name to that, thus > > creating a valid absolute file name? > Maybe, but not so standard way; we can skip that part of the fix, though. Sorry, I don't understand: which part of the fix you suggest to skip, and what will be left then? > The command provide a nice way to do that as mentioned in the doc string: > C-u 0 w No, that produces the absolute names of files in the directory shown by Dired, whereas what I meant is constructing a name of a file in another directory by concatenating a directory killed in another kill command and the file name killed by 'w'. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 29 10:30:01 2016 Received: (at 24103) by debbugs.gnu.org; 29 Jul 2016 14:30:01 +0000 Received: from localhost ([127.0.0.1]:50844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT8nZ-00048j-2k for submit@debbugs.gnu.org; Fri, 29 Jul 2016 10:30:01 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT8nY-00048W-0K for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 10:30:00 -0400 Received: by mail-pa0-f45.google.com with SMTP id fi15so31869994pac.1 for <24103@debbugs.gnu.org>; Fri, 29 Jul 2016 07:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+1H+N8/0OKaWVzzjEptlJjltvu16P0DwV3yfM8VADWM=; b=HaPyKG5dT9XNORt4AVAgDkTmZcefOPfK+Iq5c0oQ3c1IVcE1Se27J20KCVBSqjTWdS iCvRHHpMKB9Tw3FIBXNJXzNYBWS/v+P0sqX49T5PPBjeItEhFuHCiQJ8wE/NPrDwhJ2L oWhgxRPhkwu3X0IoZiVVyNRQCsudgOlvNohRlgy7uCiHYGbmcnrAnrET/XD+kqZ2C9if 2S4V56YJhn20a+bc4QaNdORBoxU+0Dfxopji7LaPb8S1xaom+CjVeWe8YcFJRY397jGD CdBGYXw9YR6Wc3WY7oumyTdiTys3Eu0w+7nDWxSbN9GNXYLElvhjhKqB9WT4agL+nc3U OL8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+1H+N8/0OKaWVzzjEptlJjltvu16P0DwV3yfM8VADWM=; b=biAI2XEzdP6hBoozCk2gIUsyUmt0TIX/a9iYEn1JcLFNsCM/z8A1WbCtPxDrain0uY MZ6lpkHA9rIkDsVhpHcruikK3AMFMbvW7RwwDGZqMkSsA5upWgAiEryaEzT0LYFaH94v iuiDfEeNP95FEDsvnwvpGVn8pjTp5QWgpJ9D+hmlg0Jdq/J2D5IsCk7A9xS8yGX2QZsz 9k6nvMHG0JKJJiA1LWMnlbcPsLvRBJZ+QARSStuAL+4ORGvN3XZixpUV3trWlu7U01qA 3EouGXjlsd4Dzg3+hXWmZ7tQawpSp0iBSkengv5RiShIVUi784oTna19gHve/2tsxbz0 e1/w== X-Gm-Message-State: AEkoousfFfevJILmagekZmifgFItiheBUNkfs5ZM5jaLCMSXEWJwGdrbLJPighBfWEgprA== X-Received: by 10.66.74.133 with SMTP id t5mr70286724pav.114.1469802593988; Fri, 29 Jul 2016 07:29:53 -0700 (PDT) Received: from calancha-pc ([103.5.140.187]) by smtp.gmail.com with ESMTPSA id w76sm25542338pfd.69.2016.07.29.07.29.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jul 2016 07:29:53 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 29 Jul 2016 23:29:50 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#24103: 25.1.50; Add white space separator when appending string In-Reply-To: <83eg6cr2yb.fsf@gnu.org> Message-ID: References: <83h9b8rbq4.fsf@gnu.org> <83eg6cr2yb.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, 29 Jul 2016, Eli Zaretskii wrote: >> The command provide a nice way to do that as mentioned in the doc string: >> C-u 0 w > > No, that produces the absolute names of files in the directory shown > by Dired, whereas what I meant is constructing a name of a file in > another directory by concatenating a directory killed in another kill > command and the file name killed by 'w'. Agreed. It might be useful. >> From: Tino Calancha >> Date: Fri, 29 Jul 2016 19:27:30 +0900 (JST) >> cc: Tino Calancha , 24103@debbugs.gnu.org > Sorry, I don't understand: which part of the fix you suggest to skip, > and what will be left then? So, the patch now fix the II) in the report: it prevent to change the kill ring when the string is empty. The command name and the doc string suggest the usage is about copying file names. I would prefer if this command have effect just when point is: 1) on a line showing a subdir name for instance: (dired-subdir-min) 2) on a line showing a file from the dired listing on a line displaying a file or subddir name for instance, (progn (goto-char (dired-subdir-min)) (dired-goto-next-file) (point)) Currently the command is enabled whatever is the point in the Dired buffer. As a consequence, the command put a "" in the kill ring if the command is called with the point in one position other than 1) 2) for instance: 3) (progn (goto-char (dired-subdir-min)) (forward-line 1) (point)) I would propose in order of preference: A) Do not change the kill ring when the command is called with point in a position like 3) (See patch below). B) Update the doc string alerting that the command is responsive even if there is no filename/subdir accesible: the kill ring will get "" in that cases. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From c7c1312e4acf942742e387a474d368266b48dc99 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Fri, 29 Jul 2016 23:06:16 +0900 Subject: [PATCH] Copy just non-empty strings to kill-ring * lisp/dired.el (dired-copy-filename-as-kill): Do not change the kill ring when the string is empty. (Bug#24103). --- lisp/dired.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/dired.el b/lisp/dired.el index 5d14291..7ead087 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -2467,10 +2467,11 @@ dired-copy-filename-as-kill 'no-dir (prefix-numeric-value arg)))) (dired-get-marked-files 'no-dir)) " ")))) - (if (eq last-command 'kill-region) - (kill-append string nil) - (kill-new string)) - (message "%s" string))) + (unless (string= string "") + (if (eq last-command 'kill-region) + (kill-append string nil) + (kill-new string)) + (message "%s" string)))) ;; Keeping Dired buffers in sync with the filesystem and with each other -- 2.8.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; GNU Emacs 25.1.50 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6) of 2016-07-28 Repository revision: 4a5b6e621c68172bb69d60fe8a76932f7c779f81 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 29 11:00:21 2016 Received: (at 24103) by debbugs.gnu.org; 29 Jul 2016 15:00:21 +0000 Received: from localhost ([127.0.0.1]:50866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT9Gv-0004r1-91 for submit@debbugs.gnu.org; Fri, 29 Jul 2016 11:00:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT9Gt-0004qo-Ev for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 11:00:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT9Gk-0002jH-Fm for 24103@debbugs.gnu.org; Fri, 29 Jul 2016 11:00:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT9Gk-0002jD-D9; Fri, 29 Jul 2016 11:00:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1592 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bT9Gh-00033f-FC; Fri, 29 Jul 2016 11:00:10 -0400 Date: Fri, 29 Jul 2016 17:59:49 +0300 Message-Id: <83a8h0qyl6.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Fri, 29 Jul 2016 23:29:50 +0900 (JST)) Subject: Re: bug#24103: 25.1.50; Add white space separator when appending string References: <83h9b8rbq4.fsf@gnu.org> <83eg6cr2yb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Tino Calancha > Date: Fri, 29 Jul 2016 23:29:50 +0900 (JST) > cc: Tino Calancha , 24103@debbugs.gnu.org > > So, the patch now fix the II) in the report: it prevent to change the kill > ring when the string is empty. That should be fine, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 30 04:29:52 2016 Received: (at 24103-done) by debbugs.gnu.org; 30 Jul 2016 08:29:52 +0000 Received: from localhost ([127.0.0.1]:51135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPea-00041H-ML for submit@debbugs.gnu.org; Sat, 30 Jul 2016 04:29:52 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPeZ-000415-Dz for 24103-done@debbugs.gnu.org; Sat, 30 Jul 2016 04:29:51 -0400 Received: by mail-pa0-f47.google.com with SMTP id pp5so37801529pac.3 for <24103-done@debbugs.gnu.org>; Sat, 30 Jul 2016 01:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:message-id:user-agent:mime-version; bh=Tri9SZU1rNW9gKrt9dBXlc5SIY6t7poiASSQqkLbTt4=; b=MaRivvnZhq3ClN7KQoNSn2JI3MmlZiBH3/RcUcZI4ZnRZ4IcJnLsDvN9cDbU32O6w/ 9M5iZVQUrbwMCKaDYemjnLifHwz24K7zMV6fJxqYAyiw/Eht41m3jmqf2rw+LCL3LU7o wDAvRiL1OrE+q7zNGjBrXoDj0anyoQr2toe39gKt9Sytz39XsNs8MgH4eVoyPF7IbDUG YilkYvPywpFRb8B7uizKcHb6o9nI3eBgPQdksTB6x4pUGvfhiVsThrasBWbps7exuCOw cPWASEBWIlsxslxHSBvnPq4ctKDts4IIxE/p0f1tqSKNOWFai3Hod3MJNPoxF2LRXceN fh+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:message-id:user-agent:mime-version; bh=Tri9SZU1rNW9gKrt9dBXlc5SIY6t7poiASSQqkLbTt4=; b=UIYL2OqgST6ekCHdfdcdm/W4HbPezHLkNKua4RfBT4058j4MWifFCB8nvHm9g+UUp8 yS3GOGx66SupYewL6OUnxdx9u0uy965j2MKJ9vdq7PxjBnKXJP+SHqyQzNG/vkw4ErqS svDqcwNDlbF4JmNLzWHnoPUriO25heRkJLxf2YpwekA0nVty7+0JpGE0LPb43mvKe7Eq bFtExxUKjKGJfvaWYBrAXclGl3amQVCuzaMcElnBp9p/nV9TpuwEqIdhjbzeqoA55VfC szJBRXSOEy+habjra2nPlHvwykqXdOuMH7ExrJ95x/5WsiUmZasHIp9KN3lqwPNqaMqt o3FA== X-Gm-Message-State: AEkoouuhmzrtCGMg+U3L80AE/ScQW5VvGUG+Q7A4A5GwEOyl1SJti61ktz+SjzsEyjr3eQ== X-Received: by 10.66.159.195 with SMTP id xe3mr77198112pab.159.1469867385536; Sat, 30 Jul 2016 01:29:45 -0700 (PDT) Received: from calancha-pc ([103.5.140.182]) by smtp.gmail.com with ESMTPSA id 81sm30271675pfm.90.2016.07.30.01.29.43 for <24103-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Jul 2016 01:29:44 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sat, 30 Jul 2016 17:29:42 +0900 (JST) X-X-Sender: calancha@calancha-pc To: 24103-done@debbugs.gnu.org Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixed in master branch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.47 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.47 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: 24103-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixed in master branch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.47 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.47 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject Fixed in master branch From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 30 04:34:14 2016 Received: (at control) by debbugs.gnu.org; 30 Jul 2016 08:34:14 +0000 Received: from localhost ([127.0.0.1]:51148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPio-00049k-IG for submit@debbugs.gnu.org; Sat, 30 Jul 2016 04:34:14 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPin-00049X-1V for control@debbugs.gnu.org; Sat, 30 Jul 2016 04:34:13 -0400 Received: by mail-pa0-f53.google.com with SMTP id fi15so37917743pac.1 for ; Sat, 30 Jul 2016 01:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:message-id:user-agent:mime-version; bh=MsA5kiDjmfT+MNwkt6XV80NLe150vkakgkvmWQkenn4=; b=JgEw+bHvx2LtpP3V66ZzAzbX9sIWzOmFioowCTKwVeM/Bp9gXAg2rJ/DbUfd7pTaN6 BP+uUM9oL6KwTKBZUmKgPVTC3Fmpn2nvEZusA+LLMmCrUhQrvNMdOXF8OtQwCHlkNk6Y mDL1dYT117Sd/JMBEFYkeubH4s+RbTUa5RRSDaMDAzokd+z2n48N1etVneQvaK5D70Zh FqzlhxcwWwIi13LG5xR8kIxxfxpmCXeTSKJBJa0PUW0CRCrYJxgQINdEw+CjeVVxqyL6 nhS5BfdgtjN29jcpWFKjm5YKfiVbBIUSxT0puFaDZ/rqklLeNFi6lz38+XPDAnonyBCc hPKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:message-id:user-agent:mime-version; bh=MsA5kiDjmfT+MNwkt6XV80NLe150vkakgkvmWQkenn4=; b=NXvjMHrJTb6h/HheSrDMdzMuj2PJjGbfmy/EqsEVT7wbcblMEosbTqjWSnpJjCX/K4 1L/DhWeCF5K6NPsv91kTslKPeilLi278h4aAC7M/CCnoWGsE+ORPPQT2qZkFeyldvEux G3FTDhyWhbgmFsReNCEK2N0Tx61JsNf+Gpl2ICRigUSDgyyBP1vUqYZJPhD9ylnD8ivZ a6A3k+2anXBFoiXJijpUL4+mUEjwTUuAWV/OVRilZzqgDOk4oq5OuyhCkWh+OQrbU/JM t6R6MocIdUOTNcClWuk2OqS73awAOUyXPOr27pM8KZ290/vRnEDJCcZprsJeF1b88zvV WUdQ== X-Gm-Message-State: AEkoousN4/AqJmkMFJyEYHem/3DvdK4n0iDUkKVT6R3X6HoRiyIEaCZDllucmFdYPRIkWQ== X-Received: by 10.66.226.201 with SMTP id ru9mr75665151pac.55.1469867647285; Sat, 30 Jul 2016 01:34:07 -0700 (PDT) Received: from calancha-pc ([103.5.140.164]) by smtp.gmail.com with ESMTPSA id wp4sm30461366pab.15.2016.07.30.01.34.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Jul 2016 01:34:06 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sat, 30 Jul 2016 17:34:04 +0900 (JST) X-X-Sender: calancha@calancha-pc To: control@debbugs.gnu.org Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 24103 dired-copy-filename-as-kill: Copy just non-empty strings [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.53 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.53 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 24103 dired-copy-filename-as-kill: Copy just non-empty strings [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.53 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.53 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 TVD_SPACE_RATIO No description available. retitle 24103 dired-copy-filename-as-kill: Copy just non-empty strings From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 30 04:37:40 2016 Received: (at control) by debbugs.gnu.org; 30 Jul 2016 08:37:40 +0000 Received: from localhost ([127.0.0.1]:51153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPm8-0004Ez-1Z for submit@debbugs.gnu.org; Sat, 30 Jul 2016 04:37:40 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPm6-0004Ek-8d for control@debbugs.gnu.org; Sat, 30 Jul 2016 04:37:38 -0400 Received: by mail-pa0-f42.google.com with SMTP id ks6so37927719pab.0 for ; Sat, 30 Jul 2016 01:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:message-id:user-agent:mime-version; bh=NlLBJNOhkJvBmmgI8WmFFxikyeE3EQKD/Uyw5NIwUsM=; b=fFCUUrIv+IF7XqKD0tXSC8mwKvafGdAAFvpa5G4yypMoJIr0lOIfXgR8646wNjeCiG UM/5qHMzKghgVLabmZCFNdbznNhjuMlwgJfUd4etPUOiHbSWNhNIgY2D7WJYc/ahlHT8 qoXFZsJDfbxksk0BrxTVRszscWuR/vz6GshJBpBmdvSb0WXlyYEvqdPuPVq8KnIhWMwF Xjkg2qHLROWbL2iQDJmFgbYym+XWm0GfSwpwyO6iGOf5nqkITwDx7upDdzqSKcVFc/Vo kuAcJYM4TyIRQB65Un93ckCmrpKujkqJ/ausmHKs8295xdnEMLhkuWca5hOspCs61cQm vV6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:message-id:user-agent:mime-version; bh=NlLBJNOhkJvBmmgI8WmFFxikyeE3EQKD/Uyw5NIwUsM=; b=aD9cnJifOUGaUcvqfPjZneg0aqV6gpAbvtVMoGgb0HKW/2rI9FB2Ftp2NTnr6tSGbI +tb1XRVt5ba0TmyxXkrx+VoZW9ObuI5lDtRtSvx1FXSQsWKYDpmrFfydRrFxAsq9rA0O TjViuk8TNUdFqU0fUqcy3RJqmQjg1Tkm7rNEXhd8uAD2JgA/WK7ocvzTkGi3yvHCh76D FApnhMW708VYK76WjA6clgcyIUBJjt5SZ2LdbBqnp4W1d5V7DDxWHN2BhGzMPqXh8UWT +3D1CC1ULkc9p9XQVBUamhi//4wTBmCXUoA35uBvknQNkcJo+i0QnWo1jRVpzUs4Y2FZ t1IA== X-Gm-Message-State: AEkooutiSHLrArYX4iUAQzOUbkwXX8T4Klgw5sAGnpogvZ/I5Eu3FQ4xDtl92eJhoam5MQ== X-Received: by 10.66.229.9 with SMTP id sm9mr75928987pac.138.1469867852393; Sat, 30 Jul 2016 01:37:32 -0700 (PDT) Received: from calancha-pc ([103.5.140.142]) by smtp.gmail.com with ESMTPSA id 191sm30387133pfx.68.2016.07.30.01.37.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Jul 2016 01:37:31 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sat, 30 Jul 2016 17:37:29 +0900 (JST) X-X-Sender: calancha@calancha-pc To: control@debbugs.gnu.org Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 24103 25.1.50; dired-copy-filename-as-kill: Copy just non-empty strings [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.220.42 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.42 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 24103 25.1.50; dired-copy-filename-as-kill: Copy just non-empty strings [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.42 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.220.42 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 TVD_SPACE_RATIO No description available. retitle 24103 25.1.50; dired-copy-filename-as-kill: Copy just non-empty strings From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 30 04:48:24 2016 Received: (at 24103) by debbugs.gnu.org; 30 Jul 2016 08:48:24 +0000 Received: from localhost ([127.0.0.1]:51166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPwV-00066W-Ej for submit@debbugs.gnu.org; Sat, 30 Jul 2016 04:48:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPwU-00066L-5N for 24103@debbugs.gnu.org; Sat, 30 Jul 2016 04:48:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTPwL-0002eS-P5 for 24103@debbugs.gnu.org; Sat, 30 Jul 2016 04:48:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTPwL-0002eH-Li; Sat, 30 Jul 2016 04:48:13 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bTPwJ-0000Oy-C2; Sat, 30 Jul 2016 04:48:11 -0400 Date: Sat, 30 Jul 2016 11:48:08 +0300 Message-Id: <83r3abpl4n.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Sat, 30 Jul 2016 17:29:42 +0900 (JST)) Subject: Re: bug#24103: (no subject) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) > From: Tino Calancha > Date: Sat, 30 Jul 2016 17:29:42 +0900 (JST) > > Fixed in master branch Thanks. Two minor comments: . When you close a bug, please reply to the last message related to that bug, so that the Subject line is meaningful (as opposed to the above). . Please try making the summary line of the commit log message be as specific as possible, within the limitations of 64 characters. The one you used here: Copy just non-empty strings to kill-ring is too general: it fails to mention Dired. I would suggest something like this: Avoid copying empty strings with Dired's 'w' command Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 31 04:37:04 2016 Received: (at 24103) by debbugs.gnu.org; 31 Jul 2016 08:37:04 +0000 Received: from localhost ([127.0.0.1]:51937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTmF5-0007av-Tk for submit@debbugs.gnu.org; Sun, 31 Jul 2016 04:37:04 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTmF5-0007aR-7z for 24103@debbugs.gnu.org; Sun, 31 Jul 2016 04:37:03 -0400 Received: by mail-pf0-f171.google.com with SMTP id p64so45545900pfb.1 for <24103@debbugs.gnu.org>; Sun, 31 Jul 2016 01:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=OvR2WLhSrDNHi4fd4AvUjPO4NtMbWwttUeTPOR/ATg0=; b=ZxLnD1SigKxSfeOQZUFQ5/+hPgIbKaamyXmC9lSq/+IoyZcZKxivslP8+5+uecKFYT qvl0+bJGdaPBhPQD98B9bhFshs2aaRViz5eLcd5DBVxqez0VCkSQQBjhEFKzhCqEchpf fwFrSL+gLPqGtUOuIsCJQCGEHDACtNc1lVFf35+QrI3dpC85Iq4i1IgWzJT7rW8rDBNC mWhe+Pm7/JPmXiIRHEltVFV16GEOYJjkLffKiI0AmkSN+eBhezUEbuVq2raeSQ77C+1A OaykdmOHfGeC7r1ariK2zNf3+m/UPwRLNoWqjZbE40krbF4zbWC7UgFWpxEbuzqmXkYT J2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=OvR2WLhSrDNHi4fd4AvUjPO4NtMbWwttUeTPOR/ATg0=; b=P3mRyR7uE7zEkuFNt1Vsaogd0Al4hEpcvYWiBEppEUSc0r7/cCpisS4P2wxkhBmsFL +QG04QYbLwJ2KgwNk6RKxGpeTIeXzul9ptSyi+XBCSFSGFdHM7vP4HhZvkDkeqRGSE2t fSnaphLEvmdqnbgbslodxo9TDCHj3I8uUysvk55DwolSF1fE291BrSwldiZqtIRcdzQw rgns8X/UPBIWLEp/T9MpzLKOpGnQIWkb6yWrNYBkqTH+SqB6AposRen+7CzsQDZr4+AE ZHoel/wpsyGyJ6JqTPhaMmGOFRwE2KlnFehUCz2/i7wbZ7LAc4qadFqr/HPYO3CdcYZH QPEg== X-Gm-Message-State: AEkoouvEl9Yjxo+js8zl/pArWOBpMYuulwqdvgHk10TFyTHO7Fa9HZXwMTgvcoUtRvhV2A== X-Received: by 10.98.80.220 with SMTP id g89mr84928349pfj.12.1469954217073; Sun, 31 Jul 2016 01:36:57 -0700 (PDT) Received: from calancha-pc ([210.160.37.174]) by smtp.gmail.com with ESMTPSA id w64sm36750069pfb.93.2016.07.31.01.36.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Jul 2016 01:36:56 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 31 Jul 2016 17:36:54 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#24103: (no subject) In-Reply-To: <83r3abpl4n.fsf@gnu.org> Message-ID: References: <83r3abpl4n.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, 30 Jul 2016, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Sat, 30 Jul 2016 17:29:42 +0900 (JST) >> >> Fixed in master branch > > Thanks. Two minor comments: > > . When you close a bug, please reply to the last message related to > that bug, so that the Subject line is meaningful (as opposed to the > above). > > . Please try making the summary line of the commit log message be as > specific as possible, within the limitations of 64 characters. The > one you used here: > > Copy just non-empty strings to kill-ring > > is too general: it fails to mention Dired. I would suggest > something like this: > > Avoid copying empty strings with Dired's 'w' command [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 SLIGHTLY_BAD_SUBJECT Subject contains something slightly spammy -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.192.171 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.192.171 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 24103 Cc: 24103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, 30 Jul 2016, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Sat, 30 Jul 2016 17:29:42 +0900 (JST) >> >> Fixed in master branch > > Thanks. Two minor comments: > > . When you close a bug, please reply to the last message related to > that bug, so that the Subject line is meaningful (as opposed to the > above). > > . Please try making the summary line of the commit log message be as > specific as possible, within the limitations of 64 characters. The > one you used here: > > Copy just non-empty strings to kill-ring > > is too general: it fails to mention Dired. I would suggest > something like this: > > Avoid copying empty strings with Dired's 'w' command [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.192.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.192.171 listed in wl.mailspike.net] 2.0 SLIGHTLY_BAD_SUBJECT Subject contains something slightly spammy -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid On Sat, 30 Jul 2016, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Sat, 30 Jul 2016 17:29:42 +0900 (JST) >> >> Fixed in master branch > > Thanks. Two minor comments: > > . When you close a bug, please reply to the last message related to > that bug, so that the Subject line is meaningful (as opposed to the > above). > > . Please try making the summary line of the commit log message be as > specific as possible, within the limitations of 64 characters. The > one you used here: > > Copy just non-empty strings to kill-ring > > is too general: it fails to mention Dired. I would suggest > something like this: > > Avoid copying empty strings with Dired's 'w' command Thanks for the tips Eli. I will follow then in future commits. Tino From unknown Mon Jun 16 23:47:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Aug 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator