GNU bug report logs - #24071
[PATCH] Refactor regex character class parsing in [:name:]

Previous Next

Package: emacs;

Reported by: Michal Nazarewicz <mina86 <at> mina86.com>

Date: Mon, 25 Jul 2016 22:55:02 UTC

Severity: wishlist

Tags: patch

Done: Michal Nazarewicz <mina86 <at> mina86.com>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 24071 <at> debbugs.gnu.org (full text, mbox):

From: Michal Nazarewicz <mina86 <at> mina86.com>
To: 24071 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: [PATCH 4/7] Don’t (require 'cl)
Date: Wed, 27 Jul 2016 18:50:44 +0200
* test/src/regex-test.el: Don’t (require 'cl).
(regex-tests-PCRE): s/loop/cl-loop/
---
 test/src/regex-tests.el | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/test/src/regex-tests.el b/test/src/regex-tests.el
index 1407441..97b9633 100644
--- a/test/src/regex-tests.el
+++ b/test/src/regex-tests.el
@@ -20,7 +20,6 @@
 ;;; Code:
 
 (require 'ert)
-(require 'cl)
 
 (ert-deftest regex-word-cc-fallback-test ()
   "Test that ‘[[:cc:]]*x’ matches ‘x’ (bug#24020).
@@ -516,9 +515,9 @@ regex-tests-PCRE
                  ('invalid-regexp 'compilation-failed))
 
                matches-observed
-               (loop for x from 0 to 20
-                     collect (and (not what-failed)
-                                  (or (match-string x string) "<unset>")))))
+               (cl-loop for x from 0 to 20
+                        collect (and (not what-failed)
+                                     (or (match-string x string) "<unset>")))))
        nil)
 
       ;; verification line: failed match
-- 
2.8.0.rc3.226.g39d4020





This bug report was last modified 8 years and 350 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.