GNU bug report logs - #24046
[PATCH] vc-git: prevent execution of git stash in error cases

Previous Next

Full log

Message #11 received at 24046 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: npostavs <at> users.sourceforge.net
Cc: 24046 <at> debbugs.gnu.org, Alexander Kuleshov <kuleshovmail <at> gmail.com>
Subject: Re: bug#24046: [PATCH] vc-git: prevent execution of git stash in
 error cases
Date: Tue, 25 Jun 2019 14:03:03 +0200

npostavs <at> users.sourceforge.net writes:

> Alexander Kuleshov <kuleshovmail <at> gmail.com> writes:
>
>> Here is simple patch which adds two additional checks to the vc-git-stash-show
>> function to check that correct stash name is passed and actually repo
>> has stashes.
>
> I'm not sure this is a good idea, we just end up duplicating checks that
> 'git stash' is going to perform anyway...

I agree, and even if we did want to add these checks, they should be
done in all the stash-related commands...

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.