From unknown Sat Aug 16 19:16:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases Resent-From: Alexander Kuleshov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2016 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 24046@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146910521123281 (code B ref -1); Thu, 21 Jul 2016 12:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jul 2016 12:46:51 +0000 Received: from localhost ([127.0.0.1]:59364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQDNL-00063R-4M for submit@debbugs.gnu.org; Thu, 21 Jul 2016 08:46:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQDNJ-00063E-WA for submit@debbugs.gnu.org; Thu, 21 Jul 2016 08:46:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQDND-0005Kw-QH for submit@debbugs.gnu.org; Thu, 21 Jul 2016 08:46:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDND-0005Kh-Mq for submit@debbugs.gnu.org; Thu, 21 Jul 2016 08:46:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDNB-0004Av-Bi for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQDNA-0005KJ-I9 for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:46:41 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:36426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDN9-0005K6-ON for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:46:40 -0400 Received: by mail-lf0-x22d.google.com with SMTP id g62so60852014lfe.3 for ; Thu, 21 Jul 2016 05:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=ePn5I7zYrrkaIoivwhEew/T8zCJ6NFzO9JrmDR+wB9o=; b=zQQwV74G0l/ytNiK5UAoj4X+YTxNKMQ8T2/tIHmN2oGa+UR7EgNPKJhkXcBJ599Mkw pgs19QU3MmhW3gt4dWmaFh0F5augqCx33B6N8O+InaNUwDr763hwFgHb5X+5lY4YNhcu n4KnB54HbtyFdv2DyaEb44KouXwEKIEqMWqKgMh+ctkrOToOyZRCwe9+gm573DeEhDDX FnggHwJd3MyuleD0IkJIqMdRlDMXashwRbmgru7mkHittA6m+LpX/PhvgH4TLvwG5CKb 2GQMh8yi0v7pCZ6+wkl6Qp/bS1QgTs3xeZhWUB1PTEUMPhT8fbF6mWRZoAQ8fDA4Dwxs pFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ePn5I7zYrrkaIoivwhEew/T8zCJ6NFzO9JrmDR+wB9o=; b=iZKR4rSsKb2jL2UHVQuVP3aOZOScsgjO5aLbPns8blmQXdi7zfWc0RdUFHwxhz1Dt8 Y77BtIZrHbs7/e/G+/zcBcul5IGSuS0gWESrbDsyQUXoOzSAj3cDN+Y7D9T5DVAIfjGp jvCn1xROpUgLyg2t86LCexSS/GZBO85Roa0fc7JKiiHWl0ni0IW8PPs8t5jfnwmTVssq 0D2zwxxMYFxcU+Tiff1U0w6uTYVHl6VkgiKtFJxV8mMsoXLQEdNnnaOD2VcJ0HbsNYr7 Fh078cDw52a4wwK+8JrzGF+bR9ong4vsHK4JMGdjiOAV26Nv9ulISDxuoAMkz5BKvuhd m7pQ== X-Gm-Message-State: ALyK8tI1VVi055VQqM9/19mPEORAFrjmLtdF6joh37SH0Us3GRWW5iLkzAJOs7wKlnjp+htCoys7oV8jBAPTzA== X-Received: by 10.25.152.135 with SMTP id a129mr21148077lfe.226.1469105198247; Thu, 21 Jul 2016 05:46:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.145.17 with HTTP; Thu, 21 Jul 2016 05:46:18 -0700 (PDT) From: Alexander Kuleshov Date: Thu, 21 Jul 2016 18:46:18 +0600 Message-ID: Content-Type: multipart/mixed; boundary=001a114035e27ac7b9053824b590 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a114035e27ac7b9053824b590 Content-Type: text/plain; charset=UTF-8 Here is simple patch which adds two additional checks to the vc-git-stash-show function to check that correct stash name is passed and actually repo has stashes. Thank you --001a114035e27ac7b9053824b590 Content-Type: text/x-patch; charset=US-ASCII; name="0001-vc-git-prevent-execution-of-git-stash-in-error-cases.patch" Content-Disposition: attachment; filename="0001-vc-git-prevent-execution-of-git-stash-in-error-cases.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqwbafu20 RnJvbSBmOWZjNjQ1NjBkY2Y4OTI4MjZlZGRjYTUzNWMwYzg2OWQyOTIyMDQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS3VsZXNob3YgPGt1bGVzaG92bWFpbEBnbWFp bC5jb20+CkRhdGU6IFRodSwgMjEgSnVsIDIwMTYgMTg6NDI6NDggKzA2MDAKU3ViamVjdDogW1BB VENIXSB2Yy1naXQ6IHByZXZlbnQgZXhlY3V0aW9uIG9mIGdpdCBzdGFzaCBpbiBlcnJvciBjYXNl cwoKKiBsaXNwL3ZjL3ZjLWdpdC5lbCAodmMtZ2l0LXN0YXNoLXNob3cpOiBwcmV2ZW50IGV4ZWN1 dGlvbiBpZiBzdGFzaApuYW1lIGlzIGVtcHR5IG9yIGEgcmVwbyBoYXNuJ3Qgc3Rhc2hlcy4KLS0t CiBsaXNwL3ZjL3ZjLWdpdC5lbCB8IDE2ICsrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdmMv dmMtZ2l0LmVsIGIvbGlzcC92Yy92Yy1naXQuZWwKaW5kZXggZTZmZTAxOS4uOTQwNzM4ZCAxMDA2 NDQKLS0tIGEvbGlzcC92Yy92Yy1naXQuZWwKKysrIGIvbGlzcC92Yy92Yy1naXQuZWwKQEAgLTEz NDgsMTIgKzEzNDgsMTYgQEAgdmMtZ2l0LXN0YXNoCiAoZGVmdW4gdmMtZ2l0LXN0YXNoLXNob3cg KG5hbWUpCiAgICJTaG93IHRoZSBjb250ZW50cyBvZiBzdGFzaCBOQU1FLiIKICAgKGludGVyYWN0 aXZlICJzU3Rhc2ggbmFtZTogIikKLSAgKHZjLXNldHVwLWJ1ZmZlciAiKnZjLWdpdC1zdGFzaCoi KQotICAodmMtZ2l0LWNvbW1hbmQgIip2Yy1naXQtc3Rhc2gqIiAnYXN5bmMgbmlsICJzdGFzaCIg InNob3ciICItcCIgbmFtZSkKLSAgKHNldC1idWZmZXIgIip2Yy1naXQtc3Rhc2gqIikKLSAgKGRp ZmYtbW9kZSkKLSAgKHNldHEgYnVmZmVyLXJlYWQtb25seSB0KQotICAocG9wLXRvLWJ1ZmZlciAo Y3VycmVudC1idWZmZXIpKSkKKyAgKGlmIChzdHJpbmc9IG5hbWUgIiIpCisgICAgICAoZXJyb3Ig InN0YXNoIG5hbWUgY2FuJ3QgYmUgZW1wdHkgc3RyaW5nLiIpKQorICAoaWYgKGVxICh2Yy1naXQt c3Rhc2gtbGlzdCkgbmlsKQorICAgICAgKGVycm9yICJUaGVyZSBhcmUgbm8gc3Rhc2hlcy4iKQor ICAgICh2Yy1zZXR1cC1idWZmZXIgIip2Yy1naXQtc3Rhc2gqIikKKyAgICAodmMtZ2l0LWNvbW1h bmQgIip2Yy1naXQtc3Rhc2gqIiAnYXN5bmMgbmlsICJzdGFzaCIgInNob3ciICItcCIgbmFtZSkK KyAgICAoc2V0LWJ1ZmZlciAiKnZjLWdpdC1zdGFzaCoiKQorICAgIChkaWZmLW1vZGUpCisgICAg KHNldHEgYnVmZmVyLXJlYWQtb25seSB0KQorICAgIChwb3AtdG8tYnVmZmVyIChjdXJyZW50LWJ1 ZmZlcikpKSkKIAogKGRlZnVuIHZjLWdpdC1zdGFzaC1hcHBseSAobmFtZSkKICAgIkFwcGx5IHN0 YXNoIE5BTUUuIgotLSAKMi44LjAucmMzLjEzNTMuZ2VhOWJkYzAKCg== --001a114035e27ac7b9053824b590-- From unknown Sat Aug 16 19:16:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2017 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alexander Kuleshov Cc: 24046@debbugs.gnu.org Received: via spool by 24046-submit@debbugs.gnu.org id=B24046.14965451169345 (code B ref 24046); Sun, 04 Jun 2017 02:59:02 +0000 Received: (at 24046) by debbugs.gnu.org; 4 Jun 2017 02:58:36 +0000 Received: from localhost ([127.0.0.1]:54452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHLkS-0002Qf-JE for submit@debbugs.gnu.org; Sat, 03 Jun 2017 22:58:36 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:38678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHLkR-0002QS-8n for 24046@debbugs.gnu.org; Sat, 03 Jun 2017 22:58:35 -0400 Received: by mail-it0-f43.google.com with SMTP id r63so49991950itc.1 for <24046@debbugs.gnu.org>; Sat, 03 Jun 2017 19:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=C61kQYoe5mqkAM+5/HFumu9s0MXaVqQhgCDcW1ZF9XA=; b=H9RtkfHAT+5kIvUQ+V2qWA2IDaRBHF1seTjW+ow37xVB9bv0u6o8ZmqS0FGAJBfZ1U q8esPz0+hdMsUKIpFYND+qLtcZr5MhqJCP1RQomYrRsm7AWHJjxaNsRuxuwPP+d+5lKb DVOYGr+B7Dh3xcwLkgYnPfPtnzc1YOLLrqnfQnQ4WS7vdf8v5OC/aky+jkHl2ZtdubyW 1k/CnvGhS03Js9sAaxAama/kVL8UvJBM07+b4DySik4AziQHRHMx5XjtgAHv5LFFvQoh D8BcqlprE3SPNkDJraYoafyia8pt+ng1KHYhuF7/U7xnip3Hq06TJvBllCyrX22RH29V pXiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=C61kQYoe5mqkAM+5/HFumu9s0MXaVqQhgCDcW1ZF9XA=; b=W9bdt9LRpWEG/NMCtzVz72L71XQSb+JVotcDHOEf1eRATR8ydhmyHd/fOFgXPz+INy VV5S/6GINFFtJmAUa3U7vP3zOQsl9ZIN3jANykFEqbM1ZcoRBbn5clWHBW+GlguSBMKH 1j/VHi3i+2L57qdr1eItLlxd52FHBEX0N4cnnuAP0t5sgqg9GHsCbF+cQr9lEDknxv+F 1a8TCr+fnEoeIoLa1BxE5y7aPlnA26LPXg71xjA8fbmyUOOm1Qh/G5zoLdI4GTVJCPLp FDFzhWUVidLKBzabZddO5MBk8jqgru5eHh3QmdiIkh/4CTMtEWlFHzDUQ/OH9nrVqVVx HU4Q== X-Gm-Message-State: AODbwcCldSSxpz3mn/704dCqhP5TLXH3NbzuH4shx1ICnRxnTKN7xqDx 3OvtivPBvaEzufkx X-Received: by 10.36.77.211 with SMTP id l202mr6794565itb.74.1496545109628; Sat, 03 Jun 2017 19:58:29 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id u140sm5103508ita.0.2017.06.03.19.58.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Jun 2017 19:58:29 -0700 (PDT) From: npostavs@users.sourceforge.net References: Date: Sat, 03 Jun 2017 23:00:07 -0400 In-Reply-To: (Alexander Kuleshov's message of "Thu, 21 Jul 2016 18:46:18 +0600") Message-ID: <87vaoczcco.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Alexander Kuleshov writes: > Here is simple patch which adds two additional checks to the vc-git-stash-show > function to check that correct stash name is passed and actually repo > has stashes. I'm not sure this is a good idea, we just end up duplicating checks that 'git stash' is going to perform anyway... From unknown Sat Aug 16 19:16:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 24046@debbugs.gnu.org, Alexander Kuleshov Received: via spool by 24046-submit@debbugs.gnu.org id=B24046.15614641909288 (code B ref 24046); Tue, 25 Jun 2019 12:04:01 +0000 Received: (at 24046) by debbugs.gnu.org; 25 Jun 2019 12:03:10 +0000 Received: from localhost ([127.0.0.1]:58815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkAH-0002Pj-Jy for submit@debbugs.gnu.org; Tue, 25 Jun 2019 08:03:10 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkAF-0002PX-Qe for 24046@debbugs.gnu.org; Tue, 25 Jun 2019 08:03:08 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfkAC-0007jo-2V; Tue, 25 Jun 2019 14:03:06 +0200 From: Lars Ingebrigtsen References: <87vaoczcco.fsf@users.sourceforge.net> Date: Tue, 25 Jun 2019 14:03:03 +0200 In-Reply-To: <87vaoczcco.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 03 Jun 2017 23:00:07 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: npostavs@users.sourceforge.net writes: > Alexander Kuleshov writes: > >> Here is simple patch which adds two additional checks to the vc-git-stash-show >> function to check that correct stash name is passed and act [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) npostavs@users.sourceforge.net writes: > Alexander Kuleshov writes: > >> Here is simple patch which adds two additional checks to the vc-git-stash-show >> function to check that correct stash name is passed and actually repo >> has stashes. > > I'm not sure this is a good idea, we just end up duplicating checks that > 'git stash' is going to perform anyway... I agree, and even if we did want to add these checks, they should be done in all the stash-related commands... So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 08:03:14 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 12:03:14 +0000 Received: from localhost ([127.0.0.1]:58818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkAM-0002Q1-39 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 08:03:14 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkAK-0002Pt-P0 for control@debbugs.gnu.org; Tue, 25 Jun 2019 08:03:13 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfkAI-0007jw-71 for control@debbugs.gnu.org; Tue, 25 Jun 2019 14:03:12 +0200 Date: Tue, 25 Jun 2019 14:03:10 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24046 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 24046 wontfix close 24046 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24046 wontfix close 24046 quit