From unknown Thu Aug 21 23:00:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24034 <24034@debbugs.gnu.org> To: bug#24034 <24034@debbugs.gnu.org> Subject: Status: 25.0.95; shr-fill-line multiplies the number of images Reply-To: bug#24034 <24034@debbugs.gnu.org> Date: Fri, 22 Aug 2025 06:00:37 +0000 retitle 24034 25.0.95; shr-fill-line multiplies the number of images reassign 24034 emacs submitter 24034 Katsumi Yamaoka severity 24034 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 20 06:29:05 2016 Received: (at submit) by debbugs.gnu.org; 20 Jul 2016 10:29:05 +0000 Received: from localhost ([127.0.0.1]:57932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPokS-0002Kq-PW for submit@debbugs.gnu.org; Wed, 20 Jul 2016 06:29:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPokR-0002KK-5D for submit@debbugs.gnu.org; Wed, 20 Jul 2016 06:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPokL-00037B-2Z for submit@debbugs.gnu.org; Wed, 20 Jul 2016 06:28:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50, T_TVD_MIME_NO_HEADERS autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPokK-000370-Vg for submit@debbugs.gnu.org; Wed, 20 Jul 2016 06:28:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPokH-0003md-M1 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 06:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPokD-00035z-G7 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 06:28:52 -0400 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:44483 helo=hampton.hostforweb.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPokD-0002r9-BJ for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 06:28:49 -0400 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60027 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1bPojS-002CfV-TE; Wed, 20 Jul 2016 05:28:04 -0500 Date: Wed, 20 Jul 2016 19:28:11 +0900 Message-ID: From: Katsumi Yamaoka To: bug-gnu-emacs@gnu.org Subject: 25.0.95; shr-fill-line multiplies the number of images Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) Cancel-Lock: sha1:HJ5lZ7zm+Ezz5ezswwZapySLHUc= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Hi, If `gnus-inhibit-images' is t, shr shows the alt text of an image in the article buffer. If the alt text is long, `shr-fill-line' devides it into two or more lines, and each line will get to have a link to the image individually. In that case, those number of images will be displayed when a user invokes the WDW command (gnus-article-show-images) even if there should be only a single image. The cause of this problem is that `shr-fill-line' divides not only the alt text but also the `image-url' text property. So, I'd like to install the following change. This is the right fix, isn't it? Regards, --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- shr.el~ 2016-03-21 22:00:40.983451400 +0000 +++ shr.el 2016-07-20 10:26:30.487350400 +0000 @@ -636,13 +636,12 @@ ;; Success; continue. (when (= (preceding-char) ?\s) (delete-char -1)) - (let ((face (get-text-property (point) 'face)) + (let ((props (text-properties-at (point))) (background-start (point))) (insert "\n") (shr-indent) - (when face - (put-text-property background-start (point) 'face - `,(shr-face-background face)))) + (when props + (add-text-properties background-start (point) props))) (setq start (point)) (shr-vertical-motion shr-internal-width) (when (looking-at " $") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 20 06:32:12 2016 Received: (at 24034) by debbugs.gnu.org; 20 Jul 2016 10:32:12 +0000 Received: from localhost ([127.0.0.1]:57937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPonU-0002Qo-9W for submit@debbugs.gnu.org; Wed, 20 Jul 2016 06:32:12 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:49996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPonS-0002Qd-KF for 24034@debbugs.gnu.org; Wed, 20 Jul 2016 06:32:11 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bPonN-0002Id-UO; Wed, 20 Jul 2016 12:32:08 +0200 From: Lars Ingebrigtsen To: Katsumi Yamaoka Subject: Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images References: Face: Date: Wed, 20 Jul 2016 12:31:56 +0200 In-Reply-To: (Katsumi Yamaoka's message of "Wed, 20 Jul 2016 19:28:11 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24034 Cc: 24034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Katsumi Yamaoka writes: > The cause of this problem is that `shr-fill-line' divides not > only the alt text but also the `image-url' text property. So, > I'd like to install the following change. This is the right > fix, isn't it? Yes, I think so. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 20 18:57:11 2016 Received: (at 24034-done) by debbugs.gnu.org; 20 Jul 2016 22:57:11 +0000 Received: from localhost ([127.0.0.1]:59081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ0QQ-0001eO-PK for submit@debbugs.gnu.org; Wed, 20 Jul 2016 18:57:10 -0400 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:54966 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ0QP-0001eC-T7 for 24034-done@debbugs.gnu.org; Wed, 20 Jul 2016 18:57:10 -0400 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:63165 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1bQ0QH-001Nmp-Ey; Wed, 20 Jul 2016 17:57:02 -0500 Date: Thu, 21 Jul 2016 07:57:12 +0900 Message-ID: From: Katsumi Yamaoka To: larsi@gnus.org Subject: Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) Cancel-Lock: sha1:KUT5yOF2RTRRocFvsbM7M5Ska8Y= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24034-done Cc: 24034-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, 20 Jul 2016 12:31:56 +0200, Lars Ingebrigtsen wrote: > Katsumi Yamaoka writes: >> The cause of this problem is that `shr-fill-line' divides not >> only the alt text but also the `image-url' text property. So, >> I'd like to install the following change. This is the right >> fix, isn't it? > Yes, I think so. Done. Thanks. From unknown Thu Aug 21 23:00:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 18 Aug 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator