GNU bug report logs - #24030
25.0.95; mouse-drag-region regression

Previous Next

Full log

Message #29 received at 24030 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24030 <at> debbugs.gnu.org, agrambot <at> gmail.com
Subject: Re: bug#24030: 25.0.95; mouse-drag-region regression
Date: Sun, 24 Jul 2016 11:02:38 -0400

> --- lisp/mouse.el~	2016-07-20 09:52:16.559875700 +0300
> +++ lisp/mouse.el	2016-07-24 17:14:34.469052800 +0300
> @@ -815,14 +815,16 @@ The region will be defined with mark and
>    (setq mouse-selection-click-count-buffer (current-buffer))
>    (deactivate-mark)
>    (let* ((scroll-margin 0) ; Avoid margin scrolling (Bug#9541).
> +	 (start-posn (event-start start-event))
> +	 (start-point (posn-point start-posn))
> +	 (start-window (posn-window start-posn))
> +	 (_ (with-selected-window start-window
> +	      (setq deactivate-mark nil)))
>           ;; We've recorded what we needed from the current buffer and
>           ;; window, now let's jump to the place of the event, where things
>           ;; are happening.
>           (_ (mouse-set-point start-event))
>           (echo-keystrokes 0)
> -	 (start-posn (event-start start-event))
> -	 (start-point (posn-point start-posn))
> -	 (start-window (posn-window start-posn))
>  	 (bounds (window-edges start-window))
>  	 (make-cursor-line-fully-visible nil)
>  	 (top (nth 1 bounds))

Looks fine to me, tho I don't think we should use with-selected-window
here, but only with-current-buffer.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.