GNU bug report logs - #24015
[PATCH] sort: make -h work with -k and blank used as thousands separator

Previous Next

Full log

View this message in rfc822 format

From: Kamil Dudka <kdudka <at> redhat.com>
To: Pádraig Brady <P <at> draigbrady.com>
Cc: 24015 <at> debbugs.gnu.org
Subject: bug#24015: [PATCH v2 1/3] sort: deduplicate code for traversing numbers
Date: Tue, 19 Jul 2016 08:09:38 +0200

On Monday, July 18, 2016 22:28:56 Pádraig Brady wrote:
> On 18/07/16 22:07, Pádraig Brady wrote:
> > Excellent. I'll push all three patches.
> > 
> > I'll adjust the first summary like s/sort:/maint: sort.c:/
> > since there is no functionality change
> > 
> > I'll also add the check for the sv_SE locale in the test.
> 
> Oops you'd done that already.
> 
> One change I did make to the test was to change
> the exp{1,3} bashism to exp1 exp3, as the tests need
> to run under any POSIX compliant shell.
> I tested that with:
> 
>   make SHELL=/bin/dash TESTS=tests/misc/sort-h-thousands-sep.sh SUBDIRS=.
> check

Perfect.  Thanks for the improvements!

Kamil

> cheers,
> Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.