GNU bug report logs - #23999
25.0.95; Emacs hangs in rectangle-mark-mode with numeric prefix argument to `C-f'

Previous Next

Package: emacs;

Reported by: nljlistbox2 <at> gmail.com (N. Jackson)

Date: Fri, 15 Jul 2016 22:27:01 UTC

Severity: normal

Found in version 25.0.95

Done: charles <at> aurox.ch (Charles A. Roelli)

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: jwiegley <at> gmail.com, eliz <at> gnu.org, 23999 <at> debbugs.gnu.org
Subject: bug#23999: 25.0.95; Emacs hangs in rectangle-mark-mode with numeric prefix argument to `C-f'
Date: Fri, 22 Jul 2016 10:17:50 -0400

>> @@ -644,7 +644,7 @@ rectangle--*-char
>>                 (curcol (current-column))
>>                 (nextcol
>>                  (condition-case nil
>> -                    (save-excursion
>> +                    (progn
>>                        (funcall cmd 1)
>>                        (cond
>>                         ((> bol (point)) (- curcol 1))

Hmm... this function is quite messy.  Using `progn' here make it even
more messy (e.g. what happens when you jump over some TAB among the
N movements).

My impression is that the whole `save-excursion' thingy should be moved
out of the while loop.  And actually there probably shouldn't be any
such loop at all: we should just do +n or -n directly.


        Stefan
This bug report was last modified 7 years and 155 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.