GNU bug report logs - #23994
25.1.50; cl-defmethod with qualifier indented incorrectly

Previous Next

Package: emacs;

Reported by: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Date: Fri, 15 Jul 2016 15:56:01 UTC

Severity: minor

Found in version 25.1.50

Fixed in version 26.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23994: closed (25.1.50; cl-defmethod with qualifier indented
 incorrectly)
Date: Wed, 26 Jul 2017 15:55:02 +0000

[Message part 1 (text/plain, inline)]
Your message dated Wed, 26 Jul 2017 18:53:54 +0300
with message-id <c93f752e-edb3-2f18-e5b3-699665812452 <at> yandex.ru>
and subject line Re: bug#23994: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) (Was: 25.1.50; cl-defmethod with qualifier indented incorrectly)
has caused the debbugs.gnu.org bug report #23994,
regarding 25.1.50; cl-defmethod with qualifier indented incorrectly
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23994: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23994
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; cl-defmethod with qualifier indented incorrectly
Date: Fri, 15 Jul 2016 08:55:03 -0700

cl-defmethod forms with a qualifier are indented incorrectly, ie:

(cl-defmethod base ((str string))
  "This one's okay"
  (message str))

(cl-defmethod base :extra "ext" ((str string))
	      "This one isn't"
	      (message "extra method")
	      (cl-call-next-method))

The incorrect indentation happens both for "single tag" qualifiers (ie
:before), and the tag-plus-string :extra qualifier.



[Message part 3 (message/rfc822, inline)]
From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Grégoire Jadi <daimrod <at> omecha.info>,
 23994-done <at> debbugs.gnu.org
Subject: Re: bug#23994: [PATCH] Fix cl-defmethod indent with qualifier
 (Bug##23994) (Was: 25.1.50; cl-defmethod with qualifier indented incorrectly)
Date: Wed, 26 Jul 2017 18:53:54 +0300

Version: 26.1

On 7/25/17 11:00 AM, Grégoire Jadi wrote:

> I've been bitten by this bug as well on 25.2.1.
> I've attached a patch to fix it.

Pushed, thanks!
This bug report was last modified 7 years and 361 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.