From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 11:55:27 2016 Received: (at submit) by debbugs.gnu.org; 15 Jul 2016 15:55:27 +0000 Received: from localhost ([127.0.0.1]:53162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO5SZ-0007lX-Mw for submit@debbugs.gnu.org; Fri, 15 Jul 2016 11:55:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO5SY-0007lK-2R for submit@debbugs.gnu.org; Fri, 15 Jul 2016 11:55:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO5SS-0003tp-08 for submit@debbugs.gnu.org; Fri, 15 Jul 2016 11:55:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO5SR-0003tj-TU for submit@debbugs.gnu.org; Fri, 15 Jul 2016 11:55:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO5SP-0004YD-Q7 for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 11:55:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO5SL-0003sD-IW for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 11:55:16 -0400 Received: from mail.ericabrahamsen.net ([50.56.99.223]:60837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO5SL-0003ml-Cn for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 11:55:13 -0400 Received: from localhost (c-67-170-105-118.hsd1.wa.comcast.net [67.170.105.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 288B92B82C5 for ; Fri, 15 Jul 2016 15:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1468598117; bh=StUg4UJisoDu3+VMli0UNtJD61gTeQnNyy0WAfU5Ybo=; h=From:To:Subject:Date:From; b=rItY4d2VGe7w4Bss2jCs/pTyKmoy12G7REgwXu1jQjnVPjLv3tkq+jNCrLEu7GA0/ li3LXyS7D8NnqilKRFtjT4OrZn7ZDMVDbW1TOfNigBBBluB4M7Fr6YR5qE6pf5fKl4 f9WlubzVQD79EbMrsFUojactY0j+ZUg+tNGgMJKM= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 25.1.50; cl-defmethod with qualifier indented incorrectly User-Agent: Notmuch/0.22 (https://notmuchmail.org) Emacs/25.1.50.33 (i686-pc-linux-gnu) Date: Fri, 15 Jul 2016 08:55:03 -0700 Message-ID: <87vb06j3qg.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) cl-defmethod forms with a qualifier are indented incorrectly, ie: (cl-defmethod base ((str string)) "This one's okay" (message str)) (cl-defmethod base :extra "ext" ((str string)) "This one isn't" (message "extra method") (cl-call-next-method)) The incorrect indentation happens both for "single tag" qualifiers (ie :before), and the tag-plus-string :extra qualifier. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 25 11:07:49 2017 Received: (at 23994) by debbugs.gnu.org; 25 Jul 2017 15:07:49 +0000 Received: from localhost ([127.0.0.1]:56056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da1R6-0006x5-Pi for submit@debbugs.gnu.org; Tue, 25 Jul 2017 11:07:49 -0400 Received: from a.omecha.info ([89.234.176.136]:37218 helo=omecha.info) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZulo-0001qj-A7 for 23994@debbugs.gnu.org; Tue, 25 Jul 2017 04:00:44 -0400 Received: from puffy.omecha.info (unknown [192.168.99.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by omecha.info (Postfix) with ESMTPSA id 2A46A1F8 for <23994@debbugs.gnu.org>; Tue, 25 Jul 2017 10:00:38 +0200 (CEST) From: daimrod@omecha.info (=?utf-8?Q?Gr=C3=A9goire?= Jadi) To: 23994@debbugs.gnu.org Subject: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) (Was: 25.1.50; cl-defmethod with qualifier indented incorrectly) Date: Tue, 25 Jul 2017 10:00:37 +0200 Message-ID: <87inihndy2.fsf@omecha.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23994 X-Mailman-Approved-At: Tue, 25 Jul 2017 11:07:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hello, I've been bitten by this bug as well on 25.2.1. I've attached a patch to fix it. Best, PS: I've FSF copyright assignment number #793656 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-cl-defmethod-indent-with-qualifier.patch >From 7aed0320d9471138c9ad6652c37fe05c563f9af8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Tue, 25 Jul 2017 09:46:32 +0200 Subject: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) lisp/emacs-lisp/cl-generic.el(cl-defmethod): Indent `cl-defmethod' like a def construct. --- lisp/emacs-lisp/cl-generic.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 6a4ee47ac2..1d29082c62 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -409,7 +409,7 @@ cl-defmethod \(and can be extended) by the various methods of `cl-generic-generalizers'. \(fn NAME [QUALIFIER] ARGS &rest [DOCSTRING] BODY)" - (declare (doc-string 3) (indent 2) + (declare (doc-string 3) (indent defun) (debug (&define ; this means we are defining something [&or name ("setf" name :name setf)] -- 2.13.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 25 11:07:49 2017 Received: (at 23994) by debbugs.gnu.org; 25 Jul 2017 15:07:49 +0000 Received: from localhost ([127.0.0.1]:56058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da1R7-0006x7-AZ for submit@debbugs.gnu.org; Tue, 25 Jul 2017 11:07:49 -0400 Received: from a.omecha.info ([89.234.176.136]:37220 helo=omecha.info) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZunQ-0001tR-CU for 23994@debbugs.gnu.org; Tue, 25 Jul 2017 04:02:24 -0400 Received: from puffy.omecha.info (unknown [192.168.99.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by omecha.info (Postfix) with ESMTPSA id CB7BD1F8 for <23994@debbugs.gnu.org>; Tue, 25 Jul 2017 10:02:18 +0200 (CEST) From: daimrod@omecha.info (=?utf-8?Q?Gr=C3=A9goire?= Jadi) To: 23994@debbugs.gnu.org Subject: Re: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) References: <87inihndy2.fsf@omecha.info> Date: Tue, 25 Jul 2017 10:02:18 +0200 In-Reply-To: <87inihndy2.fsf@omecha.info> (=?utf-8?Q?=22Gr=C3=A9goire?= Jadi"'s message of "Tue, 25 Jul 2017 10:00:37 +0200") Message-ID: <87bmo9ndv9.fsf@omecha.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23994 X-Mailman-Approved-At: Tue, 25 Jul 2017 11:07:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I forgot to mention that #23994 is a duplicate of #26067. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 11:54:05 2017 Received: (at 23994-done) by debbugs.gnu.org; 26 Jul 2017 15:54:05 +0000 Received: from localhost ([127.0.0.1]:57555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daOdR-00021g-KS for submit@debbugs.gnu.org; Wed, 26 Jul 2017 11:54:05 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daOdQ-00021D-Mt for 23994-done@debbugs.gnu.org; Wed, 26 Jul 2017 11:54:05 -0400 Received: by mail-wm0-f42.google.com with SMTP id c184so82638806wmd.0 for <23994-done@debbugs.gnu.org>; Wed, 26 Jul 2017 08:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f+o7xYReiGPkEkEu151uaDaZ6ZXw4DkDQMk3Qiq46qM=; b=R3gf8erL7UBH3OjLFy5vk0fu2p/kUbz6KvBa8XAbOSHe1OKE6h+N4FhNSKQ/l+xKzx IHF8QDqS4sZWDGGwmSaBVIRDYaCqzT7oqPGwFP0bq3mwN66M/jcNaMLGnKQWIeovNvpo jeFEV51c8KVs6vpQ0OZBWqJvBG9FQdROy3H7dE0uCHxtbyyqAdK7XqOmRgUIkJIMvNzX nDvSP5DFFfOBqY0BL/3K7fSLTpcx8DxOvAfPNrjtoCjJqHLj6x+o7U2I5MvbtWH8P0Ba bz1JCUnywldpxp4MO01iraszqS4o77jB7WvfXrP6u1YSdMTToCZ382M/pik7RPaZHeO8 YWiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f+o7xYReiGPkEkEu151uaDaZ6ZXw4DkDQMk3Qiq46qM=; b=P0G9CC04sxnK2Qev+Qwitg/bzJqriHekShD4u097AWkpZ7QBjZcWOKfIkVtDXSvcPA l/ZeTyfBF9o4JVb2CtA6NtQF/DQn88mYKfnHVY09Ncol01WQ8HGdTTe33ryNHP9DYkru hWKTSh57e03YMPZMazeFCuRaV1kcGR4scvEQ4TIwrL0QG+WZt58mQnSb7g2QOGRtWiYm gJY88pnuESMtrqDZ13d2LRTemyiEdjj5U5LdQQVMxpSp9QkRRQr/RVxMxF1yDhqN1bHT only1Nk4Z7N9K+kv9L9bXZbGZj1fWUbOdz7JFrxKlSSbV0vopJl/t0sf8kwNg4n9d3kF 8CGQ== X-Gm-Message-State: AIVw113Sh44MAUu/2bEvo/rDaI9RFf9edZrH2lX0ISwfc92W5tD0558i WhfOeOHECROux0WY9xQ= X-Received: by 10.80.151.22 with SMTP id c22mr1223273edb.30.1501084438697; Wed, 26 Jul 2017 08:53:58 -0700 (PDT) Received: from [192.168.0.133] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id q8sm2249867edc.11.2017.07.26.08.53.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 08:53:57 -0700 (PDT) Subject: Re: bug#23994: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) (Was: 25.1.50; cl-defmethod with qualifier indented incorrectly) To: =?UTF-8?Q?Gr=c3=a9goire_Jadi?= , 23994-done@debbugs.gnu.org References: <87vb06j3qg.fsf@ericabrahamsen.net> <87inihndy2.fsf@omecha.info> From: Dmitry Gutov Message-ID: Date: Wed, 26 Jul 2017 18:53:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Thunderbird/55.0 MIME-Version: 1.0 In-Reply-To: <87inihndy2.fsf@omecha.info> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 23994-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Version: 26.1 On 7/25/17 11:00 AM, Grégoire Jadi wrote: > I've been bitten by this bug as well on 25.2.1. > I've attached a patch to fix it. Pushed, thanks! From unknown Mon Aug 18 22:12:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator