GNU bug report logs - #23980
25.0.95; Events put in `unread-command-events' can be wrongly handled

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chris Feng <chris.w.feng <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23980: closed (25.0.95; Events put in `unread-command-events'
 can be wrongly handled)
Date: Sun, 19 Nov 2017 09:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 19 Nov 2017 17:39:28 +0800
with message-id <CAP4=87EAStWsyCASr9jReQPCByALbEMt87NNDr+J92B8VZ4-=g <at> mail.gmail.com>
and subject line Re: bug#23980: 25.0.95; Events put in `unread-command-events' can be wrongly handled
has caused the debbugs.gnu.org bug report #23980,
regarding 25.0.95; Events put in `unread-command-events' can be wrongly handled
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23980: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23980
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chris Feng <chris.w.feng <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.95; Events put in `unread-command-events' can be wrongly handled
Date: Thu, 14 Jul 2016 22:03:34 +0800

I encountered a bug in the command loop that when I put an event of the
form (t . EVENT) into `unread-command-events', there is a chance the
event won't get recognized with the message "<t> is undefined".
I did a bit research and found that in keyboard.c `read_char' calls
`read_decoded_event_from_main_queue' (which in turn calls
`read_event_from_main_queue' and `kbd_buffer_get_event') but does not
check if the returned event is from `Vunread_command_events'.
The problem in `read_char' can be demonstrated by the following form:

  (progn
    (run-with-timer 1 nil (lambda () (push '(t . 1) unread-command-events)))
    (read-event nil nil 2))

    => '(t . 1)

There is actually another related issue, that for an event returned by
`read_decoded_event_from_main_queue' other than the form (t . EVENT), we
can't tell whether it's from `Vunread_command_events' or not.
If it is, then we should not put it into `this_command_keys'.

Any ideas on how to fix these?

[Message part 3 (message/rfc822, inline)]

From: Chris Feng <chris.w.feng <at> gmail.com>
To: 23980-done <at> debbugs.gnu.org
Subject: Re: bug#23980: 25.0.95; Events put in `unread-command-events' can be
 wrongly handled
Date: Sun, 19 Nov 2017 17:39:28 +0800

[Message part 4 (text/plain, inline)]

The bug was fixed by 1f3f4b1296.

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.